]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - netconn.c
reverted the massive svs.connectedclients change, now back to svs.clients and svs...
[xonotic/darkplaces.git] / netconn.c
index 08ab2a0cf241240e1b2753386fb9fe94e4bf501d..90d6d40dab7487f9f800a54fce2ae47e98cad948 100755 (executable)
--- a/netconn.c
+++ b/netconn.c
@@ -621,15 +621,8 @@ void NetConn_ConnectionEstablished(lhnetsocket_t *mysocket, lhnetaddress_t *peer
 
 int NetConn_IsLocalGame(void)
 {
-       int i;
-       if (cls.state == ca_connected && sv.active/* && LHNETADDRESS_GetAddressType(cl.netcon->peeraddress) == LHNETADDRESSTYPE_LOOP*/)
-       {
-               // make sure there are no other connected clients
-               for (i = 1;i < MAX_SCOREBOARD;i++)
-                       if (svs.connectedclients[i])
-                               return false;
+       if (cls.state == ca_connected && sv.active && cl.maxclients == 1)
                return true;
-       }
        return false;
 }
 
@@ -987,7 +980,7 @@ static void NetConn_BuildChallengeString(char *buffer, int bufferlength)
 extern void SV_ConnectClient(int clientnum, netconn_t *netconnection);
 int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length, lhnetaddress_t *peeraddress)
 {
-       int i, n, ret, clientnum, responselength, best, clientcount;
+       int i, n, ret, clientnum, responselength, best;
        double besttime;
        client_t *client;
        netconn_t *conn;
@@ -1057,10 +1050,10 @@ int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length,
                                                else
                                                {
                                                        // see if this is a duplicate connection request
-                                                       for (clientnum = 0;clientnum < MAX_SCOREBOARD;clientnum++)
-                                                               if ((client = svs.connectedclients[clientnum]) && LHNETADDRESS_Compare(peeraddress, &client->netconnection->peeraddress) == 0)
+                                                       for (clientnum = 0, client = svs.clients;clientnum < svs.maxclients;clientnum++, client++)
+                                                               if (client->netconnection && LHNETADDRESS_Compare(peeraddress, &client->netconnection->peeraddress) == 0)
                                                                        break;
-                                                       if (clientnum < MAX_SCOREBOARD)
+                                                       if (clientnum < svs.maxclients)
                                                        {
                                                                // duplicate connection request
                                                                if (realtime - client->netconnection->connecttime < 2.0)
@@ -1081,39 +1074,27 @@ int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length,
                                                        else
                                                        {
                                                                // this is a new client, find a slot
-                                                               for (clientcount = 0, clientnum = 0;clientnum < MAX_SCOREBOARD;clientnum++)
-                                                                       if (svs.connectedclients[clientnum])
-                                                                               clientcount++;
-                                                               for (clientnum = 0;clientnum < MAX_SCOREBOARD;clientnum++)
-                                                                       if (!svs.connectedclients[clientnum])
+                                                               for (clientnum = 0, client = svs.clients;clientnum < svs.maxclients;clientnum++, client++)
+                                                                       if (!client->active)
                                                                                break;
-                                                               if (clientcount < max(1, sv_maxplayers.integer) && clientnum < MAX_SCOREBOARD)
+                                                               if (clientnum < svs.maxclients)
                                                                {
-                                                                       // allocate and prepare the client struct
-                                                                       if ((client = Mem_Alloc(sv_clients_mempool, sizeof(client_t))))
+                                                                       // prepare the client struct
+                                                                       if ((client->entitydatabase4 = EntityFrame4_AllocDatabase(sv_clients_mempool)))
                                                                        {
-                                                                               if ((client->entitydatabase4 = EntityFrame4_AllocDatabase(sv_clients_mempool)))
+                                                                               if ((conn = NetConn_Open(mysocket, peeraddress)))
                                                                                {
-                                                                                       if ((conn = NetConn_Open(mysocket, peeraddress)))
-                                                                                       {
-                                                                                               // allocated connection
-                                                                                               LHNETADDRESS_ToString(peeraddress, conn->address, sizeof(conn->address), true);
-                                                                                               if (developer.integer)
-                                                                                                       Con_Printf("Datagram_ParseConnectionless: sending \"accept\" to %s.\n", conn->address);
-                                                                                               NetConn_WriteString(mysocket, "\377\377\377\377accept", peeraddress);
-                                                                                               // now set up the client struct
-                                                                                               svs.connectedclients[clientnum] = client;
-                                                                                               SV_ConnectClient(clientnum, conn);
-                                                                                               NetConn_Heartbeat(1);
-                                                                                       }
-                                                                                       else
-                                                                                       {
-                                                                                               EntityFrame4_FreeDatabase(client->entitydatabase4);
-                                                                                               Mem_Free(client);
-                                                                                       }
+                                                                                       // allocated connection
+                                                                                       LHNETADDRESS_ToString(peeraddress, conn->address, sizeof(conn->address), true);
+                                                                                       if (developer.integer)
+                                                                                               Con_Printf("Datagram_ParseConnectionless: sending \"accept\" to %s.\n", conn->address);
+                                                                                       NetConn_WriteString(mysocket, "\377\377\377\377accept", peeraddress);
+                                                                                       // now set up the client
+                                                                                       SV_ConnectClient(clientnum, conn);
+                                                                                       NetConn_Heartbeat(1);
                                                                                }
                                                                                else
-                                                                                       Mem_Free(client);
+                                                                                       EntityFrame4_FreeDatabase(client->entitydatabase4);
                                                                        }
                                                                }
                                                                else
@@ -1135,13 +1116,13 @@ int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length,
                                // If there was a challenge in the getinfo message
                                if (length > 8 && string[7] == ' ')
                                        challenge = string + 8;
-                               for (i = 0, n = 0;i < MAX_SCOREBOARD;i++)
-                                       if (svs.connectedclients[i])
+                               for (i = 0, n = 0;i < svs.maxclients;i++)
+                                       if (svs.clients[i].active)
                                                n++;
                                responselength = snprintf(response, sizeof(response), "\377\377\377\377infoResponse\x0A"
                                                        "\\gamename\\%s\\modname\\%s\\sv_maxclients\\%d"
                                                        "\\clients\\%d\\mapname\\%s\\hostname\\%s\\protocol\\%d%s%s",
-                                                       gamename, com_modname, min(sv_maxplayers.integer, MAX_SCOREBOARD), n,
+                                                       gamename, com_modname, svs.maxclients, n,
                                                        sv.name, hostname.string, NET_PROTOCOL_VERSION, challenge ? "\\challenge\\" : "", challenge ? challenge : "");
                                // does it fit in the buffer?
                                if (responselength < (int)sizeof(response))
@@ -1201,10 +1182,10 @@ int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length,
                                                else
                                                {
                                                        // see if this is a duplicate connection request
-                                                       for (clientnum = 0;clientnum < MAX_SCOREBOARD;clientnum++)
-                                                               if ((client = svs.connectedclients[clientnum]) && LHNETADDRESS_Compare(peeraddress, &client->netconnection->peeraddress) == 0)
+                                                       for (clientnum = 0, client = svs.clients;clientnum < svs.maxclients;clientnum++, client++)
+                                                               if (client->netconnection && LHNETADDRESS_Compare(peeraddress, &client->netconnection->peeraddress) == 0)
                                                                        break;
-                                                       if (clientnum < MAX_SCOREBOARD)
+                                                       if (clientnum < svs.maxclients)
                                                        {
                                                                // duplicate connection request
                                                                if (realtime - client->netconnection->connecttime < 2.0)
@@ -1233,11 +1214,10 @@ int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length,
                                                        else
                                                        {
                                                                // this is a new client, find a slot
-                                                               for (clientnum = 0;clientnum < MAX_SCOREBOARD;clientnum++)
-                                                                       if (!(client = svs.connectedclients[clientnum]))
+                                                               for (clientnum = 0, client = svs.clients;clientnum < svs.maxclients;clientnum++, client++)
+                                                                       if (!client->active)
                                                                                break;
-                                                               // WARNING: this is broken code
-                                                               if (clientnum < MAX_SCOREBOARD && (client->netconnection = conn = NetConn_Open(mysocket, peeraddress)) != NULL)
+                                                               if (clientnum < svs.maxclients && (client->netconnection = conn = NetConn_Open(mysocket, peeraddress)) != NULL)
                                                                {
                                                                        // connect to the client
                                                                        // everything is allocated, just fill in the details
@@ -1292,7 +1272,7 @@ int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length,
                                                MSG_WriteString(&net_message, hostname.string);
                                                MSG_WriteString(&net_message, sv.name);
                                                MSG_WriteByte(&net_message, net_activeconnections);
-                                               MSG_WriteByte(&net_message, min(sv_maxplayers.integer, MAX_SCOREBOARD));
+                                               MSG_WriteByte(&net_message, svs.maxclients);
                                                MSG_WriteByte(&net_message, NET_PROTOCOL_VERSION);
                                                *((int *)net_message.data) = BigLong(NETFLAG_CTL | (net_message.cursize & NETFLAG_LENGTH_MASK));
                                                NetConn_Write(mysocket, net_message.data, net_message.cursize, peeraddress);
@@ -1367,25 +1347,14 @@ int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, qbyte *data, int length,
                        }
                }
 #endif
-               for (i = 0;i < MAX_SCOREBOARD;i++)
+               for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++)
                {
-                       if ((host_client = svs.connectedclients[i]))
+                       if (host_client->netconnection && host_client->netconnection->mysocket == mysocket && !LHNETADDRESS_Compare(&host_client->netconnection->peeraddress, peeraddress))
                        {
-                               if (host_client->netconnection)
-                               {
-                                       if (host_client->netconnection->mysocket == mysocket && !LHNETADDRESS_Compare(&host_client->netconnection->peeraddress, peeraddress))
-                                       {
-                                               sv_player = host_client->edict;
-                                               if ((ret = NetConn_ReceivedMessage(host_client->netconnection, data, length)) == 2)
-                                                       SV_ReadClientMessage();
-                                               return ret;
-                                       }
-                               }
-                               else
-                               {
-                                       Con_Printf("Removing client with no netconnection!\n");
-                                       SV_DropClient(true);
-                               }
+                               sv_player = host_client->edict;
+                               if ((ret = NetConn_ReceivedMessage(host_client->netconnection, data, length)) == 2)
+                                       SV_ReadClientMessage();
+                               return ret;
                        }
                }
        }
@@ -1401,9 +1370,9 @@ void NetConn_ServerFrame(void)
        for (i = 0;i < sv_numsockets;i++)
                while (sv_sockets[i] && (length = NetConn_Read(sv_sockets[i], readbuffer, sizeof(readbuffer), &peeraddress)) > 0)
                        NetConn_ServerParsePacket(sv_sockets[i], readbuffer, length, &peeraddress);
-       for (i = 0;i < MAX_SCOREBOARD;i++)
+       for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++)
        {
-               if ((host_client = svs.connectedclients[i]) && realtime > host_client->netconnection->timeout)
+               if (host_client->netconnection && realtime > host_client->netconnection->timeout)
                {
                        Con_Printf("Client \"%s\" connection timed out\n", host_client->name);
                        sv_player = host_client->edict;
@@ -1478,7 +1447,7 @@ void NetConn_Heartbeat(int priority)
 
        // make advertising optional and don't advertise singleplayer games, and
        // only send a heartbeat as often as the admin wants
-       if (sv.active && sv_public.integer && (!cl.islocalgame || sv_maxplayers.integer >= 2) && (priority > 1 || realtime > nextheartbeattime))
+       if (sv.active && sv_public.integer && svs.maxclients >= 2 && (priority > 1 || realtime > nextheartbeattime))
        {
                nextheartbeattime = realtime + sv_heartbeatperiod.value;
                for (masternum = 0;sv_masters[masternum].name;masternum++)
@@ -1505,9 +1474,9 @@ int NetConn_SendToAll(sizebuf_t *data, double blocktime)
                count = 0;
                NetConn_ClientFrame();
                NetConn_ServerFrame();
-               for (i = 0;i < MAX_SCOREBOARD;i++)
+               for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++)
                {
-                       if ((host_client = svs.connectedclients[i]))
+                       if (host_client->netconnection)
                        {
                                if (NetConn_CanSendMessage(host_client->netconnection))
                                {