MEM_VEC_FUNCTIONS(parser_t, ast_function*, functions)
static bool GMQCC_WARN parser_pop_local(parser_t *parser);
-static bool parse_variable(parser_t *parser, ast_block *localblock);
+static bool parse_variable(parser_t *parser, ast_block *localblock, bool nofields);
static ast_block* parse_block(parser_t *parser, bool warnreturn);
static bool parse_block_into(parser_t *parser, ast_block *block, bool warnreturn);
static ast_expression* parse_statement_or_block(parser_t *parser);
return v;
}
-typedef struct {
- MEM_VECTOR_MAKE(ast_value*, p);
-} paramlist_t;
-MEM_VEC_FUNCTIONS(paramlist_t, ast_value*, p)
-
-static ast_value *parse_type(parser_t *parser, int basetype, bool *isfunc)
-{
- paramlist_t params;
- ast_value *var;
- lex_ctx ctx = parser_ctx(parser);
- int vtype = basetype;
- int temptype;
- size_t i;
- bool variadic = false;
-
- MEM_VECTOR_INIT(¶ms, p);
-
- *isfunc = false;
-
- if (parser->tok == '(') {
- *isfunc = true;
- while (true) {
- ast_value *param;
- ast_value *fld;
- bool isfield = false;
- bool isfuncparam = false;
-
- if (!parser_next(parser))
- goto on_error;
-
- if (parser->tok == ')')
- break;
-
- if (parser->tok == '.') {
- isfield = true;
- if (!parser_next(parser)) {
- parseerror(parser, "expected field parameter type");
- goto on_error;
- }
- }
-
- if (parser->tok == TOKEN_DOTS) {
- /* variadic args */
- variadic = true;
- if (!parser_next(parser))
- goto on_error;
- if (parser->tok != ')') {
- parseerror(parser, "`...` must be the last parameter of a variadic function declaration");
- goto on_error;
- }
- if (opts_standard == COMPILER_QCC) {
- if (parsewarning(parser, WARN_EXTENSIONS, "variadic functions are not available in this standard"))
- goto on_error;
- }
- break;
- }
-
- temptype = parser_token(parser)->constval.t;
- if (!parser_next(parser))
- goto on_error;
-
- param = parse_type(parser, temptype, &isfuncparam);
-
- if (!param)
- goto on_error;
-
- if (parser->tok == TOKEN_IDENT) {
- /* named parameter */
- if (!ast_value_set_name(param, parser_tokval(parser)))
- goto on_error;
- if (!parser_next(parser))
- goto on_error;
- }
-
- /* This comes before the isfield part! */
- if (isfuncparam) {
- ast_value *fval = ast_value_new(ast_ctx(param), param->name, TYPE_FUNCTION);
- if (!fval) {
- ast_delete(param);
- goto on_error;
- }
- fval->expression.next = (ast_expression*)param;
- MEM_VECTOR_MOVE(¶m->expression, params, &fval->expression, params);
- fval->expression.variadic = param->expression.variadic;
- param = fval;
- }
-
- if (isfield) {
- fld = ast_value_new(ctx, param->name, TYPE_FIELD);
- fld->expression.next = (ast_expression*)param;
- param = fld;
- }
-
- if (!paramlist_t_p_add(¶ms, param)) {
- parseerror(parser, "Out of memory while parsing typename");
- goto on_error;
- }
-
- if (parser->tok == ',')
- continue;
- if (parser->tok == ')')
- break;
- parseerror(parser, "Unexpected token");
- goto on_error;
- }
- if (!parser_next(parser))
- goto on_error;
- }
-
- if (params.p_count > 8)
- parseerror(parser, "more than 8 parameters are currently not supported");
-
- var = ast_value_new(ctx, "<unnamed>", vtype);
- if (!var)
- goto on_error;
- var->expression.variadic = variadic;
- MEM_VECTOR_MOVE(¶ms, p, &var->expression, params);
- return var;
-on_error:
- for (i = 0; i < params.p_count; ++i)
- ast_value_delete(params.p[i]);
- MEM_VECTOR_CLEAR(¶ms, p);
- return NULL;
-}
-
typedef struct
{
size_t etype; /* 0 = expression, others are operators */
parseerror(parser, "TODO: assignment of new variables to be non-const");
goto onerr;
- if (!parse_variable(parser, block))
+ if (!parse_variable(parser, block, true))
goto onerr;
}
else if (parser->tok != ';')
if (parsewarning(parser, WARN_EXTENSIONS, "missing 'local' keyword when declaring a local variable"))
return false;
}
- if (!parse_variable(parser, block))
+ if (!parse_variable(parser, block, false))
return false;
*out = NULL;
return true;
parseerror(parser, "expected variable declaration");
return false;
}
- if (!parse_variable(parser, block))
+ if (!parse_variable(parser, block, true))
return false;
*out = NULL;
return true;
}
ve[e].var = NULL; /* collected */
}
- if (e != e) {
+ if (e != 3) {
parser->locals -= e;
do {
mem_d(ve[e].name);
return false;
}
-static bool parse_variable(parser_t *parser, ast_block *localblock)
+typedef struct {
+ MEM_VECTOR_MAKE(ast_value*, p);
+} paramlist_t;
+MEM_VEC_FUNCTIONS(paramlist_t, ast_value*, p)
+
+static ast_value *parse_typename(parser_t *parser, ast_value **storebase);
+static ast_value *parse_parameter_list(parser_t *parser, ast_value *var)
{
- bool isfunc = false;
- lex_ctx ctx;
+ lex_ctx ctx;
+ size_t i;
+ paramlist_t params;
+ ast_value *param;
+ ast_value *fval;
+ bool first = true;
+ bool variadic = false;
+
+ ctx = parser_ctx(parser);
- ast_value *var = NULL;
- bool cleanvar = false;
+ /* for the sake of less code we parse-in in this function */
+ if (!parser_next(parser)) {
+ parseerror(parser, "expected parameter list");
+ return NULL;
+ }
- varentry_t varent;
- varentry_t ve[3];
+ MEM_VECTOR_INIT(¶ms, p);
+
+ /* parse variables until we hit a closing paren */
+ while (parser->tok != ')') {
+ if (!first) {
+ /* there must be commas between them */
+ if (parser->tok != ',') {
+ parseerror(parser, "expected comma or end of parameter list");
+ goto on_error;
+ }
+ if (!parser_next(parser)) {
+ parseerror(parser, "expected parameter");
+ goto on_error;
+ }
+ }
+ first = false;
- ast_expression *olddecl;
+ if (parser->tok == TOKEN_DOTS) {
+ /* '...' indicates a varargs function */
+ variadic = true;
+ if (!parser_next(parser)) {
+ parseerror(parser, "expected parameter");
+ return NULL;
+ }
+ if (parser->tok != ')') {
+ parseerror(parser, "`...` must be the last parameter of a variadic function declaration");
+ goto on_error;
+ }
+ }
+ else
+ {
+ /* for anything else just parse a typename */
+ param = parse_typename(parser, NULL);
+ if (!param)
+ goto on_error;
+ if (!paramlist_t_p_add(¶ms, param))
+ goto on_error;
+ }
+ }
- ast_value *typevar;
+ /* sanity check */
+ if (params.p_count > 8)
+ parseerror(parser, "more than 8 parameters are currently not supported");
- bool hadproto;
- bool isparam;
+ /* parse-out */
+ if (!parser_next(parser)) {
+ parseerror(parser, "parse error after typename");
+ goto on_error;
+ }
- bool retval = true;
+ /* now turn 'var' into a function type */
+ fval = ast_value_new(ctx, "<type()>", TYPE_FUNCTION);
+ fval->expression.next = (ast_expression*)var;
+ fval->expression.variadic = variadic;
+ var = fval;
- /* go */
+ MEM_VECTOR_MOVE(¶ms, p, &var->expression, params);
- int basetype = parser_token(parser)->constval.t;
+ return var;
+on_error:
+ ast_delete(var);
+ for (i = 0; i < params.p_count; ++i)
+ ast_delete(params.p[i]);
+ MEM_VECTOR_CLEAR(¶ms, p);
+ return NULL;
+}
+
+/* Parse a complete typename.
+ * for single-variables (ie. function parameters or typedefs) storebase should be NULL
+ * but when parsing variables separated by comma
+ * 'storebase' should point to where the base-type should be kept.
+ * The base type makes up every bit of type information which comes *before* the
+ * variable name.
+ *
+ * The following will be parsed in its entirety:
+ * void() foo()
+ * The 'basetype' in this case is 'void()'
+ * and if there's a comma after it, say:
+ * void() foo(), bar
+ * then the type-information 'void()' can be stored in 'storebase'
+ */
+static ast_value *parse_typename(parser_t *parser, ast_value **storebase)
+{
+ ast_value *var, *tmp;
+ lex_ctx ctx;
+
+ const char *name = NULL;
+ bool isfield = false;
+
+ ctx = parser_ctx(parser);
+
+ /* types may start with a dot */
+ if (parser->tok == '.') {
+ isfield = true;
+ /* if we parsed a dot we need a typename now */
+ if (!parser_next(parser)) {
+ parseerror(parser, "expected typename for field definition");
+ return NULL;
+ }
+ if (parser->tok != TOKEN_TYPENAME) {
+ parseerror(parser, "expected typename");
+ return NULL;
+ }
+ }
+
+ /* generate the basic type value */
+ var = ast_value_new(ctx, "<type>", parser_token(parser)->constval.t);
+ /* do not yet turn into a field - remember:
+ * .void() foo; is a field too
+ * .void()() foo; is a function
+ */
+
+ /* parse on */
if (!parser_next(parser)) {
- parseerror(parser, "expected variable definition");
- return false;
+ ast_delete(var);
+ parseerror(parser, "parse error after typename");
+ return NULL;
}
- typevar = parse_type(parser, basetype, &isfunc);
- if (!typevar)
- return false;
+ /* an opening paren now starts the parameter-list of a function */
+ if (parser->tok == '(') {
+ var = parse_parameter_list(parser, var);
+ if (!var)
+ return NULL;
+ }
+ /* This is the point where we can turn it into a field */
+ if (isfield) {
+ /* turn it into a field if desired */
+ tmp = ast_value_new(ctx, "<type:f>", TYPE_FIELD);
+ tmp->expression.next = (ast_expression*)var;
+ var = tmp;
+ }
- while (true)
- {
- hadproto = false;
- olddecl = NULL;
- isparam = false;
- varent.name = NULL;
+ while (parser->tok == '(') {
+ var = parse_parameter_list(parser, var);
+ if (!var)
+ return NULL;
+ }
- ve[0].name = ve[1].name = ve[2].name = NULL;
- ve[0].var = ve[1].var = ve[2].var = NULL;
+ /* store the base if requested */
+ if (storebase) {
+ *storebase = ast_value_copy(var);
+ }
- ctx = parser_ctx(parser);
- var = ast_value_copy(typevar);
- cleanvar = true;
+ /* there may be a name now */
+ if (parser->tok == TOKEN_IDENT) {
+ name = util_strdup(parser_tokval(parser));
+ /* parse on */
+ if (!parser_next(parser)) {
+ parseerror(parser, "error after variable or field declaration");
+ return NULL;
+ }
+ }
+ /* now there may be function parens again */
+ if (parser->tok == '(' && opts_standard == COMPILER_QCC)
+ parseerror(parser, "C-style function syntax is not allowed in -std=qcc");
+ while (parser->tok == '(') {
+ var = parse_parameter_list(parser, var);
if (!var) {
- parseerror(parser, "failed to create variable");
- retval = false;
- goto cleanup;
+ if (name)
+ mem_d((void*)name);
+ return NULL;
}
+ }
- if (parser->tok != TOKEN_IDENT) {
- parseerror(parser, "expected variable name");
- retval = false;
- goto cleanup;
+ /* finally name it */
+ if (name) {
+ if (!ast_value_set_name(var, name)) {
+ ast_delete(var);
+ parseerror(parser, "internal error: failed to set name");
+ return NULL;
}
+ /* free the name, ast_value_set_name duplicates */
+ mem_d((void*)name);
+ }
- if (!localblock) {
- if (!strcmp(parser_tokval(parser), "end_sys_globals"))
- parser->crc_globals = parser->globals_count;
- else if (!strcmp(parser_tokval(parser), "end_sys_fields"))
- parser->crc_fields = parser->fields_count;
- }
+ return var;
+}
- if (!isfunc) {
- if (!localblock && (olddecl = parser_find_global(parser, parser_tokval(parser)))) {
- parseerror(parser, "global `%s` already declared here: %s:%i",
- parser_tokval(parser), ast_ctx(olddecl).file, (int)ast_ctx(olddecl).line);
+static bool parse_variable(parser_t *parser, ast_block *localblock, bool nofields)
+{
+ ast_value *var;
+ ast_value *proto;
+ ast_expression *old;
+ bool was_end;
+ size_t i;
+
+ ast_value *basetype = NULL;
+ bool retval = true;
+ bool isparam = false;
+ bool isvector = false;
+ bool cleanvar = true;
+
+ varentry_t varent, ve[3];
+
+ /* get the first complete variable */
+ var = parse_typename(parser, &basetype);
+ if (!var) {
+ if (basetype)
+ ast_delete(basetype);
+ return false;
+ }
+
+ memset(&varent, 0, sizeof(varent));
+ memset(&ve, 0, sizeof(ve));
+
+ while (true) {
+ proto = NULL;
+
+ /* Part 0: finish the type */
+ while (parser->tok == '(') {
+ if (opts_standard == COMPILER_QCC)
+ parseerror(parser, "C-style function syntax is not allowed in -std=qcc");
+ var = parse_parameter_list(parser, var);
+ if (!var) {
retval = false;
goto cleanup;
}
+ }
- if (localblock) {
- olddecl = parser_find_local(parser, parser_tokval(parser), parser->blocklocal, &isparam);
- if (opts_standard == COMPILER_GMQCC)
+ /* Part 1:
+ * check for validity: (end_sys_..., multiple-definitions, prototypes, ...)
+ * Also: if there was a prototype, `var` will be deleted and set to `proto` which
+ * is then filled with the previous definition and the parameter-names replaced.
+ */
+ if (!localblock) {
+ /* Deal with end_sys_ vars */
+ was_end = false;
+ if (!strcmp(var->name, "end_sys_globals")) {
+ parser->crc_globals = parser->globals_count;
+ was_end = true;
+ }
+ else if (!strcmp(var->name, "end_sys_fields")) {
+ parser->crc_fields = parser->fields_count;
+ was_end = true;
+ }
+ if (was_end && var->expression.vtype == TYPE_FIELD) {
+ if (parsewarning(parser, WARN_END_SYS_FIELDS,
+ "global '%s' hint should not be a field",
+ parser_tokval(parser)))
{
- if (olddecl)
- {
- if (!isparam) {
- parseerror(parser, "local `%s` already declared here: %s:%i",
- parser_tokval(parser), ast_ctx(olddecl).file, (int)ast_ctx(olddecl).line);
- retval = false;
- goto cleanup;
- }
- }
+ retval = false;
+ goto cleanup;
+ }
+ }
- if( (!isparam && olddecl) ||
- (olddecl = parser_find_local(parser, parser_tokval(parser), 0, &isparam))
- )
+ if (!nofields && var->expression.vtype == TYPE_FIELD)
+ {
+ /* deal with field declarations */
+ old = parser_find_field(parser, var->name);
+ if (old) {
+ if (parsewarning(parser, WARN_FIELD_REDECLARED, "field `%s` already declared here: %s:%i",
+ var->name, ast_ctx(old).file, (int)ast_ctx(old).line))
{
- if (parsewarning(parser, WARN_LOCAL_SHADOWS,
- "local `%s` is shadowing a parameter", parser_tokval(parser)))
- {
- parseerror(parser, "local `%s` already declared here: %s:%i",
- parser_tokval(parser), ast_ctx(olddecl).file, (int)ast_ctx(olddecl).line);
- retval = false;
- goto cleanup;
- }
+ retval = false;
+ goto cleanup;
+ }
+ ast_delete(var);
+ var = NULL;
+ goto skipvar;
+ /*
+ parseerror(parser, "field `%s` already declared here: %s:%i",
+ var->name, ast_ctx(old).file, ast_ctx(old).line);
+ retval = false;
+ goto cleanup;
+ */
+ }
+ if (opts_standard == COMPILER_QCC &&
+ (old = parser_find_global(parser, var->name)))
+ {
+ parseerror(parser, "cannot declare a field and a global of the same name with -std=qcc");
+ parseerror(parser, "field `%s` already declared here: %s:%i",
+ var->name, ast_ctx(old).file, ast_ctx(old).line);
+ retval = false;
+ goto cleanup;
+ }
+ }
+ else
+ {
+ /* deal with other globals */
+ old = parser_find_global(parser, var->name);
+ if (old && var->expression.vtype == TYPE_FUNCTION && old->expression.vtype == TYPE_FUNCTION)
+ {
+ /* This is a function which had a prototype */
+ if (!ast_istype(old, ast_value)) {
+ parseerror(parser, "internal error: prototype is not an ast_value");
+ retval = false;
+ goto cleanup;
+ }
+ proto = (ast_value*)old;
+ if (!ast_compare_type((ast_expression*)proto, (ast_expression*)var)) {
+ parseerror(parser, "conflicting types for `%s`, previous declaration was here: %s:%i",
+ proto->name,
+ ast_ctx(proto).file, ast_ctx(proto).line);
+ retval = false;
+ goto cleanup;
}
+ /* we need the new parameter-names */
+ for (i = 0; i < proto->expression.params_count; ++i)
+ ast_value_set_name(proto->expression.params[i], var->expression.params[i]->name);
+ ast_delete(var);
+ var = proto;
}
else
{
- if (olddecl)
+ /* other globals */
+ if (old) {
+ parseerror(parser, "global `%s` already declared here: %s:%i",
+ var->name, ast_ctx(old).file, ast_ctx(old).line);
+ retval = false;
+ goto cleanup;
+ }
+ if (opts_standard == COMPILER_QCC &&
+ (old = parser_find_field(parser, var->name)))
{
- ast_value_delete(var);
- var = NULL;
- if (isparam &&
- parsewarning(parser, WARN_LOCAL_SHADOWS,
- "a parameter is shadowing local `%s`", parser_tokval(parser)))
- {
- retval = false;
- goto cleanup;
- }
- else if (!isparam)
- {
- parseerror(parser, "local `%s` already declared here: %s:%i",
- parser_tokval(parser), ast_ctx(olddecl).file, (int)ast_ctx(olddecl).line);
- retval = false;
- goto cleanup;
- }
- goto nextvar;
+ parseerror(parser, "cannot declare a field and a global of the same name with -std=qcc");
+ parseerror(parser, "global `%s` already declared here: %s:%i",
+ var->name, ast_ctx(old).file, ast_ctx(old).line);
+ retval = false;
+ goto cleanup;
}
}
}
}
-
- if (!ast_value_set_name(var, parser_tokval(parser))) {
- parseerror(parser, "failed to set variable name\n");
- retval = false;
- goto cleanup;
- }
-
- if (isfunc) {
- /* a function was defined */
- ast_value *fval;
- ast_value *proto = NULL;
- bool dummy;
-
- if (!localblock)
- olddecl = parser_find_global(parser, parser_tokval(parser));
- else
- olddecl = parser_find_local(parser, parser_tokval(parser), parser->blocklocal, &dummy);
-
- if (olddecl) {
- /* we had a prototype */
- if (!ast_istype(olddecl, ast_value)) {
- /* vector v;
- * void() v_x = {}
- */
- parseerror(parser, "cannot declare a function with the same name as a vector's member: %s",
- parser_tokval(parser));
+ else /* it's not a global */
+ {
+ old = parser_find_local(parser, var->name, parser->blocklocal, &isparam);
+ if (old && !isparam) {
+ parseerror(parser, "local `%s` already declared here: %s:%i",
+ var->name, ast_ctx(old).file, (int)ast_ctx(old).line);
+ retval = false;
+ goto cleanup;
+ }
+ old = parser_find_local(parser, var->name, 0, &isparam);
+ if (old && isparam) {
+ if (parsewarning(parser, WARN_LOCAL_SHADOWS,
+ "local `%s` is shadowing a parameter", var->name))
+ {
+ parseerror(parser, "local `%s` already declared here: %s:%i",
+ var->name, ast_ctx(old).file, (int)ast_ctx(old).line);
retval = false;
goto cleanup;
}
-
- proto = (ast_value*)olddecl;
+ if (opts_standard != COMPILER_GMQCC) {
+ ast_delete(var);
+ var = NULL;
+ goto skipvar;
+ }
}
+ }
- /* turn var into a value of TYPE_FUNCTION, with the old var
- * as return type
- */
- fval = ast_value_new(ctx, var->name, TYPE_FUNCTION);
- if (!fval) {
- retval = false;
- goto cleanup;
- }
+ /* Part 2:
+ * Create the global/local, and deal with vector types.
+ */
+ if (!proto) {
+ if (var->expression.vtype == TYPE_VECTOR)
+ isvector = true;
+ else if (var->expression.vtype == TYPE_FIELD &&
+ var->expression.next->expression.vtype == TYPE_VECTOR)
+ isvector = true;
- fval->expression.next = (ast_expression*)var;
- MEM_VECTOR_MOVE(&var->expression, params, &fval->expression, params);
- fval->expression.variadic = var->expression.variadic;
- var = NULL;
-
- /* we compare the type late here, but it's easier than
- * messing with the parameter-vector etc. earlier
- */
- if (proto) {
- size_t param;
- if (!ast_compare_type((ast_expression*)proto, (ast_expression*)fval)) {
- parseerror(parser, "conflicting types for `%s`, previous declaration was here: %s:%i",
- proto->name,
- ast_ctx(proto).file, ast_ctx(proto).line);
- ast_value_delete(fval);
+ if (isvector) {
+ if (!create_vector_members(parser, var, ve)) {
retval = false;
goto cleanup;
}
- /* copy over the parameter names */
- for (param = 0; param < fval->expression.params_count; ++param)
- ast_value_set_name(proto->expression.params[param], fval->expression.params[param]->name);
- /* copy the new context */
- ast_ctx(proto) = ast_ctx(fval);
-
- /* now ditch the rest of the new data */
- ast_value_delete(fval);
- fval = proto;
- hadproto = true;
}
- var = fval;
- }
-
- if (!hadproto) {
varent.name = util_strdup(var->name);
- varent.var = (ast_expression*)var;
+ varent.var = (ast_expression*)var;
if (!localblock) {
- if (!(retval = parser_t_globals_add(parser, varent)))
- goto cleanup;
+ /* deal with global variables, fields, functions */
+ if (!nofields && var->expression.vtype == TYPE_FIELD) {
+ if (!(retval = parser_t_fields_add(parser, varent)))
+ goto cleanup;
+ if (isvector) {
+ for (i = 0; i < 3; ++i) {
+ if (!(retval = parser_t_fields_add(parser, ve[i])))
+ break;
+ }
+ if (!retval) {
+ parser->fields_count -= i+1;
+ goto cleanup;
+ }
+ }
+ }
+ else {
+ if (!(retval = parser_t_globals_add(parser, varent)))
+ goto cleanup;
+ if (isvector) {
+ for (i = 0; i < 3; ++i) {
+ if (!(retval = parser_t_globals_add(parser, ve[i])))
+ break;
+ }
+ if (!retval) {
+ parser->globals_count -= i+1;
+ goto cleanup;
+ }
+ }
+ }
} else {
if (!(retval = parser_t_locals_add(parser, varent)))
goto cleanup;
parser->locals_count--;
goto cleanup;
}
- }
-
- if (var->expression.vtype == TYPE_VECTOR)
- {
- size_t e;
- if (!create_vector_members(parser, var, ve)) {
- retval = false;
- goto cleanup;
- }
-
- if (!localblock) {
- for (e = 0; e < 3; ++e) {
- if (!(retval = parser_t_globals_add(parser, ve[e])))
+ if (isvector) {
+ for (i = 0; i < 3; ++i) {
+ if (!(retval = parser_t_locals_add(parser, ve[i])))
break;
- }
- if (!retval) {
- parser->globals_count -= e+1;
- goto cleanup;
- }
- } else {
- for (e = 0; e < 3; ++e) {
- if (!(retval = parser_t_locals_add(parser, ve[e])))
+ if (!(retval = ast_block_collect(localblock, ve[i].var)))
break;
- if (!(retval = ast_block_collect(localblock, ve[e].var)))
- break;
- ve[e].var = NULL; /* from here it's being collected in the block */
+ ve[i].var = NULL; /* from here it's being collected in the block */
}
if (!retval) {
- parser->locals_count -= e+1;
+ parser->locals_count -= i+1;
localblock->locals_count--;
goto cleanup;
}
}
- ve[0].name = ve[1].name = ve[2].name = NULL;
- ve[0].var = ve[1].var = ve[2].var = NULL;
}
- cleanvar = false;
+
varent.name = NULL;
+ ve[0].name = ve[1].name = ve[2].name = NULL;
+ ve[0].var = ve[1].var = ve[2].var = NULL;
+ cleanvar = false;
}
-nextvar:
- if (!(retval = parser_next(parser)))
- goto cleanup;
-
+skipvar:
if (parser->tok == ';') {
- ast_value_delete(typevar);
- return parser_next(parser);
+ ast_delete(basetype);
+ if (!parser_next(parser)) {
+ parseerror(parser, "error after variable declaration");
+ return false;
+ }
+ return true;
}
- if (parser->tok == ',') {
- /* another var */
- if (!(retval = parser_next(parser)))
- goto cleanup;
- continue;
+ if (parser->tok == ',')
+ goto another;
+
+ if (!var || (!localblock && !nofields && basetype->expression.vtype == TYPE_FIELD)) {
+ parseerror(parser, "missing comma or semicolon while parsing variables");
+ break;
}
- /* NOTE: only 'typevar' needs to be deleted from here on, so 'cleanup' won't be used
- * to avoid having too many gotos
- */
if (localblock && opts_standard == COMPILER_QCC) {
if (parsewarning(parser, WARN_LOCAL_CONSTANTS,
"initializing expression turns variable `%s` into a constant in this standard",
var->name) )
{
- ast_value_delete(typevar);
- return false;
+ break;
}
}
- if (parser->tok != '=') {
- if (opts_standard == COMPILER_QCC)
- parseerror(parser, "missing semicolon");
- else
+ if (parser->tok != '{') {
+ if (parser->tok != '=') {
parseerror(parser, "missing semicolon or initializer");
- ast_value_delete(typevar);
- return false;
- }
+ break;
+ }
- if (!parser_next(parser)) {
- ast_value_delete(typevar);
- return false;
+ if (!parser_next(parser)) {
+ parseerror(parser, "error parsing initializer");
+ break;
+ }
+ }
+ else if (opts_standard == COMPILER_QCC) {
+ parseerror(parser, "expected '=' before function body in this standard");
}
if (parser->tok == '#') {
if (localblock) {
parseerror(parser, "cannot declare builtins within functions");
- ast_value_delete(typevar);
- return false;
+ break;
}
- if (!isfunc) {
+ if (var->expression.vtype != TYPE_FUNCTION) {
parseerror(parser, "unexpected builtin number, '%s' is not a function", var->name);
- ast_value_delete(typevar);
- return false;
+ break;
}
if (!parser_next(parser)) {
parseerror(parser, "expected builtin number");
- ast_value_delete(typevar);
- return false;
+ break;
}
if (parser->tok != TOKEN_INTCONST) {
parseerror(parser, "builtin number must be an integer constant");
- ast_value_delete(typevar);
- return false;
+ break;
}
if (parser_token(parser)->constval.i <= 0) {
- parseerror(parser, "builtin number must be positive integer greater than zero");
- ast_value_delete(typevar);
- return false;
+ parseerror(parser, "builtin number must be an integer greater than zero");
+ break;
}
func = ast_function_new(ast_ctx(var), var->name, var);
if (!func) {
parseerror(parser, "failed to allocate function for `%s`", var->name);
- ast_value_delete(typevar);
- return false;
+ break;
}
if (!parser_t_functions_add(parser, func)) {
parseerror(parser, "failed to allocate slot for function `%s`", var->name);
ast_function_delete(func);
var->constval.vfunc = NULL;
- ast_value_delete(typevar);
- return false;
+ break;
}
func->builtin = -parser_token(parser)->constval.i;
if (!parser_next(parser)) {
- ast_value_delete(typevar);
- return false;
+ parseerror(parser, "expected comma or semicolon");
+ ast_function_delete(func);
+ var->constval.vfunc = NULL;
+ break;
}
}
else if (parser->tok == '{' || parser->tok == '[')
{
- ast_value_delete(typevar);
if (localblock) {
parseerror(parser, "cannot declare functions within functions");
- return false;
+ break;
}
- if (!parse_function_body(parser, var)) {
- return false;
- }
+ if (!parse_function_body(parser, var))
+ break;
+ ast_delete(basetype);
return true;
} else {
ast_expression *cexp;
ast_value *cval;
cexp = parse_expression_leave(parser, true);
- if (!cexp) {
- ast_value_delete(typevar);
- return false;
- }
+ if (!cexp)
+ break;
cval = (ast_value*)cexp;
if (!ast_istype(cval, ast_value) || !cval->isconst)
}
}
+another:
if (parser->tok == ',') {
- /* another */
+ if (!parser_next(parser)) {
+ parseerror(parser, "expected another variable");
+ break;
+ }
+
+ if (parser->tok != TOKEN_IDENT) {
+ parseerror(parser, "expected another variable");
+ break;
+ }
+ var = ast_value_copy(basetype);
+ cleanvar = true;
+ ast_value_set_name(var, parser_tokval(parser));
+ if (!parser_next(parser)) {
+ parseerror(parser, "error parsing variable declaration");
+ break;
+ }
continue;
}
if (parser->tok != ';') {
- parseerror(parser, "missing semicolon");
- ast_value_delete(typevar);
- return false;
+ parseerror(parser, "missing semicolon after variables");
+ break;
}
- (void)parser_next(parser);
+ if (!parser_next(parser)) {
+ parseerror(parser, "parse error after variable declaration");
+ break;
+ }
- ast_value_delete(typevar);
+ ast_delete(basetype);
return true;
}
+ if (cleanvar && var)
+ ast_delete(var);
+ ast_delete(basetype);
+ return false;
+
cleanup:
- ast_delete(typevar);
- if (var && cleanvar) ast_delete(var);
+ ast_delete(basetype);
+ if (cleanvar && var)
+ ast_delete(var);
if (varent.name) mem_d(varent.name);
if (ve[0].name) mem_d(ve[0].name);
if (ve[1].name) mem_d(ve[1].name);
if (ve[0].var) mem_d(ve[0].var);
if (ve[1].var) mem_d(ve[1].var);
if (ve[2].var) mem_d(ve[2].var);
-
return retval;
}
static bool parser_global_statement(parser_t *parser)
{
- if (parser->tok == TOKEN_TYPENAME)
+ if (parser->tok == TOKEN_TYPENAME || parser->tok == '.')
{
- return parse_variable(parser, NULL);
+ return parse_variable(parser, NULL, false);
}
else if (parser->tok == TOKEN_KEYWORD)
{
/* handle 'var' and 'const' */
- return false;
- }
- else if (parser->tok == '.')
- {
- ast_value *var;
- ast_value *typevar;
- ast_value *fld;
- ast_expression *oldex;
- bool isfunc = false;
- int basetype;
- lex_ctx ctx = parser_ctx(parser);
- varentry_t varent;
-
- /* entity-member declaration */
- if (!parser_next(parser) || parser->tok != TOKEN_TYPENAME) {
- parseerror(parser, "expected member variable definition");
- return false;
- }
-
- /* remember the base/return type */
- basetype = parser_token(parser)->constval.t;
-
- /* parse into the declaration */
- if (!parser_next(parser)) {
- parseerror(parser, "expected field definition");
- return false;
- }
-
- /* parse the field type fully */
- typevar = var = parse_type(parser, basetype, &isfunc);
- if (!var)
- return false;
-
- while (true) {
- var = ast_value_copy(typevar);
- /* now the field name */
- if (parser->tok != TOKEN_IDENT) {
- parseerror(parser, "expected field name");
- ast_delete(var);
- return false;
- }
-
- /* check for an existing field
- * in original qc we also have to check for an existing
- * global named like the field
- */
- if (opts_standard == COMPILER_QCC) {
- if (parser_find_global(parser, parser_tokval(parser))) {
- parseerror(parser, "cannot declare a field and a global of the same name with -std=qcc");
- ast_delete(var);
- return false;
- }
- }
-
- if (isfunc) {
- ast_value *fval;
- fval = ast_value_new(ctx, var->name, TYPE_FUNCTION);
- if (!fval) {
- ast_value_delete(var);
- return false;
- }
- fval->expression.next = (ast_expression*)var;
- MEM_VECTOR_MOVE(&var->expression, params, &fval->expression, params);
- fval->expression.variadic = var->expression.variadic;
- var = fval;
- }
-
- if (!strcmp(parser_tokval(parser), "end_sys_fields")) {
- if (parsewarning(parser, WARN_END_SYS_FIELDS, "by convention end_sys_fields should be declared as global, rather than a field")) {
- ast_value_delete(var);
- return false;
- }
- }
-
- /* turn it into a field */
- fld = ast_value_new(ctx, parser_tokval(parser), TYPE_FIELD);
- fld->expression.next = (ast_expression*)var;
-
- if ( (oldex = parser_find_field(parser, parser_tokval(parser)))) {
- if (ast_istype(oldex, ast_member)) {
- parseerror(parser, "cannot declare a field with the same name as a vector component, component %s has been declared here: %s:%i",
- parser_tokval(parser), ast_ctx(oldex).file, (int)ast_ctx(oldex).line);
- ast_delete(fld);
- return false;
- }
- if (!ast_istype(oldex, ast_value)) {
- /* not possible / sanity check */
- parseerror(parser, "internal error: %s is not an ast_value", parser_tokval(parser));
- ast_delete(fld);
- return false;
- }
-
- if (!ast_compare_type(oldex, (ast_expression*)fld)) {
- parseerror(parser, "field %s has previously been declared with a different type here: %s:%i",
- parser_tokval(parser), ast_ctx(oldex).file, (int)ast_ctx(oldex).line);
- ast_delete(fld);
- return false;
- } else {
- if (parsewarning(parser, WARN_FIELD_REDECLARED, "field `%s` has already been declared here: %s:%i",
- parser_tokval(parser), ast_ctx(oldex).file, (int)ast_ctx(oldex).line))
- {
- ast_delete(fld);
- return false;
- }
- }
-
- ast_delete(fld);
- goto nextfield;
- }
-
- varent.var = (ast_expression*)fld;
- varent.name = util_strdup(fld->name);
- (void)!parser_t_fields_add(parser, varent);
-
- if (var->expression.vtype == TYPE_VECTOR)
- {
- /* create _x, _y and _z fields as well */
- varentry_t ve[3];
- if (!create_vector_members(parser, fld, ve)) {
- ast_delete(fld);
- return false;
- }
- (void)!parser_t_fields_add(parser, ve[0]);
- (void)!parser_t_fields_add(parser, ve[1]);
- (void)!parser_t_fields_add(parser, ve[2]);
- }
-
-nextfield:
+ if (!strcmp(parser_tokval(parser), "var")) {
if (!parser_next(parser)) {
- parseerror(parser, "expected semicolon or another field name");
- return false;
- }
- if (parser->tok == ';')
- break;
- if (parser->tok != ',' || !parser_next(parser)) {
- parseerror(parser, "expected semicolon or another field name");
+ parseerror(parser, "expected variable declaration after 'var'");
return false;
}
+ return parse_variable(parser, NULL, true);
}
- ast_delete(typevar);
-
- /* skip the semicolon */
- if (!parser_next(parser))
- return parser->tok == TOKEN_EOF;
-
- return true;
+ return false;
}
else if (parser->tok == '$')
{