]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - console.c
improved plane distance epsilon checking and improved precision when converting brush...
[xonotic/darkplaces.git] / console.c
index 6754b08f603eecff116898092ca63e367cd5e2ba..c244706d25aee8feb25c56f76c08c16fa3cda3f4 100644 (file)
--- a/console.c
+++ b/console.c
@@ -41,10 +41,9 @@ int con_current;
 int con_x;
 char con_text[CON_TEXTSIZE];
 
-//seconds
-cvar_t con_notifytime = {CVAR_SAVE, "con_notifytime","3"};
-cvar_t con_notify = {CVAR_SAVE, "con_notify","4"};
-cvar_t con_textsize = {CVAR_SAVE, "con_textsize","8"}; //[515]: console text size in pixels
+cvar_t con_notifytime = {CVAR_SAVE, "con_notifytime","3", "how long notify lines last, in seconds"};
+cvar_t con_notify = {CVAR_SAVE, "con_notify","4", "how many notify lines to show (0-32)"};
+cvar_t con_textsize = {CVAR_SAVE, "con_textsize","8", "console text size in virtual 2D pixels"};       //[515]: console text size in pixels
 
 #define MAX_NOTIFYLINES 32
 // cl.time time the line was generated for transparent notify lines
@@ -54,6 +53,11 @@ int con_vislines;
 
 qboolean con_initialized;
 
+// used for server replies to rcon command
+qboolean rcon_redirect = false;
+int rcon_redirect_bufferpos = 0;
+char rcon_redirect_buffer[1400];
+
 
 /*
 ==============================================================================
@@ -63,7 +67,7 @@ LOGGING
 ==============================================================================
 */
 
-cvar_t log_file = {0, "log_file",""};
+cvar_t log_file = {0, "log_file","", "filename to log messages to"};
 char crt_log_file [MAX_OSPATH] = "";
 qfile_t* logfile = NULL;
 
@@ -149,10 +153,11 @@ void Log_Start (void)
        // Dump the contents of the log queue into the log file and free it
        if (logqueue != NULL)
        {
-               if (logfile != NULL && logq_ind != 0)
-                       FS_Write (logfile, logqueue, logq_ind);
-               Mem_Free (logqueue);
+               unsigned char *temp = logqueue;
                logqueue = NULL;
+               if (logfile != NULL && logq_ind != 0)
+                       FS_Write (logfile, temp, logq_ind);
+               Mem_Free (temp);
                logq_ind = 0;
                logq_size = 0;
        }
@@ -388,7 +393,7 @@ void Con_Init (void)
        con_linewidth = 80;
        con_totallines = CON_TEXTSIZE / con_linewidth;
 
-       // Allocate a log queue
+       // Allocate a log queue, this will be freed after configs are parsed
        logq_size = MAX_INPUTLINE;
        logqueue = (unsigned char *)Mem_Alloc (tempmempool, logq_size);
        logq_ind = 0;
@@ -409,11 +414,11 @@ void Con_Init_Commands (void)
        Cvar_RegisterVariable (&con_textsize);
 
        // register our commands
-       Cmd_AddCommand ("toggleconsole", Con_ToggleConsole_f);
-       Cmd_AddCommand ("messagemode", Con_MessageMode_f);
-       Cmd_AddCommand ("messagemode2", Con_MessageMode2_f);
-       Cmd_AddCommand ("clear", Con_Clear_f);
-       Cmd_AddCommand ("maps", Con_Maps_f);                                                    // By [515]
+       Cmd_AddCommand ("toggleconsole", Con_ToggleConsole_f, "opens or closes the console");
+       Cmd_AddCommand ("messagemode", Con_MessageMode_f, "input a chat message to say to everyone");
+       Cmd_AddCommand ("messagemode2", Con_MessageMode2_f, "input a chat message to say to only your team");
+       Cmd_AddCommand ("clear", Con_Clear_f, "clear console history");
+       Cmd_AddCommand ("maps", Con_Maps_f, "list information about available maps");   // By [515]
 
        con_initialized = true;
        Con_Print("Console initialized.\n");
@@ -562,9 +567,13 @@ void Con_Print(const char *msg)
 
        for (;*msg;msg++)
        {
+               // if this print is in response to an rcon command, add the character
+               // to the rcon redirect buffer
+               if (rcon_redirect && rcon_redirect_bufferpos < (int)sizeof(rcon_redirect_buffer) - 1)
+                       rcon_redirect_buffer[rcon_redirect_bufferpos++] = *msg;
+               // if this is the beginning of a new line, print timestamp
                if (index == 0)
                {
-                       // if this is the beginning of a new line, print timestamp
                        const char *timestamp = timestamps.integer ? Sys_TimeString(timeformat.string) : "";
                        // reset the color
                        // FIXME: 1. perhaps we should use a terminal system 2. use a constant instead of 7!
@@ -573,23 +582,13 @@ void Con_Print(const char *msg)
                        line[index++] = STRING_COLOR_DEFAULT + '0';
                        // special color codes for chat messages must always come first
                        // for Con_PrintToHistory to work properly
-                       if (*msg <= 2)
+                       if (*msg == 1 || *msg == 2)
                        {
+                               // play talk wav
                                if (*msg == 1)
-                               {
-                                       // play talk wav
                                        S_LocalSound ("sound/misc/talk.wav");
-                               }
-                               //if (gamemode == GAME_NEXUIZ)
-                               //{
-                                       line[index++] = STRING_COLOR_TAG;
-                                       line[index++] = '3';
-                               //}
-                               //else
-                               //{
-                               //      // go to colored text
-                               //      mask = 128;
-                               //}
+                               line[index++] = STRING_COLOR_TAG;
+                               line[index++] = '3';
                                msg++;
                        }
                        // store timestamp
@@ -748,7 +747,7 @@ void Con_DrawNotify (void)
 {
        float   x, v;
        char    *text;
-       int             i;
+       int             i, stop;
        float   time;
        char    temptext[MAX_INPUTLINE];
        int colorindex = -1; //-1 for default
@@ -761,7 +760,9 @@ void Con_DrawNotify (void)
                v = 8;
        else
                v = 0;
-       for (i= con_current-con_notify.integer+1 ; i<=con_current ; i++)
+       // make a copy of con_current here so that we can't get in a runaway loop printing new messages while drawing the notify text
+       stop = con_current;
+       for (i= stop-con_notify.integer+1 ; i<=stop ; i++)
        {
 
                if (i < 0)
@@ -775,10 +776,25 @@ void Con_DrawNotify (void)
                text = con_text + (i % con_totallines)*con_linewidth;
 
                if (gamemode == GAME_NEXUIZ) {
-                       int linewidth;
+                       int chars = 0;
+                       int finalchars = 0;
+                       int j;
 
-                       for (linewidth = con_linewidth; linewidth && text[linewidth-1] == ' '; linewidth--);
-                       x = (vid_conwidth.integer - linewidth * con_textsize.value) * 0.5;
+                       // count up to the last non-whitespace, and ignore color codes
+                       for (j = 0;j < con_linewidth && text[j];j++)
+                       {
+                               if (text[j] == '^' && (text[j+1] >= '0' && text[j+1] <= '9'))
+                               {
+                                       j++;
+                                       continue;
+                               }
+                               chars++;
+                               if (text[j] == ' ')
+                                       continue;
+                               finalchars = chars;
+                       }
+                       // center the line using the calculated width
+                       x = (vid_conwidth.integer - finalchars * con_textsize.value) * 0.5;
                } else
                        x = 0;
 
@@ -823,7 +839,7 @@ The typing input line at the bottom should only be drawn if typing is allowed
 */
 void Con_DrawConsole (int lines)
 {
-       int i, rows, j;
+       int i, rows, j, stop;
        float y;
        char *text;
        int colorindex = -1;
@@ -832,10 +848,7 @@ void Con_DrawConsole (int lines)
                return;
 
 // draw the background
-       if (scr_conbrightness.value >= 0.01f)
-               DrawQ_Pic(0, lines - vid_conheight.integer, "gfx/conback", vid_conwidth.integer, vid_conheight.integer, scr_conbrightness.value, scr_conbrightness.value, scr_conbrightness.value, scr_conalpha.value, 0);
-       else
-               DrawQ_Fill(0, lines - vid_conheight.integer, vid_conwidth.integer, vid_conheight.integer, 0, 0, 0, scr_conalpha.value, 0);
+       DrawQ_Pic(0, lines - vid_conheight.integer, scr_conbrightness.value >= 0.01f ? Draw_CachePic("gfx/conback", true) : NULL, vid_conwidth.integer, vid_conheight.integer, scr_conbrightness.value, scr_conbrightness.value, scr_conbrightness.value, scr_conalpha.value, 0);
        DrawQ_String(vid_conwidth.integer - strlen(engineversion) * con_textsize.value - con_textsize.value, lines - con_textsize.value, engineversion, 0, con_textsize.value, con_textsize.value, 1, 0, 0, 1, 0);
 
 // draw the text
@@ -844,7 +857,9 @@ void Con_DrawConsole (int lines)
        rows = (int)ceil((lines/con_textsize.value)-2);         // rows of text to draw
        y = lines - (rows+2)*con_textsize.value;        // may start slightly negative
 
-       for (i = con_current - rows + 1;i <= con_current;i++, y += con_textsize.value)
+       // make a copy of con_current here so that we can't get in a runaway loop printing new messages while drawing the notify text
+       stop = con_current;
+       for (i = stop - rows + 1;i <= stop;i++, y += con_textsize.value)
        {
                j = max(i - con_backscroll, 0);
                text = con_text + (j % con_totallines)*con_linewidth;
@@ -882,7 +897,7 @@ qboolean GetMapList (const char *s, char *completedname, int completednamebuffer
                return false;
        if (t->numfilenames > 1)
                Con_Printf("^1 %i maps found :\n", t->numfilenames);
-       len = Z_Malloc(t->numfilenames);
+       len = (unsigned char *)Z_Malloc(t->numfilenames);
        min = 666;
        for(max=i=0;i<t->numfilenames;i++)
        {
@@ -950,7 +965,7 @@ qboolean GetMapList (const char *s, char *completedname, int completednamebuffer
                        if (!entities && lumplen >= 10)
                        {
                                FS_Seek(f, lumpofs, SEEK_SET);
-                               entities = Z_Malloc(lumplen + 1);
+                               entities = (char *)Z_Malloc(lumplen + 1);
                                FS_Read(f, entities, lumplen);
                        }
                        if (entities)
@@ -962,7 +977,7 @@ qboolean GetMapList (const char *s, char *completedname, int completednamebuffer
                                for (;;)
                                {
                                        int l;
-                                       if (!COM_ParseToken(&data, false))
+                                       if (!COM_ParseTokenConsole(&data))
                                                break;
                                        if (com_token[0] == '{')
                                                continue;
@@ -973,9 +988,9 @@ qboolean GetMapList (const char *s, char *completedname, int completednamebuffer
                                        for (l = 0;l < (int)sizeof(keyname) - 1 && com_token[k+l] && com_token[k+l] > ' ';l++)
                                                keyname[l] = com_token[k+l];
                                        keyname[l] = 0;
-                                       if (!COM_ParseToken(&data, false))
+                                       if (!COM_ParseTokenConsole(&data))
                                                break;
-                                       if (developer.integer >= 2)
+                                       if (developer.integer >= 100)
                                                Con_Printf("key: %s %s\n", keyname, com_token);
                                        if (!strcmp(keyname, "message"))
                                        {
@@ -1108,7 +1123,7 @@ void Con_CompleteCommandLine (void)
                                if (GetMapList(s, t, sizeof(t)))
                                {
                                        // first move the cursor
-                                       key_linepos += strlen(t) - strlen(s);
+                                       key_linepos += (int)strlen(t) - (int)strlen(s);
 
                                        // and now do the actual work
                                        *s = 0;
@@ -1117,16 +1132,31 @@ void Con_CompleteCommandLine (void)
 
                                        // and fix the cursor
                                        if(key_linepos > (int) strlen(key_lines[edit_line]))
-                                               key_linepos = strlen(key_lines[edit_line]);
+                                               key_linepos = (int) strlen(key_lines[edit_line]);
                                }
                                return;
                        }
                }
 
-       // Count number of possible matches
+       // Count number of possible matches and print them
        c = Cmd_CompleteCountPossible(s);
+       if (c)
+       {
+               Con_Printf("\n%i possible command%s\n", c, (c > 1) ? "s: " : ":");
+               Cmd_CompleteCommandPrint(s);
+       }
        v = Cvar_CompleteCountPossible(s);
+       if (v)
+       {
+               Con_Printf("\n%i possible variable%s\n", v, (v > 1) ? "s: " : ":");
+               Cvar_CompleteCvarPrint(s);
+       }
        a = Cmd_CompleteAliasCountPossible(s);
+       if (a)
+       {
+               Con_Printf("\n%i possible aliases%s\n", a, (a > 1) ? "s: " : ":");
+               Cmd_CompleteAliasPrint(s);
+       }
 
        if (!(c + v + a))       // No possible matches
        {
@@ -1135,76 +1165,48 @@ void Con_CompleteCommandLine (void)
                return;
        }
 
-       if (c + v + a == 1) {
-               if (c)
-                       list[0] = Cmd_CompleteBuildList(s);
-               else if (v)
-                       list[0] = Cvar_CompleteBuildList(s);
-               else
-                       list[0] = Cmd_CompleteAliasBuildList(s);
-               cmd = *list[0];
-               cmd_len = (int)strlen (cmd);
-       } else {
-               if (c)
-                       cmd = *(list[0] = Cmd_CompleteBuildList(s));
-               if (v)
-                       cmd = *(list[1] = Cvar_CompleteBuildList(s));
-               if (a)
-                       cmd = *(list[2] = Cmd_CompleteAliasBuildList(s));
-
-               cmd_len = (int)strlen (s);
-               do {
-                       for (i = 0; i < 3; i++) {
-                               char ch = cmd[cmd_len];
-                               const char **l = list[i];
-                               if (l) {
-                                       while (*l && (*l)[cmd_len] == ch)
-                                               l++;
-                                       if (*l)
-                                               break;
-                               }
-                       }
-                       if (i == 3)
-                               cmd_len++;
-               } while (i == 3);
-               // 'quakebar'
-               Con_Print("\n\35");
-               for (i = 0; i < con_linewidth - 4; i++)
-                       Con_Print("\36");
-               Con_Print("\37\n");
-
-               // Print Possible Commands
-               if (c) {
-                       Con_Printf("%i possible command%s\n", c, (c > 1) ? "s: " : ":");
-                       Con_DisplayList(list[0]);
-               }
-
-               if (v) {
-                       Con_Printf("%i possible variable%s\n", v, (v > 1) ? "s: " : ":");
-                       Con_DisplayList(list[1]);
-               }
+       if (c)
+               cmd = *(list[0] = Cmd_CompleteBuildList(s));
+       if (v)
+               cmd = *(list[1] = Cvar_CompleteBuildList(s));
+       if (a)
+               cmd = *(list[2] = Cmd_CompleteAliasBuildList(s));
 
-               if (a) {
-                       Con_Printf("%i possible aliases%s\n", a, (a > 1) ? "s: " : ":");
-                       Con_DisplayList(list[2]);
+       for (cmd_len = (int)strlen(s);;cmd_len++)
+       {
+               const char **l;
+               for (i = 0; i < 3; i++)
+                       if (list[i])
+                               for (l = list[i];*l;l++)
+                                       if ((*l)[cmd_len] != cmd[cmd_len])
+                                               goto done;
+               // all possible matches share this character, so we continue...
+               if (!cmd[cmd_len])
+               {
+                       // if all matches ended at the same position, stop
+                       // (this means there is only one match)
+                       break;
                }
        }
+done:
 
-       if (cmd) {
-               strncpy(key_lines[edit_line] + pos, cmd, cmd_len);
-               key_linepos = cmd_len + pos;
-               if (c + v + a == 1) {
-                       key_lines[edit_line][key_linepos] = ' ';
-                       key_linepos++;
-               }
-               if(s2[0])
-                       strcpy(&key_lines[edit_line][key_linepos], s2);
-               else
-                       key_lines[edit_line][key_linepos] = 0;
+       // prevent a buffer overrun by limiting cmd_len according to remaining space
+       cmd_len = min(cmd_len, (int)sizeof(key_lines[edit_line]) - 1 - pos);
+       if (cmd)
+       {
+               key_linepos = pos;
+               memcpy(&key_lines[edit_line][key_linepos], cmd, cmd_len);
+               key_linepos += cmd_len;
+               // if there is only one match, add a space after it
+               if (c + v + a == 1 && key_linepos < (int)sizeof(key_lines[edit_line]) - 1)
+                       key_lines[edit_line][key_linepos++] = ' ';
        }
-       else
-               if(s2[0])
-                       strcpy(&key_lines[edit_line][key_linepos], s2);
+
+       // use strlcat to avoid a buffer overrun
+       key_lines[edit_line][key_linepos] = 0;
+       strlcat(key_lines[edit_line], s2, sizeof(key_lines[edit_line]));
+
+       // free the command, cvar, and alias lists
        for (i = 0; i < 3; i++)
                if (list[i])
                        Mem_Free((void *)list[i]);