]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - console.c
fix two pointer bugs in ODE code
[xonotic/darkplaces.git] / console.c
index 5648a491bdaf28aca4d5954ce62e38cc3c3fbab2..fc29e5f789742f22a297d8e6891c335508990222 100644 (file)
--- a/console.c
+++ b/console.c
@@ -36,13 +36,8 @@ int con_backscroll;
 
 conbuffer_t con;
 
-#define CON_LINES_IDX(i) CONBUFFER_LINES_IDX(&con, i)
-#define CON_LINES_UNIDX(i) CONBUFFER_LINES_UNIDX(&con, i)
-#define CON_LINES_LAST CONBUFFER_LINES_LAST(&con)
 #define CON_LINES(i) CONBUFFER_LINES(&con, i)
-#define CON_LINES_PRED(i) CONBUFFER_LINES_PRED(&con, i)
-#define CON_LINES_SUCC(i) CONBUFFER_LINES_SUCC(&con, i)
-#define CON_LINES_FIRST CONBUFFER_LINES_FIRST(&con)
+#define CON_LINES_LAST CONBUFFER_LINES_LAST(&con)
 #define CON_LINES_COUNT CONBUFFER_LINES_COUNT(&con)
 
 cvar_t con_notifytime = {CVAR_SAVE, "con_notifytime","3", "how long notify lines last, in seconds"};
@@ -56,6 +51,7 @@ cvar_t con_chatwidth = {CVAR_SAVE, "con_chatwidth","1.0", "relative chat window
 cvar_t con_textsize = {CVAR_SAVE, "con_textsize","8", "console text size in virtual 2D pixels"};
 cvar_t con_notifysize = {CVAR_SAVE, "con_notifysize","8", "notify text size in virtual 2D pixels"};
 cvar_t con_chatsize = {CVAR_SAVE, "con_chatsize","8", "chat text size in virtual 2D pixels (if con_chat is enabled)"};
+cvar_t con_chatsound = {CVAR_SAVE, "con_chatsound","1", "enables chat sound to play on message"};
 
 
 cvar_t sys_specialcharactertranslation = {0, "sys_specialcharactertranslation", "1", "terminal console conchars to ASCII translation (set to 0 if your conchars.tga is for an 8bit character set or if you want raw output)"};
@@ -80,9 +76,9 @@ cvar_t con_nickcompletion_flags = {CVAR_SAVE, "con_nickcompletion_flags", "11",
 #define NICKS_ALPHANUMERICS_ONLY 8
 #define NICKS_NO_SPACES 16
 
-cvar_t con_completion_playdemo = {CVAR_SAVE, "con_completion_playdemo", "*.dem"};
-cvar_t con_completion_timedemo = {CVAR_SAVE, "con_completion_timedemo", "*.dem"};
-cvar_t con_completion_exec = {CVAR_SAVE, "con_completion_exec", "*.cfg"};
+cvar_t con_completion_playdemo = {CVAR_SAVE, "con_completion_playdemo", "*.dem", "completion pattern for the playdemo command"};
+cvar_t con_completion_timedemo = {CVAR_SAVE, "con_completion_timedemo", "*.dem", "completion pattern for the timedemo command"};
+cvar_t con_completion_exec = {CVAR_SAVE, "con_completion_exec", "*.cfg", "completion pattern for the exec command"};
 
 int con_linewidth;
 int con_vislines;
@@ -100,9 +96,9 @@ char rcon_redirect_buffer[1400];
 void ConBuffer_Init(conbuffer_t *buf, int textsize, int maxlines, mempool_t *mempool)
 {
        buf->textsize = textsize;
-       buf->text = Mem_Alloc(mempool, textsize);
+       buf->text = (char *) Mem_Alloc(mempool, textsize);
        buf->maxlines = maxlines;
-       buf->lines = Mem_Alloc(mempool, maxlines * sizeof(*buf->lines));
+       buf->lines = (con_lineinfo_t *) Mem_Alloc(mempool, maxlines * sizeof(*buf->lines));
        buf->lines_first = 0;
        buf->lines_count = 0;
 }
@@ -144,7 +140,7 @@ void ConBuffer_FixTimes(conbuffer_t *buf)
        int i;
        if(buf->lines_count >= 1)
        {
-               double diff = cl.time - (buf->lines + CONBUFFER_LINES_LAST(buf))->addtime;
+               double diff = cl.time - CONBUFFER_LINES_LAST(buf).addtime;
                if(diff < 0)
                {
                        for(i = 0; i < buf->lines_count; ++i)
@@ -165,7 +161,7 @@ void ConBuffer_DeleteLine(conbuffer_t *buf)
        if(buf->lines_count == 0)
                return;
        --buf->lines_count;
-       buf->lines_first = CONBUFFER_LINES_IDX(buf, 1);
+       buf->lines_first = (buf->lines_first + 1) % buf->maxlines;
 }
 
 /*
@@ -199,7 +195,7 @@ static char *ConBuffer_BytesLeft(conbuffer_t *buf, int len)
        else
        {
                char *firstline_start = buf->lines[buf->lines_first].start;
-               char *lastline_onepastend = buf->lines[CONBUFFER_LINES_LAST(buf)].start + buf->lines[CONBUFFER_LINES_LAST(buf)].len;
+               char *lastline_onepastend = CONBUFFER_LINES_LAST(buf).start + CONBUFFER_LINES_LAST(buf).len;
                // the buffer is cyclic, so we first have two cases...
                if(firstline_start < lastline_onepastend) // buffer is contiguous
                {
@@ -251,7 +247,7 @@ void ConBuffer_AddLine(conbuffer_t *buf, const char *line, int len, int mask)
 
        //fprintf(stderr, "Now have %d lines (%d -> %d).\n", buf->lines_count, buf->lines_first, CON_LINES_LAST);
 
-       p = buf->lines + CONBUFFER_LINES_LAST(buf);
+       p = &CONBUFFER_LINES_LAST(buf);
        p->start = putpos;
        p->len = len;
        p->addtime = cl.time;
@@ -314,6 +310,8 @@ LOGGING
 ==============================================================================
 */
 
+/// \name Logging
+//@{
 cvar_t log_file = {0, "log_file","", "filename to log messages to"};
 cvar_t log_dest_udp = {0, "log_dest_udp","", "UDP address to log messages to (in QW rcon compatible format); multiple destinations can be separated by spaces; DO NOT SPECIFY DNS NAMES HERE"};
 char log_dest_buffer[1400]; // UDP packet
@@ -327,13 +325,13 @@ size_t logq_ind = 0;
 size_t logq_size = 0;
 
 void Log_ConPrint (const char *msg);
-
+//@}
 /*
 ====================
 Log_DestBuffer_Init
 ====================
 */
-static void Log_DestBuffer_Init()
+static void Log_DestBuffer_Init(void)
 {
        memcpy(log_dest_buffer, "\377\377\377\377n", 5); // QW rcon print
        log_dest_buffer_pos = 5;
@@ -344,7 +342,7 @@ static void Log_DestBuffer_Init()
 Log_DestBuffer_Flush
 ====================
 */
-void Log_DestBuffer_Flush()
+void Log_DestBuffer_Flush(void)
 {
        lhnetaddress_t log_dest_addr;
        lhnetsocket_t *log_dest_socket;
@@ -594,8 +592,6 @@ void Con_ToggleConsole_f (void)
 /*
 ================
 Con_ClearNotify
-
-Clear all notify lines.
 ================
 */
 void Con_ClearNotify (void)
@@ -615,6 +611,8 @@ void Con_MessageMode_f (void)
 {
        key_dest = key_message;
        chat_mode = 0; // "say"
+       chat_bufferlen = 0;
+       chat_buffer[0] = 0;
 }
 
 
@@ -627,6 +625,8 @@ void Con_MessageMode2_f (void)
 {
        key_dest = key_message;
        chat_mode = 1; // "say_team"
+       chat_bufferlen = 0;
+       chat_buffer[0] = 0;
 }
 
 /*
@@ -648,8 +648,6 @@ void Con_CommandMode_f (void)
 /*
 ================
 Con_CheckResize
-
-If the line width has changed, reformat the buffer.
 ================
 */
 void Con_CheckResize (void)
@@ -714,7 +712,7 @@ void Con_ConDump_f (void)
        FS_Close(file);
 }
 
-void Con_Clear_f ()
+void Con_Clear_f (void)
 {
        ConBuffer_Clear(&con);
 }
@@ -756,6 +754,7 @@ void Con_Init (void)
        Cvar_RegisterVariable (&con_notifysize);
        Cvar_RegisterVariable (&con_notifytime);
        Cvar_RegisterVariable (&con_textsize);
+       Cvar_RegisterVariable (&con_chatsound);
 
        // --blub
        Cvar_RegisterVariable (&con_nickcompletion);
@@ -837,7 +836,7 @@ void Con_PrintToHistory(const char *txt, int mask)
        }
 }
 
-/* The translation table between the graphical font and plain ASCII  --KB */
+/*! The translation table between the graphical font and plain ASCII  --KB */
 static char qfont_table[256] = {
        '\0', '#',  '#',  '#',  '#',  '.',  '#',  '#',
        '#',  9,    10,   '#',  ' ',  13,   '.',  '.',
@@ -882,7 +881,7 @@ void Con_Rcon_Redirect_Init(lhnetsocket_t *sock, lhnetaddress_t *dest)
        rcon_redirect_bufferpos = 5;
 }
 
-void Con_Rcon_Redirect_Flush()
+void Con_Rcon_Redirect_Flush(void)
 {
        rcon_redirect_buffer[rcon_redirect_bufferpos] = 0;
        NetConn_WriteString(rcon_redirect_sock, rcon_redirect_buffer, rcon_redirect_dest);
@@ -890,14 +889,14 @@ void Con_Rcon_Redirect_Flush()
        rcon_redirect_bufferpos = 5;
 }
 
-void Con_Rcon_Redirect_End()
+void Con_Rcon_Redirect_End(void)
 {
        Con_Rcon_Redirect_Flush();
        rcon_redirect_dest = NULL;
        rcon_redirect_sock = NULL;
 }
 
-void Con_Rcon_Redirect_Abort()
+void Con_Rcon_Redirect_Abort(void)
 {
        rcon_redirect_dest = NULL;
        rcon_redirect_sock = NULL;
@@ -906,10 +905,9 @@ void Con_Rcon_Redirect_Abort()
 /*
 ================
 Con_Rcon_AddChar
-
-Adds a character to the rcon buffer
 ================
 */
+/// Adds a character to the rcon buffer.
 void Con_Rcon_AddChar(int c)
 {
        if(log_dest_buffer_appending)
@@ -1005,8 +1003,6 @@ static char Sys_Con_NearestColor(const unsigned char _r, const unsigned char _g,
 /*
 ================
 Con_Print
-
-Prints to all appropriate console targets, and adds timestamps
 ================
 */
 extern cvar_t timestamps;
@@ -1037,19 +1033,22 @@ void Con_Print(const char *msg)
                                // play talk wav
                                if (*msg == 1)
                                {
-                                       if(gamemode == GAME_NEXUIZ)
-                                       {
-                                               if(msg[1] == '\r' && cl.foundtalk2wav)
-                                                       S_LocalSound ("sound/misc/talk2.wav");
-                                               else
-                                                       S_LocalSound ("sound/misc/talk.wav");
-                                       }
-                                       else
+                                       if (con_chatsound.value)
                                        {
-                                               if (msg[1] == '(' && cl.foundtalk2wav)
-                                                       S_LocalSound ("sound/misc/talk2.wav");
+                                               if(gamemode == GAME_NEXUIZ)
+                                               {
+                                                       if(msg[1] == '\r' && cl.foundtalk2wav)
+                                                               S_LocalSound ("sound/misc/talk2.wav");
+                                                       else
+                                                               S_LocalSound ("sound/misc/talk.wav");
+                                               }
                                                else
-                                                       S_LocalSound ("sound/misc/talk.wav");
+                                               {
+                                                       if (msg[1] == '(' && cl.foundtalk2wav)
+                                                               S_LocalSound ("sound/misc/talk2.wav");
+                                                       else
+                                                               S_LocalSound ("sound/misc/talk.wav");
+                                               }
                                        }
                                        mask = CON_MASK_CHAT;
                                }
@@ -1271,8 +1270,6 @@ void Con_Print(const char *msg)
 /*
 ================
 Con_Printf
-
-Prints to all appropriate console targets
 ================
 */
 void Con_Printf(const char *fmt, ...)
@@ -1290,8 +1287,6 @@ void Con_Printf(const char *fmt, ...)
 /*
 ================
 Con_DPrint
-
-A Con_Print that only shows up if the "developer" cvar is set
 ================
 */
 void Con_DPrint(const char *msg)
@@ -1304,8 +1299,6 @@ void Con_DPrint(const char *msg)
 /*
 ================
 Con_DPrintf
-
-A Con_Printf that only shows up if the "developer" cvar is set
 ================
 */
 void Con_DPrintf(const char *fmt, ...)
@@ -1629,6 +1622,7 @@ int Con_MeasureConsoleLine(int lineno)
 {
        float width = vid_conwidth.value;
        con_text_info_t ti;
+       con_lineinfo_t *li = &CON_LINES(lineno);
 
        //if(con.lines[lineno].mask & CON_MASK_LOADEDHISTORY)
        //      return 0;
@@ -1636,8 +1630,7 @@ int Con_MeasureConsoleLine(int lineno)
        ti.fontsize = con_textsize.value;
        ti.font = FONT_CONSOLE;
 
-       return COM_Wordwrap(con.lines[lineno].start, con.lines[lineno].len, 0, width, Con_WordWidthFunc, &ti, Con_CountLineFunc, NULL);
-               // FIXME uses con in a non abstracted way
+       return COM_Wordwrap(li->start, li->len, 0, width, Con_WordWidthFunc, &ti, Con_CountLineFunc, NULL);
 }
 
 /*
@@ -1649,11 +1642,11 @@ Returns the height of a given console line; calculates it if necessary.
 */
 int Con_LineHeight(int i)
 {
-       int h = con.lines[i].height;
+       con_lineinfo_t *li = &CON_LINES(i);
+       int h = li->height;
        if(h != -1)
                return h;
-       return con.lines[i].height = Con_MeasureConsoleLine(i);
-               // FIXME uses con in a non abstracted way
+       return li->height = Con_MeasureConsoleLine(i);
 }
 
 /*
@@ -1669,6 +1662,7 @@ int Con_DrawConsoleLine(float y, int lineno, float ymin, float ymax)
 {
        float width = vid_conwidth.value;
        con_text_info_t ti;
+       con_lineinfo_t *li = &CON_LINES(lineno);
 
        //if(con.lines[lineno].mask & CON_MASK_LOADEDHISTORY)
        //      return 0;
@@ -1683,8 +1677,7 @@ int Con_DrawConsoleLine(float y, int lineno, float ymin, float ymax)
        ti.ymax = ymax;
        ti.width = width;
 
-       return COM_Wordwrap(con.lines[lineno].start, con.lines[lineno].len, 0, width, Con_WordWidthFunc, &ti, Con_DisplayLineFunc, &ti);
-               // FIXME uses con in a non abstracted way
+       return COM_Wordwrap(li->start, li->len, 0, width, Con_WordWidthFunc, &ti, Con_DisplayLineFunc, &ti);
 }
 
 /*
@@ -1698,15 +1691,14 @@ con_backscroll.
 void Con_LastVisibleLine(int *last, int *limitlast)
 {
        int lines_seen = 0;
-       int ic;
+       int i;
 
        if(con_backscroll < 0)
                con_backscroll = 0;
 
        // now count until we saw con_backscroll actual lines
-       for(ic = 0; ic < CON_LINES_COUNT; ++ic)
+       for(i = CON_LINES_COUNT - 1; i >= 0; --i)
        {
-               int i = CON_LINES_IDX(CON_LINES_COUNT - 1 - ic);
                int h = Con_LineHeight(i);
 
                // line is the last visible line?
@@ -1758,20 +1750,19 @@ void Con_DrawConsole (int lines)
                y = ymax - con_textsize.value;
 
                if(limitlast)
-                       y += (con.lines[last].height - limitlast) * con_textsize.value;
+                       y += (CON_LINES(last).height - limitlast) * con_textsize.value;
                                // FIXME uses con in a non abstracted way
                i = last;
 
                for(;;)
                {
                        y -= Con_DrawConsoleLine(y, i, 0, ymax) * con_textsize.value;
-                       if(i == con.lines_first)
-                               // FIXME uses con in a non abstracted way
+                       if(i == 0)
                                break; // top of console buffer
                        if(y < 0)
                                break; // top of console window
                        limitlast = 0;
-                       i = CON_LINES_PRED(i);
+                       --i;
                }
        }