]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - cvar.c
Reworked v_isometric code significantly, it now defaults to a proper isometric view...
[xonotic/darkplaces.git] / cvar.c
diff --git a/cvar.c b/cvar.c
index 111550a8632107df7d141d4aebf2592965cdc128..2a0acae8edefad814c472bf0df404c64b6e7925e 100644 (file)
--- a/cvar.c
+++ b/cvar.c
@@ -21,11 +21,11 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
 #include "quakedef.h"
 
-char *cvar_dummy_description = "custom cvar";
+const char *cvar_dummy_description = "custom cvar";
 
 cvar_t *cvar_vars = NULL;
 cvar_t *cvar_hashtable[CVAR_HASHSIZE];
-char *cvar_null_string = "";
+const char *cvar_null_string = "";
 
 /*
 ============
@@ -70,37 +70,76 @@ cvar_t *Cvar_FindVarAfter (const char *prev_var_name, int neededflags)
        return var;
 }
 
+static cvar_t *Cvar_FindVarLink (const char *var_name, cvar_t **parent, cvar_t ***link, cvar_t **prev_alpha)
+{
+       int hashindex;
+       cvar_t *var;
+
+       // use hash lookup to minimize search time
+       hashindex = CRC_Block((const unsigned char *)var_name, strlen(var_name));
+       if(parent) *parent = NULL;
+       if(prev_alpha) *prev_alpha = NULL;
+       if(link) *link = &cvar_hashtable[hashindex];
+       for (var = cvar_hashtable[hashindex];var;var = var->nextonhashchain)
+       {
+               if (!strcmp (var_name, var->name))
+               {
+                       if(!prev_alpha || var == cvar_vars)
+                               return var;
+
+                       *prev_alpha = cvar_vars;
+                       // if prev_alpha happens to become NULL then there has been some inconsistency elsewhere
+                       // already - should I still insert '*prev_alpha &&' in the loop?
+                       while((*prev_alpha)->next != var)
+                               *prev_alpha = (*prev_alpha)->next;
+                       return var;
+               }
+               if(parent) *parent = var;
+       }
+
+       return NULL;
+}
+
 /*
 ============
 Cvar_VariableValue
 ============
 */
-float Cvar_VariableValue (const char *var_name)
+float Cvar_VariableValueOr (const char *var_name, float def)
 {
        cvar_t *var;
 
        var = Cvar_FindVar (var_name);
        if (!var)
-               return 0;
+               return def;
        return atof (var->string);
 }
 
+float Cvar_VariableValue (const char *var_name)
+{
+       return Cvar_VariableValueOr(var_name, 0);
+}
 
 /*
 ============
 Cvar_VariableString
 ============
 */
-const char *Cvar_VariableString (const char *var_name)
+const char *Cvar_VariableStringOr (const char *var_name, const char *def)
 {
        cvar_t *var;
 
        var = Cvar_FindVar (var_name);
        if (!var)
-               return cvar_null_string;
+               return def;
        return var->string;
 }
 
+const char *Cvar_VariableString (const char *var_name)
+{
+       return Cvar_VariableStringOr(var_name, cvar_null_string);
+}
+
 /*
 ============
 Cvar_VariableDefString
@@ -223,16 +262,84 @@ void Cvar_CompleteCvarPrint (const char *partial)
                        Con_Printf ("^3%s^7 is \"%s\" [\"%s\"] %s\n", cvar->name, cvar->string, cvar->defstring, cvar->description);
 }
 
+// check if a cvar is held by some progs
+static qboolean Cvar_IsAutoCvar(cvar_t *var)
+{
+       int i;
+       prvm_prog_t *prog;
+       for (i = 0;i < PRVM_PROG_MAX;i++)
+       {
+               prog = &prvm_prog_list[i];
+               if (prog->loaded && var->globaldefindex[i] >= 0)
+                       return true;
+       }
+       return false;
+}
+
+// we assume that prog is already set to the target progs
+static void Cvar_UpdateAutoCvar(cvar_t *var)
+{
+       int i;
+       int j;
+       const char *s;
+       vec3_t v;
+       prvm_prog_t *prog;
+       for (i = 0;i < PRVM_PROG_MAX;i++)
+       {
+               prog = &prvm_prog_list[i];
+               if (prog->loaded && var->globaldefindex[i] >= 0)
+               {
+                       // MUST BE SYNCED WITH prvm_edict.c PRVM_LoadProgs
+                       switch(prog->globaldefs[var->globaldefindex[i]].type & ~DEF_SAVEGLOBAL)
+                       {
+                       case ev_float:
+                               PRVM_GLOBALFIELDFLOAT(prog->globaldefs[var->globaldefindex[i]].ofs) = var->value;
+                               break;
+                       case ev_vector:
+                               s = var->string;
+                               VectorClear(v);
+                               for (j = 0;j < 3;j++)
+                               {
+                                       while (*s && ISWHITESPACE(*s))
+                                               s++;
+                                       if (!*s)
+                                               break;
+                                       v[j] = atof(s);
+                                       while (!ISWHITESPACE(*s))
+                                               s++;
+                                       if (!*s)
+                                               break;
+                               }
+                               VectorCopy(v, PRVM_GLOBALFIELDVECTOR(prog->globaldefs[var->globaldefindex[i]].ofs));
+                               break;
+                       case ev_string:
+                               PRVM_ChangeEngineString(prog, var->globaldefindex_stringno[i], var->string);
+                               PRVM_GLOBALFIELDSTRING(prog->globaldefs[var->globaldefindex[i]].ofs) = var->globaldefindex_stringno[i];
+                               break;
+                       }
+               }
+       }
+}
+
+// called after loading a savegame
+void Cvar_UpdateAllAutoCvars(void)
+{
+       cvar_t *var;
+       for (var = cvar_vars ; var ; var = var->next)
+               Cvar_UpdateAutoCvar(var);
+}
 
 /*
 ============
 Cvar_Set
 ============
 */
-void Cvar_SetQuick_Internal (cvar_t *var, const char *value)
+extern cvar_t sv_disablenotify;
+static void Cvar_SetQuick_Internal (cvar_t *var, const char *value)
 {
        qboolean changed;
        size_t valuelen;
+       char vabuf[1024];
 
        changed = strcmp(var->string, value) != 0;
        // LordHavoc: don't reallocate when there is no change
@@ -243,14 +350,14 @@ void Cvar_SetQuick_Internal (cvar_t *var, const char *value)
        valuelen = strlen(value);
        if (!var->string || strlen(var->string) != valuelen)
        {
-               Z_Free (var->string);   // free the old value string
+               Z_Free ((char *)var->string);   // free the old value string
 
                var->string = (char *)Z_Malloc (valuelen + 1);
        }
-       memcpy (var->string, value, valuelen + 1);
+       memcpy ((char *)var->string, value, valuelen + 1);
        var->value = atof (var->string);
        var->integer = (int) var->value;
-       if ((var->flags & CVAR_NOTIFY) && changed && sv.active)
+       if ((var->flags & CVAR_NOTIFY) && changed && sv.active && !sv_disablenotify.integer)
                SV_BroadcastPrintf("\"%s\" changed to \"%s\"\n", var->name, var->string);
 #if 0
        // TODO: add infostring support to the server?
@@ -278,16 +385,18 @@ void Cvar_SetQuick_Internal (cvar_t *var, const char *value)
                if (!strcmp(var->name, "_cl_color"))
                {
                        int top = (var->integer >> 4) & 15, bottom = var->integer & 15;
-                       CL_SetInfo("topcolor", va("%i", top), true, false, false, false);
-                       CL_SetInfo("bottomcolor", va("%i", bottom), true, false, false, false);
+                       CL_SetInfo("topcolor", va(vabuf, sizeof(vabuf), "%i", top), true, false, false, false);
+                       CL_SetInfo("bottomcolor", va(vabuf, sizeof(vabuf), "%i", bottom), true, false, false, false);
                        if (cls.protocol != PROTOCOL_QUAKEWORLD && cls.netcon)
                        {
                                MSG_WriteByte(&cls.netcon->message, clc_stringcmd);
-                               MSG_WriteString(&cls.netcon->message, va("color %i %i", top, bottom));
+                               MSG_WriteString(&cls.netcon->message, va(vabuf, sizeof(vabuf), "color %i %i", top, bottom));
                        }
                }
                else if (!strcmp(var->name, "_cl_rate"))
-                       CL_SetInfo("rate", va("%i", var->integer), true, false, false, false);
+                       CL_SetInfo("rate", va(vabuf, sizeof(vabuf), "%i", var->integer), true, false, false, false);
+               else if (!strcmp(var->name, "_cl_rate_burstsize"))
+                       CL_SetInfo("rate_burstsize", va(vabuf, sizeof(vabuf), "%i", var->integer), true, false, false, false);
                else if (!strcmp(var->name, "_cl_playerskin"))
                        CL_SetInfo("playerskin", var->string, true, false, false, false);
                else if (!strcmp(var->name, "_cl_playermodel"))
@@ -302,9 +411,13 @@ void Cvar_SetQuick_Internal (cvar_t *var, const char *value)
                        if(var->integer <= 0)
                                Cvar_Set("rcon_password", "");
                }
+#ifdef CONFIG_MENU
                else if (!strcmp(var->name, "net_slist_favorites"))
                        NetConn_UpdateFavorites();
+#endif
        }
+
+       Cvar_UpdateAutoCvar(var);
 }
 
 void Cvar_SetQuick (cvar_t *var, const char *value)
@@ -315,8 +428,8 @@ void Cvar_SetQuick (cvar_t *var, const char *value)
                return;
        }
 
-       if (developer.integer >= 100)
-               Con_Printf("Cvar_SetQuick({\"%s\", \"%s\", %i, \"%s\"}, \"%s\");\n", var->name, var->string, var->flags, var->defstring, value);
+       if (developer_extra.integer)
+               Con_DPrintf("Cvar_SetQuick({\"%s\", \"%s\", %i, \"%s\"}, \"%s\");\n", var->name, var->string, var->flags, var->defstring, value);
 
        Cvar_SetQuick_Internal(var, value);
 }
@@ -373,9 +486,10 @@ void Cvar_RegisterVariable (cvar_t *variable)
        cvar_t *current, *next, *cvar;
        char *oldstr;
        size_t alloclen;
+       int i;
 
-       if (developer.integer >= 100)
-               Con_Printf("Cvar_RegisterVariable({\"%s\", \"%s\", %i});\n", variable->name, variable->string, variable->flags);
+       if (developer_extra.integer)
+               Con_DPrintf("Cvar_RegisterVariable({\"%s\", \"%s\", %i});\n", variable->name, variable->string, variable->flags);
 
 // first check to see if it has already been defined
        cvar = Cvar_FindVar (variable->name);
@@ -383,8 +497,8 @@ void Cvar_RegisterVariable (cvar_t *variable)
        {
                if (cvar->flags & CVAR_ALLOCATED)
                {
-                       if (developer.integer >= 100)
-                               Con_Printf("...  replacing existing allocated cvar {\"%s\", \"%s\", %i}\n", cvar->name, cvar->string, cvar->flags);
+                       if (developer_extra.integer)
+                               Con_DPrintf("...  replacing existing allocated cvar {\"%s\", \"%s\", %i}\n", cvar->name, cvar->string, cvar->flags);
                        // fixed variables replace allocated ones
                        // (because the engine directly accesses fixed variables)
                        // NOTE: this isn't actually used currently
@@ -395,6 +509,9 @@ void Cvar_RegisterVariable (cvar_t *variable)
                        variable->defstring = cvar->defstring;
                        variable->value = atof (variable->string);
                        variable->integer = (int) variable->value;
+                       // Preserve autocvar status.
+                       memcpy(variable->globaldefindex, cvar->globaldefindex, sizeof(variable->globaldefindex));
+                       memcpy(variable->globaldefindex_stringno, cvar->globaldefindex_stringno, sizeof(variable->globaldefindex_stringno));
                        // replace cvar with this one...
                        variable->next = cvar->next;
                        if (cvar_vars == cvar)
@@ -412,11 +529,11 @@ void Cvar_RegisterVariable (cvar_t *variable)
 
                        // get rid of old allocated cvar
                        // (but not cvar->string and cvar->defstring, because we kept those)
-                       Z_Free(cvar->name);
+                       Z_Free((char *)cvar->name);
                        Z_Free(cvar);
                }
                else
-                       Con_Printf("Can't register variable %s, already defined\n", variable->name);
+                       Con_DPrintf("Can't register variable %s, already defined\n", variable->name);
                return;
        }
 
@@ -428,15 +545,19 @@ void Cvar_RegisterVariable (cvar_t *variable)
        }
 
 // copy the value off, because future sets will Z_Free it
-       oldstr = variable->string;
+       oldstr = (char *)variable->string;
        alloclen = strlen(variable->string) + 1;
        variable->string = (char *)Z_Malloc (alloclen);
-       memcpy (variable->string, oldstr, alloclen);
+       memcpy ((char *)variable->string, oldstr, alloclen);
        variable->defstring = (char *)Z_Malloc (alloclen);
-       memcpy (variable->defstring, oldstr, alloclen);
+       memcpy ((char *)variable->defstring, oldstr, alloclen);
        variable->value = atof (variable->string);
        variable->integer = (int) variable->value;
 
+       // Mark it as not an autocvar.
+       for (i = 0;i < PRVM_PROG_MAX;i++)
+               variable->globaldefindex[i] = -1;
+
 // link the variable in
 // alphanumerical order
        for( current = NULL, next = cvar_vars ; next && strcmp( next->name, variable->name ) < 0 ; current = next, next = next->next )
@@ -465,10 +586,10 @@ cvar_t *Cvar_Get (const char *name, const char *value, int flags, const char *ne
 {
        int hashindex;
        cvar_t *current, *next, *cvar;
-       size_t alloclen;
+       int i;
 
-       if (developer.integer >= 100)
-               Con_Printf("Cvar_Get(\"%s\", \"%s\", %i);\n", name, value, flags);
+       if (developer_extra.integer)
+               Con_DPrintf("Cvar_Get(\"%s\", \"%s\", %i);\n", name, value, flags);
 
 // first check to see if it has already been defined
        cvar = Cvar_FindVar (name);
@@ -479,14 +600,10 @@ cvar_t *Cvar_Get (const char *name, const char *value, int flags, const char *ne
                if(newdescription && (cvar->flags & CVAR_ALLOCATED))
                {
                        if(cvar->description != cvar_dummy_description)
-                               Z_Free(cvar->description);
+                               Z_Free((char *)cvar->description);
 
                        if(*newdescription)
-                       {
-                               alloclen = strlen(newdescription) + 1;
-                               cvar->description = (char *)Z_Malloc(alloclen);
-                               memcpy(cvar->description, newdescription, alloclen);
-                       }
+                               cvar->description = (char *)Mem_strdup(zonemempool, newdescription);
                        else
                                cvar->description = cvar_dummy_description;
                }
@@ -512,26 +629,21 @@ cvar_t *Cvar_Get (const char *name, const char *value, int flags, const char *ne
 // FIXME: these never get Z_Free'd
        cvar = (cvar_t *)Z_Malloc(sizeof(cvar_t));
        cvar->flags = flags | CVAR_ALLOCATED;
-       alloclen = strlen(name) + 1;
-       cvar->name = (char *)Z_Malloc(alloclen);
-       memcpy(cvar->name, name, alloclen);
-       alloclen = strlen(value) + 1;
-       cvar->string = (char *)Z_Malloc(alloclen);
-       memcpy(cvar->string, value, alloclen);
-       cvar->defstring = (char *)Z_Malloc(alloclen);
-       memcpy(cvar->defstring, value, alloclen);
+       cvar->name = (char *)Mem_strdup(zonemempool, name);
+       cvar->string = (char *)Mem_strdup(zonemempool, value);
+       cvar->defstring = (char *)Mem_strdup(zonemempool, value);
        cvar->value = atof (cvar->string);
        cvar->integer = (int) cvar->value;
 
        if(newdescription && *newdescription)
-       {
-               alloclen = strlen(newdescription) + 1;
-               cvar->description = (char *)Z_Malloc(alloclen);
-               memcpy(cvar->description, newdescription, alloclen);
-       }
+               cvar->description = (char *)Mem_strdup(zonemempool, newdescription);
        else
                cvar->description = cvar_dummy_description; // actually checked by VM_cvar_type
 
+       // Mark it as not an autocvar.
+       for (i = 0;i < PRVM_PROG_MAX;i++)
+               cvar->globaldefindex[i] = -1;
+
 // link the variable in
 // alphanumerical order
        for( current = NULL, next = cvar_vars ; next && strcmp( next->name, cvar->name ) < 0 ; current = next, next = next->next )
@@ -574,7 +686,7 @@ qboolean    Cvar_Command (void)
                return true;
        }
 
-       if (developer.integer >= 100)
+       if (developer_extra.integer)
                Con_DPrint("Cvar_Command: ");
 
        if (v->flags & CVAR_READONLY)
@@ -583,7 +695,7 @@ qboolean    Cvar_Command (void)
                return true;
        }
        Cvar_Set (v->name, Cmd_Argv(1));
-       if (developer.integer >= 100)
+       if (developer_extra.integer)
                Con_DPrint("\n");
        return true;
 }
@@ -610,14 +722,105 @@ void Cvar_LockDefaults_f (void)
 
                        //Con_Printf("locking cvar %s (%s -> %s)\n", var->name, var->string, var->defstring);
                        var->flags |= CVAR_DEFAULTSET;
-                       Z_Free(var->defstring);
+                       Z_Free((char *)var->defstring);
                        alloclen = strlen(var->string) + 1;
                        var->defstring = (char *)Z_Malloc(alloclen);
-                       memcpy(var->defstring, var->string, alloclen);
+                       memcpy((char *)var->defstring, var->string, alloclen);
                }
        }
 }
 
+void Cvar_SaveInitState(void)
+{
+       cvar_t *c;
+       for (c = cvar_vars;c;c = c->next)
+       {
+               c->initstate = true;
+               c->initflags = c->flags;
+               c->initdefstring = Mem_strdup(zonemempool, c->defstring);
+               c->initstring = Mem_strdup(zonemempool, c->string);
+               c->initvalue = c->value;
+               c->initinteger = c->integer;
+               VectorCopy(c->vector, c->initvector);
+       }
+}
+
+void Cvar_RestoreInitState(void)
+{
+       int hashindex;
+       cvar_t *c, **cp;
+       cvar_t *c2, **cp2;
+       for (cp = &cvar_vars;(c = *cp);)
+       {
+               if (c->initstate)
+               {
+                       // restore this cvar, it existed at init
+                       if (((c->flags ^ c->initflags) & CVAR_MAXFLAGSVAL)
+                        || strcmp(c->defstring ? c->defstring : "", c->initdefstring ? c->initdefstring : "")
+                        || strcmp(c->string ? c->string : "", c->initstring ? c->initstring : ""))
+                       {
+                               Con_DPrintf("Cvar_RestoreInitState: Restoring cvar \"%s\"\n", c->name);
+                               if (c->defstring)
+                                       Z_Free((char *)c->defstring);
+                               c->defstring = Mem_strdup(zonemempool, c->initdefstring);
+                               if (c->string)
+                                       Z_Free((char *)c->string);
+                               c->string = Mem_strdup(zonemempool, c->initstring);
+                       }
+                       c->flags = c->initflags;
+                       c->value = c->initvalue;
+                       c->integer = c->initinteger;
+                       VectorCopy(c->initvector, c->vector);
+                       cp = &c->next;
+               }
+               else
+               {
+                       if (!(c->flags & CVAR_ALLOCATED))
+                       {
+                               Con_DPrintf("Cvar_RestoreInitState: Unable to destroy cvar \"%s\", it was registered after init!\n", c->name);
+                               // In this case, at least reset it to the default.
+                               if((c->flags & CVAR_NORESETTODEFAULTS) == 0)
+                                       Cvar_SetQuick(c, c->defstring);
+                               cp = &c->next;
+                               continue;
+                       }
+                       if (Cvar_IsAutoCvar(c))
+                       {
+                               Con_DPrintf("Cvar_RestoreInitState: Unable to destroy cvar \"%s\", it is an autocvar used by running progs!\n", c->name);
+                               // In this case, at least reset it to the default.
+                               if((c->flags & CVAR_NORESETTODEFAULTS) == 0)
+                                       Cvar_SetQuick(c, c->defstring);
+                               cp = &c->next;
+                               continue;
+                       }
+                       // remove this cvar, it did not exist at init
+                       Con_DPrintf("Cvar_RestoreInitState: Destroying cvar \"%s\"\n", c->name);
+                       // unlink struct from hash
+                       hashindex = CRC_Block((const unsigned char *)c->name, strlen(c->name)) % CVAR_HASHSIZE;
+                       for (cp2 = &cvar_hashtable[hashindex];(c2 = *cp2);)
+                       {
+                               if (c2 == c)
+                               {
+                                       *cp2 = c2->nextonhashchain;
+                                       break;
+                               }
+                               else
+                                       cp2 = &c2->nextonhashchain;
+                       }
+                       // unlink struct from main list
+                       *cp = c->next;
+                       // free strings
+                       if (c->defstring)
+                               Z_Free((char *)c->defstring);
+                       if (c->string)
+                               Z_Free((char *)c->string);
+                       if (c->description && c->description != cvar_dummy_description)
+                               Z_Free((char *)c->description);
+                       // free struct
+                       Z_Free(c);
+               }
+       }
+}
 
 void Cvar_ResetToDefaults_All_f (void)
 {
@@ -664,10 +867,10 @@ void Cvar_WriteVariables (qfile_t *f)
 
        // don't save cvars that match their default value
        for (var = cvar_vars ; var ; var = var->next)
-               if ((var->flags & CVAR_SAVE) && (strcmp(var->string, var->defstring) || (var->flags & CVAR_ALLOCATED)))
+               if ((var->flags & CVAR_SAVE) && (strcmp(var->string, var->defstring) || ((var->flags & CVAR_ALLOCATED) && !(var->flags & CVAR_DEFAULTSET))))
                {
-                       Cmd_QuoteString(buf1, sizeof(buf1), var->name, "\"\\$");
-                       Cmd_QuoteString(buf2, sizeof(buf2), var->string, "\"\\$");
+                       Cmd_QuoteString(buf1, sizeof(buf1), var->name, "\"\\$", false);
+                       Cmd_QuoteString(buf2, sizeof(buf2), var->string, "\"\\$", false);
                        FS_Printf(f, "%s\"%s\" \"%s\"\n", var->flags & CVAR_ALLOCATED ? "seta " : "", buf1, buf2);
                }
 }
@@ -692,15 +895,15 @@ void Cvar_List_f (void)
        {
                partial = Cmd_Argv (1);
                len = strlen(partial);
+               ispattern = (strchr(partial, '*') || strchr(partial, '?'));
        }
        else
        {
                partial = NULL;
                len = 0;
+               ispattern = false;
        }
 
-       ispattern = partial && (strchr(partial, '*') || strchr(partial, '?'));
-
        count = 0;
        for (cvar = cvar_vars; cvar; cvar = cvar->next)
        {
@@ -742,7 +945,7 @@ void Cvar_Set_f (void)
                return;
        }
 
-       if (developer.integer >= 100)
+       if (developer_extra.integer)
                Con_DPrint("Set: ");
 
        // all looks ok, create/modify the cvar
@@ -768,13 +971,67 @@ void Cvar_SetA_f (void)
                return;
        }
 
-       if (developer.integer >= 100)
+       if (developer_extra.integer)
                Con_DPrint("SetA: ");
 
        // all looks ok, create/modify the cvar
        Cvar_Get(Cmd_Argv(1), Cmd_Argv(2), CVAR_SAVE, Cmd_Argc() > 3 ? Cmd_Argv(3) : NULL);
 }
 
+void Cvar_Del_f (void)
+{
+       int i;
+       cvar_t *cvar, *parent, **link, *prev;
+
+       if(Cmd_Argc() < 2)
+       {
+               Con_Printf("Del: wrong number of parameters, useage: unset <variablename1> [<variablename2> ...]\n");
+               return;
+       }
+       for(i = 1; i < Cmd_Argc(); ++i)
+       {
+               cvar = Cvar_FindVarLink(Cmd_Argv(i), &parent, &link, &prev);
+               if(!cvar)
+               {
+                       Con_Printf("Del: %s is not defined\n", Cmd_Argv(i));
+                       continue;
+               }
+               if(cvar->flags & CVAR_READONLY)
+               {
+                       Con_Printf("Del: %s is read-only\n", cvar->name);
+                       continue;
+               }
+               if(!(cvar->flags & CVAR_ALLOCATED))
+               {
+                       Con_Printf("Del: %s is static and cannot be deleted\n", cvar->name);
+                       continue;
+               }
+               if(cvar == cvar_vars)
+               {
+                       cvar_vars = cvar->next;
+               }
+               else
+               {
+                       // in this case, prev must be set, otherwise there has been some inconsistensy
+                       // elsewhere already... should I still check for prev != NULL?
+                       prev->next = cvar->next;
+               }
+
+               if(parent)
+                       parent->nextonhashchain = cvar->nextonhashchain;
+               else if(link)
+                       *link = cvar->nextonhashchain;
+
+               if(cvar->description != cvar_dummy_description)
+                       Z_Free((char *)cvar->description);
+
+               Z_Free((char *)cvar->name);
+               Z_Free((char *)cvar->string);
+               Z_Free((char *)cvar->defstring);
+               Z_Free(cvar);
+       }
+}
+
 #ifdef FILLALLCVARSWITHRUBBISH
 void Cvar_FillAll_f()
 {