]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - image.c
eliminated qbyte type, now uses unsigned char throughout the engine for this purpose
[xonotic/darkplaces.git] / image.c
diff --git a/image.c b/image.c
index 4dae89a9a9880087a2ba99ac06c45205b70c3b8a..623ed5891d5837676a446c74f95714a21b3bb32a 100644 (file)
--- a/image.c
+++ b/image.c
 int            image_width;
 int            image_height;
 
-void Image_CopyMux(qbyte *outpixels, const qbyte *inpixels, int width, int height, int flipx, int flipy, int flipdiagonal, int numincomponents, int numoutcomponents, int *inputcomponentindices)
+#if 1
+// written by LordHavoc in a readable way, optimized by Vic, further optimized by LordHavoc (the non-special index case), readable version preserved below this
+void Image_CopyMux(unsigned char *outpixels, const unsigned char *inpixels, int inputwidth, int inputheight, qboolean inputflipx, qboolean inputflipy, qboolean inputflipdiagonal, int numoutputcomponents, int numinputcomponents, int *outputinputcomponentindices)
 {
        int index, c, x, y;
-       const qbyte *in, *inrow, *incolumn;
-       if (flipdiagonal)
+       const unsigned char *in, *line;
+       int row_inc = (inputflipy ? -inputwidth : inputwidth) * numinputcomponents, col_inc = (inputflipx ? -1 : 1) * numinputcomponents;
+       int row_ofs = (inputflipy ? (inputheight - 1) * inputwidth * numinputcomponents : 0), col_ofs = (inputflipx ? (inputwidth - 1) * numinputcomponents : 0);
+
+       for (c = 0; c < numoutputcomponents; c++)
+               if (outputinputcomponentindices[c] & 0x80000000)
+                       break;
+       if (c < numoutputcomponents)
        {
-               for (y = 0;y < height;y++)
+               // special indices used
+               if (inputflipdiagonal)
                {
-                       incolumn = inpixels + (flipx ? width - 1 - y : y) * numincomponents;
-                       for (x = 0;x < width;x++)
+                       for (x = 0, line = inpixels + col_ofs; x < inputwidth; x++, line += col_inc)
+                               for (y = 0, in = line + row_ofs; y < inputheight; y++, in += row_inc, outpixels += numinputcomponents)
+                                       for (c = 0; c < numoutputcomponents; c++)
+                                               outpixels[c] = ((index = outputinputcomponentindices[c]) & 0x80000000) ? index : in[index];
+               }
+               else
+               {
+                       for (y = 0, line = inpixels + row_ofs; y < inputheight; y++, line += row_inc)
+                               for (x = 0, in = line + col_ofs; x < inputwidth; x++, in += col_inc, outpixels += numinputcomponents)
+                                       for (c = 0; c < numoutputcomponents; c++)
+                                               outpixels[c] = ((index = outputinputcomponentindices[c]) & 0x80000000) ? index : in[index];
+               }
+       }
+       else
+       {
+               // special indices not used
+               if (inputflipdiagonal)
+               {
+                       for (x = 0, line = inpixels + col_ofs; x < inputwidth; x++, line += col_inc)
+                               for (y = 0, in = line + row_ofs; y < inputheight; y++, in += row_inc, outpixels += numinputcomponents)
+                                       for (c = 0; c < numoutputcomponents; c++)
+                                               outpixels[c] = in[outputinputcomponentindices[c]];
+               }
+               else
+               {
+                       for (y = 0, line = inpixels + row_ofs; y < inputheight; y++, line += row_inc)
+                               for (x = 0, in = line + col_ofs; x < inputwidth; x++, in += col_inc, outpixels += numinputcomponents)
+                                       for (c = 0; c < numoutputcomponents; c++)
+                                               outpixels[c] = in[outputinputcomponentindices[c]];
+               }
+       }
+}
+#else
+// intentionally readable version
+void Image_CopyMux(unsigned char *outpixels, const unsigned char *inpixels, int inputwidth, int inputheight, qboolean inputflipx, qboolean inputflipy, qboolean inputflipdiagonal, int numoutputcomponents, int numinputcomponents, int *outputinputcomponentindices)
+{
+       int index, c, x, y;
+       const unsigned char *in, *inrow, *incolumn;
+       if (inputflipdiagonal)
+       {
+               for (x = 0;x < inputwidth;x++)
+               {
+                       for (y = 0;y < inputheight;y++)
                        {
-                               in = incolumn + (flipy ? height - 1 - x : x) * width * numincomponents;
-                               for (c = 0;c < numoutcomponents;c++)
+                               in = inpixels + ((inputflipy ? inputheight - 1 - y : y) * inputwidth + (inputflipx ? inputwidth - 1 - x : x)) * numinputcomponents;
+                               for (c = 0;c < numoutputcomponents;c++)
                                {
-                                       index = inputcomponentindices[c];
-                                       *outpixels++ = (index & 0x80000000) ? (index - 0x8000000) : in[index];
+                                       index = outputinputcomponentindices[c];
+                                       if (index & 0x80000000)
+                                               *outpixels++ = index;
+                                       else
+                                               *outpixels++ = in[index];
                                }
                        }
                }
        }
        else
        {
-               for (y = 0;y < height;y++)
+               for (y = 0;y < inputheight;y++)
                {
-                       inrow = inpixels + (flipy ? height - 1 - y : y) * width * numincomponents;
-                       for (x = 0;x < width;x++)
+                       for (x = 0;x < inputwidth;x++)
                        {
-                               in = inrow + (flipx ? width - 1 - x : x) * numincomponents;
-                               for (c = 0;c < numoutcomponents;c++)
+                               in = inpixels + ((inputflipy ? inputheight - 1 - y : y) * inputwidth + (inputflipx ? inputwidth - 1 - x : x)) * numinputcomponents;
+                               for (c = 0;c < numoutputcomponents;c++)
                                {
-                                       index = inputcomponentindices[c];
-                                       *outpixels++ = (index & 0x80000000) ? (index - 0x8000000) : in[index];
+                                       index = outputinputcomponentindices[c];
+                                       if (index & 0x80000000)
+                                               *outpixels++ = index;
+                                       else
+                                               *outpixels++ = in[index];
                                }
                        }
                }
        }
 }
+#endif
 
-void Image_GammaRemapRGB(const qbyte *in, qbyte *out, int pixels, const qbyte *gammar, const qbyte *gammag, const qbyte *gammab)
+void Image_GammaRemapRGB(const unsigned char *in, unsigned char *out, int pixels, const unsigned char *gammar, const unsigned char *gammag, const unsigned char *gammab)
 {
        while (pixels--)
        {
@@ -58,9 +114,9 @@ void Image_GammaRemapRGB(const qbyte *in, qbyte *out, int pixels, const qbyte *g
 }
 
 // note: pal must be 32bit color
-void Image_Copy8bitRGBA(const qbyte *in, qbyte *out, int pixels, const unsigned int *pal)
+void Image_Copy8bitRGBA(const unsigned char *in, unsigned char *out, int pixels, const unsigned int *pal)
 {
-       int *iout = (void *)out;
+       int *iout = (int *)out;
        while (pixels >= 8)
        {
                iout[0] = pal[in[0]];
@@ -103,7 +159,7 @@ void Image_Copy8bitRGBA(const qbyte *in, qbyte *out, int pixels, const unsigned
 =================================================================
 */
 
-typedef struct
+typedef struct pcx_s
 {
     char       manufacturer;
     char       version;
@@ -124,11 +180,11 @@ typedef struct
 LoadPCX
 ============
 */
-qbyte* LoadPCX (qbyte *f, int matchwidth, int matchheight)
+unsigned char* LoadPCX (const unsigned char *f, int matchwidth, int matchheight)
 {
        pcx_t pcx;
-       qbyte *a, *b, *image_rgba, *pbuf;
-       const qbyte *palette, *fin, *enddata;
+       unsigned char *a, *b, *image_rgba, *pbuf;
+       const unsigned char *palette, *fin, *enddata;
        int x, y, x2, dataByte;
 
        if (fs_filesize < (int)sizeof(pcx) + 768)
@@ -164,7 +220,7 @@ qbyte* LoadPCX (qbyte *f, int matchwidth, int matchheight)
 
        palette = f + fs_filesize - 768;
 
-       image_rgba = Mem_Alloc(tempmempool, image_width*image_height*4);
+       image_rgba = (unsigned char *)Mem_Alloc(tempmempool, image_width*image_height*4);
        if (!image_rgba)
        {
                Con_Printf("LoadPCX: not enough memory for %i by %i image\n", image_width, image_height);
@@ -233,19 +289,7 @@ TargaHeader;
 
 void PrintTargaHeader(TargaHeader *t)
 {
-       Con_Print("TargaHeader:\n");
-       Con_Printf("uint8 id_length = %i;\n", t->id_length);
-       Con_Printf("uint8 colormap_type = %i;\n", t->colormap_type);
-       Con_Printf("uint8 image_type = %i;\n", t->image_type);
-       Con_Printf("uint16 colormap_index = %i;\n", t->colormap_index);
-       Con_Printf("uint16 colormap_length = %i;\n", t->colormap_length);
-       Con_Printf("uint8 colormap_size = %i;\n", t->colormap_size);
-       Con_Printf("uint16 x_origin = %i;\n", t->x_origin);
-       Con_Printf("uint16 y_origin = %i;\n", t->y_origin);
-       Con_Printf("uint16 width = %i;\n", t->width);
-       Con_Printf("uint16 height = %i;\n", t->height);
-       Con_Printf("uint8 pixel_size = %i;\n", t->pixel_size);
-       Con_Printf("uint8 attributes = %i;\n", t->attributes);
+       Con_Printf("TargaHeader:\nuint8 id_length = %i;\nuint8 colormap_type = %i;\nuint8 image_type = %i;\nuint16 colormap_index = %i;\nuint16 colormap_length = %i;\nuint8 colormap_size = %i;\nuint16 x_origin = %i;\nuint16 y_origin = %i;\nuint16 width = %i;\nuint16 height = %i;\nuint8 pixel_size = %i;\nuint8 attributes = %i;\n", t->id_length, t->colormap_type, t->image_type, t->colormap_index, t->colormap_length, t->colormap_size, t->x_origin, t->y_origin, t->width, t->height, t->pixel_size, t->attributes);
 }
 
 /*
@@ -253,13 +297,14 @@ void PrintTargaHeader(TargaHeader *t)
 LoadTGA
 =============
 */
-qbyte *LoadTGA (qbyte *f, int matchwidth, int matchheight)
+unsigned char *LoadTGA (const unsigned char *f, int matchwidth, int matchheight)
 {
-       int x, y, row_inc, compressed, readpixelcount, red, green, blue, alpha, runlen, pindex;
-       qbyte *pixbuf, *image_rgba;
-       qbyte *fin, *enddata;
+       int x, y, row_inc, compressed, readpixelcount, red, green, blue, alpha, runlen, pindex, alphabits;
+       unsigned char *pixbuf, *image_rgba;
+       const unsigned char *fin, *enddata;
+       unsigned char *p;
        TargaHeader targa_header;
-       unsigned char palette[256*4], *p;
+       unsigned char palette[256*4];
 
        if (fs_filesize < 19)
                return NULL;
@@ -288,26 +333,17 @@ qbyte *LoadTGA (qbyte *f, int matchwidth, int matchheight)
        targa_header.pixel_size = f[16];
        targa_header.attributes = f[17];
 
+       // advance to end of header
        fin = f + 18;
-       if (targa_header.id_length != 0)
-               fin += targa_header.id_length;  // skip TARGA image comment
-       if (targa_header.image_type == 2 || targa_header.image_type == 10)
-       {
-               if (targa_header.pixel_size != 24 && targa_header.pixel_size != 32)
-               {
-                       Con_Print("LoadTGA: only 24bit and 32bit pixel sizes supported for type 2 and type 10 images\n");
-                       PrintTargaHeader(&targa_header);
-                       return NULL;
-               }
-       }
-       else if (targa_header.image_type == 1 || targa_header.image_type == 9)
+
+       // skip TARGA image comment (usually 0 bytes)
+       fin += targa_header.id_length;
+
+       // read/skip the colormap if present (note: according to the TARGA spec it
+       // can be present even on truecolor or greyscale images, just not used by
+       // the image data)
+       if (targa_header.colormap_type)
        {
-               if (targa_header.pixel_size != 8)
-               {
-                       Con_Print("LoadTGA: only 8bit pixel size for type 1, 3, 9, and 11 images supported\n");
-                       PrintTargaHeader(&targa_header);
-                       return NULL;
-               }
                if (targa_header.colormap_length > 256)
                {
                        Con_Print("LoadTGA: only up to 256 colormap_length supported\n");
@@ -347,6 +383,26 @@ qbyte *LoadTGA (qbyte *f, int matchwidth, int matchheight)
                        return NULL;
                }
        }
+
+       // check our pixel_size restrictions according to image_type
+       if (targa_header.image_type == 2 || targa_header.image_type == 10)
+       {
+               if (targa_header.pixel_size != 24 && targa_header.pixel_size != 32)
+               {
+                       Con_Print("LoadTGA: only 24bit and 32bit pixel sizes supported for type 2 and type 10 images\n");
+                       PrintTargaHeader(&targa_header);
+                       return NULL;
+               }
+       }
+       else if (targa_header.image_type == 1 || targa_header.image_type == 9)
+       {
+               if (targa_header.pixel_size != 8)
+               {
+                       Con_Print("LoadTGA: only 8bit pixel size for type 1, 3, 9, and 11 images supported\n");
+                       PrintTargaHeader(&targa_header);
+                       return NULL;
+               }
+       }
        else if (targa_header.image_type == 3 || targa_header.image_type == 11)
        {
                if (targa_header.pixel_size != 8)
@@ -369,7 +425,15 @@ qbyte *LoadTGA (qbyte *f, int matchwidth, int matchheight)
                return NULL;
        }
 
-       image_rgba = Mem_Alloc(tempmempool, image_width * image_height * 4);
+       // number of attribute bits per pixel, we only support 0 or 8
+       alphabits = targa_header.attributes & 0x0F;
+       if (alphabits != 8 && alphabits != 0)
+       {
+               Con_Print("LoadTGA: only 0 or 8 attribute (alpha) bits supported\n");
+               return NULL;
+       }
+
+       image_rgba = (unsigned char *)Mem_Alloc(tempmempool, image_width * image_height * 4);
        if (!image_rgba)
        {
                Con_Printf("LoadTGA: not enough memory for %i by %i image\n", image_width, image_height);
@@ -445,6 +509,8 @@ qbyte *LoadTGA (qbyte *f, int matchwidth, int matchheight)
                                                red = green = blue = *fin++;
                                                break;
                                        }
+                                       if (!alphabits)
+                                               alpha = 255;
                                }
                        }
                        *pixbuf++ = red;
@@ -470,9 +536,9 @@ qbyte *LoadTGA (qbyte *f, int matchwidth, int matchheight)
 LoadLMP
 ============
 */
-qbyte *LoadLMP (qbyte *f, int matchwidth, int matchheight)
+unsigned char *LoadLMP (const unsigned char *f, int matchwidth, int matchheight, qboolean loadAs8Bit)
 {
-       qbyte *image_rgba;
+       unsigned char *image_buffer;
 
        if (fs_filesize < 9)
        {
@@ -481,8 +547,8 @@ qbyte *LoadLMP (qbyte *f, int matchwidth, int matchheight)
        }
 
        // parse the very complicated header *chuckle*
-       image_width = f[0] + f[1] * 256 + f[2] * 65536 + f[3] * 16777216;
-       image_height = f[4] + f[5] * 256 + f[6] * 65536 + f[7] * 16777216;
+       image_width = BuffLittleLong(f);
+       image_height = BuffLittleLong(f + 4);
        if (image_width > 4096 || image_height > 4096 || image_width <= 0 || image_height <= 0)
        {
                Con_Printf("LoadLMP: invalid size %ix%i\n", image_width, image_height);
@@ -491,23 +557,32 @@ qbyte *LoadLMP (qbyte *f, int matchwidth, int matchheight)
        if ((matchwidth && image_width != matchwidth) || (matchheight && image_height != matchheight))
                return NULL;
 
-       if (fs_filesize < 8 + image_width * image_height)
+       if (fs_filesize < (fs_offset_t)(8 + image_width * image_height))
        {
                Con_Print("LoadLMP: invalid LMP file\n");
                return NULL;
        }
 
-       image_rgba = Mem_Alloc(tempmempool, image_width * image_height * 4);
-       if (!image_rgba)
+       if (loadAs8Bit)
        {
-               Con_Printf("LoadLMP: not enough memory for %i by %i image\n", image_width, image_height);
-               return NULL;
+               image_buffer = (unsigned char *)Mem_Alloc(tempmempool, image_width * image_height);
+               memcpy(image_buffer, f + 8, image_width * image_height);
        }
-       Image_Copy8bitRGBA(f + 8, image_rgba, image_width * image_height, palette_complete);
-       return image_rgba;
+       else
+       {
+               image_buffer = (unsigned char *)Mem_Alloc(tempmempool, image_width * image_height * 4);
+               Image_Copy8bitRGBA(f + 8, image_buffer, image_width * image_height, palette_complete);
+       }
+       return image_buffer;
 }
 
-typedef struct
+static unsigned char *LoadLMPRGBA (const unsigned char *f, int matchwidth, int matchheight)
+{
+       return LoadLMP(f, matchwidth, matchheight, false);
+}
+
+
+typedef struct q2wal_s
 {
        char            name[32];
        unsigned        width, height;
@@ -518,10 +593,10 @@ typedef struct
        int                     value;
 } q2wal_t;
 
-qbyte *LoadWAL (qbyte *f, int matchwidth, int matchheight)
+unsigned char *LoadWAL (const unsigned char *f, int matchwidth, int matchheight)
 {
-       qbyte *image_rgba;
-       const q2wal_t *inwal = (const void *)f;
+       unsigned char *image_rgba;
+       const q2wal_t *inwal = (const q2wal_t *)f;
 
        if (fs_filesize < (int) sizeof(q2wal_t))
        {
@@ -545,7 +620,7 @@ qbyte *LoadWAL (qbyte *f, int matchwidth, int matchheight)
                return NULL;
        }
 
-       image_rgba = Mem_Alloc(tempmempool, image_width * image_height * 4);
+       image_rgba = (unsigned char *)Mem_Alloc(tempmempool, image_width * image_height * 4);
        if (!image_rgba)
        {
                Con_Printf("LoadLMP: not enough memory for %i by %i image\n", image_width, image_height);
@@ -556,49 +631,6 @@ qbyte *LoadWAL (qbyte *f, int matchwidth, int matchheight)
 }
 
 
-
-/*
-============
-LoadLMP
-============
-*/
-qbyte *LoadLMPAs8Bit (qbyte *f, int matchwidth, int matchheight)
-{
-       qbyte *image_8bit;
-
-       if (fs_filesize < 9)
-       {
-               Con_Print("LoadLMPAs8Bit: invalid LMP file\n");
-               return NULL;
-       }
-
-       // parse the very complicated header *chuckle*
-       image_width = f[0] + f[1] * 256 + f[2] * 65536 + f[3] * 16777216;
-       image_height = f[4] + f[5] * 256 + f[6] * 65536 + f[7] * 16777216;
-       if (image_width > 4096 || image_height > 4096 || image_width <= 0 || image_height <= 0)
-       {
-               Con_Printf("LoadLMPAs8Bit: invalid size %ix%i\n", image_width, image_height);
-               return NULL;
-       }
-       if ((matchwidth && image_width != matchwidth) || (matchheight && image_height != matchheight))
-               return NULL;
-
-       if (fs_filesize < 8 + image_width * image_height)
-       {
-               Con_Print("LoadLMPAs8Bit: invalid LMP file\n");
-               return NULL;
-       }
-
-       image_8bit = Mem_Alloc(tempmempool, image_width * image_height);
-       if (!image_8bit)
-       {
-               Con_Printf("LoadLMPAs8Bit: not enough memory for %i by %i image\n", image_width, image_height);
-               return NULL;
-       }
-       memcpy(image_8bit, f + 8, image_width * image_height);
-       return image_8bit;
-}
-
 void Image_StripImageExtension (const char *in, char *out)
 {
        const char *end, *temp;
@@ -620,10 +652,10 @@ void Image_StripImageExtension (const char *in, char *out)
                strcpy(out, in);
 }
 
-struct
+struct imageformat_s
 {
        const char *formatstring;
-       qbyte *(*loadfunc)(qbyte *f, int matchwidth, int matchheight);
+       unsigned char *(*loadfunc)(const unsigned char *f, int matchwidth, int matchheight);
 }
 imageformats[] =
 {
@@ -636,18 +668,21 @@ imageformats[] =
        {"%s.tga", LoadTGA},
        {"%s.jpg", JPEG_LoadImage},
        {"%s.pcx", LoadPCX},
-       {"%s.lmp", LoadLMP},
+       {"%s.lmp", LoadLMPRGBA},
        {NULL, NULL}
 };
 
-qbyte *loadimagepixels (const char *filename, qboolean complain, int matchwidth, int matchheight)
+unsigned char *loadimagepixels (const char *filename, qboolean complain, int matchwidth, int matchheight)
 {
        int i;
-       qbyte *f, *data = NULL;
+       unsigned char *f, *data = NULL;
        char basename[MAX_QPATH], name[MAX_QPATH], *c;
        if (developer_memorydebug.integer)
                Mem_CheckSentinelsGlobal();
-       Image_StripImageExtension(filename, basename); // strip filename extensions to allow replacement by other types
+       if (developer_texturelogging.integer)
+               Log_Printf("textures.log", "%s\n", filename);
+       strlcpy(basename, filename, sizeof(basename));
+       Image_StripImageExtension(basename, basename); // strip filename extensions to allow replacement by other types
        // replace *'s with #, so commandline utils don't get confused when dealing with the external files
        for (c = basename;*c;c++)
                if (*c == '*')
@@ -655,7 +690,7 @@ qbyte *loadimagepixels (const char *filename, qboolean complain, int matchwidth,
        for (i = 0;imageformats[i].formatstring;i++)
        {
                sprintf (name, imageformats[i].formatstring, basename);
-               f = FS_LoadFile(name, true);
+               f = FS_LoadFile(name, tempmempool, true);
                if (f)
                {
                        data = imageformats[i].loadfunc(f, matchwidth, matchheight);
@@ -683,7 +718,7 @@ qbyte *loadimagepixels (const char *filename, qboolean complain, int matchwidth,
        return NULL;
 }
 
-int image_makemask (const qbyte *in, qbyte *out, int size)
+int image_makemask (const unsigned char *in, unsigned char *out, int size)
 {
        int i, count;
        count = 0;
@@ -699,9 +734,9 @@ int image_makemask (const qbyte *in, qbyte *out, int size)
        return count;
 }
 
-qbyte* loadimagepixelsmask (const char *filename, qboolean complain, int matchwidth, int matchheight)
+unsigned char* loadimagepixelsmask (const char *filename, qboolean complain, int matchwidth, int matchheight)
 {
-       qbyte *in, *data;
+       unsigned char *in, *data;
        in = data = loadimagepixels(filename, complain, matchwidth, matchheight);
        if (!data)
                return NULL;
@@ -716,7 +751,7 @@ qbyte* loadimagepixelsmask (const char *filename, qboolean complain, int matchwi
 
 rtexture_t *loadtextureimage (rtexturepool_t *pool, const char *filename, int matchwidth, int matchheight, qboolean complain, int flags)
 {
-       qbyte *data;
+       unsigned char *data;
        rtexture_t *rt;
        if (!(data = loadimagepixels (filename, complain, matchwidth, matchheight)))
                return 0;
@@ -727,7 +762,7 @@ rtexture_t *loadtextureimage (rtexturepool_t *pool, const char *filename, int ma
 
 rtexture_t *loadtextureimagemask (rtexturepool_t *pool, const char *filename, int matchwidth, int matchheight, qboolean complain, int flags)
 {
-       qbyte *data;
+       unsigned char *data;
        rtexture_t *rt;
        if (!(data = loadimagepixelsmask (filename, complain, matchwidth, matchheight)))
                return 0;
@@ -740,7 +775,7 @@ rtexture_t *image_masktex;
 rtexture_t *image_nmaptex;
 rtexture_t *loadtextureimagewithmask (rtexturepool_t *pool, const char *filename, int matchwidth, int matchheight, qboolean complain, int flags)
 {
-       qbyte *data;
+       unsigned char *data;
        rtexture_t *rt;
        image_masktex = NULL;
        image_nmaptex = NULL;
@@ -758,14 +793,14 @@ rtexture_t *loadtextureimagewithmask (rtexturepool_t *pool, const char *filename
 
 rtexture_t *loadtextureimagewithmaskandnmap (rtexturepool_t *pool, const char *filename, int matchwidth, int matchheight, qboolean complain, int flags, float bumpscale)
 {
-       qbyte *data, *data2;
+       unsigned char *data, *data2;
        rtexture_t *rt;
        image_masktex = NULL;
        image_nmaptex = NULL;
        if (!(data = loadimagepixels (filename, complain, matchwidth, matchheight)))
                return 0;
 
-       data2 = Mem_Alloc(tempmempool, image_width * image_height * 4);
+       data2 = (unsigned char *)Mem_Alloc(tempmempool, image_width * image_height * 4);
 
        rt = R_LoadTexture2D(pool, filename, image_width, image_height, data, TEXTYPE_RGBA, flags, NULL);
 
@@ -783,11 +818,11 @@ rtexture_t *loadtextureimagewithmaskandnmap (rtexturepool_t *pool, const char *f
 
 rtexture_t *loadtextureimagebumpasnmap (rtexturepool_t *pool, const char *filename, int matchwidth, int matchheight, qboolean complain, int flags, float bumpscale)
 {
-       qbyte *data, *data2;
+       unsigned char *data, *data2;
        rtexture_t *rt;
        if (!(data = loadimagepixels (filename, complain, matchwidth, matchheight)))
                return 0;
-       data2 = Mem_Alloc(tempmempool, image_width * image_height * 4);
+       data2 = (unsigned char *)Mem_Alloc(tempmempool, image_width * image_height * 4);
 
        Image_HeightmapToNormalmap(data, data2, image_width, image_height, (flags & TEXF_CLAMP) != 0, bumpscale);
        rt = R_LoadTexture2D(pool, filename, image_width, image_height, data2, TEXTYPE_RGBA, flags, NULL);
@@ -797,13 +832,11 @@ rtexture_t *loadtextureimagebumpasnmap (rtexturepool_t *pool, const char *filena
        return rt;
 }
 
-qboolean Image_WriteTGARGB_preflipped (const char *filename, int width, int height, const qbyte *data)
+qboolean Image_WriteTGARGB_preflipped (const char *filename, int width, int height, const unsigned char *data, unsigned char *buffer)
 {
        qboolean ret;
-       qbyte *buffer, *out;
-       const qbyte *in, *end;
-
-       buffer = Mem_Alloc(tempmempool, width*height*3 + 18);
+       unsigned char *out;
+       const unsigned char *in, *end;
 
        memset (buffer, 0, 18);
        buffer[2] = 2;          // uncompressed type
@@ -825,17 +858,16 @@ qboolean Image_WriteTGARGB_preflipped (const char *filename, int width, int heig
        }
        ret = FS_WriteFile (filename, buffer, width*height*3 + 18 );
 
-       Mem_Free(buffer);
        return ret;
 }
 
-void Image_WriteTGARGB (const char *filename, int width, int height, const qbyte *data)
+void Image_WriteTGARGB (const char *filename, int width, int height, const unsigned char *data)
 {
        int y;
-       qbyte *buffer, *out;
-       const qbyte *in, *end;
+       unsigned char *buffer, *out;
+       const unsigned char *in, *end;
 
-       buffer = Mem_Alloc(tempmempool, width*height*3 + 18);
+       buffer = (unsigned char *)Mem_Alloc(tempmempool, width*height*3 + 18);
 
        memset (buffer, 0, 18);
        buffer[2] = 2;          // uncompressed type
@@ -863,13 +895,13 @@ void Image_WriteTGARGB (const char *filename, int width, int height, const qbyte
        Mem_Free(buffer);
 }
 
-void Image_WriteTGARGBA (const char *filename, int width, int height, const qbyte *data)
+void Image_WriteTGARGBA (const char *filename, int width, int height, const unsigned char *data)
 {
        int y;
-       qbyte *buffer, *out;
-       const qbyte *in, *end;
+       unsigned char *buffer, *out;
+       const unsigned char *in, *end;
 
-       buffer = Mem_Alloc(tempmempool, width*height*4 + 18);
+       buffer = (unsigned char *)Mem_Alloc(tempmempool, width*height*4 + 18);
 
        memset (buffer, 0, 18);
        buffer[2] = 2;          // uncompressed type
@@ -878,6 +910,7 @@ void Image_WriteTGARGBA (const char *filename, int width, int height, const qbyt
        buffer[14] = (height >> 0) & 0xFF;
        buffer[15] = (height >> 8) & 0xFF;
        buffer[16] = 32;        // pixel size
+       buffer[17] = 8; // transparent flag? (seems to be needed by gimp)
 
        // swap rgba to bgra and flip upside down
        out = buffer + 18;
@@ -898,9 +931,9 @@ void Image_WriteTGARGBA (const char *filename, int width, int height, const qbyt
        Mem_Free(buffer);
 }
 
-qboolean Image_CheckAlpha(const qbyte *data, int size, qboolean rgba)
+qboolean Image_CheckAlpha(const unsigned char *data, int size, qboolean rgba)
 {
-       const qbyte *end;
+       const unsigned char *end;
        if (rgba)
        {
                // check alpha bytes
@@ -918,7 +951,7 @@ qboolean Image_CheckAlpha(const qbyte *data, int size, qboolean rgba)
        return 0;
 }
 
-static void Image_Resample32LerpLine (const qbyte *in, qbyte *out, int inwidth, int outwidth)
+static void Image_Resample32LerpLine (const unsigned char *in, unsigned char *out, int inwidth, int outwidth)
 {
        int             j, xi, oldx = 0, f, fstep, endx, lerp;
        fstep = (int) (inwidth*65536.0f/outwidth);
@@ -934,10 +967,10 @@ static void Image_Resample32LerpLine (const qbyte *in, qbyte *out, int inwidth,
                if (xi < endx)
                {
                        lerp = f & 0xFFFF;
-                       *out++ = (qbyte) ((((in[4] - in[0]) * lerp) >> 16) + in[0]);
-                       *out++ = (qbyte) ((((in[5] - in[1]) * lerp) >> 16) + in[1]);
-                       *out++ = (qbyte) ((((in[6] - in[2]) * lerp) >> 16) + in[2]);
-                       *out++ = (qbyte) ((((in[7] - in[3]) * lerp) >> 16) + in[3]);
+                       *out++ = (unsigned char) ((((in[4] - in[0]) * lerp) >> 16) + in[0]);
+                       *out++ = (unsigned char) ((((in[5] - in[1]) * lerp) >> 16) + in[1]);
+                       *out++ = (unsigned char) ((((in[6] - in[2]) * lerp) >> 16) + in[2]);
+                       *out++ = (unsigned char) ((((in[7] - in[3]) * lerp) >> 16) + in[3]);
                }
                else // last pixel of the line has no pixel to lerp to
                {
@@ -949,7 +982,7 @@ static void Image_Resample32LerpLine (const qbyte *in, qbyte *out, int inwidth,
        }
 }
 
-static void Image_Resample24LerpLine (const qbyte *in, qbyte *out, int inwidth, int outwidth)
+static void Image_Resample24LerpLine (const unsigned char *in, unsigned char *out, int inwidth, int outwidth)
 {
        int             j, xi, oldx = 0, f, fstep, endx, lerp;
        fstep = (int) (inwidth*65536.0f/outwidth);
@@ -965,9 +998,9 @@ static void Image_Resample24LerpLine (const qbyte *in, qbyte *out, int inwidth,
                if (xi < endx)
                {
                        lerp = f & 0xFFFF;
-                       *out++ = (qbyte) ((((in[3] - in[0]) * lerp) >> 16) + in[0]);
-                       *out++ = (qbyte) ((((in[4] - in[1]) * lerp) >> 16) + in[1]);
-                       *out++ = (qbyte) ((((in[5] - in[2]) * lerp) >> 16) + in[2]);
+                       *out++ = (unsigned char) ((((in[3] - in[0]) * lerp) >> 16) + in[0]);
+                       *out++ = (unsigned char) ((((in[4] - in[1]) * lerp) >> 16) + in[1]);
+                       *out++ = (unsigned char) ((((in[5] - in[2]) * lerp) >> 16) + in[2]);
                }
                else // last pixel of the line has no pixel to lerp to
                {
@@ -978,21 +1011,21 @@ static void Image_Resample24LerpLine (const qbyte *in, qbyte *out, int inwidth,
        }
 }
 
-int resamplerowsize = 0;
-qbyte *resamplerow1 = NULL;
-qbyte *resamplerow2 = NULL;
-mempool_t *resamplemempool = NULL;
-
-#define LERPBYTE(i) r = resamplerow1[i];out[i] = (qbyte) ((((resamplerow2[i] - r) * lerp) >> 16) + r)
+#define LERPBYTE(i) r = resamplerow1[i];out[i] = (unsigned char) ((((resamplerow2[i] - r) * lerp) >> 16) + r)
 void Image_Resample32Lerp(const void *indata, int inwidth, int inheight, void *outdata, int outwidth, int outheight)
 {
        int i, j, r, yi, oldy, f, fstep, lerp, endy = (inheight-1), inwidth4 = inwidth*4, outwidth4 = outwidth*4;
-       qbyte *out;
-       const qbyte *inrow;
-       out = outdata;
+       unsigned char *out;
+       const unsigned char *inrow;
+       unsigned char *resamplerow1;
+       unsigned char *resamplerow2;
+       out = (unsigned char *)outdata;
        fstep = (int) (inheight*65536.0f/outheight);
 
-       inrow = indata;
+       resamplerow1 = (unsigned char *)Mem_Alloc(tempmempool, outwidth*4*2);
+       resamplerow2 = resamplerow1 + outwidth*4;
+
+       inrow = (const unsigned char *)indata;
        oldy = 0;
        Image_Resample32LerpLine (inrow, resamplerow1, inwidth, outwidth);
        Image_Resample32LerpLine (inrow + inwidth4, resamplerow2, inwidth, outwidth);
@@ -1004,7 +1037,7 @@ void Image_Resample32Lerp(const void *indata, int inwidth, int inheight, void *o
                        lerp = f & 0xFFFF;
                        if (yi != oldy)
                        {
-                               inrow = (qbyte *)indata + inwidth4*yi;
+                               inrow = (unsigned char *)indata + inwidth4*yi;
                                if (yi == oldy+1)
                                        memcpy(resamplerow1, resamplerow2, outwidth4);
                                else
@@ -1067,7 +1100,7 @@ void Image_Resample32Lerp(const void *indata, int inwidth, int inheight, void *o
                {
                        if (yi != oldy)
                        {
-                               inrow = (qbyte *)indata + inwidth4*yi;
+                               inrow = (unsigned char *)indata + inwidth4*yi;
                                if (yi == oldy+1)
                                        memcpy(resamplerow1, resamplerow2, outwidth4);
                                else
@@ -1077,15 +1110,19 @@ void Image_Resample32Lerp(const void *indata, int inwidth, int inheight, void *o
                        memcpy(out, resamplerow1, outwidth4);
                }
        }
+
+       Mem_Free(resamplerow1);
+       resamplerow1 = NULL;
+       resamplerow2 = NULL;
 }
 
-void Image_Resample32Nearest(const void *indata, int inwidth, int inheight, void *outdata, int outwidth, int outheight)
+void Image_Resample32Nolerp(const void *indata, int inwidth, int inheight, void *outdata, int outwidth, int outheight)
 {
        int i, j;
        unsigned frac, fracstep;
        // relies on int being 4 bytes
        int *inrow, *out;
-       out = outdata;
+       out = (int *)outdata;
 
        fracstep = inwidth*0x10000/outwidth;
        for (i = 0;i < outheight;i++)
@@ -1119,12 +1156,17 @@ void Image_Resample32Nearest(const void *indata, int inwidth, int inheight, void
 void Image_Resample24Lerp(const void *indata, int inwidth, int inheight, void *outdata, int outwidth, int outheight)
 {
        int i, j, r, yi, oldy, f, fstep, lerp, endy = (inheight-1), inwidth3 = inwidth * 3, outwidth3 = outwidth * 3;
-       qbyte *out;
-       const qbyte *inrow;
-       out = outdata;
+       unsigned char *out;
+       const unsigned char *inrow;
+       unsigned char *resamplerow1;
+       unsigned char *resamplerow2;
+       out = (unsigned char *)outdata;
        fstep = (int) (inheight*65536.0f/outheight);
 
-       inrow = indata;
+       resamplerow1 = (unsigned char *)Mem_Alloc(tempmempool, outwidth*3*2);
+       resamplerow2 = resamplerow1 + outwidth*3;
+
+       inrow = (const unsigned char *)indata;
        oldy = 0;
        Image_Resample24LerpLine (inrow, resamplerow1, inwidth, outwidth);
        Image_Resample24LerpLine (inrow + inwidth3, resamplerow2, inwidth, outwidth);
@@ -1136,7 +1178,7 @@ void Image_Resample24Lerp(const void *indata, int inwidth, int inheight, void *o
                        lerp = f & 0xFFFF;
                        if (yi != oldy)
                        {
-                               inrow = (qbyte *)indata + inwidth3*yi;
+                               inrow = (unsigned char *)indata + inwidth3*yi;
                                if (yi == oldy+1)
                                        memcpy(resamplerow1, resamplerow2, outwidth3);
                                else
@@ -1192,7 +1234,7 @@ void Image_Resample24Lerp(const void *indata, int inwidth, int inheight, void *o
                {
                        if (yi != oldy)
                        {
-                               inrow = (qbyte *)indata + inwidth3*yi;
+                               inrow = (unsigned char *)indata + inwidth3*yi;
                                if (yi == oldy+1)
                                        memcpy(resamplerow1, resamplerow2, outwidth3);
                                else
@@ -1202,19 +1244,22 @@ void Image_Resample24Lerp(const void *indata, int inwidth, int inheight, void *o
                        memcpy(out, resamplerow1, outwidth3);
                }
        }
+       Mem_Free(resamplerow1);
+       resamplerow1 = NULL;
+       resamplerow2 = NULL;
 }
 
 void Image_Resample24Nolerp(const void *indata, int inwidth, int inheight, void *outdata, int outwidth, int outheight)
 {
        int i, j, f, inwidth3 = inwidth * 3;
        unsigned frac, fracstep;
-       qbyte *inrow, *out;
-       out = outdata;
+       unsigned char *inrow, *out;
+       out = (unsigned char *)outdata;
 
        fracstep = inwidth*0x10000/outwidth;
        for (i = 0;i < outheight;i++)
        {
-               inrow = (qbyte *)indata + inwidth3*(i*inheight/outheight);
+               inrow = (unsigned char *)indata + inwidth3*(i*inheight/outheight);
                frac = fracstep >> 1;
                j = outwidth - 4;
                while (j >= 0)
@@ -1247,23 +1292,16 @@ Image_Resample
 void Image_Resample (const void *indata, int inwidth, int inheight, int indepth, void *outdata, int outwidth, int outheight, int outdepth, int bytesperpixel, int quality)
 {
        if (indepth != 1 || outdepth != 1)
-               Sys_Error("Image_Resample: 3D resampling not supported\n");
-       if (resamplerowsize < outwidth*4)
        {
-               if (resamplerow1)
-                       Mem_Free(resamplerow1);
-               resamplerowsize = outwidth*4;
-               if (!resamplemempool)
-                       resamplemempool = Mem_AllocPool("Image Scaling Buffer");
-               resamplerow1 = Mem_Alloc(resamplemempool, resamplerowsize*2);
-               resamplerow2 = resamplerow1 + resamplerowsize;
+               Con_Printf ("Image_Resample: 3D resampling not supported\n");
+               return;
        }
        if (bytesperpixel == 4)
        {
                if (quality)
                        Image_Resample32Lerp(indata, inwidth, inheight, outdata, outwidth, outheight);
                else
-                       Image_Resample32Nearest(indata, inwidth, inheight, outdata, outwidth, outheight);
+                       Image_Resample32Nolerp(indata, inwidth, inheight, outdata, outwidth, outheight);
        }
        else if (bytesperpixel == 3)
        {
@@ -1273,15 +1311,18 @@ void Image_Resample (const void *indata, int inwidth, int inheight, int indepth,
                        Image_Resample24Nolerp(indata, inwidth, inheight, outdata, outwidth, outheight);
        }
        else
-               Sys_Error("Image_Resample: unsupported bytesperpixel %i\n", bytesperpixel);
+               Con_Printf ("Image_Resample: unsupported bytesperpixel %i\n", bytesperpixel);
 }
 
 // in can be the same as out
-void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *depth, int destwidth, int destheight, int destdepth, int bytesperpixel)
+void Image_MipReduce(const unsigned char *in, unsigned char *out, int *width, int *height, int *depth, int destwidth, int destheight, int destdepth, int bytesperpixel)
 {
        int x, y, nextrow;
        if (*depth != 1 || destdepth != 1)
-               Sys_Error("Image_Resample: 3D resampling not supported\n");
+       {
+               Con_Printf ("Image_Resample: 3D resampling not supported\n");
+               return;
+       }
        nextrow = *width * bytesperpixel;
        if (*width > destwidth)
        {
@@ -1296,10 +1337,10 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                {
                                        for (x = 0;x < *width;x++)
                                        {
-                                               out[0] = (qbyte) ((in[0] + in[4] + in[nextrow  ] + in[nextrow+4]) >> 2);
-                                               out[1] = (qbyte) ((in[1] + in[5] + in[nextrow+1] + in[nextrow+5]) >> 2);
-                                               out[2] = (qbyte) ((in[2] + in[6] + in[nextrow+2] + in[nextrow+6]) >> 2);
-                                               out[3] = (qbyte) ((in[3] + in[7] + in[nextrow+3] + in[nextrow+7]) >> 2);
+                                               out[0] = (unsigned char) ((in[0] + in[4] + in[nextrow  ] + in[nextrow+4]) >> 2);
+                                               out[1] = (unsigned char) ((in[1] + in[5] + in[nextrow+1] + in[nextrow+5]) >> 2);
+                                               out[2] = (unsigned char) ((in[2] + in[6] + in[nextrow+2] + in[nextrow+6]) >> 2);
+                                               out[3] = (unsigned char) ((in[3] + in[7] + in[nextrow+3] + in[nextrow+7]) >> 2);
                                                out += 4;
                                                in += 8;
                                        }
@@ -1312,9 +1353,9 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                {
                                        for (x = 0;x < *width;x++)
                                        {
-                                               out[0] = (qbyte) ((in[0] + in[3] + in[nextrow  ] + in[nextrow+3]) >> 2);
-                                               out[1] = (qbyte) ((in[1] + in[4] + in[nextrow+1] + in[nextrow+4]) >> 2);
-                                               out[2] = (qbyte) ((in[2] + in[5] + in[nextrow+2] + in[nextrow+5]) >> 2);
+                                               out[0] = (unsigned char) ((in[0] + in[3] + in[nextrow  ] + in[nextrow+3]) >> 2);
+                                               out[1] = (unsigned char) ((in[1] + in[4] + in[nextrow+1] + in[nextrow+4]) >> 2);
+                                               out[2] = (unsigned char) ((in[2] + in[5] + in[nextrow+2] + in[nextrow+5]) >> 2);
                                                out += 3;
                                                in += 6;
                                        }
@@ -1322,7 +1363,7 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                }
                        }
                        else
-                               Sys_Error("Image_MipReduce: unsupported bytesperpixel %i\n", bytesperpixel);
+                               Con_Printf ("Image_MipReduce: unsupported bytesperpixel %i\n", bytesperpixel);
                }
                else
                {
@@ -1333,10 +1374,10 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                {
                                        for (x = 0;x < *width;x++)
                                        {
-                                               out[0] = (qbyte) ((in[0] + in[4]) >> 1);
-                                               out[1] = (qbyte) ((in[1] + in[5]) >> 1);
-                                               out[2] = (qbyte) ((in[2] + in[6]) >> 1);
-                                               out[3] = (qbyte) ((in[3] + in[7]) >> 1);
+                                               out[0] = (unsigned char) ((in[0] + in[4]) >> 1);
+                                               out[1] = (unsigned char) ((in[1] + in[5]) >> 1);
+                                               out[2] = (unsigned char) ((in[2] + in[6]) >> 1);
+                                               out[3] = (unsigned char) ((in[3] + in[7]) >> 1);
                                                out += 4;
                                                in += 8;
                                        }
@@ -1348,16 +1389,16 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                {
                                        for (x = 0;x < *width;x++)
                                        {
-                                               out[0] = (qbyte) ((in[0] + in[3]) >> 1);
-                                               out[1] = (qbyte) ((in[1] + in[4]) >> 1);
-                                               out[2] = (qbyte) ((in[2] + in[5]) >> 1);
+                                               out[0] = (unsigned char) ((in[0] + in[3]) >> 1);
+                                               out[1] = (unsigned char) ((in[1] + in[4]) >> 1);
+                                               out[2] = (unsigned char) ((in[2] + in[5]) >> 1);
                                                out += 3;
                                                in += 6;
                                        }
                                }
                        }
                        else
-                               Sys_Error("Image_MipReduce: unsupported bytesperpixel %i\n", bytesperpixel);
+                               Con_Printf ("Image_MipReduce: unsupported bytesperpixel %i\n", bytesperpixel);
                }
        }
        else
@@ -1372,10 +1413,10 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                {
                                        for (x = 0;x < *width;x++)
                                        {
-                                               out[0] = (qbyte) ((in[0] + in[nextrow  ]) >> 1);
-                                               out[1] = (qbyte) ((in[1] + in[nextrow+1]) >> 1);
-                                               out[2] = (qbyte) ((in[2] + in[nextrow+2]) >> 1);
-                                               out[3] = (qbyte) ((in[3] + in[nextrow+3]) >> 1);
+                                               out[0] = (unsigned char) ((in[0] + in[nextrow  ]) >> 1);
+                                               out[1] = (unsigned char) ((in[1] + in[nextrow+1]) >> 1);
+                                               out[2] = (unsigned char) ((in[2] + in[nextrow+2]) >> 1);
+                                               out[3] = (unsigned char) ((in[3] + in[nextrow+3]) >> 1);
                                                out += 4;
                                                in += 4;
                                        }
@@ -1388,9 +1429,9 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                {
                                        for (x = 0;x < *width;x++)
                                        {
-                                               out[0] = (qbyte) ((in[0] + in[nextrow  ]) >> 1);
-                                               out[1] = (qbyte) ((in[1] + in[nextrow+1]) >> 1);
-                                               out[2] = (qbyte) ((in[2] + in[nextrow+2]) >> 1);
+                                               out[0] = (unsigned char) ((in[0] + in[nextrow  ]) >> 1);
+                                               out[1] = (unsigned char) ((in[1] + in[nextrow+1]) >> 1);
+                                               out[2] = (unsigned char) ((in[2] + in[nextrow+2]) >> 1);
                                                out += 3;
                                                in += 3;
                                        }
@@ -1398,10 +1439,10 @@ void Image_MipReduce(const qbyte *in, qbyte *out, int *width, int *height, int *
                                }
                        }
                        else
-                               Sys_Error("Image_MipReduce: unsupported bytesperpixel %i\n", bytesperpixel);
+                               Con_Printf ("Image_MipReduce: unsupported bytesperpixel %i\n", bytesperpixel);
                }
                else
-                       Sys_Error("Image_MipReduce: desired size already achieved\n");
+                       Con_Printf ("Image_MipReduce: desired size already achieved\n");
        }
 }
 
@@ -1449,8 +1490,8 @@ void Image_HeightmapToNormalmap(const unsigned char *inpixels, unsigned char *ou
                        n[1] = dv[0][2]*dv[1][0]-dv[0][0]*dv[1][2];
                        n[2] = dv[0][0]*dv[1][1]-dv[0][1]*dv[1][0];
                        */
-                       n[0] = ((p1[0] + p1[1] + p1[2]) - (p0[0] + p0[1] + p0[2]));
-                       n[1] = ((p0[0] + p0[1] + p0[2]) - (p2[0] + p2[1] + p2[2]));
+                       n[0] = ((p0[0] + p0[1] + p0[2]) - (p1[0] + p1[1] + p1[2]));
+                       n[1] = ((p2[0] + p2[1] + p2[2]) - (p0[0] + p0[1] + p0[2]));
                        n[2] = ibumpscale;
                        VectorNormalize(n);
                        /*
@@ -1464,7 +1505,7 @@ void Image_HeightmapToNormalmap(const unsigned char *inpixels, unsigned char *ou
                        out[0] = 128.0f + n[0] * 127.0f;
                        out[1] = 128.0f + n[1] * 127.0f;
                        out[2] = 128.0f + n[2] * 127.0f;
-                       out[3] = 255;
+                       out[3] = (p0[0] + p0[1] + p0[2]) / 3;
                        out += 4;
                }
        }
@@ -1473,10 +1514,11 @@ void Image_HeightmapToNormalmap(const unsigned char *inpixels, unsigned char *ou
 int image_loadskin(imageskin_t *s, char *shadername)
 {
        int j;
-       qbyte *bumppixels;
+       unsigned char *bumppixels;
        int bumppixels_width, bumppixels_height;
        char name[MAX_QPATH];
-       Image_StripImageExtension(shadername, name);
+       strlcpy(name, shadername, sizeof(name));
+       Image_StripImageExtension(name, name);
        memset(s, 0, sizeof(*s));
        s->basepixels = loadimagepixels(name, false, 0, 0);
        if (s->basepixels == NULL)
@@ -1487,7 +1529,7 @@ int image_loadskin(imageskin_t *s, char *shadername)
        bumppixels = NULL;bumppixels_width = 0;bumppixels_height = 0;
        if (Image_CheckAlpha(s->basepixels, s->basepixels_width * s->basepixels_height, true))
        {
-               s->maskpixels = Mem_Alloc(loadmodel->mempool, s->basepixels_width * s->basepixels_height * 4);
+               s->maskpixels = (unsigned char *)Mem_Alloc(loadmodel->mempool, s->basepixels_width * s->basepixels_height * 4);
                s->maskpixels_width = s->basepixels_width;
                s->maskpixels_height = s->basepixels_height;
                memcpy(s->maskpixels, s->basepixels, s->maskpixels_width * s->maskpixels_height * 4);
@@ -1541,7 +1583,7 @@ int image_loadskin(imageskin_t *s, char *shadername)
                {
                        if (r_shadow_bumpscale_bumpmap.value > 0)
                        {
-                               s->nmappixels = Mem_Alloc(loadmodel->mempool, bumppixels_width * bumppixels_height * 4);
+                               s->nmappixels = (unsigned char *)Mem_Alloc(loadmodel->mempool, bumppixels_width * bumppixels_height * 4);
                                s->nmappixels_width = bumppixels_width;
                                s->nmappixels_height = bumppixels_height;
                                Image_HeightmapToNormalmap(bumppixels, s->nmappixels, s->nmappixels_width, s->nmappixels_height, false, r_shadow_bumpscale_bumpmap.value);
@@ -1551,7 +1593,7 @@ int image_loadskin(imageskin_t *s, char *shadername)
                {
                        if (r_shadow_bumpscale_basetexture.value > 0)
                        {
-                               s->nmappixels = Mem_Alloc(loadmodel->mempool, s->basepixels_width * s->basepixels_height * 4);
+                               s->nmappixels = (unsigned char *)Mem_Alloc(loadmodel->mempool, s->basepixels_width * s->basepixels_height * 4);
                                s->nmappixels_width = s->basepixels_width;
                                s->nmappixels_height = s->basepixels_height;
                                Image_HeightmapToNormalmap(s->basepixels, s->nmappixels, s->nmappixels_width, s->nmappixels_height, false, r_shadow_bumpscale_basetexture.value);