fix a number of char types that should be int, to make them immune to

[xonotic/darkplaces.git] / menu.c

diff --git a/menu.c b/menu.c
index dea6f27e78b6b740ae0899679dd7eab2c7c04594..144de64aeeda29a977e2c6f55e967e8b3425694d 100644 (file)
--- a/menu.c
+++ b/menu.c
@@ -82,28 +82,28 @@ static void M_ServerList_Draw (void);
 static void M_ModList_Draw (void);
 
 
-static void M_Main_Key (int key, char ascii);
-       static void M_SinglePlayer_Key (int key, char ascii);
-               static void M_Transfusion_Episode_Key (int key, char ascii);
-                       static void M_Transfusion_Skill_Key (int key, char ascii);
-               static void M_Load_Key (int key, char ascii);
-               static void M_Save_Key (int key, char ascii);
-       static void M_MultiPlayer_Key (int key, char ascii);
-               static void M_Setup_Key (int key, char ascii);
-       static void M_Options_Key (int key, char ascii);
-       static void M_Options_Effects_Key (int key, char ascii);
-       static void M_Options_Graphics_Key (int key, char ascii);
-       static void M_Options_ColorControl_Key (int key, char ascii);
-               static void M_Keys_Key (int key, char ascii);
-               static void M_Reset_Key (int key, char ascii);
-               static void M_Video_Key (int key, char ascii);
-       static void M_Help_Key (int key, char ascii);
-       static void M_Credits_Key (int key, char ascii);
-       static void M_Quit_Key (int key, char ascii);
-static void M_LanConfig_Key (int key, char ascii);
-static void M_GameOptions_Key (int key, char ascii);
-static void M_ServerList_Key (int key, char ascii);
-static void M_ModList_Key (int key, char ascii);
+static void M_Main_Key (int key, int ascii);
+       static void M_SinglePlayer_Key (int key, int ascii);
+               static void M_Transfusion_Episode_Key (int key, int ascii);
+                       static void M_Transfusion_Skill_Key (int key, int ascii);
+               static void M_Load_Key (int key, int ascii);
+               static void M_Save_Key (int key, int ascii);
+       static void M_MultiPlayer_Key (int key, int ascii);
+               static void M_Setup_Key (int key, int ascii);
+       static void M_Options_Key (int key, int ascii);
+       static void M_Options_Effects_Key (int key, int ascii);
+       static void M_Options_Graphics_Key (int key, int ascii);
+       static void M_Options_ColorControl_Key (int key, int ascii);
+               static void M_Keys_Key (int key, int ascii);
+               static void M_Reset_Key (int key, int ascii);
+               static void M_Video_Key (int key, int ascii);
+       static void M_Help_Key (int key, int ascii);
+       static void M_Credits_Key (int key, int ascii);
+       static void M_Quit_Key (int key, int ascii);
+static void M_LanConfig_Key (int key, int ascii);
+static void M_GameOptions_Key (int key, int ascii);
+static void M_ServerList_Key (int key, int ascii);
+static void M_ModList_Key (int key, int ascii);
 
 static qboolean        m_entersound;           // play after drawing a frame, so caching won't disrupt the sound
 
@@ -316,7 +316,7 @@ void M_Menu_Demos_f (void)
 }
 
 
-static void M_Demo_Key (int k, char ascii)
+static void M_Demo_Key (int k, int ascii)
 {
        switch (k)
        {
@@ -467,7 +467,7 @@ static void M_Main_Draw (void)
 }
 
 
-static void M_Main_Key (int key, char ascii)
+static void M_Main_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -748,7 +748,7 @@ static void M_SinglePlayer_Draw (void)
 }
 
 
-static void M_SinglePlayer_Key (int key, char ascii)
+static void M_SinglePlayer_Key (int key, int ascii)
 {
        if (gamemode == GAME_GOODVSBAD2 || gamemode == GAME_BATTLEMECH)
        {
@@ -829,8 +829,8 @@ static void M_ScanSaves (void)
        {
                strlcpy (m_filenames[i], "--- UNUSED SLOT ---", sizeof(m_filenames[i]));
                loadable[i] = false;
-               sprintf (name, "s%i.sav", (int)i);
-               f = FS_Open (name, "rb", false, false);
+               dpsnprintf (name, sizeof(name), "s%i.sav", (int)i);
+               f = FS_OpenRealFile (name, "rb", false);
                if (!f)
                        continue;
                // read enough to get the comment
@@ -913,7 +913,7 @@ static void M_Save_Draw (void)
 }
 
 
-static void M_Load_Key (int k, char ascii)
+static void M_Load_Key (int k, int ascii)
 {
        switch (k)
        {
@@ -954,7 +954,7 @@ static void M_Load_Key (int k, char ascii)
 }
 
 
-static void M_Save_Key (int k, char ascii)
+static void M_Save_Key (int k, int ascii)
 {
        switch (k)
        {
@@ -1017,7 +1017,7 @@ static void M_Transfusion_Episode_Draw (void)
        M_DrawPic (0, 120 + (m_episode_cursor + 1) * 40, va("gfx/menu/episode%iselected", m_episode_cursor + 1));
 }
 
-static void M_Transfusion_Episode_Key (int key, char ascii)
+static void M_Transfusion_Episode_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -1075,7 +1075,7 @@ static void M_Transfusion_Skill_Draw (void)
        M_DrawPic (0, 140 + (m_skill_cursor + 1) *40, va("gfx/menu/difficulty%iselected", m_skill_cursor + 1));
 }
 
-static void M_Transfusion_Skill_Key (int key, char ascii)
+static void M_Transfusion_Skill_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -1189,7 +1189,7 @@ static void M_MultiPlayer_Draw (void)
 }
 
 
-static void M_MultiPlayer_Key (int key, char ascii)
+static void M_MultiPlayer_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -1382,7 +1382,7 @@ static void M_Setup_Draw (void)
 }
 
 
-static void M_Setup_Key (int k, char ascii)
+static void M_Setup_Key (int k, int ascii)
 {
        int                     l;
 
@@ -1508,9 +1508,9 @@ static void M_DrawSlider (int x, int y, float num, float rangemin, float rangema
        M_DrawCharacter (x+i*8, y, 130);
        M_DrawCharacter (x + (SLIDER_RANGE-1)*8 * range, y, 131);
        if (fabs((int)num - num) < 0.01)
-               sprintf(text, "%i", (int)num);
+               dpsnprintf(text, sizeof(text), "%i", (int)num);
        else
-               sprintf(text, "%.3f", num);
+               dpsnprintf(text, sizeof(text), "%.3f", num);
        M_Print(x + (SLIDER_RANGE+2) * 8, y, text);
 }
 
@@ -1668,7 +1668,7 @@ static void M_Options_Draw (void)
 }
 
 
-static void M_Options_Key (int k, char ascii)
+static void M_Options_Key (int k, int ascii)
 {
        switch (k)
        {
@@ -1883,7 +1883,7 @@ static void M_Options_Effects_Draw (void)
 }
 
 
-static void M_Options_Effects_Key (int k, char ascii)
+static void M_Options_Effects_Key (int k, int ascii)
 {
        switch (k)
        {
@@ -2019,7 +2019,7 @@ static void M_Options_Graphics_Draw (void)
 }
 
 
-static void M_Options_Graphics_Key (int k, char ascii)
+static void M_Options_Graphics_Key (int k, int ascii)
 {
        switch (k)
        {
@@ -2176,7 +2176,7 @@ static void M_Options_ColorControl_Draw (void)
        float x, c, s, t, u, v;
        cachepic_t      *p, *dither;
 
-       dither = Draw_CachePic ("gfx/colorcontrol/ditherpattern");
+       dither = Draw_CachePic_Flags ("gfx/colorcontrol/ditherpattern", CACHEPICFLAG_NOCLAMP);
 
        M_Background(320, 256);
 
@@ -2246,7 +2246,7 @@ static void M_Options_ColorControl_Draw (void)
 }
 
 
-static void M_Options_ColorControl_Key (int k, char ascii)
+static void M_Options_ColorControl_Key (int k, int ascii)
 {
        switch (k)
        {
@@ -2511,7 +2511,7 @@ static int                bind_grab;
 
 void M_Menu_Keys_f (void)
 {
-       key_dest = key_menu;
+       key_dest = key_menu_grabbed;
        m_state = m_keys;
        m_entersound = true;
 }
@@ -2620,7 +2620,7 @@ static void M_Keys_Draw (void)
 }
 
 
-static void M_Keys_Key (int k, char ascii)
+static void M_Keys_Key (int k, int ascii)
 {
        char    cmd[80];
        int             keys[NUMKEYS];
@@ -2634,7 +2634,7 @@ static void M_Keys_Key (int k, char ascii)
                }
                else //if (k != '`')
                {
-                       sprintf (cmd, "bind \"%s\" \"%s\"\n", Key_KeynumToString (k), bindnames[keys_cursor][0]);
+                       dpsnprintf (cmd, sizeof(cmd), "bind \"%s\" \"%s\"\n", Key_KeynumToString (k), bindnames[keys_cursor][0]);
                        Cbuf_InsertText (cmd);
                }
 
@@ -2696,7 +2696,7 @@ void M_Menu_Reset_f (void)
 }
 
 
-static void M_Reset_Key (int key, char ascii)
+static void M_Reset_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -2959,7 +2959,7 @@ static void M_Menu_Video_AdjustSliders (int dir)
 }
 
 
-static void M_Video_Key (int key, char ascii)
+static void M_Video_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -3042,7 +3042,7 @@ static void M_Help_Draw (void)
 }
 
 
-static void M_Help_Key (int key, char ascii)
+static void M_Help_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -3089,7 +3089,7 @@ static void M_Credits_Draw (void)
 }
 
 
-static void M_Credits_Key (int key, char ascii)
+static void M_Credits_Key (int key, int ascii)
 {
                M_Menu_Main_f ();
 }
@@ -3196,7 +3196,7 @@ void M_Menu_Quit_f (void)
 }
 
 
-static void M_Quit_Key (int key, char ascii)
+static void M_Quit_Key (int key, int ascii)
 {
        switch (key)
        {
@@ -3272,7 +3272,7 @@ void M_Menu_LanConfig_f (void)
        if (StartingGame)
                lanConfig_cursor = 1;
        lanConfig_port = 26000;
-       sprintf(lanConfig_portname, "%u", (unsigned int) lanConfig_port);
+       dpsnprintf(lanConfig_portname, sizeof(lanConfig_portname), "%u", (unsigned int) lanConfig_port);
 
        M_Update_Return_Reason("");
 }
@@ -3331,7 +3331,7 @@ static void M_LanConfig_Draw (void)
 }
 
 
-static void M_LanConfig_Key (int key, char ascii)
+static void M_LanConfig_Key (int key, int ascii)
 {
        int             l;
 
@@ -3438,7 +3438,7 @@ static void M_LanConfig_Key (int key, char ascii)
        l =  atoi(lanConfig_portname);
        if (l <= 65535)
                lanConfig_port = l;
-       sprintf(lanConfig_portname, "%u", (unsigned int) lanConfig_port);
+       dpsnprintf(lanConfig_portname, sizeof(lanConfig_portname), "%u", (unsigned int) lanConfig_port);
 }
 
 //=============================================================================
@@ -4239,7 +4239,7 @@ static void M_NetStart_Change (int dir)
        }
 }
 
-static void M_GameOptions_Key (int key, char ascii)
+static void M_GameOptions_Key (int key, int ascii)
 {
        gamelevels_t *g;
        int l;
@@ -4395,7 +4395,7 @@ static void M_ServerList_Draw (void)
 }
 
 
-static void M_ServerList_Key(int k, char ascii)
+static void M_ServerList_Key(int k, int ascii)
 {
        switch (k)
        {
@@ -4615,7 +4615,7 @@ static void M_ModList_Draw (void)
        }
 }
 
-static void M_ModList_Key(int k, char ascii)
+static void M_ModList_Key(int k, int ascii)
 {
        switch (k)
        {
@@ -4665,7 +4665,7 @@ static void M_ModList_Key(int k, char ascii)
 //=============================================================================
 /* Menu Subsystem */
 
-static void M_KeyEvent(int key, char ascii, qboolean downevent);
+static void M_KeyEvent(int key, int ascii, qboolean downevent);
 static void M_Draw(void);
 void M_ToggleMenu_f(void);
 static void M_Shutdown(void);
@@ -4902,7 +4902,7 @@ void M_Draw (void)
 }
 
 
-void M_KeyEvent (int key, char ascii, qboolean downevent)
+void M_KeyEvent (int key, int ascii, qboolean downevent)
 {
        if (!downevent)
                return;
@@ -5067,7 +5067,7 @@ void MP_Error(const char *format, ...)
        Host_AbortCurrentFrame();
 }
 
-void MP_KeyEvent (int key, char ascii, qboolean downevent)
+void MP_KeyEvent (int key, int ascii, qboolean downevent)
 {
        PRVM_Begin;
        PRVM_SetProg(PRVM_MENUPROG);
@@ -5182,7 +5182,7 @@ void MP_Restart(void)
 //============================================================================
 // Menu router
 
-void (*MR_KeyEvent) (int key, char ascii, qboolean downevent);
+void (*MR_KeyEvent) (int key, int ascii, qboolean downevent);
 void (*MR_Draw) (void);
 void (*MR_ToggleMenu_f) (void);
 void (*MR_Shutdown) (void);