case SLIF_NAME:
result = strcasecmp( B->info.name, A->info.name );
break;
+ case SLIF_QCSTATUS:
+ result = strcasecmp( B->info.qcstatus, A->info.qcstatus ); // not really THAT useful, though
+ break;
+ case SLIF_PLAYERS:
+ result = strcasecmp( B->info.players, A->info.qcstatus ); // not really THAT useful, though
+ break;
default:
Con_DPrint( "_ServerList_Entry_Compare: Bad serverlist_sortbyfield!\n" );
break;
case SLMO_GREATEREQUAL:
case SLMO_CONTAINS:
case SLMO_NOTCONTAIN:
+ case SLMO_STARTSWITH:
+ case SLMO_NOTSTARTSWITH:
return A >= B;
default:
Con_DPrint( "_ServerList_CompareInt: Bad op!\n" );
static qboolean _ServerList_CompareStr( const char *A, serverlist_maskop_t op, const char *B )
{
int i;
- char bufferA[ 256 ], bufferB[ 256 ]; // should be more than enough
- for (i = 0;i < (int)sizeof(bufferA)-1 && A[i];i++)
- bufferA[i] = (A[i] >= 'A' && A[i] <= 'Z') ? (A[i] + 'a' - 'A') : A[i];
+ char bufferA[ 1400 ], bufferB[ 1400 ]; // should be more than enough
+ COM_StringDecolorize(A, 0, bufferA, sizeof(bufferA), false);
+ for (i = 0;i < (int)sizeof(bufferA)-1 && bufferA[i];i++)
+ bufferA[i] = (bufferA[i] >= 'A' && bufferA[i] <= 'Z') ? (bufferA[i] + 'a' - 'A') : bufferA[i];
bufferA[i] = 0;
for (i = 0;i < (int)sizeof(bufferB)-1 && B[i];i++)
bufferB[i] = (B[i] >= 'A' && B[i] <= 'Z') ? (B[i] + 'a' - 'A') : B[i];
return *bufferB && !!strstr( bufferA, bufferB ); // we want a real bool
case SLMO_NOTCONTAIN:
return !*bufferB || !strstr( bufferA, bufferB );
+ case SLMO_STARTSWITH:
+ //Con_Printf("startsWith: %s %s\n", bufferA, bufferB);
+ return *bufferB && !memcmp(bufferA, bufferB, strlen(bufferB));
+ case SLMO_NOTSTARTSWITH:
+ return !*bufferB || memcmp(bufferA, bufferB, strlen(bufferB));
case SLMO_LESS:
return strcmp( bufferA, bufferB ) < 0;
case SLMO_LESSEQUAL:
if( *mask->info.name
&& !_ServerList_CompareStr( info->name, mask->tests[SLIF_NAME], mask->info.name ) )
return false;
+ if( *mask->info.qcstatus
+ && !_ServerList_CompareStr( info->qcstatus, mask->tests[SLIF_QCSTATUS], mask->info.qcstatus ) )
+ return false;
+ if( *mask->info.players
+ && !_ServerList_CompareStr( info->players, mask->tests[SLIF_PLAYERS], mask->info.players ) )
+ return false;
return true;
}
// FIXME: change this to be more readable (...)
// now check whether it passes through the masks
- for( start = 0 ; serverlist_andmasks[start].active && start < SERVERLIST_ANDMASKCOUNT ; start++ )
+ for( start = 0 ; start < SERVERLIST_ANDMASKCOUNT && serverlist_andmasks[start].active; start++ )
if( !_ServerList_Entry_Mask( &serverlist_andmasks[start], &entry->info ) )
return;
- for( start = 0 ; serverlist_ormasks[start].active && start < SERVERLIST_ORMASKCOUNT ; start++ )
+ for( start = 0 ; start < SERVERLIST_ORMASKCOUNT && serverlist_ormasks[start].active ; start++ )
if( _ServerList_Entry_Mask( &serverlist_ormasks[start], &entry->info ) )
break;
if( start == SERVERLIST_ORMASKCOUNT || (start > 0 && !serverlist_ormasks[start].active) )
serverlist_cache[serverlist_cachecount].info.ping = 1000 + 1024 - i;
dpsnprintf( serverlist_cache[serverlist_cachecount].info.name, sizeof(serverlist_cache[serverlist_cachecount].info.name), "Black's ServerList Test %i", i );
serverlist_cache[serverlist_cachecount].finished = true;
- sprintf( serverlist_cache[serverlist_cachecount].line1, "%i %s", serverlist_cache[serverlist_cachecount].info.ping, serverlist_cache[serverlist_cachecount].info.name );
+ dpsnprintf( serverlist_cache[serverlist_cachecount].line1, sizeof(serverlist_cache[serverlist_cachecount].info.line1), "%i %s", serverlist_cache[serverlist_cachecount].info.ping, serverlist_cache[serverlist_cachecount].info.name );
ServerList_ViewList_Insert( &serverlist_cache[serverlist_cachecount] );
serverlist_cachecount++;
}
M_Update_Return_Reason(rejectreason);
return true;
}
+ if (length >= 15 && !memcmp(string, "statusResponse\x0A", 15))
+ {
+ serverlist_info_t *info;
+ char *p;
+ int n;
+
+ string += 15;
+ // search the cache for this server and update it
+ n = NetConn_ClientParsePacket_ServerList_ProcessReply(addressstring2);
+ if (n < 0)
+ return true;
+
+ info = &serverlist_cache[n].info;
+ info->game[0] = 0;
+ info->mod[0] = 0;
+ info->map[0] = 0;
+ info->name[0] = 0;
+ info->qcstatus[0] = 0;
+ info->players[0] = 0;
+ info->protocol = -1;
+ info->numplayers = 0;
+ info->numbots = -1;
+ info->maxplayers = 0;
+ info->gameversion = 0;
+
+ p = strchr(string, '\n');
+ if(p)
+ {
+ *p = 0; // cut off the string there
+ ++p;
+ }
+ else
+ Con_Printf("statusResponse without players block?\n");
+
+ if ((s = SearchInfostring(string, "gamename" )) != NULL) strlcpy(info->game, s, sizeof (info->game));
+ if ((s = SearchInfostring(string, "modname" )) != NULL) strlcpy(info->mod , s, sizeof (info->mod ));
+ if ((s = SearchInfostring(string, "mapname" )) != NULL) strlcpy(info->map , s, sizeof (info->map ));
+ if ((s = SearchInfostring(string, "hostname" )) != NULL) strlcpy(info->name, s, sizeof (info->name));
+ if ((s = SearchInfostring(string, "protocol" )) != NULL) info->protocol = atoi(s);
+ if ((s = SearchInfostring(string, "clients" )) != NULL) info->numplayers = atoi(s);
+ if ((s = SearchInfostring(string, "bots" )) != NULL) info->numbots = atoi(s);
+ if ((s = SearchInfostring(string, "sv_maxclients")) != NULL) info->maxplayers = atoi(s);
+ if ((s = SearchInfostring(string, "gameversion" )) != NULL) info->gameversion = atoi(s);
+ if ((s = SearchInfostring(string, "qcstatus" )) != NULL) strlcpy(info->qcstatus, s, sizeof(info->qcstatus));
+ if (p != NULL) strlcpy(info->players, p, sizeof(info->players));
+ info->numhumans = info->numplayers - max(0, info->numbots);
+ info->freeslots = info->maxplayers - info->numplayers;
+
+ NetConn_ClientParsePacket_ServerList_UpdateCache(n);
+
+ return true;
+ }
if (length >= 13 && !memcmp(string, "infoResponse\x0A", 13))
{
serverlist_info_t *info;
info->mod[0] = 0;
info->map[0] = 0;
info->name[0] = 0;
+ info->qcstatus[0] = 0;
+ info->players[0] = 0;
info->protocol = -1;
info->numplayers = 0;
info->numbots = -1;
info->maxplayers = 0;
info->gameversion = 0;
+
if ((s = SearchInfostring(string, "gamename" )) != NULL) strlcpy(info->game, s, sizeof (info->game));
if ((s = SearchInfostring(string, "modname" )) != NULL) strlcpy(info->mod , s, sizeof (info->mod ));
if ((s = SearchInfostring(string, "mapname" )) != NULL) strlcpy(info->map , s, sizeof (info->map ));
if ((s = SearchInfostring(string, "bots" )) != NULL) info->numbots = atoi(s);
if ((s = SearchInfostring(string, "sv_maxclients")) != NULL) info->maxplayers = atoi(s);
if ((s = SearchInfostring(string, "gameversion" )) != NULL) info->gameversion = atoi(s);
+ if ((s = SearchInfostring(string, "qcstatus" )) != NULL) strlcpy(info->qcstatus, s, sizeof(info->qcstatus));
info->numhumans = info->numplayers - max(0, info->numbots);
info->freeslots = info->maxplayers - info->numplayers;
return true;
info = &serverlist_cache[n].info;
- strlcpy(info->game, "QuakeWorld", sizeof(info->game));;
+ strlcpy(info->game, "QuakeWorld", sizeof(info->game));
if ((s = SearchInfostring(string, "*gamedir" )) != NULL) strlcpy(info->mod , s, sizeof (info->mod ));else info->mod[0] = 0;
if ((s = SearchInfostring(string, "map" )) != NULL) strlcpy(info->map , s, sizeof (info->map ));else info->map[0] = 0;
if ((s = SearchInfostring(string, "hostname" )) != NULL) strlcpy(info->name, s, sizeof (info->name));else info->name[0] = 0;
else
{
for (socket = 0; socket < cl_numsockets ; socket++)
- NetConn_WriteString(cl_sockets[socket], "\377\377\377\377getinfo", &address);
+ NetConn_WriteString(cl_sockets[socket], "\377\377\377\377getstatus", &address);
}
// update the entry fields
buffer[i] = 0;
}
+// (div0) build the full response only if possible; better a getinfo response than no response at all if getstatus won't fit
static qboolean NetConn_BuildStatusResponse(const char* challenge, char* out_msg, size_t out_size, qboolean fullstatus)
{
+ const char *qcstatus = NULL;
unsigned int nb_clients = 0, nb_bots = 0, i;
int length;
+ SV_VM_Begin();
+
// How many clients are there?
for (i = 0;i < (unsigned int)svs.maxclients;i++)
{
}
}
+ if(prog->globaloffsets.worldstatus >= 0)
+ {
+ const char *str = PRVM_G_STRING(prog->globaloffsets.worldstatus);
+ if(str && *str)
+ {
+ char *p;
+ const char *q;
+ qcstatus = p = Mem_Alloc(tempmempool, strlen(str) + 1);
+ for(q = str; *q; ++q)
+ if(*q != '\\')
+ *p++ = *q;
+ *p = 0;
+ }
+ }
+
// TODO: we should add more information for the full status string
length = dpsnprintf(out_msg, out_size,
"\377\377\377\377%s\x0A"
"\\gamename\\%s\\modname\\%s\\gameversion\\%d\\sv_maxclients\\%d"
"\\clients\\%d\\bots\\%d\\mapname\\%s\\hostname\\%s\\protocol\\%d"
"%s%s"
+ "%s%s"
"%s",
fullstatus ? "statusResponse" : "infoResponse",
gamename, com_modname, gameversion.integer, svs.maxclients,
nb_clients, nb_bots, sv.name, hostname.string, NET_PROTOCOL_VERSION,
+ qcstatus ? "\\qcstatus\\" : "", qcstatus ? qcstatus : "",
challenge ? "\\challenge\\" : "", challenge ? challenge : "",
fullstatus ? "\n" : "");
+ if(qcstatus)
+ {
+ Mem_Free((char *)qcstatus);
+ qcstatus = NULL;
+ }
+
// Make sure it fits in the buffer
if (length < 0)
- return false;
+ goto bad;
if (fullstatus)
{
char *ptr;
int left;
+ int savelength;
+
+ savelength = length;
ptr = out_msg + length;
left = (int)out_size - length;
pingvalue = bound(1, pingvalue, 9999);
else
pingvalue = 0;
- length = dpsnprintf(ptr, left, "%d %d \"%s\"\n",
- cl->frags,
- pingvalue,
- cleanname);
+
+ if(prog->fieldoffsets.clientstatus >= 0)
+ {
+ const char *str = PRVM_E_STRING(PRVM_EDICT_NUM(i + 1), prog->fieldoffsets.clientstatus);
+ if(str && *str)
+ {
+ char *p;
+ const char *q;
+ qcstatus = p = Mem_Alloc(tempmempool, strlen(str) + 1);
+ for(q = str; *q; ++q)
+ if(*q != '\\' && *q != ' ')
+ *p++ = *q;
+ *p = 0;
+ }
+ }
+
+ if(qcstatus)
+ {
+ length = dpsnprintf(ptr, left, "%s %d \"%s\"\n",
+ qcstatus,
+ pingvalue,
+ cleanname);
+ Mem_Free((char *)qcstatus);
+ qcstatus = NULL;
+ }
+ else
+ length = dpsnprintf(ptr, left, "%d %d \"%s\"\n",
+ cl->frags,
+ pingvalue,
+ cleanname);
+
if(length < 0)
- return false;
+ {
+ // out of space?
+ // turn it into an infoResponse!
+ out_msg[savelength] = 0;
+ memcpy(out_msg + 4, "infoResponse\x0A", 13);
+ memmove(out_msg + 17, out_msg + 19, savelength - 19);
+ break;
+ }
left -= length;
ptr += length;
}
}
}
+ SV_VM_End();
return true;
+
+bad:
+ SV_VM_End();
+ return false;
}
static qboolean NetConn_PreventConnectFlood(lhnetaddress_t *peeraddress)
const char *RCon_Authenticate(const char *password, const char *s, const char *endpos)
{
const char *text;
+ qboolean hasquotes;
if(!strcmp(rcon_password.string, password))
return "rcon";
size_t l = strlen(s);
if(l)
{
- text = s;
-
- if (!COM_ParseToken_Console(&text))
- return NULL;
-
- // com_token now contains the command
- if(!strstr(va(" %s ", rcon_restricted_commands.string), va(" %s ", com_token)))
- return NULL;
+ hasquotes = (strchr(s, '"') != NULL);
+ // sorry, we can't allow these substrings in wildcard expressions,
+ // as they can mess with the argument counts
+ text = rcon_restricted_commands.string;
+ while(COM_ParseToken_Console(&text))
+ {
+ // com_token now contains a pattern to check for...
+ if(strchr(com_token, '*') || strchr(com_token, '?')) // wildcard expression, * can only match a SINGLE argument
+ {
+ if(!hasquotes)
+ if(matchpattern_with_separator(s, com_token, true, " ", true)) // note how we excluded tab, newline etc. above
+ goto match;
+ }
+ else if(strchr(com_token, ' ')) // multi-arg expression? must match in whole
+ {
+ if(!strcmp(com_token, s))
+ goto match;
+ }
+ else // single-arg expression? must match the beginning of the command
+ {
+ if(!strcmp(com_token, s))
+ goto match;
+ if(!memcmp(va("%s ", com_token), s, strlen(com_token) + 1))
+ goto match;
+ }
+ }
+ // if we got here, nothing matched!
+ return NULL;
}
+match:
s += l + 1;
}
{
size_t l = strlen(s);
if(l)
+ {
+ client_t *host_client_save = host_client;
Cmd_ExecuteString(s, src_command);
+ host_client = host_client_save;
+ // in case it is a command that changes host_client (like restart)
+ }
s += l + 1;
}
rcon_redirect_buffer[rcon_redirect_bufferpos] = 0;
SZ_Clear(&net_message);
// search LAN for DarkPlaces servers
- NetConn_WriteString(cl_sockets[i], "\377\377\377\377getinfo", &broadcastaddress);
+ NetConn_WriteString(cl_sockets[i], "\377\377\377\377getstatus", &broadcastaddress);
// build the getservers message to send to the dpmaster master servers
dpsnprintf(request, sizeof(request), "\377\377\377\377getservers %s %u empty full\x0A", gamename, NET_PROTOCOL_VERSION);