]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - netconn.c
improved setinfo handling so that quakeworld works much better now (name/topcolor...
[xonotic/darkplaces.git] / netconn.c
index 039f7e1f552f3b51b5e6a6d29e3fbbe314e41fc3..67a293e083d88068dd047b177d36bcc2816104be 100755 (executable)
--- a/netconn.c
+++ b/netconn.c
@@ -49,22 +49,19 @@ static cvar_t sv_qwmasters [] =
        {CVAR_SAVE, "sv_qwmaster2", "", "user-chosen qwmaster server 2"},
        {CVAR_SAVE, "sv_qwmaster3", "", "user-chosen qwmaster server 3"},
        {CVAR_SAVE, "sv_qwmaster4", "", "user-chosen qwmaster server 4"},
-       {0, "sv_qwmasterextra1", "satan.idsoftware.com", "default qwmaster server 1 (admin: idSoftware)"},
-       {0, "sv_qwmasterextra2", "192.246.40.37:27000", "id Limbo (admin: id Software)"},
-       {0, "sv_qwmasterextra3", "192.246.40.37:27002", "id CTF (admin: id Software)"},
-       {0, "sv_qwmasterextra4", "192.246.40.37:27003", "id TeamFortress (admin: id Software)"},
-       {0, "sv_qwmasterextra5", "192.246.40.37:27004", "id Miscilaneous (admin: id Software)"},
-       {0, "sv_qwmasterextra6", "192.246.40.37:27006", "id Deathmatch Only (admin: id Software)"},
-       {0, "sv_qwmasterextra7", "150.254.66.120:27000", "Poland's master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra8", "62.112.145.129:27000", "Ocrana master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra9", "master.edome.net", "edome master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra10", "qwmaster.barrysworld.com", "barrysworld master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra11", "qwmaster.ocrana.de:27000", "Ocrana2 master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra12", "213.221.174.165:27000", "unknown1 master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra13", "195.74.0.8", "unknown2 master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra14", "192.246.40.37", "unknown3 master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra15", "192.246.40.37:27006", "unknown4 master server. (admin: unknown)"},
-       {0, "sv_qwmasterextra16", "204.182.161.2", "unknown5 master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra1", "192.246.40.37:27000", "id Limbo (admin: id Software)"},
+       {0, "sv_qwmasterextra2", "192.246.40.37:27002", "id CTF (admin: id Software)"},
+       {0, "sv_qwmasterextra3", "192.246.40.37:27003", "id TeamFortress (admin: id Software)"},
+       {0, "sv_qwmasterextra4", "192.246.40.37:27004", "id Miscilaneous (admin: id Software)"},
+       {0, "sv_qwmasterextra5", "192.246.40.37:27006", "id Deathmatch Only (admin: id Software)"},
+       {0, "sv_qwmasterextra6", "150.254.66.120:27000", "Poland's master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra7", "62.112.145.129:27000", "Ocrana master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra8", "master.edome.net", "edome master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra9", "qwmaster.barrysworld.com", "barrysworld master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra10", "qwmaster.ocrana.de:27000", "Ocrana2 master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra11", "213.221.174.165:27000", "unknown1 master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra12", "195.74.0.8", "unknown2 master server. (admin: unknown)"},
+       {0, "sv_qwmasterextra13", "204.182.161.2", "unknown3 master server. (admin: unknown)"},
        {0, NULL, NULL, NULL}
 };
 
@@ -116,10 +113,10 @@ static double serverlist_querywaittime = 0;
 static unsigned char sendbuffer[NET_HEADERSIZE+NET_MAXMESSAGE];
 static unsigned char readbuffer[NET_HEADERSIZE+NET_MAXMESSAGE];
 
-int cl_numsockets;
-lhnetsocket_t *cl_sockets[16];
-int sv_numsockets;
-lhnetsocket_t *sv_sockets[16];
+static int cl_numsockets;
+static lhnetsocket_t *cl_sockets[16];
+static int sv_numsockets;
+static lhnetsocket_t *sv_sockets[16];
 
 netconn_t *netconn_list = NULL;
 mempool_t *netconn_mempool = NULL;
@@ -209,7 +206,12 @@ static qboolean _ServerList_Entry_Compare( serverlist_entry_t *A, serverlist_ent
 
        if( serverlist_sortdescending )
                return result > 0;
-       return result < 0;
+       if (result != 0)
+               return result < 0;
+       // if the chosen sort key is identical, sort by index
+       // (makes this a stable sort, so that later replies from servers won't
+       //  shuffle the servers around when they have the same ping)
+       return A < B;
 }
 
 static qboolean _ServerList_CompareInt( int A, serverlist_maskop_t op, int B )
@@ -1194,15 +1196,15 @@ static int NetConn_ClientParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                        if (info->ping == 100000)
                                        serverreplycount++;
 
+                       // update the ping
                        pingtime = (int)((Sys_DoubleTime() - serverlist_cache[n].querytime) * 1000.0 + 0.5);
                        pingtime = bound(0, pingtime, 9999);
-                       // update the ping
-                       info->ping = pingtime;
+                       info->ping = min(info->ping, pingtime);
 
                        // legacy/old stuff move it to the menu ASAP
 
                        // build description strings for the things users care about
-                       dpsnprintf(serverlist_cache[n].line1, sizeof(serverlist_cache[n].line1), "^%c%5d^7 ^%c%3u^7/%3u %-65.65s", pingtime >= 300 ? '1' : (pingtime >= 200 ? '3' : '7'), (int)pingtime, ((info->numplayers > 0 && info->numplayers < info->maxplayers) ? (info->numplayers >= 4 ? '7' : '3') : '1'), info->numplayers, info->maxplayers, info->name);
+                       dpsnprintf(serverlist_cache[n].line1, sizeof(serverlist_cache[n].line1), "^%c%5d^7 ^%c%3u^7/%3u %-65.65s", info->ping >= 300 ? '1' : (info->ping >= 200 ? '3' : '7'), (int)info->ping, ((info->numplayers > 0 && info->numplayers < info->maxplayers) ? (info->numplayers >= 4 ? '7' : '3') : '1'), info->numplayers, info->maxplayers, info->name);
                        dpsnprintf(serverlist_cache[n].line2, sizeof(serverlist_cache[n].line2), "^5%-21.21s %-19.19s ^%c%-17.17s^5 %-20.20s", info->cname, info->game, (info->gameversion != gameversion.integer) ? '1' : '5', info->mod, info->map);
                        if( serverlist_cache[n].query == SQS_QUERIED ) {
                                ServerList_ViewList_Remove( &serverlist_cache[n] );
@@ -1268,7 +1270,7 @@ static int NetConn_ClientParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                        length -= 2;
                        masterreplycount++;
                        if (serverlist_consoleoutput)
-                               Con_Print("received QuakeWorld server list...\n");
+                               Con_Printf("received QuakeWorld server list from %s...\n", addressstring2);
                        while (length >= 6 && (data[0] != 0xFF || data[1] != 0xFF || data[2] != 0xFF || data[3] != 0xFF) && data[4] * 256 + data[5] != 0)
                        {
                                int n;
@@ -1309,7 +1311,7 @@ static int NetConn_ClientParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                /*
                if (!strncmp(string, "ping", 4))
                {
-                       if (developer.integer)
+                       if (developer.integer >= 10)
                                Con_Printf("Received ping from %s, sending ack\n", UDP_AddrToString(readaddr));
                        NetConn_WriteString(mysocket, "\377\377\377\377ack", peeraddress);
                        return true;
@@ -1414,12 +1416,12 @@ static int NetConn_ClientParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                        pingtime = (int)((Sys_DoubleTime() - serverlist_cache[n].querytime) * 1000.0 + 0.5);
                        pingtime = bound(0, pingtime, 9999);
                        // update the ping
-                       info->ping = pingtime;
+                       info->ping = min(info->ping, pingtime);
 
                        // legacy/old stuff move it to the menu ASAP
 
                        // build description strings for the things users care about
-                       dpsnprintf(serverlist_cache[n].line1, sizeof(serverlist_cache[n].line1), "^%c%5d^7 ^%c%3u^7/%3u %-65.65s", pingtime >= 300 ? '1' : (pingtime >= 200 ? '3' : '7'), (int)pingtime, ((info->numplayers > 0 && info->numplayers < info->maxplayers) ? (info->numplayers >= 4 ? '7' : '3') : '1'), info->numplayers, info->maxplayers, info->name);
+                       dpsnprintf(serverlist_cache[n].line1, sizeof(serverlist_cache[n].line1), "^%c%5d^7 ^%c%3u^7/%3u %-65.65s", info->ping >= 300 ? '1' : (info->ping >= 200 ? '3' : '7'), (int)info->ping, ((info->numplayers > 0 && info->numplayers < info->maxplayers) ? (info->numplayers >= 4 ? '7' : '3') : '1'), info->numplayers, info->maxplayers, info->name);
                        dpsnprintf(serverlist_cache[n].line2, sizeof(serverlist_cache[n].line2), "^4%-21.21s %-19.19s ^%c%-17.17s^4 %-20.20s", info->cname, info->game, (info->gameversion != gameversion.integer) ? '1' : '4', info->mod, info->map);
                        if( serverlist_cache[n].query == SQS_QUERIED ) {
                                ServerList_ViewList_Remove( &serverlist_cache[n] );
@@ -1459,7 +1461,7 @@ static int NetConn_ClientParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                switch (c)
                {
                case CCREP_ACCEPT:
-                       if (developer.integer)
+                       if (developer.integer >= 10)
                                Con_Printf("Datagram_ParseConnectionless: received CCREP_ACCEPT from %s.\n", addressstring2);
                        if (cls.connect_trying)
                        {
@@ -1477,14 +1479,14 @@ static int NetConn_ClientParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                        }
                        break;
                case CCREP_REJECT:
-                       if (developer.integer)
+                       if (developer.integer >= 10)
                                Con_Printf("Datagram_ParseConnectionless: received CCREP_REJECT from %s.\n", addressstring2);
                        cls.connect_trying = false;
                        M_Update_Return_Reason((char *)data);
                        break;
 #if 0
                case CCREP_SERVER_INFO:
-                       if (developer.integer)
+                       if (developer.integer >= 10)
                                Con_Printf("Datagram_ParseConnectionless: received CCREP_SERVER_INFO from %s.\n", addressstring2);
                        if (cls.state != ca_dedicated)
                        {
@@ -1519,12 +1521,12 @@ static int NetConn_ClientParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                        break;
                case CCREP_PLAYER_INFO:
                        // we got a CCREP_PLAYER_INFO??
-                       //if (developer.integer)
+                       //if (developer.integer >= 10)
                                Con_Printf("Datagram_ParseConnectionless: received CCREP_PLAYER_INFO from %s.\n", addressstring2);
                        break;
                case CCREP_RULE_INFO:
                        // we got a CCREP_RULE_INFO??
-                       //if (developer.integer)
+                       //if (developer.integer >= 10)
                                Con_Printf("Datagram_ParseConnectionless: received CCREP_RULE_INFO from %s.\n", addressstring2);
                        break;
 #endif
@@ -1558,7 +1560,7 @@ void NetConn_QueryQueueFrame(void)
                return;
 
        // each time querycounter reaches 1.0 issue a query
-       querycounter += host_realframetime * net_slist_queriespersecond.value;
+       querycounter += cl.realframetime * net_slist_queriespersecond.value;
        maxqueries = (int)querycounter;
        maxqueries = bound(0, maxqueries, net_slist_queriesperframe.integer);
        querycounter -= maxqueries;
@@ -1789,7 +1791,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                        stringbuf[length] = 0;
                        string = stringbuf;
 
-                       if (developer.integer)
+                       if (developer.integer >= 10)
                        {
                                LHNETADDRESS_ToString(peeraddress, addressstring2, sizeof(addressstring2), true);
                                Con_Printf("NetConn_ServerParsePacket: %s sent us a command:\n", addressstring2);
@@ -1833,7 +1835,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                                // check engine protocol
                                                if (strcmp(SearchInfostring(string, "protocol"), "darkplaces 3"))
                                                {
-                                                       if (developer.integer)
+                                                       if (developer.integer >= 10)
                                                                Con_Printf("Datagram_ParseConnectionless: sending \"reject Wrong game protocol.\" to %s.\n", addressstring2);
                                                        NetConn_WriteString(mysocket, "\377\377\377\377reject Wrong game protocol.", peeraddress);
                                                }
@@ -1847,7 +1849,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                                        {
                                                                // client is still trying to connect,
                                                                // so we send a duplicate reply
-                                                               if (developer.integer)
+                                                               if (developer.integer >= 10)
                                                                        Con_Printf("Datagram_ParseConnectionless: sending duplicate accept to %s.\n", addressstring2);
                                                                NetConn_WriteString(mysocket, "\377\377\377\377accept", peeraddress);
                                                        }
@@ -1877,7 +1879,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                                                        {
                                                                                // allocated connection
                                                                                LHNETADDRESS_ToString(peeraddress, conn->address, sizeof(conn->address), true);
-                                                                               if (developer.integer)
+                                                                               if (developer.integer >= 10)
                                                                                        Con_Printf("Datagram_ParseConnectionless: sending \"accept\" to %s.\n", conn->address);
                                                                                NetConn_WriteString(mysocket, "\377\377\377\377accept", peeraddress);
                                                                                // now set up the client
@@ -1890,7 +1892,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                                                else
                                                                {
                                                                        // server is full
-                                                                       if (developer.integer)
+                                                                       if (developer.integer >= 10)
                                                                                Con_Printf("Datagram_ParseConnectionless: sending \"reject Server is full.\" to %s.\n", addressstring2);
                                                                        NetConn_WriteString(mysocket, "\377\377\377\377reject Server is full.", peeraddress);
                                                                }
@@ -1910,7 +1912,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
 
                                if (NetConn_BuildStatusResponse(challenge, response, sizeof(response), false))
                                {
-                                       if (developer.integer)
+                                       if (developer.integer >= 10)
                                                Con_Printf("Sending reply to master %s - %s\n", addressstring2, response);
                                        NetConn_WriteString(mysocket, response, peeraddress);
                                }
@@ -1926,7 +1928,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
 
                                if (NetConn_BuildStatusResponse(challenge, response, sizeof(response), true))
                                {
-                                       if (developer.integer)
+                                       if (developer.integer >= 10)
                                                Con_Printf("Sending reply to client %s - %s\n", addressstring2, response);
                                        NetConn_WriteString(mysocket, response, peeraddress);
                                }
@@ -1975,7 +1977,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                        /*
                        if (!strncmp(string, "ping", 4))
                        {
-                               if (developer.integer)
+                               if (developer.integer >= 10)
                                        Con_Printf("Received ping from %s, sending ack\n", UDP_AddrToString(readaddr));
                                NetConn_WriteString(mysocket, "\377\377\377\377ack", peeraddress);
                                return true;
@@ -2001,13 +2003,13 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                switch (c)
                                {
                                case CCREQ_CONNECT:
-                                       //if (developer.integer)
+                                       if (developer.integer >= 10)
                                                Con_Printf("Datagram_ParseConnectionless: received CCREQ_CONNECT from %s.\n", addressstring2);
                                        if (length >= (int)strlen("QUAKE") + 1 + 1)
                                        {
                                                if (memcmp(data, "QUAKE", strlen("QUAKE") + 1) != 0 || (int)data[strlen("QUAKE") + 1] != NET_PROTOCOL_VERSION)
                                                {
-                                                       if (developer.integer)
+                                                       if (developer.integer >= 10)
                                                                Con_Printf("Datagram_ParseConnectionless: sending CCREP_REJECT \"Incompatible version.\" to %s.\n", addressstring2);
                                                        SZ_Clear(&net_message);
                                                        // save space for the header, filled in later
@@ -2031,7 +2033,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                                                {
                                                                        // client is still trying to connect,
                                                                        // so we send a duplicate reply
-                                                                       if (developer.integer)
+                                                                       if (developer.integer >= 10)
                                                                                Con_Printf("Datagram_ParseConnectionless: sending duplicate CCREP_ACCEPT to %s.\n", addressstring2);
                                                                        SZ_Clear(&net_message);
                                                                        // save space for the header, filled in later
@@ -2065,7 +2067,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                                                        // connect to the client
                                                                        // everything is allocated, just fill in the details
                                                                        strlcpy (conn->address, addressstring2, sizeof (conn->address));
-                                                                       if (developer.integer)
+                                                                       if (developer.integer >= 10)
                                                                                Con_Printf("Datagram_ParseConnectionless: sending CCREP_ACCEPT to %s.\n", addressstring2);
                                                                        // send back the info about the server connection
                                                                        SZ_Clear(&net_message);
@@ -2084,7 +2086,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                                                }
                                                                else
                                                                {
-                                                                       //if (developer.integer)
+                                                                       if (developer.integer >= 10)
                                                                                Con_Printf("Datagram_ParseConnectionless: sending CCREP_REJECT \"Server is full.\" to %s.\n", addressstring2);
                                                                        // no room; try to let player know
                                                                        SZ_Clear(&net_message);
@@ -2102,11 +2104,11 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                        break;
 #if 0
                                case CCREQ_SERVER_INFO:
-                                       if (developer.integer)
+                                       if (developer.integer >= 10)
                                                Con_Printf("Datagram_ParseConnectionless: received CCREQ_SERVER_INFO from %s.\n", addressstring2);
                                        if (sv.active && !strcmp(MSG_ReadString(), "QUAKE"))
                                        {
-                                               if (developer.integer)
+                                               if (developer.integer >= 10)
                                                        Con_Printf("Datagram_ParseConnectionless: sending CCREP_SERVER_INFO to %s.\n", addressstring2);
                                                SZ_Clear(&net_message);
                                                // save space for the header, filled in later
@@ -2125,7 +2127,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                        }
                                        break;
                                case CCREQ_PLAYER_INFO:
-                                       if (developer.integer)
+                                       if (developer.integer >= 10)
                                                Con_Printf("Datagram_ParseConnectionless: received CCREQ_PLAYER_INFO from %s.\n", addressstring2);
                                        if (sv.active)
                                        {
@@ -2156,7 +2158,7 @@ static int NetConn_ServerParsePacket(lhnetsocket_t *mysocket, unsigned char *dat
                                        }
                                        break;
                                case CCREQ_RULE_INFO:
-                                       if (developer.integer)
+                                       if (developer.integer >= 10)
                                                Con_Printf("Datagram_ParseConnectionless: received CCREQ_RULE_INFO from %s.\n", addressstring2);
                                        if (sv.active)
                                        {
@@ -2210,7 +2212,6 @@ void NetConn_ServerFrame(void)
 {
        int i, length;
        lhnetaddress_t peeraddress;
-       NetConn_UpdateSockets();
        for (i = 0;i < sv_numsockets;i++)
                while (sv_sockets[i] && (length = NetConn_Read(sv_sockets[i], readbuffer, sizeof(readbuffer), &peeraddress)) > 0)
                        NetConn_ServerParsePacket(sv_sockets[i], readbuffer, length, &peeraddress);
@@ -2298,8 +2299,14 @@ void NetConn_QueryMasters(qboolean querydp, qboolean queryqw)
                                {
                                        if (sv_qwmasters[masternum].string && LHNETADDRESS_FromString(&masteraddress, sv_qwmasters[masternum].string, QWMASTER_PORT) && LHNETADDRESS_GetAddressType(&masteraddress) == LHNETADDRESS_GetAddressType(LHNET_AddressFromSocket(cl_sockets[i])))
                                        {
+                                               if (m_state != m_slist)
+                                               {
+                                                       char lookupstring[128];
+                                                       LHNETADDRESS_ToString(&masteraddress, lookupstring, sizeof(lookupstring), true);
+                                                       Con_Printf("Querying master %s (resolved from %s)\n", lookupstring, sv_qwmasters[masternum].string);
+                                               }
                                                masterquerycount++;
-                                               NetConn_Write(cl_sockets[i], request, 7, &masteraddress);
+                                               NetConn_Write(cl_sockets[i], request, strlen(request) + 1, &masteraddress);
                                        }
                                }
                        }