-Added a more descriptive comment for prvm_edict_t::p

[xonotic/darkplaces.git] / pr_cmds.c

diff --git a/pr_cmds.c b/pr_cmds.c
index 17cb6c9adcf55b1e963dc0dde22d3c82810af895..92086fae44a7c26f2d666b4137ffa68e459d117a 100644 (file)
--- a/pr_cmds.c
+++ b/pr_cmds.c
@@ -95,6 +95,7 @@ char *ENGINE_EXTENSIONS =
 "DP_HALFLIFE_MAP "
 "DP_HALFLIFE_MAP_CVAR "
 "DP_INPUTBUTTONS "
+"DP_LITSPRITES "
 "DP_LITSUPPORT "
 "DP_MONSTERWALK "
 "DP_MOVETYPEBOUNCEMISSILE "
@@ -1031,37 +1032,46 @@ findradius (origin, radius)
 void PF_findradius (void)
 {
        edict_t *ent, *chain;
-       float radius;
-       float radius2;
-       float *org;
-       float eorg[3];
+       vec_t radius, radius2;
+       vec3_t org, eorg, mins, maxs;
        int i;
+       int numtouchedicts;
+       edict_t *touchedicts[MAX_EDICTS];
 
        chain = (edict_t *)sv.edicts;
 
-       org = G_VECTOR(OFS_PARM0);
+       VectorCopy(G_VECTOR(OFS_PARM0), org);
        radius = G_FLOAT(OFS_PARM1);
        radius2 = radius * radius;
 
-       ent = NEXT_EDICT(sv.edicts);
-       for (i=1 ; i<sv.num_edicts ; i++, ent = NEXT_EDICT(ent))
+       mins[0] = org[0] - radius;
+       mins[1] = org[1] - radius;
+       mins[2] = org[2] - radius;
+       maxs[0] = org[0] + radius;
+       maxs[1] = org[1] + radius;
+       maxs[2] = org[2] + radius;
+       numtouchedicts = SV_EntitiesInBox(mins, maxs, MAX_EDICTS, touchedicts);
+       if (numtouchedicts > MAX_EDICTS)
+       {
+               // this never happens
+               Con_Printf("SV_EntitiesInBox returned %i edicts, max was %i\n", numtouchedicts, MAX_EDICTS);
+               numtouchedicts = MAX_EDICTS;
+       }
+       for (i = 0;i < numtouchedicts;i++)
        {
+               ent = touchedicts[i];
                pr_xfunction->builtinsprofile++;
-               if (ent->e->free)
-                       continue;
-               if (ent->v->solid == SOLID_NOT)
-                       continue;
-
-               // LordHavoc: compare against bounding box rather than center,
-               // and use DotProduct instead of Length, major speedup
+               // LordHavoc: compare against bounding box rather than center so it
+               // doesn't miss large objects, and use DotProduct instead of Length
+               // for a major speedup
                eorg[0] = (org[0] - ent->v->origin[0]) - bound(ent->v->mins[0], (org[0] - ent->v->origin[0]), ent->v->maxs[0]);
                eorg[1] = (org[1] - ent->v->origin[1]) - bound(ent->v->mins[1], (org[1] - ent->v->origin[1]), ent->v->maxs[1]);
                eorg[2] = (org[2] - ent->v->origin[2]) - bound(ent->v->mins[2], (org[2] - ent->v->origin[2]), ent->v->maxs[2]);
-               if (DotProduct(eorg, eorg) > radius2)
-                       continue;
-
-               ent->v->chain = EDICT_TO_PROG(chain);
-               chain = ent;
+               if (DotProduct(eorg, eorg) < radius2)
+               {
+                       ent->v->chain = EDICT_TO_PROG(chain);
+                       chain = ent;
+               }
        }
 
        RETURN_EDICT(chain);
@@ -1630,7 +1640,10 @@ void PF_aim (void)
        float   speed;
 
        // assume failure if it returns early
-       VectorClear(G_VECTOR(OFS_RETURN));
+       VectorCopy(pr_global_struct->v_forward, G_VECTOR(OFS_RETURN));
+       // if sv_aim is so high it can't possibly accept anything, skip out early
+       if (sv_aim.value >= 1)
+               return;
 
        ent = G_EDICT(OFS_PARM0);
        if (ent == sv.edicts)
@@ -3278,10 +3291,13 @@ void PF_cvar_string (void)
 
        str = G_STRING(OFS_PARM0);
        var = Cvar_FindVar (str);
-
-       tmp = PR_GetTempString();
-       strcpy(tmp, var->string);
-
+       if (var)
+       {
+               tmp = PR_GetTempString();
+               strcpy(tmp, var->string);
+       }
+       else
+               tmp = "";
        G_INT(OFS_RETURN) = PR_SetString(tmp);
 }