]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - prvm_execprogram.h
use unsigned comparisons for most of the boundschecks in the vm
[xonotic/darkplaces.git] / prvm_execprogram.h
index 3ae82b335c3ba44dcc33575a6c45ff95b681e707..9620daca72176be7c4c45717970c2e2114561a81 100644 (file)
 
 // This code isn't #ifdef/#define protectable, don't try.
 
+#if PRVMSLOWINTERPRETER
+               {
+                       if (prog->watch_global_type != ev_void)
+                       {
+                               prvm_eval_t *f = PRVM_GLOBALFIELDVALUE(prog->watch_global);
+                               prog->xstatement = st + 1 - prog->statements;
+                               PRVM_Watchpoint(prog, 1, "Global watchpoint hit by engine", prog->watch_global_type, &prog->watch_global_value, f);
+                       }
+                       if (prog->watch_field_type != ev_void && prog->watch_edict < prog->max_edicts)
+                       {
+                               prvm_eval_t *f = PRVM_EDICTFIELDVALUE(prog->edicts + prog->watch_edict, prog->watch_field);
+                               prog->xstatement = st + 1 - prog->statements;
+                               PRVM_Watchpoint(prog, 1, "Entityfield watchpoint hit by engine", prog->watch_field_type, &prog->watch_edictfield_value, f);
+                       }
+               }
+#endif
+
                while (1)
                {
                        st++;
                        if (prog->trace)
                                PRVM_PrintStatement(prog, st);
                        prog->statement_profile[st - prog->statements]++;
+                       if (prog->break_statement >= 0)
+                               if ((st - prog->statements) == prog->break_statement)
+                               {
+                                       prog->xstatement = st - prog->statements;
+                                       PRVM_Breakpoint(prog, prog->break_stack_index, "Breakpoint hit");
+                               }
 #endif
 
                        switch (st->op)
                                OPC->_float = OPA->vector[0]*OPB->vector[0] + OPA->vector[1]*OPB->vector[1] + OPA->vector[2]*OPB->vector[2];
                                break;
                        case OP_MUL_FV:
-                               OPC->vector[0] = OPA->_float * OPB->vector[0];
-                               OPC->vector[1] = OPA->_float * OPB->vector[1];
-                               OPC->vector[2] = OPA->_float * OPB->vector[2];
+                               tempfloat = OPA->_float;
+                               OPC->vector[0] = tempfloat * OPB->vector[0];
+                               OPC->vector[1] = tempfloat * OPB->vector[1];
+                               OPC->vector[2] = tempfloat * OPB->vector[2];
                                break;
                        case OP_MUL_VF:
-                               OPC->vector[0] = OPB->_float * OPA->vector[0];
-                               OPC->vector[1] = OPB->_float * OPA->vector[1];
-                               OPC->vector[2] = OPB->_float * OPA->vector[2];
+                               tempfloat = OPB->_float;
+                               OPC->vector[0] = tempfloat * OPA->vector[0];
+                               OPC->vector[1] = tempfloat * OPA->vector[1];
+                               OPC->vector[2] = tempfloat * OPA->vector[2];
                                break;
                        case OP_DIV_F:
                                if( OPB->_float != 0.0f )
                                }
                                break;
                        case OP_BITAND:
-                               OPC->_float = (int)OPA->_float & (int)OPB->_float;
+                               OPC->_float = (prvm_int_t)OPA->_float & (prvm_int_t)OPB->_float;
                                break;
                        case OP_BITOR:
-                               OPC->_float = (int)OPA->_float | (int)OPB->_float;
+                               OPC->_float = (prvm_int_t)OPA->_float | (prvm_int_t)OPB->_float;
                                break;
                        case OP_GE:
                                OPC->_float = OPA->_float >= OPB->_float;
                        case OP_STOREP_FLD:             // integers
                        case OP_STOREP_S:
                        case OP_STOREP_FNC:             // pointers
-                               if (OPB->_int < 0 || OPB->_int + 1 > prog->entityfieldsarea)
+                               if ((unsigned int)OPB->_int >= (unsigned int)prog->entityfieldsarea)
                                {
                                        PreError();
-                                       prog->error_cmd("%s attempted to write to an out of bounds edict (%i)", prog->name, OPB->_int);
+                                       prog->error_cmd("%s attempted to write to an out of bounds edict (%i)", prog->name, (int)OPB->_int);
                                        goto cleanup;
                                }
                                if (OPB->_int < prog->entityfields && !prog->allowworldwrites)
                                {
                                        prog->xstatement = st - prog->statements;
-                                       VM_Warning(prog, "assignment to world.%s (field %i) in %s\n", PRVM_GetString(prog, PRVM_ED_FieldAtOfs(prog, OPB->_int)->s_name), OPB->_int, prog->name);
+                                       VM_Warning(prog, "assignment to world.%s (field %i) in %s\n", PRVM_GetString(prog, PRVM_ED_FieldAtOfs(prog, OPB->_int)->s_name), (int)OPB->_int, prog->name);
                                }
                                ptr = (prvm_eval_t *)(prog->edictsfields + OPB->_int);
                                ptr->_int = OPA->_int;
                                if (OPB->_int < 0 || OPB->_int + 3 > prog->entityfieldsarea)
                                {
                                        PreError();
-                                       prog->error_cmd("%s attempted to write to an out of bounds edict (%i)", prog->name, OPB->_int);
+                                       prog->error_cmd("%s attempted to write to an out of bounds edict (%i)", prog->name, (int)OPB->_int);
                                        goto cleanup;
                                }
                                if (OPB->_int < prog->entityfields && !prog->allowworldwrites)
                                {
                                        prog->xstatement = st - prog->statements;
-                                       VM_Warning(prog, "assignment to world.%s (field %i) in %s\n", PRVM_GetString(prog, PRVM_ED_FieldAtOfs(prog, OPB->_int)->s_name), OPB->_int, prog->name);
+                                       VM_Warning(prog, "assignment to world.%s (field %i) in %s\n", PRVM_GetString(prog, PRVM_ED_FieldAtOfs(prog, OPB->_int)->s_name), (int)OPB->_int, prog->name);
                                }
                                ptr = (prvm_eval_t *)(prog->edictsfields + OPB->_int);
                                ptr->ivector[0] = OPA->ivector[0];
                                break;
 
                        case OP_ADDRESS:
-                               if (OPA->edict < 0 || OPA->edict >= prog->max_edicts)
+                               if ((unsigned int)OPA->edict >= (unsigned int)prog->max_edicts)
                                {
                                        PreError();
                                        prog->error_cmd("%s Progs attempted to address an out of bounds edict number", prog->name);
                                if ((unsigned int)(OPB->_int) >= (unsigned int)(prog->entityfields))
                                {
                                        PreError();
-                                       prog->error_cmd("%s attempted to address an invalid field (%i) in an edict", prog->name, OPB->_int);
+                                       prog->error_cmd("%s attempted to address an invalid field (%i) in an edict", prog->name, (int)OPB->_int);
                                        goto cleanup;
                                }
 #if 0
                                }
 #endif
                                ed = PRVM_PROG_TO_EDICT(OPA->edict);
-                               OPC->_int = ed->fields.vp - prog->edictsfields + OPB->_int;
+                               OPC->_int = ed->fields.fp - prog->edictsfields + OPB->_int;
                                break;
 
                        case OP_LOAD_F:
                        case OP_LOAD_ENT:
                        case OP_LOAD_S:
                        case OP_LOAD_FNC:
-                               if (OPA->edict < 0 || OPA->edict >= prog->max_edicts)
+                               if ((unsigned int)OPA->edict >= (unsigned int)prog->max_edicts)
                                {
                                        PreError();
                                        prog->error_cmd("%s Progs attempted to read an out of bounds edict number", prog->name);
                                if ((unsigned int)(OPB->_int) >= (unsigned int)(prog->entityfields))
                                {
                                        PreError();
-                                       prog->error_cmd("%s attempted to read an invalid field in an edict (%i)", prog->name, OPB->_int);
+                                       prog->error_cmd("%s attempted to read an invalid field in an edict (%i)", prog->name, (int)OPB->_int);
                                        goto cleanup;
                                }
                                ed = PRVM_PROG_TO_EDICT(OPA->edict);
-                               OPC->_int = ((prvm_eval_t *)((int *)ed->fields.vp + OPB->_int))->_int;
+                               OPC->_int = ((prvm_eval_t *)(ed->fields.ip + OPB->_int))->_int;
                                break;
 
                        case OP_LOAD_V:
-                               if (OPA->edict < 0 || OPA->edict >= prog->max_edicts)
+                               if ((unsigned int)OPA->edict >= (unsigned int)prog->max_edicts)
                                {
                                        PreError();
                                        prog->error_cmd("%s Progs attempted to read an out of bounds edict number", prog->name);
                                if (OPB->_int < 0 || OPB->_int + 2 >= prog->entityfields)
                                {
                                        PreError();
-                                       prog->error_cmd("%s attempted to read an invalid field in an edict (%i)", prog->name, OPB->_int);
+                                       prog->error_cmd("%s attempted to read an invalid field in an edict (%i)", prog->name, (int)OPB->_int);
                                        goto cleanup;
                                }
                                ed = PRVM_PROG_TO_EDICT(OPA->edict);
-                               OPC->ivector[0] = ((prvm_eval_t *)((int *)ed->fields.vp + OPB->_int))->ivector[0];
-                               OPC->ivector[1] = ((prvm_eval_t *)((int *)ed->fields.vp + OPB->_int))->ivector[1];
-                               OPC->ivector[2] = ((prvm_eval_t *)((int *)ed->fields.vp + OPB->_int))->ivector[2];
+                               ptr = (prvm_eval_t *)(ed->fields.ip + OPB->_int);
+                               OPC->ivector[0] = ptr->ivector[0];
+                               OPC->ivector[1] = ptr->ivector[1];
+                               OPC->ivector[2] = ptr->ivector[2];
                                break;
 
                //==================
                                if (!OPA->function)
                                        prog->error_cmd("NULL function in %s", prog->name);
 
-                               if(!OPA->function || OPA->function >= (unsigned int)prog->numfunctions)
+                               if(!OPA->function || OPA->function < 0 || OPA->function >= prog->numfunctions)
                                {
                                        PreError();
                                        prog->error_cmd("%s CALL outside the program", prog->name);
                                        }
                                        else
                                                prog->error_cmd("No such builtin #%i in %s; most likely cause: outdated engine build. Try updating!", builtinnumber, prog->name);
+
+                                       if (prog->trace != cachedpr_trace)
+                                               goto chooseexecprogram;
                                }
                                else
                                        st = prog->statements + PRVM_EnterFunction(prog, newf);
                                prog->xfunction->profile += (st - startst);
                                prog->xstatement = st - prog->statements;
 
-                               prog->globals.generic[OFS_RETURN] = prog->globals.generic[st->operand[0]];
-                               prog->globals.generic[OFS_RETURN+1] = prog->globals.generic[st->operand[0]+1];
-                               prog->globals.generic[OFS_RETURN+2] = prog->globals.generic[st->operand[0]+2];
+                               prog->globals.ip[OFS_RETURN  ] = prog->globals.ip[st->operand[0]  ];
+                               prog->globals.ip[OFS_RETURN+1] = prog->globals.ip[st->operand[0]+1];
+                               prog->globals.ip[OFS_RETURN+2] = prog->globals.ip[st->operand[0]+2];
 
                                st = prog->statements + PRVM_LeaveFunction(prog);
                                startst = st;
                                if (prog->depth <= exitdepth)
                                        goto cleanup; // all done
-                               if (prog->trace != cachedpr_trace)
-                                       goto chooseexecprogram;
                                break;
 
                        case OP_STATE:
                                OPC->_int = OPA->_int + OPB->_int;
                                break;
                        case OP_ADD_IF:
-                               OPC->_int = OPA->_int + (int) OPB->_float;
+                               OPC->_int = OPA->_int + (prvm_int_t) OPB->_float;
                                break;
                        case OP_ADD_FI:
-                               OPC->_float = OPA->_float + (float) OPB->_int;
+                               OPC->_float = OPA->_float + (prvm_vec_t) OPB->_int;
                                break;
                        case OP_SUB_I:
                                OPC->_int = OPA->_int - OPB->_int;
                                break;
                        case OP_SUB_IF:
-                               OPC->_int = OPA->_int - (int) OPB->_float;
+                               OPC->_int = OPA->_int - (prvm_int_t) OPB->_float;
                                break;
                        case OP_SUB_FI:
-                               OPC->_float = OPA->_float - (float) OPB->_int;
+                               OPC->_float = OPA->_float - (prvm_vec_t) OPB->_int;
                                break;
                        case OP_MUL_I:
                                OPC->_int = OPA->_int * OPB->_int;
                                break;
                        case OP_MUL_IF:
-                               OPC->_int = OPA->_int * (int) OPB->_float;
+                               OPC->_int = OPA->_int * (prvm_int_t) OPB->_float;
                                break;
                        case OP_MUL_FI:
-                               OPC->_float = OPA->_float * (float) OPB->_int;
+                               OPC->_float = OPA->_float * (prvm_vec_t) OPB->_int;
                                break;
                        case OP_MUL_VI:
-                               OPC->vector[0] = (float) OPB->_int * OPA->vector[0];
-                               OPC->vector[1] = (float) OPB->_int * OPA->vector[1];
-                               OPC->vector[2] = (float) OPB->_int * OPA->vector[2];
+                               OPC->vector[0] = (prvm_vec_t) OPB->_int * OPA->vector[0];
+                               OPC->vector[1] = (prvm_vec_t) OPB->_int * OPA->vector[1];
+                               OPC->vector[2] = (prvm_vec_t) OPB->_int * OPA->vector[2];
                                break;
                        case OP_DIV_VF:
                                {
                                OPC->_int = OPA->_int / OPB->_int;
                                break;
                        case OP_DIV_IF:
-                               OPC->_int = OPA->_int / (int) OPB->_float;
+                               OPC->_int = OPA->_int / (prvm_int_t) OPB->_float;
                                break;
                        case OP_DIV_FI:
-                               OPC->_float = OPA->_float / (float) OPB->_int;
+                               OPC->_float = OPA->_float / (prvm_vec_t) OPB->_int;
                                break;
                        case OP_CONV_IF:
                                OPC->_float = OPA->_int;
                                OPC->_int = OPA->_int | OPB->_int;
                                break;
                        case OP_BITAND_IF:
-                               OPC->_int = OPA->_int & (int)OPB->_float;
+                               OPC->_int = OPA->_int & (prvm_int_t)OPB->_float;
                                break;
                        case OP_BITOR_IF:
-                               OPC->_int = OPA->_int | (int)OPB->_float;
+                               OPC->_int = OPA->_int | (prvm_int_t)OPB->_float;
                                break;
                        case OP_BITAND_FI:
-                               OPC->_float = (int)OPA->_float & OPB->_int;
+                               OPC->_float = (prvm_int_t)OPA->_float & OPB->_int;
                                break;
                        case OP_BITOR_FI:
-                               OPC->_float = (int)OPA->_float | OPB->_int;
+                               OPC->_float = (prvm_int_t)OPA->_float | OPB->_int;
                                break;
                        case OP_GE_I:
                                OPC->_float = OPA->_int >= OPB->_int;
                                OPC->_float = OPA->_int || OPB->_int;
                                break;
                        case OP_GE_IF:
-                               OPC->_float = (float)OPA->_int >= OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int >= OPB->_float;
                                break;
                        case OP_LE_IF:
-                               OPC->_float = (float)OPA->_int <= OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int <= OPB->_float;
                                break;
                        case OP_GT_IF:
-                               OPC->_float = (float)OPA->_int > OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int > OPB->_float;
                                break;
                        case OP_LT_IF:
-                               OPC->_float = (float)OPA->_int < OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int < OPB->_float;
                                break;
                        case OP_AND_IF:
-                               OPC->_float = (float)OPA->_int && OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int && OPB->_float;
                                break;
                        case OP_OR_IF:
-                               OPC->_float = (float)OPA->_int || OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int || OPB->_float;
                                break;
                        case OP_GE_FI:
-                               OPC->_float = OPA->_float >= (float)OPB->_int;
+                               OPC->_float = OPA->_float >= (prvm_vec_t)OPB->_int;
                                break;
                        case OP_LE_FI:
-                               OPC->_float = OPA->_float <= (float)OPB->_int;
+                               OPC->_float = OPA->_float <= (prvm_vec_t)OPB->_int;
                                break;
                        case OP_GT_FI:
-                               OPC->_float = OPA->_float > (float)OPB->_int;
+                               OPC->_float = OPA->_float > (prvm_vec_t)OPB->_int;
                                break;
                        case OP_LT_FI:
-                               OPC->_float = OPA->_float < (float)OPB->_int;
+                               OPC->_float = OPA->_float < (prvm_vec_t)OPB->_int;
                                break;
                        case OP_AND_FI:
-                               OPC->_float = OPA->_float && (float)OPB->_int;
+                               OPC->_float = OPA->_float && (prvm_vec_t)OPB->_int;
                                break;
                        case OP_OR_FI:
-                               OPC->_float = OPA->_float || (float)OPB->_int;
+                               OPC->_float = OPA->_float || (prvm_vec_t)OPB->_int;
                                break;
                        case OP_NOT_I:
                                OPC->_float = !OPA->_int;
                                OPC->_float = OPA->_int == OPB->_int;
                                break;
                        case OP_EQ_IF:
-                               OPC->_float = (float)OPA->_int == OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int == OPB->_float;
                                break;
                        case OP_EQ_FI:
-                               OPC->_float = OPA->_float == (float)OPB->_int;
+                               OPC->_float = OPA->_float == (prvm_vec_t)OPB->_int;
                                break;
                        case OP_NE_I:
                                OPC->_float = OPA->_int != OPB->_int;
                                break;
                        case OP_NE_IF:
-                               OPC->_float = (float)OPA->_int != OPB->_float;
+                               OPC->_float = (prvm_vec_t)OPA->_int != OPB->_float;
                                break;
                        case OP_NE_FI:
-                               OPC->_float = OPA->_float != (float)OPB->_int;
+                               OPC->_float = OPA->_float != (prvm_vec_t)OPB->_int;
                                break;
                        case OP_STORE_I:
                                OPB->_int = OPA->_int;
                                break;
 
                        case OP_GADDRESS:
-                               i = OPA->_int + (int) OPB->_float;
+                               i = OPA->_int + (prvm_int_t) OPB->_float;
 #if PRBOUNDSCHECK
                                if (i < 0 || i >= pr_globaldefs)
                                {
                                prog->error_cmd("Bad opcode %i in %s", st->op, prog->name);
                                goto cleanup;
                        }
+#if PRVMSLOWINTERPRETER
+                       {
+                               if (prog->watch_global_type != ev_void)
+                               {
+                                       prvm_eval_t *f = PRVM_GLOBALFIELDVALUE(prog->watch_global);
+                                       prog->xstatement = st - prog->statements;
+                                       PRVM_Watchpoint(prog, 0, "Global watchpoint hit", prog->watch_global_type, &prog->watch_global_value, f);
+                               }
+                               if (prog->watch_field_type != ev_void && prog->watch_edict < prog->max_edicts)
+                               {
+                                       prvm_eval_t *f = PRVM_EDICTFIELDVALUE(prog->edicts + prog->watch_edict, prog->watch_field);
+                                       prog->xstatement = st - prog->statements;
+                                       PRVM_Watchpoint(prog, 0, "Entityfield watchpoint hit", prog->watch_field_type, &prog->watch_edictfield_value, f);
+                               }
+                       }
+#endif
                }
 
 #undef PreError