]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - r_shadow.c
now supports GL_EXT_stencil_two_side extension (found on NV30/R300 class cards),...
[xonotic/darkplaces.git] / r_shadow.c
index a9440ac81e6ed508930b47131f159b39c7085da3..9a660ed911cf4ae9a9997446eabd48aa019537b2 100644 (file)
@@ -122,7 +122,7 @@ extern void R_Shadow_EditLights_Init(void);
 #define SHADOWSTAGE_NONE 0
 #define SHADOWSTAGE_STENCIL 1
 #define SHADOWSTAGE_LIGHT 2
-#define SHADOWSTAGE_ERASESTENCIL 3
+#define SHADOWSTAGE_STENCILTWOSIDE 3
 
 int r_shadowstage = SHADOWSTAGE_NONE;
 int r_shadow_reloadlights = false;
@@ -179,6 +179,7 @@ cvar_t r_shadow_dlightshadows = {CVAR_SAVE, "r_shadow_dlightshadows", "1"};
 cvar_t r_shadow_showtris = {0, "r_shadow_showtris", "0"};
 cvar_t r_shadow_staticworldlights = {0, "r_shadow_staticworldlights", "1"};
 cvar_t r_shadow_cull = {0, "r_shadow_cull", "1"};
+cvar_t gl_ext_stenciltwoside = {0, "gl_ext_stenciltwoside", "1"};
 
 int c_rt_lights, c_rt_clears, c_rt_scissored;
 int c_rt_shadowmeshes, c_rt_shadowtris, c_rt_lightmeshes, c_rt_lighttris;
@@ -308,6 +309,7 @@ void R_Shadow_Init(void)
        Cvar_RegisterVariable(&r_shadow_showtris);
        Cvar_RegisterVariable(&r_shadow_staticworldlights);
        Cvar_RegisterVariable(&r_shadow_cull);
+       Cvar_RegisterVariable(&gl_ext_stenciltwoside);
        if (gamemode == GAME_TENEBRAE)
        {
                Cvar_SetValue("r_shadow_gloss", 2);
@@ -719,6 +721,8 @@ void R_Shadow_Stage_Begin(void)
 
        if (r_shadow_texture3d.integer && !gl_texture3d)
                Cvar_SetValueQuick(&r_shadow_texture3d, 0);
+       if (gl_ext_stenciltwoside.integer && !gl_support_stenciltwoside)
+               Cvar_SetValueQuick(&gl_ext_stenciltwoside, 0);
 
        if (!r_shadow_attenuation2dtexture
         || (!r_shadow_attenuation3dtexture && r_shadow_texture3d.integer)
@@ -763,7 +767,7 @@ void R_Shadow_Stage_ShadowVolumes(void)
        memset(&m, 0, sizeof(m));
        R_Mesh_State_Texture(&m);
        GL_Color(1, 1, 1, 1);
-       qglColorMask(0, 0, 0, 0);
+       GL_ColorMask(0, 0, 0, 0);
        GL_BlendFunc(GL_ONE, GL_ZERO);
        GL_DepthMask(false);
        GL_DepthTest(true);
@@ -778,10 +782,25 @@ void R_Shadow_Stage_ShadowVolumes(void)
        qglDepthFunc(GL_LESS);
        qglCullFace(GL_FRONT); // quake is backwards, this culls back faces
        qglEnable(GL_STENCIL_TEST);
-       qglStencilOp(GL_KEEP, GL_KEEP, GL_KEEP);
-       qglStencilFunc(GL_ALWAYS, 128, 0xFF);
-       r_shadowstage = SHADOWSTAGE_STENCIL;
-       qglClear(GL_STENCIL_BUFFER_BIT);
+       qglStencilFunc(GL_ALWAYS, 128, ~0);
+       if (gl_ext_stenciltwoside.integer)
+       {
+               r_shadowstage = SHADOWSTAGE_STENCILTWOSIDE;
+               qglEnable(GL_STENCIL_TEST_TWO_SIDE_EXT);
+        qglActiveStencilFaceEXT(GL_FRONT); // quake is backwards, this is back faces
+               qglStencilMask(~0);
+               qglStencilOp(GL_KEEP, GL_INCR, GL_KEEP);
+        qglActiveStencilFaceEXT(GL_BACK); // quake is backwards, this is front faces
+               qglStencilMask(~0);
+               qglStencilOp(GL_KEEP, GL_DECR, GL_KEEP);
+       }
+       else
+       {
+               r_shadowstage = SHADOWSTAGE_STENCIL;
+               qglStencilMask(~0);
+               qglStencilOp(GL_KEEP, GL_KEEP, GL_KEEP);
+       }
+       GL_Clear(GL_STENCIL_BUFFER_BIT);
        c_rt_clears++;
        // LordHavoc note: many shadow volumes reside entirely inside the world
        // (that is to say they are entirely bounded by their lit surfaces),
@@ -803,10 +822,13 @@ void R_Shadow_Stage_LightWithoutShadows(void)
        qglPolygonOffset(0, 0);
        //qglDisable(GL_POLYGON_OFFSET_FILL);
        GL_Color(1, 1, 1, 1);
-       qglColorMask(1, 1, 1, 1);
+       GL_ColorMask(1, 1, 1, 1);
        qglDepthFunc(GL_EQUAL);
        qglCullFace(GL_FRONT); // quake is backwards, this culls back faces
        qglDisable(GL_STENCIL_TEST);
+       if (gl_support_stenciltwoside)
+               qglDisable(GL_STENCIL_TEST_TWO_SIDE_EXT);
+       qglStencilMask(~0);
        qglStencilOp(GL_KEEP, GL_KEEP, GL_KEEP);
        qglStencilFunc(GL_EQUAL, 128, 0xFF);
        r_shadowstage = SHADOWSTAGE_LIGHT;
@@ -824,10 +846,13 @@ void R_Shadow_Stage_LightWithShadows(void)
        qglPolygonOffset(0, 0);
        //qglDisable(GL_POLYGON_OFFSET_FILL);
        GL_Color(1, 1, 1, 1);
-       qglColorMask(1, 1, 1, 1);
+       GL_ColorMask(1, 1, 1, 1);
        qglDepthFunc(GL_EQUAL);
        qglCullFace(GL_FRONT); // quake is backwards, this culls back faces
        qglEnable(GL_STENCIL_TEST);
+       if (gl_support_stenciltwoside)
+               qglDisable(GL_STENCIL_TEST_TWO_SIDE_EXT);
+       qglStencilMask(~0);
        qglStencilOp(GL_KEEP, GL_KEEP, GL_KEEP);
        // only draw light where this geometry was already rendered AND the
        // stencil is 128 (values other than this mean shadow)
@@ -847,12 +872,15 @@ void R_Shadow_Stage_End(void)
        qglPolygonOffset(0, 0);
        //qglDisable(GL_POLYGON_OFFSET_FILL);
        GL_Color(1, 1, 1, 1);
-       qglColorMask(1, 1, 1, 1);
+       GL_ColorMask(1, 1, 1, 1);
        GL_Scissor(r_view_x, r_view_y, r_view_width, r_view_height);
        qglDepthFunc(GL_LEQUAL);
        qglCullFace(GL_FRONT); // quake is backwards, this culls back faces
        qglDisable(GL_STENCIL_TEST);
        qglStencilOp(GL_KEEP, GL_KEEP, GL_KEEP);
+       if (gl_support_stenciltwoside)
+               qglDisable(GL_STENCIL_TEST_TWO_SIDE_EXT);
+       qglStencilMask(~0);
        qglStencilFunc(GL_ALWAYS, 128, 0xFF);
        r_shadowstage = SHADOWSTAGE_NONE;
 }
@@ -1178,7 +1206,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                        m.pointer_texcoord[1] = varray_texcoord3f[1];
                        m.pointer_texcoord[2] = varray_texcoord3f[2];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        GL_BlendFunc(GL_ONE, GL_ZERO);
                        R_Shadow_GenTexCoords_Diffuse_NormalCubeMap(varray_texcoord3f[1], numverts, vertex3f, svector3f, tvector3f, normal3f, relativelightorigin);
                        R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[2], numverts, vertex3f, matrix_modeltoattenuationxyz);
@@ -1196,7 +1224,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                                R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[1], numverts, vertex3f, matrix_modeltolight);
                        }
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        VectorScale(lightcolor, r_shadow_lightintensityscale.value, color2);
                        for (renders = 0;renders < 64 && (color2[0] > 0 || color2[1] > 0 || color2[2] > 0);renders++, color2[0]--, color2[1]--, color2[2]--)
@@ -1217,7 +1245,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                        m.tex3d[0] = R_GetTexture(r_shadow_attenuation3dtexture);
                        m.pointer_texcoord[0] = varray_texcoord3f[0];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        GL_BlendFunc(GL_ONE, GL_ZERO);
                        R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[0], numverts, vertex3f, matrix_modeltoattenuationxyz);
                        R_Mesh_Draw(numverts, numtriangles, elements);
@@ -1248,7 +1276,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                                R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[1], numverts, vertex3f, matrix_modeltolight);
                        }
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        VectorScale(lightcolor, r_shadow_lightintensityscale.value, color2);
                        for (renders = 0;renders < 64 && (color2[0] > 0 || color2[1] > 0 || color2[2] > 0);renders++, color2[0]--, color2[1]--, color2[2]--)
@@ -1273,7 +1301,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                        m.pointer_texcoord[0] = texcoord2f;
                        m.pointer_texcoord[1] = varray_texcoord3f[1];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        GL_BlendFunc(GL_ONE, GL_ZERO);
                        R_Shadow_GenTexCoords_Diffuse_NormalCubeMap(varray_texcoord3f[1], numverts, vertex3f, svector3f, tvector3f, normal3f, relativelightorigin);
                        R_Mesh_Draw(numverts, numtriangles, elements);
@@ -1286,7 +1314,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                        m.pointer_texcoord[0] = texcoord2f;
                        m.pointer_texcoord[1] = varray_texcoord3f[1];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[1], numverts, vertex3f, matrix_modeltoattenuationxyz);
                        VectorScale(lightcolor, r_shadow_lightintensityscale.value, color2);
@@ -1316,7 +1344,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                        m.pointer_texcoord[2] = varray_texcoord2f[2];
                        m.pointer_texcoord[3] = varray_texcoord2f[3];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        GL_BlendFunc(GL_ONE, GL_ZERO);
                        R_Shadow_GenTexCoords_Diffuse_NormalCubeMap(varray_texcoord3f[1], numverts, vertex3f, svector3f, tvector3f, normal3f, relativelightorigin);
                        R_Shadow_Transform_Vertex3f_TexCoord2f(varray_texcoord2f[2], numverts, vertex3f, matrix_modeltoattenuationxyz);
@@ -1335,7 +1363,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                                R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[1], numverts, vertex3f, matrix_modeltolight);
                        }
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        VectorScale(lightcolor, r_shadow_lightintensityscale.value, color2);
                        for (renders = 0;renders < 64 && (color2[0] > 0 || color2[1] > 0 || color2[2] > 0);renders++, color2[0]--, color2[1]--, color2[2]--)
@@ -1358,7 +1386,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                        m.pointer_texcoord[0] = varray_texcoord2f[0];
                        m.pointer_texcoord[1] = varray_texcoord2f[1];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        GL_BlendFunc(GL_ONE, GL_ZERO);
                        R_Shadow_Transform_Vertex3f_TexCoord2f(varray_texcoord2f[0], numverts, vertex3f, matrix_modeltoattenuationxyz);
                        R_Shadow_Transform_Vertex3f_TexCoord2f(varray_texcoord2f[1], numverts, vertex3f, matrix_modeltoattenuationz);
@@ -1390,7 +1418,7 @@ void R_Shadow_DiffuseLighting(int numverts, int numtriangles, const int *element
                                R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[1], numverts, vertex3f, matrix_modeltolight);
                        }
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        VectorScale(lightcolor, r_shadow_lightintensityscale.value, color2);
                        for (renders = 0;renders < 64 && (color2[0] > 0 || color2[1] > 0 || color2[2] > 0);renders++, color2[0]--, color2[1]--, color2[2]--)
@@ -1467,7 +1495,7 @@ void R_Shadow_SpecularLighting(int numverts, int numtriangles, const int *elemen
                        m.pointer_texcoord[0] = texcoord2f;
                        m.pointer_texcoord[1] = varray_texcoord3f[1];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        // this squares the result
                        GL_BlendFunc(GL_SRC_ALPHA, GL_ZERO);
                        R_Shadow_GenTexCoords_Specular_NormalCubeMap(varray_texcoord3f[1], numverts, vertex3f, svector3f, tvector3f, normal3f, relativelightorigin, relativeeyeorigin);
@@ -1510,7 +1538,7 @@ void R_Shadow_SpecularLighting(int numverts, int numtriangles, const int *elemen
                        }
                        m.pointer_texcoord[0] = texcoord2f;
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        VectorScale(lightcolor, colorscale, color2);
                        for (renders = 0;renders < 64 && (color2[0] > 0 || color2[1] > 0 || color2[2] > 0);renders++, color2[0]--, color2[1]--, color2[2]--)
@@ -1534,7 +1562,7 @@ void R_Shadow_SpecularLighting(int numverts, int numtriangles, const int *elemen
                        m.pointer_texcoord[0] = texcoord2f;
                        m.pointer_texcoord[1] = varray_texcoord3f[1];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        // this squares the result
                        GL_BlendFunc(GL_SRC_ALPHA, GL_ZERO);
                        R_Shadow_GenTexCoords_Specular_NormalCubeMap(varray_texcoord3f[1], numverts, vertex3f, svector3f, tvector3f, normal3f, relativelightorigin, relativeeyeorigin);
@@ -1563,7 +1591,7 @@ void R_Shadow_SpecularLighting(int numverts, int numtriangles, const int *elemen
                        m.pointer_texcoord[0] = texcoord2f;
                        m.pointer_texcoord[1] = varray_texcoord3f[1];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        R_Shadow_Transform_Vertex3f_TexCoord3f(varray_texcoord3f[1], numverts, vertex3f, matrix_modeltoattenuationxyz);
                        VectorScale(lightcolor, colorscale, color2);
@@ -1588,7 +1616,7 @@ void R_Shadow_SpecularLighting(int numverts, int numtriangles, const int *elemen
                        m.pointer_texcoord[0] = texcoord2f;
                        m.pointer_texcoord[1] = varray_texcoord3f[1];
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(0,0,0,1);
+                       GL_ColorMask(0,0,0,1);
                        // this squares the result
                        GL_BlendFunc(GL_SRC_ALPHA, GL_ZERO);
                        R_Shadow_GenTexCoords_Specular_NormalCubeMap(varray_texcoord3f[1], numverts, vertex3f, svector3f, tvector3f, normal3f, relativelightorigin, relativeeyeorigin);
@@ -1634,7 +1662,7 @@ void R_Shadow_SpecularLighting(int numverts, int numtriangles, const int *elemen
                        }
                        m.pointer_texcoord[0] = texcoord2f;
                        R_Mesh_State_Texture(&m);
-                       qglColorMask(1,1,1,0);
+                       GL_ColorMask(1,1,1,0);
                        GL_BlendFunc(GL_DST_ALPHA, GL_ONE);
                        VectorScale(lightcolor, colorscale, color2);
                        for (renders = 0;renders < 64 && (color2[0] > 0 || color2[1] > 0 || color2[2] > 0);renders++, color2[0]--, color2[1]--, color2[2]--)
@@ -1698,7 +1726,6 @@ void R_RTLight_UpdateFromDLight(rtlight_t *rtlight, const dlight_t *light, int i
 // (undone by R_FreeCompiledRTLight, which R_UpdateLight calls)
 void R_RTLight_Compile(rtlight_t *rtlight)
 {
-#if 0
        int i, j, k, l, maxverts = 256, tris;
        float *vertex3f = NULL, mins[3], maxs[3];
        shadowmesh_t *mesh, *castmesh = NULL;
@@ -1908,7 +1935,19 @@ void R_RTLight_Compile(rtlight_t *rtlight)
                        for (mesh = castmesh;mesh;mesh = mesh->next)
                        {
                                Mod_BuildTriangleNeighbors(mesh->neighbor3i, mesh->element3i, mesh->numtriangles);
-                               if ((tris = R_Shadow_ConstructShadowVolume(castmesh->numverts, 0, castmesh->numtriangles, castmesh->element3i, castmesh->neighbor3i, castmesh->vertex3f, NULL, shadowelements, vertex3f, rtlight->shadoworigin, r_shadow_projectdistance.value)))
+                               R_Shadow_PrepareShadowMark(mesh->numtriangles);
+                               for (i = 0;i < mesh->numtriangles;i++)
+                               {
+                                       const float *v[3];
+                                       v[0] = mesh->vertex3f + mesh->element3i[i*3+0] * 3;
+                                       v[1] = mesh->vertex3f + mesh->element3i[i*3+1] * 3;
+                                       v[2] = mesh->vertex3f + mesh->element3i[i*3+2] * 3;
+                                       if (PointInfrontOfTriangle(rtlight->shadoworigin, v[0], v[1], v[2]) && rtlight->cullmaxs[0] > min(v[0][0], min(v[1][0], v[2][0])) && rtlight->cullmins[0] < max(v[0][0], max(v[1][0], v[2][0])) && rtlight->cullmaxs[1] > min(v[0][1], min(v[1][1], v[2][1])) && rtlight->cullmins[1] < max(v[0][1], max(v[1][1], v[2][1])) && rtlight->cullmaxs[2] > min(v[0][2], min(v[1][2], v[2][2])) && rtlight->cullmins[2] < max(v[0][2], max(v[1][2], v[2][2])))
+                                               shadowmarklist[numshadowmark++] = i;
+                               }
+                               if (maxshadowelements < numshadowmark * 24)
+                                       R_Shadow_ResizeShadowElements((numshadowmark + 256) * 24);
+                               if ((tris = R_Shadow_ConstructShadowVolume(mesh->numverts, mesh->numtriangles, mesh->element3i, mesh->neighbor3i, mesh->vertex3f, NULL, shadowelements, vertex3f, rtlight->shadoworigin, r_shadow_projectdistance.value, numshadowmark, shadowmarklist)))
                                        Mod_ShadowMesh_AddMesh(r_shadow_mempool, rtlight->static_meshchain_shadow, NULL, NULL, NULL, vertex3f, NULL, NULL, NULL, NULL, tris, shadowelements);
                        }
                        Mem_Free(vertex3f);
@@ -1930,7 +1969,6 @@ void R_RTLight_Compile(rtlight_t *rtlight)
                for (mesh = rtlight->static_meshchain_light;mesh;mesh = mesh->next)
                        l += mesh->numtriangles;
        Con_DPrintf("static light built: %f %f %f : %f %f %f box, %i shadow volume triangles, %i light triangles\n", rtlight->cullmins[0], rtlight->cullmins[1], rtlight->cullmins[2], rtlight->cullmaxs[0], rtlight->cullmaxs[1], rtlight->cullmaxs[2], k, l);
-#endif
 }
 
 void R_RTLight_Uncompile(rtlight_t *rtlight)
@@ -2028,7 +2066,7 @@ void R_DrawRTLight(rtlight_t *rtlight, int visiblevolumes)
                                qglDisable(GL_DEPTH_TEST);
                                qglDisable(GL_STENCIL_TEST);
                                //qglDisable(GL_CULL_FACE);
-                               qglColorMask(1,1,1,1);
+                               GL_ColorMask(1,1,1,1);
                                memset(&m, 0, sizeof(m));
                                R_Mesh_State_Texture(&m);
                                GL_Color(0,0.1,0,1);
@@ -2044,7 +2082,7 @@ void R_DrawRTLight(rtlight_t *rtlight, int visiblevolumes)
                                if (stencilenabled)
                                {
                                        qglEnable(GL_STENCIL_TEST);
-                                       qglColorMask(0,0,0,0);
+                                       GL_ColorMask(0,0,0,0);
                                }
                        }
                        R_Shadow_RenderShadowMeshVolume(rtlight->static_meshchain_shadow);
@@ -2283,7 +2321,7 @@ rtexture_t *R_Shadow_LoadCubemap(const char *basename)
                for (j = 0;j < 3;j++)
                        for (i = 0;i < 6;i++)
                                Con_Printf("%s\"%s%s.tga\"", j + i > 0 ? ", " : "", basename, suffix[j][i].suffix);
-               Con_Printf(" and was unable to find any of them.\n");
+               Con_Print(" and was unable to find any of them.\n");
        }
        return cubemaptexture;
 }
@@ -2314,7 +2352,7 @@ void R_Shadow_NewWorldLight(vec3_t origin, vec3_t angles, vec3_t color, vec_t ra
 
        if (radius < 15 || DotProduct(color, color) < 0.03)
        {
-               Con_Printf("R_Shadow_NewWorldLight: refusing to create a light too small/dim\n");
+               Con_Print("R_Shadow_NewWorldLight: refusing to create a light too small/dim\n");
                return;
        }
 
@@ -2439,7 +2477,7 @@ void R_Shadow_LoadWorldLights(void)
        float origin[3], radius, color[3], angles[3], corona;
        if (cl.worldmodel == NULL)
        {
-               Con_Printf("No map loaded.\n");
+               Con_Print("No map loaded.\n");
                return;
        }
        FS_StripExtension (cl.worldmodel->name, name, sizeof (name));
@@ -2451,6 +2489,22 @@ void R_Shadow_LoadWorldLights(void)
                n = 0;
                while (*s)
                {
+                       t = s;
+                       /*
+                       shadow = true;
+                       for (;COM_Parse(t, true) && strcmp(
+                       if (COM_Parse(t, true))
+                       {
+                               if (com_token[0] == '!')
+                               {
+                                       shadow = false;
+                                       origin[0] = atof(com_token+1);
+                               }
+                               else
+                                       origin[0] = atof(com_token);
+                               if (Com_Parse(t
+                       }
+                       */
                        t = s;
                        while (*s && *s != '\n')
                                s++;
@@ -2500,7 +2554,7 @@ void R_Shadow_SaveWorldLights(void)
                return;
        if (cl.worldmodel == NULL)
        {
-               Con_Printf("No map loaded.\n");
+               Con_Print("No map loaded.\n");
                return;
        }
        FS_StripExtension (cl.worldmodel->name, name, sizeof (name));
@@ -2509,7 +2563,7 @@ void R_Shadow_SaveWorldLights(void)
        buf = NULL;
        for (light = r_shadow_worldlightchain;light;light = light->next)
        {
-               sprintf(line, "%s%f %f %f %f %f %f %f %d %s %f %f %f %f\n", light->shadow ? "" : "!", light->origin[0], light->origin[1], light->origin[2], light->radius / r_editlights_rtlightssizescale.value, light->color[0] / r_editlights_rtlightscolorscale.value, light->color[1] / r_editlights_rtlightscolorscale.value, light->color[2] / r_editlights_rtlightscolorscale.value, light->style, light->cubemapname ? light->cubemapname : "\"\"", light->corona, light->angles[0], light->angles[1], light->angles[2]);
+               sprintf(line, "%s%f %f %f %f %f %f %f %d %s %f %f %f %f\n", light->shadow ? "" : "!", light->origin[0], light->origin[1], light->origin[2], light->radius / r_editlights_rtlightssizescale.value, light->color[0] / r_editlights_rtlightscolorscale.value, light->color[1] / r_editlights_rtlightscolorscale.value, light->color[2] / r_editlights_rtlightscolorscale.value, light->style, light->cubemapname[0] ? light->cubemapname : "\"\"", light->corona, light->angles[0], light->angles[1], light->angles[2]);
                if (bufchars + (int) strlen(line) > bufmaxchars)
                {
                        bufmaxchars = bufchars + strlen(line) + 2048;
@@ -2541,7 +2595,7 @@ void R_Shadow_LoadLightsFile(void)
        float origin[3], radius, color[3], subtract, spotdir[3], spotcone, falloff, distbias;
        if (cl.worldmodel == NULL)
        {
-               Con_Printf("No map loaded.\n");
+               Con_Print("No map loaded.\n");
                return;
        }
        FS_StripExtension (cl.worldmodel->name, name, sizeof (name));
@@ -2588,7 +2642,7 @@ void R_Shadow_LoadWorldLightsFromMap_LightArghliteTyrlite(void)
 
        if (cl.worldmodel == NULL)
        {
-               Con_Printf("No map loaded.\n");
+               Con_Print("No map loaded.\n");
                return;
        }
        data = cl.worldmodel->brush.entities;
@@ -2816,12 +2870,12 @@ void R_Shadow_EditLights_Spawn_f(void)
        vec3_t color;
        if (!r_editlights.integer)
        {
-               Con_Printf("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
+               Con_Print("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
                return;
        }
        if (Cmd_Argc() != 1)
        {
-               Con_Printf("r_editlights_spawn does not take parameters\n");
+               Con_Print("r_editlights_spawn does not take parameters\n");
                return;
        }
        color[0] = color[1] = color[2] = 1;
@@ -2836,12 +2890,12 @@ void R_Shadow_EditLights_Edit_f(void)
        char cubemapname[1024];
        if (!r_editlights.integer)
        {
-               Con_Printf("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
+               Con_Print("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
                return;
        }
        if (!r_shadow_selectedlight)
        {
-               Con_Printf("No selected light.\n");
+               Con_Print("No selected light.\n");
                return;
        }
        VectorCopy(r_shadow_selectedlight->origin, origin);
@@ -2931,7 +2985,7 @@ void R_Shadow_EditLights_Edit_f(void)
                }
                origin[2] += atof(Cmd_Argv(2));
        }
-       if (!strcmp(Cmd_Argv(1), "angles"))
+       else if (!strcmp(Cmd_Argv(1), "angles"))
        {
                if (Cmd_Argc() != 5)
                {
@@ -2989,7 +3043,7 @@ void R_Shadow_EditLights_Edit_f(void)
                }
                radius = atof(Cmd_Argv(2));
        }
-       else if (Cmd_Argc() == 3 && !strcmp(Cmd_Argv(1), "style"))
+       else if (!strcmp(Cmd_Argv(1), "style"))
        {
                if (Cmd_Argc() != 3)
                {
@@ -2998,7 +3052,7 @@ void R_Shadow_EditLights_Edit_f(void)
                }
                style = atoi(Cmd_Argv(2));
        }
-       else if (Cmd_Argc() == 3 && !strcmp(Cmd_Argv(1), "cubemap"))
+       else if (!strcmp(Cmd_Argv(1), "cubemap"))
        {
                if (Cmd_Argc() > 3)
                {
@@ -3010,7 +3064,7 @@ void R_Shadow_EditLights_Edit_f(void)
                else
                        cubemapname[0] = 0;
        }
-       else if (Cmd_Argc() == 3 && !strcmp(Cmd_Argv(1), "shadows"))
+       else if (!strcmp(Cmd_Argv(1), "shadows"))
        {
                if (Cmd_Argc() != 3)
                {
@@ -3030,8 +3084,8 @@ void R_Shadow_EditLights_Edit_f(void)
        }
        else
        {
-               Con_Printf("usage: r_editlights_edit [property] [value]\n");
-               Con_Printf("Selected light's properties:\n");
+               Con_Print("usage: r_editlights_edit [property] [value]\n");
+               Con_Print("Selected light's properties:\n");
                Con_Printf("Origin : %f %f %f\n", r_shadow_selectedlight->origin[0], r_shadow_selectedlight->origin[1], r_shadow_selectedlight->origin[2]);
                Con_Printf("Angles : %f %f %f\n", r_shadow_selectedlight->angles[0], r_shadow_selectedlight->angles[1], r_shadow_selectedlight->angles[2]);
                Con_Printf("Color  : %f %f %f\n", r_shadow_selectedlight->color[0], r_shadow_selectedlight->color[1], r_shadow_selectedlight->color[2]);
@@ -3071,12 +3125,12 @@ void R_Shadow_EditLights_ToggleShadow_f(void)
 {
        if (!r_editlights.integer)
        {
-               Con_Printf("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
+               Con_Print("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
                return;
        }
        if (!r_shadow_selectedlight)
        {
-               Con_Printf("No selected light.\n");
+               Con_Print("No selected light.\n");
                return;
        }
        R_Shadow_NewWorldLight(r_shadow_selectedlight->origin, r_shadow_selectedlight->angles, r_shadow_selectedlight->color, r_shadow_selectedlight->radius, r_shadow_selectedlight->corona, r_shadow_selectedlight->style, !r_shadow_selectedlight->shadow, r_shadow_selectedlight->cubemapname);
@@ -3088,12 +3142,12 @@ void R_Shadow_EditLights_ToggleCorona_f(void)
 {
        if (!r_editlights.integer)
        {
-               Con_Printf("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
+               Con_Print("Cannot spawn light when not in editing mode.  Set r_editlights to 1.\n");
                return;
        }
        if (!r_shadow_selectedlight)
        {
-               Con_Printf("No selected light.\n");
+               Con_Print("No selected light.\n");
                return;
        }
        R_Shadow_NewWorldLight(r_shadow_selectedlight->origin, r_shadow_selectedlight->angles, r_shadow_selectedlight->color, r_shadow_selectedlight->radius, !r_shadow_selectedlight->corona, r_shadow_selectedlight->style, r_shadow_selectedlight->shadow, r_shadow_selectedlight->cubemapname);
@@ -3105,12 +3159,12 @@ void R_Shadow_EditLights_Remove_f(void)
 {
        if (!r_editlights.integer)
        {
-               Con_Printf("Cannot remove light when not in editing mode.  Set r_editlights to 1.\n");
+               Con_Print("Cannot remove light when not in editing mode.  Set r_editlights to 1.\n");
                return;
        }
        if (!r_shadow_selectedlight)
        {
-               Con_Printf("No selected light.\n");
+               Con_Print("No selected light.\n");
                return;
        }
        R_Shadow_FreeWorldLight(r_shadow_selectedlight);
@@ -3119,7 +3173,7 @@ void R_Shadow_EditLights_Remove_f(void)
 
 void R_Shadow_EditLights_Help_f(void)
 {
-       Con_Printf(
+       Con_Print(
 "Documentation on r_editlights system:\n"
 "Settings:\n"
 "r_editlights : enable/disable editing mode\n"