]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - sv_main.c
Lots of str[n]cat, str[n]cpy, and [v]sprintf have been replaced by strlcat, strlcpy...
[xonotic/darkplaces.git] / sv_main.c
index 310a726fab1cf35d5923463d2f704f7cbea71a73..ac6368249cca465938f4f9b4cb49f219079259cc 100644 (file)
--- a/sv_main.c
+++ b/sv_main.c
@@ -20,10 +20,8 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 // sv_main.c -- server main program
 
 #include "quakedef.h"
-#include "portals.h"
 
 static cvar_t sv_cullentities_pvs = {0, "sv_cullentities_pvs", "0"}; // fast but loose
-static cvar_t sv_cullentities_portal = {0, "sv_cullentities_portal", "0"}; // extremely accurate visibility checking, but too slow
 static cvar_t sv_cullentities_trace = {0, "sv_cullentities_trace", "1"}; // tends to get false negatives, uses a timeout to keep entities visible a short time after becoming hidden
 static cvar_t sv_cullentities_stats = {0, "sv_cullentities_stats", "0"};
 static cvar_t sv_entpatch = {0, "sv_entpatch", "1"};
@@ -34,7 +32,6 @@ server_static_t svs;
 static char localmodels[MAX_MODELS][5];                        // inline model names for precache
 
 mempool_t *sv_edicts_mempool = NULL;
-mempool_t *sv_clients_mempool = NULL;
 
 //============================================================================
 
@@ -62,7 +59,6 @@ void SV_Init (void)
        Cvar_RegisterVariable (&sv_nostep);
        Cvar_RegisterVariable (&sv_deltacompress);
        Cvar_RegisterVariable (&sv_cullentities_pvs);
-       Cvar_RegisterVariable (&sv_cullentities_portal);
        Cvar_RegisterVariable (&sv_cullentities_trace);
        Cvar_RegisterVariable (&sv_cullentities_stats);
        Cvar_RegisterVariable (&sv_entpatch);
@@ -74,7 +70,6 @@ void SV_Init (void)
                sprintf (localmodels[i], "*%i", i);
 
        sv_edicts_mempool = Mem_AllocPool("server edicts");
-       sv_clients_mempool = Mem_AllocPool("server clients");
 }
 
 /*
@@ -263,8 +258,8 @@ void SV_SendServerinfo (client_t *client)
        MSG_WriteString (&client->message,message);
 
        MSG_WriteByte (&client->message, svc_serverinfo);
-       MSG_WriteLong (&client->message, DPPROTOCOL_VERSION4);
-       MSG_WriteByte (&client->message, MAX_SCOREBOARD);
+       MSG_WriteLong (&client->message, PROTOCOL_DARKPLACES4);
+       MSG_WriteByte (&client->message, svs.maxclients);
 
        if (!coop.integer && deathmatch.integer)
                MSG_WriteByte (&client->message, GAME_DEATHMATCH);
@@ -311,12 +306,13 @@ void SV_ConnectClient (int clientnum, netconn_t *netconnection)
        int                             i;
        float                   spawn_parms[NUM_SPAWN_PARMS];
 
-       client = svs.connectedclients[clientnum];
+       client = svs.clients + clientnum;
 
 // set up the client_t
        if (sv.loadgame)
                memcpy (spawn_parms, client->spawn_parms, sizeof(spawn_parms));
        memset (client, 0, sizeof(*client));
+       client->active = true;
        client->netconnection = netconnection;
 
        Con_DPrintf("Client %s connected\n", client->netconnection->address);
@@ -387,7 +383,7 @@ SV_WriteEntitiesToClient
 void SV_WriteEntitiesToClient (client_t *client, edict_t *clent, sizebuf_t *msg)
 {
        int e, clentnum, bits, alpha, glowcolor, glowsize, scale, effects, lightsize;
-       int culled_pvs, culled_portal, culled_trace, visibleentities, totalentities;
+       int culled_pvs, culled_trace, visibleentities, totalentities;
        qbyte *pvs;
        vec3_t origin, angles, entmins, entmaxs, testorigin, testeye;
        float nextfullupdate, alphaf;
@@ -405,7 +401,6 @@ void SV_WriteEntitiesToClient (client_t *client, edict_t *clent, sizebuf_t *msg)
                fatbytes = sv.worldmodel->brush.FatPVS(sv.worldmodel, testeye, 8, sv_writeentitiestoclient_pvs, sizeof(sv_writeentitiestoclient_pvs));
 
        culled_pvs = 0;
-       culled_portal = 0;
        culled_trace = 0;
        visibleentities = 0;
        totalentities = 0;
@@ -509,22 +504,16 @@ void SV_WriteEntitiesToClient (client_t *client, edict_t *clent, sizebuf_t *msg)
                                continue;
                        }
 
-                       // or not visible through the portals
-                       if (sv_cullentities_portal.integer && !Portal_CheckBox(sv.worldmodel, testeye, entmins, entmaxs))
-                       {
-                               culled_portal++;
-                               continue;
-                       }
-
                        // don't try to cull embedded brush models with this, they're sometimes huge (spanning several rooms)
-                       if (sv_cullentities_trace.integer && (model == NULL || model->type != mod_brush || model->name[0] != '*'))
+                       if (sv_cullentities_trace.integer && (model == NULL || model->brush.TraceBox == NULL || model->name[0] != '*'))
                        {
                                // LordHavoc: test random offsets, to maximize chance of detection
                                testorigin[0] = lhrandom(entmins[0], entmaxs[0]);
                                testorigin[1] = lhrandom(entmins[1], entmaxs[1]);
                                testorigin[2] = lhrandom(entmins[2], entmaxs[2]);
 
-                               if (SV_Move(testeye, vec3_origin, vec3_origin, testorigin, MOVE_WORLDONLY, NULL).fraction == 1)
+                               sv.worldmodel->brush.TraceBox(sv.worldmodel, &trace, testeye, testeye, testorigin, testorigin, SUPERCONTENTS_SOLID);
+                               if (trace.fraction == 1)
                                        client->visibletime[e] = realtime + 1;
                                else
                                {
@@ -533,7 +522,8 @@ void SV_WriteEntitiesToClient (client_t *client, edict_t *clent, sizebuf_t *msg)
                                        testorigin[1] = bound(entmins[1], testeye[1], entmaxs[1]);
                                        testorigin[2] = bound(entmins[2], testeye[2], entmaxs[2]);
 
-                                       if (SV_Move(testeye, vec3_origin, vec3_origin, testorigin, MOVE_WORLDONLY, NULL).fraction == 1)
+                                       sv.worldmodel->brush.TraceBox(sv.worldmodel, &trace, testeye, testeye, testorigin, testorigin, SUPERCONTENTS_SOLID);
+                                       if (trace.fraction == 1)
                                                client->visibletime[e] = realtime + 1;
                                        else if (realtime > client->visibletime[e])
                                        {
@@ -690,16 +680,16 @@ void SV_WriteEntitiesToClient (client_t *client, edict_t *clent, sizebuf_t *msg)
                        MSG_WriteShort (msg,e);
                else
                        MSG_WriteByte (msg,e);
-               if (bits & U_MODEL)             MSG_WriteByte (msg,     ent->v->modelindex);
-               if (bits & U_FRAME)             MSG_WriteByte (msg, ent->v->frame);
-               if (bits & U_COLORMAP)  MSG_WriteByte (msg, ent->v->colormap);
-               if (bits & U_SKIN)              MSG_WriteByte (msg, ent->v->skin);
-               if (bits & U_EFFECTS)   MSG_WriteByte (msg, ent->v->effects);
-               if (bits & U_ORIGIN1)   MSG_WriteDPCoord (msg, origin[0]);
+               if (bits & U_MODEL)             MSG_WriteByte(msg,      ent->v->modelindex);
+               if (bits & U_FRAME)             MSG_WriteByte(msg, ent->v->frame);
+               if (bits & U_COLORMAP)  MSG_WriteByte(msg, ent->v->colormap);
+               if (bits & U_SKIN)              MSG_WriteByte(msg, ent->v->skin);
+               if (bits & U_EFFECTS)   MSG_WriteByte(msg, ent->v->effects);
+               if (bits & U_ORIGIN1)   MSG_WriteDPCoord(msg, origin[0]);
                if (bits & U_ANGLE1)    MSG_WriteAngle(msg, angles[0]);
-               if (bits & U_ORIGIN2)   MSG_WriteDPCoord (msg, origin[1]);
+               if (bits & U_ORIGIN2)   MSG_WriteDPCoord(msg, origin[1]);
                if (bits & U_ANGLE2)    MSG_WriteAngle(msg, angles[1]);
-               if (bits & U_ORIGIN3)   MSG_WriteDPCoord (msg, origin[2]);
+               if (bits & U_ORIGIN3)   MSG_WriteDPCoord(msg, origin[2]);
                if (bits & U_ANGLE3)    MSG_WriteAngle(msg, angles[2]);
 
                // LordHavoc: new stuff
@@ -713,7 +703,7 @@ void SV_WriteEntitiesToClient (client_t *client, edict_t *clent, sizebuf_t *msg)
        }
 
        if (sv_cullentities_stats.integer)
-               Con_Printf("client \"%s\" entities: %d total, %d visible, %d culled by: %d pvs %d portal %d trace\n", client->name, totalentities, visibleentities, culled_pvs + culled_portal + culled_trace, culled_pvs, culled_portal, culled_trace);
+               Con_Printf("client \"%s\" entities: %d total, %d visible, %d culled by: %d pvs %d trace\n", client->name, totalentities, visibleentities, culled_pvs + culled_trace, culled_pvs, culled_trace);
 }
 #else
 static int numsendentities;
@@ -723,6 +713,7 @@ static entity_state_t *sendentitiesindex[MAX_EDICTS];
 void SV_PrepareEntitiesForSending(void)
 {
        int e, i;
+       float f;
        edict_t *ent;
        entity_state_t cs;
        // send all entities that touch the pvs
@@ -760,25 +751,33 @@ void SV_PrepareEntitiesForSending(void)
                if (i >= 1 && i < MAX_MODELS && *PR_GetString(ent->v->model))
                        cs.modelindex = i;
 
-
                cs.alpha = 255;
-               i = (int)(GETEDICTFIELDVALUE(ent, eval_alpha)->_float * 255.0f);
-               if (i)
+               f = (GETEDICTFIELDVALUE(ent, eval_alpha)->_float * 255.0f);
+               if (f)
+               {
+                       i = (int)f;
                        cs.alpha = (qbyte)bound(0, i, 255);
+               }
                // halflife
-               i = (int)(GETEDICTFIELDVALUE(ent, eval_renderamt)->_float);
-               if (i)
+               f = (GETEDICTFIELDVALUE(ent, eval_renderamt)->_float);
+               if (f)
+               {
+                       i = (int)f;
                        cs.alpha = (qbyte)bound(0, i, 255);
+               }
 
                cs.scale = 16;
-               i = (int)(GETEDICTFIELDVALUE(ent, eval_scale)->_float * 16.0f);
-               if (i)
+               f = (GETEDICTFIELDVALUE(ent, eval_scale)->_float * 16.0f);
+               if (f)
+               {
+                       i = (int)f;
                        cs.scale = (qbyte)bound(0, i, 255);
+               }
 
                cs.glowcolor = 254;
-               i = (int)(GETEDICTFIELDVALUE(ent, eval_glow_color)->_float);
-               if (i)
-                       cs.glowcolor = i;
+               f = (GETEDICTFIELDVALUE(ent, eval_glow_color)->_float);
+               if (f)
+                       cs.glowcolor = (int)f;
 
                if (GETEDICTFIELDVALUE(ent, eval_fullbright)->_float)
                        cs.effects |= EF_FULLBRIGHT;
@@ -822,7 +821,7 @@ void SV_PrepareEntitiesForSending(void)
                // we can omit invisible entities with no effects that are not clients
                // LordHavoc: this could kill tags attached to an invisible entity, I
                // just hope we never have to support that case
-               if (cs.number > MAX_SCOREBOARD && ((cs.effects & EF_NODRAW) || (!cs.modelindex && !cs.specialvisibilityradius)))
+               if (cs.number > svs.maxclients && ((cs.effects & EF_NODRAW) || (!cs.modelindex && !cs.specialvisibilityradius)))
                        continue;
                sendentitiesindex[e] = sendentities + numsendentities;
                sendentities[numsendentities++] = cs;
@@ -833,7 +832,6 @@ static int sententitiesmark = 0;
 static int sententities[MAX_EDICTS];
 static int sententitiesconsideration[MAX_EDICTS];
 static int sv_writeentitiestoclient_culled_pvs;
-static int sv_writeentitiestoclient_culled_portal;
 static int sv_writeentitiestoclient_culled_trace;
 static int sv_writeentitiestoclient_visibleentities;
 static int sv_writeentitiestoclient_totalentities;
@@ -924,12 +922,6 @@ void SV_MarkWriteEntityStateToClient(entity_state_t *s)
                                sv_writeentitiestoclient_culled_pvs++;
                                return;
                        }
-                       // or not visible through the portals
-                       if (sv_cullentities_portal.integer && !Portal_CheckBox(sv.worldmodel, sv_writeentitiestoclient_testeye, lightmins, lightmaxs))
-                       {
-                               sv_writeentitiestoclient_culled_portal++;
-                               return;
-                       }
                        // or not seen by random tracelines
                        if (sv_cullentities_trace.integer)
                        {
@@ -937,7 +929,7 @@ void SV_MarkWriteEntityStateToClient(entity_state_t *s)
                                testorigin[0] = (entmins[0] + entmaxs[0]) * 0.5f;
                                testorigin[1] = (entmins[1] + entmaxs[1]) * 0.5f;
                                testorigin[2] = (entmins[2] + entmaxs[2]) * 0.5f;
-                               trace = SV_Move(sv_writeentitiestoclient_testeye, vec3_origin, vec3_origin, testorigin, MOVE_WORLDONLY, NULL);
+                               sv.worldmodel->brush.TraceBox(sv.worldmodel, &trace, sv_writeentitiestoclient_testeye, sv_writeentitiestoclient_testeye, testorigin, testorigin, SUPERCONTENTS_SOLID);
                                if (trace.fraction == 1 || BoxesOverlap(trace.endpos, trace.endpos, entmins, entmaxs))
                                        sv_writeentitiestoclient_client->visibletime[s->number] = realtime + 1;
                                else
@@ -946,7 +938,7 @@ void SV_MarkWriteEntityStateToClient(entity_state_t *s)
                                        testorigin[0] = lhrandom(entmins[0], entmaxs[0]);
                                        testorigin[1] = lhrandom(entmins[1], entmaxs[1]);
                                        testorigin[2] = lhrandom(entmins[2], entmaxs[2]);
-                                       trace = SV_Move(sv_writeentitiestoclient_testeye, vec3_origin, vec3_origin, testorigin, MOVE_WORLDONLY, NULL);
+                                       sv.worldmodel->brush.TraceBox(sv.worldmodel, &trace, sv_writeentitiestoclient_testeye, sv_writeentitiestoclient_testeye, testorigin, testorigin, SUPERCONTENTS_SOLID);
                                        if (trace.fraction == 1 || BoxesOverlap(trace.endpos, trace.endpos, entmins, entmaxs))
                                                sv_writeentitiestoclient_client->visibletime[s->number] = realtime + 1;
                                        else
@@ -957,7 +949,7 @@ void SV_MarkWriteEntityStateToClient(entity_state_t *s)
                                                        testorigin[0] = lhrandom(lightmins[0], lightmaxs[0]);
                                                        testorigin[1] = lhrandom(lightmins[1], lightmaxs[1]);
                                                        testorigin[2] = lhrandom(lightmins[2], lightmaxs[2]);
-                                                       trace = SV_Move(sv_writeentitiestoclient_testeye, vec3_origin, vec3_origin, testorigin, MOVE_WORLDONLY, NULL);
+                                                       sv.worldmodel->brush.TraceBox(sv.worldmodel, &trace, sv_writeentitiestoclient_testeye, sv_writeentitiestoclient_testeye, testorigin, testorigin, SUPERCONTENTS_SOLID);
                                                        if (trace.fraction == 1 || BoxesOverlap(trace.endpos, trace.endpos, entmins, entmaxs))
                                                                sv_writeentitiestoclient_client->visibletime[s->number] = realtime + 1;
                                                }
@@ -993,6 +985,16 @@ void SV_WriteEntitiesToClient(client_t *client, edict_t *clent, sizebuf_t *msg)
        buf.data = data;
        buf.maxsize = sizeof(data);
 
+       d = client->entitydatabase4;
+
+       for (i = 0;i < MAX_ENTITY_HISTORY;i++)
+               if (!d->commit[i].numentities)
+                       break;
+       // if commit buffer full, just don't bother writing an update this frame
+       if (i == MAX_ENTITY_HISTORY)
+               return;
+       d->currentcommit = d->commit + i;
+
        // this state's number gets played around with later
        ClearStateToDefault(&inactiveentitystate);
        //inactiveentitystate = defaultstate;
@@ -1000,7 +1002,6 @@ void SV_WriteEntitiesToClient(client_t *client, edict_t *clent, sizebuf_t *msg)
        sv_writeentitiestoclient_client = client;
 
        sv_writeentitiestoclient_culled_pvs = 0;
-       sv_writeentitiestoclient_culled_portal = 0;
        sv_writeentitiestoclient_culled_trace = 0;
        sv_writeentitiestoclient_visibleentities = 0;
        sv_writeentitiestoclient_totalentities = 0;
@@ -1030,17 +1031,23 @@ void SV_WriteEntitiesToClient(client_t *client, edict_t *clent, sizebuf_t *msg)
        for (i = 0;i < numsendentities;i++)
                SV_MarkWriteEntityStateToClient(sendentities + i);
 
-       d = client->entitydatabase4;
        // calculate maximum bytes to allow in this packet
        // deduct 4 to account for the end data
        maxbytes = min(msg->maxsize, MAX_PACKETFRAGMENT) - 4;
 
-       d->currentcommit = d->commit + EntityFrame4_SV_ChooseCommitToReplace(d);
        d->currentcommit->numentities = 0;
        d->currentcommit->framenum = ++client->entityframenumber;
        MSG_WriteByte(msg, svc_entities);
        MSG_WriteLong(msg, d->referenceframenum);
        MSG_WriteLong(msg, d->currentcommit->framenum);
+       if (developer_networkentities.integer >= 1)
+       {
+               Con_Printf("send svc_entities ref:%i num:%i (database: ref:%i commits:", d->referenceframenum, d->currentcommit->framenum, d->referenceframenum);
+               for (i = 0;i < MAX_ENTITY_HISTORY;i++)
+                       if (d->commit[i].numentities)
+                               Con_Printf(" %i", d->commit[i].framenum);
+               Con_Printf(")\n");
+       }
        if (d->currententitynumber >= sv.max_edicts)
                startnumber = 1;
        else
@@ -1109,7 +1116,7 @@ void SV_WriteEntitiesToClient(client_t *client, edict_t *clent, sizebuf_t *msg)
        d->currentcommit = NULL;
 
        if (sv_cullentities_stats.integer)
-               Con_Printf("client \"%s\" entities: %d total, %d visible, %d culled by: %d pvs %d portal %d trace\n", client->name, sv_writeentitiestoclient_totalentities, sv_writeentitiestoclient_visibleentities, sv_writeentitiestoclient_culled_pvs + sv_writeentitiestoclient_culled_portal + sv_writeentitiestoclient_culled_trace, sv_writeentitiestoclient_culled_pvs, sv_writeentitiestoclient_culled_portal, sv_writeentitiestoclient_culled_trace);
+               Con_Printf("client \"%s\" entities: %d total, %d visible, %d culled by: %d pvs %d trace\n", client->name, sv_writeentitiestoclient_totalentities, sv_writeentitiestoclient_visibleentities, sv_writeentitiestoclient_culled_pvs + sv_writeentitiestoclient_culled_trace, sv_writeentitiestoclient_culled_pvs, sv_writeentitiestoclient_culled_trace);
 }
 #endif
 
@@ -1200,7 +1207,7 @@ void SV_WriteClientdataToMessage (edict_t *ent, sizebuf_t *msg)
        if ( ent->v->waterlevel >= 2)
                bits |= SU_INWATER;
 
-       // dpprotocol
+       // PROTOCOL_DARKPLACES
        VectorClear(punchvector);
        if ((val = GETEDICTFIELDVALUE(ent, eval_punchvector)))
                VectorCopy(val->vector, punchvector);
@@ -1223,8 +1230,8 @@ void SV_WriteClientdataToMessage (edict_t *ent, sizebuf_t *msg)
        {
                if (ent->v->punchangle[i])
                        bits |= (SU_PUNCH1<<i);
-               if (punchvector[i]) // dpprotocol
-                       bits |= (SU_PUNCHVEC1<<i); // dpprotocol
+               if (punchvector[i]) // PROTOCOL_DARKPLACES
+                       bits |= (SU_PUNCHVEC1<<i); // PROTOCOL_DARKPLACES
                if (ent->v->velocity[i])
                        bits |= (SU_VELOCITY1<<i);
        }
@@ -1260,9 +1267,9 @@ void SV_WriteClientdataToMessage (edict_t *ent, sizebuf_t *msg)
        for (i=0 ; i<3 ; i++)
        {
                if (bits & (SU_PUNCH1<<i))
-                       MSG_WritePreciseAngle(msg, ent->v->punchangle[i]); // dpprotocol
-               if (bits & (SU_PUNCHVEC1<<i)) // dpprotocol
-                       MSG_WriteDPCoord(msg, punchvector[i]); // dpprotocol
+                       MSG_WritePreciseAngle(msg, ent->v->punchangle[i]); // PROTOCOL_DARKPLACES
+               if (bits & (SU_PUNCHVEC1<<i)) // PROTOCOL_DARKPLACES
+                       MSG_WriteDPCoord(msg, punchvector[i]); // PROTOCOL_DARKPLACES
                if (bits & (SU_VELOCITY1<<i))
                        MSG_WriteChar (msg, ent->v->velocity[i]/16);
        }
@@ -1284,7 +1291,7 @@ void SV_WriteClientdataToMessage (edict_t *ent, sizebuf_t *msg)
        MSG_WriteByte (msg, ent->v->ammo_rockets);
        MSG_WriteByte (msg, ent->v->ammo_cells);
 
-       if (gamemode == GAME_HIPNOTIC || gamemode == GAME_ROGUE)
+       if (gamemode == GAME_HIPNOTIC || gamemode == GAME_ROGUE || gamemode == GAME_NEXUIZ)
        {
                for(i=0;i<32;i++)
                {
@@ -1353,71 +1360,67 @@ void SV_UpdateToReliableMessages (void)
        char *s;
 
 // check for changes to be sent over the reliable streams
-       for (i = 0;i < MAX_SCOREBOARD;i++)
+       for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++)
        {
-               // only update the client fields if they've spawned in
-               if ((host_client = svs.connectedclients[i]) && host_client->spawned)
+               // update the host_client fields we care about according to the entity fields
+               sv_player = EDICT_NUM(i+1);
+               s = PR_GetString(sv_player->v->netname);
+               if (s != host_client->name)
                {
-                       // update the host_client fields we care about according to the entity fields
-                       sv_player = host_client->edict;
-                       s = PR_GetString(sv_player->v->netname);
-                       if (s != host_client->name)
-                       {
-                               if (s == NULL)
-                                       s = "";
-                               // point the string back at host_client->name to keep it safe
-                               strncpy(host_client->name, s, sizeof(host_client->name) - 1);
-                               sv_player->v->netname = PR_SetString(host_client->name);
-                       }
-                       if ((val = GETEDICTFIELDVALUE(sv_player, eval_clientcolors)) && host_client->colors != val->_float)
-                               host_client->colors = val->_float;
-                       host_client->frags = sv_player->v->frags;
-                       if (gamemode == GAME_NEHAHRA)
-                               if ((val = GETEDICTFIELDVALUE(sv_player, eval_pmodel)) && host_client->pmodel != val->_float)
-                                       host_client->pmodel = val->_float;
-
-                       // if the fields changed, send messages about the changes
-                       if (strcmp(host_client->old_name, host_client->name))
+                       if (s == NULL)
+                               s = "";
+                       // point the string back at host_client->name to keep it safe
+                       strlcpy (host_client->name, s, sizeof (host_client->name));
+                       sv_player->v->netname = PR_SetString(host_client->name);
+               }
+               if ((val = GETEDICTFIELDVALUE(sv_player, eval_clientcolors)) && host_client->colors != val->_float)
+                       host_client->colors = val->_float;
+               host_client->frags = sv_player->v->frags;
+               if (gamemode == GAME_NEHAHRA)
+                       if ((val = GETEDICTFIELDVALUE(sv_player, eval_pmodel)) && host_client->pmodel != val->_float)
+                               host_client->pmodel = val->_float;
+
+               // if the fields changed, send messages about the changes
+               if (strcmp(host_client->old_name, host_client->name))
+               {
+                       strcpy(host_client->old_name, host_client->name);
+                       for (j = 0, client = svs.clients;j < svs.maxclients;j++, client++)
                        {
-                               strcpy(host_client->old_name, host_client->name);
-                               for (j = 0;j < MAX_SCOREBOARD;j++)
-                               {
-                                       if (!(client = svs.connectedclients[j]) || !client->spawned)
-                                               continue;
-                                       MSG_WriteByte (&client->message, svc_updatename);
-                                       MSG_WriteByte (&client->message, i);
-                                       MSG_WriteString (&client->message, host_client->name);
-                               }
+                               if (!client->spawned || !client->netconnection)
+                                       continue;
+                               MSG_WriteByte (&client->message, svc_updatename);
+                               MSG_WriteByte (&client->message, i);
+                               MSG_WriteString (&client->message, host_client->name);
                        }
-                       if (host_client->old_colors != host_client->colors)
+               }
+               if (host_client->old_colors != host_client->colors)
+               {
+                       host_client->old_colors = host_client->colors;
+                       for (j = 0, client = svs.clients;j < svs.maxclients;j++, client++)
                        {
-                               host_client->old_colors = host_client->colors;
-                               for (j = 0;j < MAX_SCOREBOARD;j++)
-                               {
-                                       if (!(client = svs.connectedclients[j]) || !client->spawned)
-                                               continue;
-                                       MSG_WriteByte (&client->message, svc_updatecolors);
-                                       MSG_WriteByte (&client->message, i);
-                                       MSG_WriteByte (&client->message, host_client->colors);
-                               }
+                               if (!client->spawned || !client->netconnection)
+                                       continue;
+                               MSG_WriteByte (&client->message, svc_updatecolors);
+                               MSG_WriteByte (&client->message, i);
+                               MSG_WriteByte (&client->message, host_client->colors);
                        }
-                       if (host_client->old_frags != host_client->frags)
+               }
+               if (host_client->old_frags != host_client->frags)
+               {
+                       host_client->old_frags = host_client->frags;
+                       for (j = 0, client = svs.clients;j < svs.maxclients;j++, client++)
                        {
-                               host_client->old_frags = host_client->frags;
-                               for (j = 0;j < MAX_SCOREBOARD;j++)
-                               {
-                                       if (!(client = svs.connectedclients[j]) || !client->spawned)
-                                               continue;
-                                       MSG_WriteByte (&client->message, svc_updatefrags);
-                                       MSG_WriteByte (&client->message, i);
-                                       MSG_WriteShort (&client->message, host_client->frags);
-                               }
+                               if (!client->spawned || !client->netconnection)
+                                       continue;
+                               MSG_WriteByte (&client->message, svc_updatefrags);
+                               MSG_WriteByte (&client->message, i);
+                               MSG_WriteShort (&client->message, host_client->frags);
                        }
                }
        }
 
-       for (j = 0;j < MAX_SCOREBOARD;j++)
-               if ((client = svs.connectedclients[j]))
+       for (j = 0, client = svs.clients;j < svs.maxclients;j++, client++)
+               if (client->netconnection)
                        SZ_Write (&client->message, sv.reliable_datagram.data, sv.reliable_datagram.cursize);
 
        SZ_Clear (&sv.reliable_datagram);
@@ -1461,12 +1464,17 @@ void SV_SendClientMessages (void)
        SV_UpdateToReliableMessages();
 
 // build individual updates
-       for (i = 0;i < MAX_SCOREBOARD;i++)
+       for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++)
        {
-               if (!(host_client = svs.connectedclients[i]))
+               if (!host_client->active)
                        continue;
+               if (!host_client->netconnection)
+               {
+                       SZ_Clear(&host_client->message);
+                       continue;
+               }
 
-               if (host_client->deadsocket || !host_client->netconnection || host_client->message.overflowed)
+               if (host_client->deadsocket || host_client->message.overflowed)
                {
                        SV_DropClient (true);   // if the message couldn't send, kick off
                        continue;
@@ -1573,7 +1581,7 @@ void SV_CreateBaseline (void)
 
                if (svent->e->free)
                        continue;
-               if (entnum > MAX_SCOREBOARD && !svent->v->modelindex)
+               if (entnum > svs.maxclients && !svent->v->modelindex)
                        continue;
 
                // create entity baseline
@@ -1581,7 +1589,7 @@ void SV_CreateBaseline (void)
                VectorCopy (svent->v->angles, svent->e->baseline.angles);
                svent->e->baseline.frame = svent->v->frame;
                svent->e->baseline.skin = svent->v->skin;
-               if (entnum > 0 && entnum <= MAX_SCOREBOARD)
+               if (entnum > 0 && entnum <= svs.maxclients)
                {
                        svent->e->baseline.colormap = entnum;
                        svent->e->baseline.modelindex = SV_ModelIndex("progs/player.mdl");
@@ -1664,9 +1672,9 @@ void SV_SaveSpawnparms (void)
 
        svs.serverflags = pr_global_struct->serverflags;
 
-       for (i = 0;i < MAX_SCOREBOARD;i++)
+       for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++)
        {
-               if (!(host_client = svs.connectedclients[i]))
+               if (!host_client->active)
                        continue;
 
        // call the progs to get default spawn parms for the new client
@@ -1774,7 +1782,7 @@ void SV_SpawnServer (const char *server)
 
 // allocate server memory
        // start out with just enough room for clients and a reasonable estimate of entities
-       sv.max_edicts = max(MAX_SCOREBOARD + 1, 512);
+       sv.max_edicts = max(svs.maxclients + 1, 512);
        sv.max_edicts = min(sv.max_edicts, MAX_EDICTS);
 
        // clear the edict memory pool
@@ -1807,7 +1815,7 @@ void SV_SpawnServer (const char *server)
        sv.signon.data = sv.signon_buf;
 
 // leave slots at start for clients only
-       sv.num_edicts = MAX_SCOREBOARD+1;
+       sv.num_edicts = svs.maxclients+1;
 
        sv.state = ss_loading;
        sv.paused = false;
@@ -1836,7 +1844,7 @@ void SV_SpawnServer (const char *server)
 
        sv.model_precache[0] = "";
        sv.model_precache[1] = sv.modelname;
-       for (i = 1;i < sv.worldmodel->brushq1.numsubmodels;i++)
+       for (i = 1;i < sv.worldmodel->brush.numsubmodels;i++)
        {
                sv.model_precache[i+1] = localmodels[i];
                sv.models[i+1] = Mod_ForName (localmodels[i], false, false, false);
@@ -1900,8 +1908,8 @@ void SV_SpawnServer (const char *server)
 #endif
 
 // send serverinfo to all connected clients
-       for (i = 0;i < MAX_SCOREBOARD;i++)
-               if ((host_client = svs.connectedclients[i]))
+       for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++)
+               if (host_client->netconnection)
                        SV_SendServerinfo(host_client);
 
        Con_DPrintf ("Server spawned.\n");