]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - sv_user.c
reworked predicted player physics to call PlayerPreThink before the move and PlayerPo...
[xonotic/darkplaces.git] / sv_user.c
index de1412c62e45f5094396ed37d048f3ebd3582343..8dbd05c0e818dc1067061fc7b04ac4501835688e 100644 (file)
--- a/sv_user.c
+++ b/sv_user.c
@@ -68,7 +68,7 @@ void SV_SetIdealPitch (void)
                bottom[1] = top[1];
                bottom[2] = top[2] - 160;
 
-               tr = SV_Move (top, vec3_origin, vec3_origin, bottom, MOVE_NOMONSTERS, host_client->edict);
+               tr = SV_Move (top, vec3_origin, vec3_origin, bottom, MOVE_NOMONSTERS, host_client->edict, SUPERCONTENTS_SOLID);
                // if looking at a wall, leave ideal the way is was
                if (tr.startsolid)
                        return;
@@ -134,7 +134,7 @@ void SV_UserFriction (void)
        start[2] = host_client->edict->fields.server->origin[2] + host_client->edict->fields.server->mins[2];
        stop[2] = start[2] - 34;
 
-       trace = SV_Move (start, vec3_origin, vec3_origin, stop, MOVE_NOMONSTERS, host_client->edict);
+       trace = SV_Move (start, vec3_origin, vec3_origin, stop, MOVE_NOMONSTERS, host_client->edict, SV_GenericHitSuperContentsMask(host_client->edict));
 
        if (trace.fraction == 1.0)
                friction = sv_friction.value*sv_edgefriction.value;
@@ -208,7 +208,7 @@ void DropPunchAngle (void)
                len = 0;
        VectorScale (host_client->edict->fields.server->punchangle, len, host_client->edict->fields.server->punchangle);
 
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_punchvector)))
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.punchvector)))
        {
                len = VectorNormalizeLength (val->vector);
 
@@ -277,7 +277,7 @@ void SV_WaterMove (void)
        speed = VectorLength(host_client->edict->fields.server->velocity);
        if (speed)
        {
-               newspeed = speed - sv.frametime * speed * sv_waterfriction.value;
+               newspeed = speed - sv.frametime * speed * (sv_waterfriction.value < 0 ? sv_friction.value : sv_waterfriction.value);
                if (newspeed < 0)
                        newspeed = 0;
                temp = newspeed/speed;
@@ -379,10 +379,25 @@ the move fields specify an intended velocity in pix/sec
 the angle fields specify an exact angular motion in degrees
 ===================
 */
+extern cvar_t sv_playerphysicsqc;
 void SV_ClientThink (void)
 {
        vec3_t v_angle;
 
+       SV_ApplyClientMove();
+       // make sure the velocity is sane (not a NaN)
+       SV_CheckVelocity(host_client->edict);
+
+       // LordHavoc: QuakeC replacement for SV_ClientThink (player movement)
+       if (prog->funcoffsets.SV_PlayerPhysics && sv_playerphysicsqc.integer)
+       {
+               prog->globals.server->time = sv.time;
+               prog->globals.server->self = PRVM_EDICT_TO_PROG(host_client->edict);
+               PRVM_ExecuteProgram (prog->funcoffsets.SV_PlayerPhysics, "QC function SV_PlayerPhysics is missing");
+               SV_CheckVelocity(host_client->edict);
+               return;
+       }
+
        if (host_client->edict->fields.server->movetype == MOVETYPE_NONE)
                return;
 
@@ -409,6 +424,7 @@ void SV_ClientThink (void)
        if ( (int)host_client->edict->fields.server->flags & FL_WATERJUMP )
        {
                SV_WaterJump ();
+               SV_CheckVelocity(host_client->edict);
                return;
        }
 
@@ -426,10 +442,12 @@ void SV_ClientThink (void)
        if ((host_client->edict->fields.server->waterlevel >= 2) && (host_client->edict->fields.server->movetype != MOVETYPE_NOCLIP))
        {
                SV_WaterMove ();
+               SV_CheckVelocity(host_client->edict);
                return;
        }
 
        SV_AirMove ();
+       SV_CheckVelocity(host_client->edict);
 }
 
 /*
@@ -437,14 +455,11 @@ void SV_ClientThink (void)
 SV_ReadClientMove
 ===================
 */
-qboolean SV_ReadClientMove (void)
+int sv_numreadmoves = 0;
+usercmd_t sv_readmoves[CL_MAX_USERCMDS];
+void SV_ReadClientMove (void)
 {
-       qboolean kickplayer = false;
        int i;
-#ifdef NUM_PING_TIMES
-       double total;
-#endif
-       double moveframetime;
        usercmd_t newmove;
        usercmd_t *move = &newmove;
 
@@ -459,9 +474,12 @@ qboolean SV_ReadClientMove (void)
        if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__);
        move->receivetime = (float)sv.time;
 
+#if DEBUGMOVES
+       Con_Printf("%s move%i #%i %ims (%ims) %i %i '%i %i %i' '%i %i %i'\n", move->time > move->receivetime ? "^3read future" : "^4read normal", sv_numreadmoves + 1, move->sequence, (int)floor((move->time - host_client->cmd.time) * 1000.0 + 0.5), (int)floor(move->time * 1000.0 + 0.5), move->impulse, move->buttons, (int)move->viewangles[0], (int)move->viewangles[1], (int)move->viewangles[2], (int)move->forwardmove, (int)move->sidemove, (int)move->upmove);
+#endif
        // limit reported time to current time
        // (incase the client is trying to cheat)
-       move->time = min(move->time, move->receivetime);
+       move->time = min(move->time, move->receivetime + sv.frametime);
 
        // read current angles
        for (i = 0;i < 3;i++)
@@ -521,67 +539,121 @@ qboolean SV_ReadClientMove (void)
                if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__);
        }
 
-       if (move->sequence && move->sequence <= host_client->movesequence)
-       {
-               // repeat of old input (to fight packet loss)
-               return kickplayer;
-       }
-
        // if the previous move has not been applied yet, we need to accumulate
        // the impulse/buttons from it
        if (!host_client->cmd.applied)
        {
                if (!move->impulse)
                        move->impulse = host_client->cmd.impulse;
-               move->buttons |= host_client->cmd.impulse;
+               move->buttons |= host_client->cmd.buttons;
        }
 
-       moveframetime = bound(0, move->time - host_client->cmd.time, 0.1);
-       //Con_Printf("movesequence = %i (%i lost), moveframetime = %f\n", move->sequence, move->sequence ? move->sequence - host_client->movesequence - 1 : 0, moveframetime);
+       // now store this move for later execution
+       // (we have to buffer the moves because of old ones being repeated)
+       if (sv_numreadmoves < CL_MAX_USERCMDS)
+               sv_readmoves[sv_numreadmoves++] = *move;
+}
 
+void SV_ExecuteClientMoves(void)
+{
+       int moveindex;
+       float moveframetime;
+       double oldframetime;
+       double oldframetime2;
+#ifdef NUM_PING_TIMES
+       double total;
+#endif
+       prvm_eval_t *val;
+       if (sv_numreadmoves < 1)
+               return;
+       // only start accepting input once the player is spawned
+       if (!host_client->spawned)
+               return;
+#if DEBUGMOVES
+       Con_Printf("SV_ExecuteClientMoves: read %i moves at sv.time %f\n", sv_numreadmoves, (float)sv.time);
+#endif
        // disable clientside movement prediction in some cases
-       if (ceil((move->receivetime - move->time) * 1000.0) < sv_clmovement_minping.integer)
+       if (ceil(max(sv_readmoves[sv_numreadmoves-1].receivetime - sv_readmoves[sv_numreadmoves-1].time, 0) * 1000.0) < sv_clmovement_minping.integer)
                host_client->clmovement_disabletimeout = realtime + sv_clmovement_minping_disabletime.value / 1000.0;
-       if (!sv_clmovement_enable.integer || host_client->clmovement_disabletimeout > realtime)
-               move->sequence = 0;
+       // several conditions govern whether clientside movement prediction is allowed
+       if (sv_readmoves[sv_numreadmoves-1].sequence && sv_clmovement_enable.integer && sv_clmovement_waitforinput.integer > 0 && host_client->clmovement_disabletimeout <= realtime && host_client->edict->fields.server->movetype == MOVETYPE_WALK && (!(val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.disableclientprediction)) || !val->_float))
+       {
+               // process the moves in order and ignore old ones
+               // but always trust the latest move
+               // (this deals with bogus initial move sequences after level change,
+               //  where the client will eventually catch up with the level change
+               //  and reset its move sequence)
+               for (moveindex = 0;moveindex < sv_numreadmoves;moveindex++)
+               {
+                       usercmd_t *move = sv_readmoves + moveindex;
+                       if (host_client->movesequence < move->sequence || moveindex == sv_numreadmoves - 1)
+                       {
+#if DEBUGMOVES
+                               Con_Printf("%smove #%i %ims (%ims) %i %i '%i %i %i' '%i %i %i'\n", (move->time - host_client->cmd.time) > sv.frametime ? "^1" : "^2", move->sequence, (int)floor((move->time - host_client->cmd.time) * 1000.0 + 0.5), (int)floor(move->time * 1000.0 + 0.5), move->impulse, move->buttons, (int)move->viewangles[0], (int)move->viewangles[1], (int)move->viewangles[2], (int)move->forwardmove, (int)move->sidemove, (int)move->upmove);
+#endif
+                               // this is a new move
+                               moveframetime = bound(0, move->time - host_client->cmd.time, 0.1);
+                               //Con_Printf("movesequence = %i (%i lost), moveframetime = %f\n", move->sequence, move->sequence ? move->sequence - host_client->movesequence - 1 : 0, moveframetime);
+                               host_client->cmd = *move;
+                               host_client->movesequence = move->sequence;
+
+                               // if using prediction, we need to perform moves when packets are
+                               // received, even if multiple occur in one frame
+                               // (they can't go beyond the current time so there is no cheat issue
+                               //  with this approach, and if they don't send input for a while they
+                               //  start moving anyway, so the longest 'lagaport' possible is
+                               //  determined by the sv_clmovement_waitforinput cvar)
+                               if (moveframetime <= 0)
+                                       continue;
+                               oldframetime = prog->globals.server->frametime;
+                               oldframetime2 = sv.frametime;
+                               // update ping time for qc to see while executing this move
+                               host_client->ping = host_client->cmd.receivetime - host_client->cmd.time;
+                               // the server and qc frametime values must be changed temporarily
+                               prog->globals.server->frametime = sv.frametime = moveframetime;
+                               // if move is more than 50ms, split it into two moves (this matches QWSV behavior and the client prediction)
+                               if (sv.frametime > 0.05)
+                               {
+                                       prog->globals.server->frametime = sv.frametime = moveframetime * 0.5f;
+                                       SV_Physics_ClientMove();
+                               }
+                               SV_Physics_ClientMove();
+                               sv.frametime = oldframetime2;
+                               prog->globals.server->frametime = oldframetime;
+                               host_client->clmovement_skipphysicsframes = sv_clmovement_waitforinput.integer;
+                       }
+               }
+       }
+       else
+       {
+               // try to gather button bits from old moves, but only if their time is
+               // advancing (ones with the same timestamp can't be trusted)
+               for (moveindex = 0;moveindex < sv_numreadmoves-1;moveindex++)
+               {
+                       usercmd_t *move = sv_readmoves + moveindex;
+                       if (host_client->cmd.time < move->time)
+                       {
+                               sv_readmoves[sv_numreadmoves-1].buttons |= move->buttons;
+                               if (move->impulse)
+                                       sv_readmoves[sv_numreadmoves-1].impulse = move->impulse;
+                       }
+               }
+               // now copy the new move
+               host_client->cmd = sv_readmoves[sv_numreadmoves-1];
+               host_client->movesequence = 0;
+               // make sure that normal physics takes over immediately
+               host_client->clmovement_skipphysicsframes = 0;
+       }
 
        // calculate average ping time
-       host_client->ping = move->receivetime - move->time;
+       host_client->ping = host_client->cmd.receivetime - host_client->cmd.time;
 #ifdef NUM_PING_TIMES
-       host_client->ping_times[host_client->num_pings % NUM_PING_TIMES] = move->receivetime - move->time;
+       host_client->ping_times[host_client->num_pings % NUM_PING_TIMES] = host_client->cmd.receivetime - host_client->cmd.time;
        host_client->num_pings++;
        for (i=0, total = 0;i < NUM_PING_TIMES;i++)
                total += host_client->ping_times[i];
        host_client->ping = total / NUM_PING_TIMES;
 #endif
-
-       // only start accepting input once the player is spawned
-       if (host_client->spawned)
-       {
-               // at this point we know this input is new and should be stored
-               host_client->cmd = *move;
-               host_client->movesequence = move->sequence;
-               // if using prediction, we need to perform moves when packets are
-               // received, even if multiple occur in one frame
-               // (they can't go beyond the current time so there is no cheat issue
-               //  with this approach, and if they don't send input for a while they
-               //  start moving anyway, so the longest 'lagaport' possible is
-               //  determined by the sv_clmovement_waitforinput cvar)
-               if (host_client->movesequence && sv_clmovement_waitforinput.integer > 0 && moveframetime > 0)
-               {
-                       double oldframetime = prog->globals.server->frametime;
-                       double oldframetime2 = sv.frametime;
-                       // the server and qc frametime values must be changed temporarily
-                       sv.frametime = moveframetime;
-                       prog->globals.server->frametime = moveframetime;
-                       SV_Physics_ClientEntity(host_client->edict);
-                       sv.frametime = oldframetime2;
-                       prog->globals.server->frametime = oldframetime;
-                       host_client->clmovement_skipphysicsframes = sv_clmovement_waitforinput.integer;
-               }
-       }
-
-       return kickplayer;
 }
 
 void SV_ApplyClientMove (void)
@@ -607,29 +679,29 @@ void SV_ApplyClientMove (void)
        // only send the impulse to qc once
        move->impulse = 0;
        VectorCopy(move->viewangles, host_client->edict->fields.server->v_angle);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button3))) val->_float = ((move->buttons >> 2) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button4))) val->_float = ((move->buttons >> 3) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button5))) val->_float = ((move->buttons >> 4) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button6))) val->_float = ((move->buttons >> 5) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button7))) val->_float = ((move->buttons >> 6) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button8))) val->_float = ((move->buttons >> 7) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button9))) val->_float = ((move->buttons >> 11) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button10))) val->_float = ((move->buttons >> 12) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button11))) val->_float = ((move->buttons >> 13) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button12))) val->_float = ((move->buttons >> 14) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button13))) val->_float = ((move->buttons >> 15) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button14))) val->_float = ((move->buttons >> 16) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button15))) val->_float = ((move->buttons >> 17) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_button16))) val->_float = ((move->buttons >> 18) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_buttonuse))) val->_float = ((move->buttons >> 8) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_buttonchat))) val->_float = ((move->buttons >> 9) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_cursor_active))) val->_float = ((move->buttons >> 10) & 1);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_movement))) VectorSet(val->vector, move->forwardmove, move->sidemove, move->upmove);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_cursor_screen))) VectorCopy(move->cursor_screen, val->vector);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_cursor_trace_start))) VectorCopy(move->cursor_start, val->vector);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_cursor_trace_endpos))) VectorCopy(move->cursor_impact, val->vector);
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_cursor_trace_ent))) val->edict = PRVM_EDICT_TO_PROG(PRVM_EDICT_NUM(move->cursor_entitynumber));
-       if ((val = PRVM_GETEDICTFIELDVALUE(host_client->edict, eval_ping))) val->_float = host_client->ping * 1000.0;
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button3))) val->_float = ((move->buttons >> 2) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button4))) val->_float = ((move->buttons >> 3) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button5))) val->_float = ((move->buttons >> 4) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button6))) val->_float = ((move->buttons >> 5) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button7))) val->_float = ((move->buttons >> 6) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button8))) val->_float = ((move->buttons >> 7) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button9))) val->_float = ((move->buttons >> 11) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button10))) val->_float = ((move->buttons >> 12) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button11))) val->_float = ((move->buttons >> 13) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button12))) val->_float = ((move->buttons >> 14) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button13))) val->_float = ((move->buttons >> 15) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button14))) val->_float = ((move->buttons >> 16) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button15))) val->_float = ((move->buttons >> 17) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button16))) val->_float = ((move->buttons >> 18) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.buttonuse))) val->_float = ((move->buttons >> 8) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.buttonchat))) val->_float = ((move->buttons >> 9) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_active))) val->_float = ((move->buttons >> 10) & 1);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.movement))) VectorSet(val->vector, move->forwardmove, move->sidemove, move->upmove);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_screen))) VectorCopy(move->cursor_screen, val->vector);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_trace_start))) VectorCopy(move->cursor_start, val->vector);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_trace_endpos))) VectorCopy(move->cursor_impact, val->vector);
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_trace_ent))) val->edict = PRVM_EDICT_TO_PROG(PRVM_EDICT_NUM(move->cursor_entitynumber));
+       if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.ping))) val->_float = host_client->ping * 1000.0;
 }
 
 void SV_FrameLost(int framenum)
@@ -661,6 +733,7 @@ void SV_ReadClientMessage(void)
        char *s;
 
        //MSG_BeginReading ();
+       sv_numreadmoves = 0;
 
        for(;;)
        {
@@ -682,6 +755,8 @@ void SV_ReadClientMessage(void)
                if (cmd == -1)
                {
                        // end of message
+                       // apply the moves that were read this frame
+                       SV_ExecuteClientMoves();
                        break;
                }
 
@@ -701,13 +776,13 @@ void SV_ReadClientMessage(void)
                         || strncasecmp(s, "begin", 5) == 0
                         || strncasecmp(s, "prespawn", 8) == 0)
                                Cmd_ExecuteString (s, src_client);
-                       else if (SV_ParseClientCommandQC)
+                       else if (prog->funcoffsets.SV_ParseClientCommand)
                        {
                                int restorevm_tempstringsbuf_cursize;
                                restorevm_tempstringsbuf_cursize = vm_tempstringsbuf.cursize;
                                PRVM_G_INT(OFS_PARM0) = PRVM_SetTempString(s);
                                prog->globals.server->self = PRVM_EDICT_TO_PROG(host_client->edict);
-                               PRVM_ExecuteProgram ((func_t)(SV_ParseClientCommandQC - prog->functions), "QC function SV_ParseClientCommand is missing");
+                               PRVM_ExecuteProgram (prog->funcoffsets.SV_ParseClientCommand, "QC function SV_ParseClientCommand is missing");
                                vm_tempstringsbuf.cursize = restorevm_tempstringsbuf_cursize;
                        }
                        else
@@ -719,9 +794,7 @@ void SV_ReadClientMessage(void)
                        return;
 
                case clc_move:
-                       // if ReadClientMove returns true, the client tried to speed cheat
-                       if (SV_ReadClientMove ())
-                               SV_DropClient (false);
+                       SV_ReadClientMove();
                        break;
 
                case clc_ackdownloaddata: