]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - view.c
Faster speeds and tighter limits by default
[xonotic/darkplaces.git] / view.c
diff --git a/view.c b/view.c
index 4172d096314dafa30b5e8cc67a3bde70c9f05a1d..b19f110a5ecee637ed86323545da62e3c0d8f7a1 100644 (file)
--- a/view.c
+++ b/view.c
@@ -46,11 +46,18 @@ cvar_t cl_bobmodel_up = {CVAR_SAVE, "cl_bobmodel_up", "0.06", "gun bobbing upwar
 cvar_t cl_bobmodel_speed = {CVAR_SAVE, "cl_bobmodel_speed", "7", "gun bobbing speed"};
 
 cvar_t cl_leanmodel_side = {CVAR_SAVE, "cl_leanmodel_side", "1", "enables gun leaning sideways"};
-cvar_t cl_leanmodel_side_speed = {CVAR_SAVE, "cl_leanmodel_side_speed", "2.5", "gun leaning sideways speed"};
-cvar_t cl_leanmodel_side_limit = {CVAR_SAVE, "cl_leanmodel_side_limit", "7.5", "gun leaning sideways limit"};
+cvar_t cl_leanmodel_side_speed = {CVAR_SAVE, "cl_leanmodel_side_speed", "15", "gun leaning sideways speed"};
+cvar_t cl_leanmodel_side_limit = {CVAR_SAVE, "cl_leanmodel_side_limit", "5", "gun leaning sideways limit"};
 cvar_t cl_leanmodel_up = {CVAR_SAVE, "cl_leanmodel_up", "1", "enables gun leaning upward"};
-cvar_t cl_leanmodel_up_speed = {CVAR_SAVE, "cl_leanmodel_up_speed", "2", "gun leaning upward speed"};
-cvar_t cl_leanmodel_up_limit = {CVAR_SAVE, "cl_leanmodel_up_limit", "5", "gun leaning upward limit"};
+cvar_t cl_leanmodel_up_speed = {CVAR_SAVE, "cl_leanmodel_up_speed", "10", "gun leaning upward speed"};
+cvar_t cl_leanmodel_up_limit = {CVAR_SAVE, "cl_leanmodel_up_limit", "2.5", "gun leaning upward limit"};
+
+cvar_t cl_followmodel_side = {CVAR_SAVE, "cl_followmodel_side", "1", "enables gun following sideways"};
+cvar_t cl_followmodel_side_speed = {CVAR_SAVE, "cl_followmodel_side_speed", "15", "gun following sideways speed"};
+cvar_t cl_followmodel_side_limit = {CVAR_SAVE, "cl_followmodel_side_limit", "1", "gun following sideways limit"};
+cvar_t cl_followmodel_up = {CVAR_SAVE, "cl_followmodel_up", "1", "enables gun following upward"};
+cvar_t cl_followmodel_up_speed = {CVAR_SAVE, "cl_followmodel_up_speed", "10", "gun following upward speed"};
+cvar_t cl_followmodel_up_limit = {CVAR_SAVE, "cl_followmodel_up_limit", "0.5", "gun following upward limit"};
 
 cvar_t cl_viewmodel_scale = {0, "cl_viewmodel_scale", "1", "changes size of gun model, lower values prevent poking into walls but cause strange artifacts on lighting and especially r_stereo/vid_stereobuffer options where the size of the gun becomes visible"};
 
@@ -360,8 +367,6 @@ V_CalcRefdef
 static vec3_t eyeboxmins = {-16, -16, -24};
 static vec3_t eyeboxmaxs = { 16,  16,  32};
 #endif
-float viewmodel_push_x, viewmodel_push_y;
-vec3_t gunorg_follow;
 void V_CalcRefdef (void)
 {
        entity_t *ent;
@@ -527,7 +532,75 @@ void V_CalcRefdef (void)
                                if (cl.stats[STAT_HEALTH] > 0)
                                {
                                        double xyspeed, bob;
+                                       vec_t d;
+                                       vec_t ef_speed = cl.realframetime * cl.movevars_timescale;
+
+                                       // gun model leaning code
+                                       if(cl_leanmodel_up.value && cl_leanmodel_up_speed.value * ef_speed < 1) // bad things happen if this goes over 1, so prevent the effect
+                                       {
+                                               // prevent the gun from doing a 360* rotation when going around the 0 <-> 360 border
+                                               if(cl.viewangles[PITCH] - cl.viewmodel_push_x >= 180)
+                                                       cl.viewmodel_push_x += 360;
+                                               if(cl.viewmodel_push_x - cl.viewangles[PITCH] >= 180)
+                                                       cl.viewmodel_push_x -= 360;
+
+                                               d = cl.viewangles[PITCH] - cl.viewmodel_push_x;
+                                               cl.viewmodel_push_x = bound(cl.viewangles[PITCH] - cl_leanmodel_up_limit.value, cl.viewmodel_push_x + d * cl_leanmodel_up_speed.value * ef_speed, cl.viewangles[PITCH] + cl_leanmodel_up_limit.value);
+                                       }
+                                       else
+                                               cl.viewmodel_push_x = cl.viewangles[PITCH];
+
+                                       if(cl_leanmodel_side.value && cl_leanmodel_side_speed.value * ef_speed < 1) // bad things happen if this goes over 1, so prevent the effect
+                                       {
+                                               // prevent the gun from doing a 360* rotation when going around the 0 <-> 360 border
+                                               if(cl.viewangles[YAW] - cl.viewmodel_push_y >= 180)
+                                                       cl.viewmodel_push_y += 360;
+                                               if(cl.viewmodel_push_y - cl.viewangles[YAW] >= 180)
+                                                       cl.viewmodel_push_y -= 360;
+
+                                               d = cl.viewangles[YAW] - cl.viewmodel_push_y;
+                                               cl.viewmodel_push_y = bound(cl.viewangles[YAW] - cl_leanmodel_side_limit.value, cl.viewmodel_push_y + d * cl_leanmodel_side_speed.value * ef_speed, cl.viewangles[YAW] + cl_leanmodel_side_limit.value);
+                                       }
+                                       else
+                                               cl.viewmodel_push_y = cl.viewangles[YAW];
+
+                                       VectorSet(gunangles, cl.viewmodel_push_x, cl.viewmodel_push_y, viewangles[2]);
 
+                                       // gun model following code
+                                       if(cl_followmodel_side.value && cl_followmodel_side_speed.value * ef_speed < 1) // bad things happen if this goes over 1, so prevent the effect
+                                       {
+                                               vec_t d0 = vieworg[0] - cl.gunorg_follow[0];
+                                               vec_t d1 = vieworg[1] - cl.gunorg_follow[1];
+                                               d = sqrt(d0 * d0 + d1 * d1);
+                                               if(d > 0)
+                                               {
+                                                       cl.gunorg_follow[0] = cl.gunorg_follow[0] + d0 * cl_followmodel_side_speed.value * ef_speed;
+                                                       cl.gunorg_follow[1] = cl.gunorg_follow[1] + d1 * cl_followmodel_side_speed.value * ef_speed;
+                                                       d *= (1 - cl_followmodel_side_speed.value * ef_speed);
+                                                       if(d > cl_followmodel_side_limit.value)
+                                                       {
+                                                               cl.gunorg_follow[0] = vieworg[0] - (d0 / d) * cl_followmodel_side_limit.value;
+                                                               cl.gunorg_follow[1] = vieworg[1] - (d1 / d) * cl_followmodel_side_limit.value;
+                                                       }
+                                               }
+                                       }
+                                       else
+                                       {
+                                               cl.gunorg_follow[0] = vieworg[0];
+                                               cl.gunorg_follow[1] = vieworg[1];
+                                       }
+
+                                       if(cl_followmodel_up.value && cl_followmodel_up_speed.value * ef_speed < 1) // bad things happen if this goes over 1, so prevent the effect
+                                       {
+                                               d = vieworg[2] - cl.gunorg_follow[2];
+                                               cl.gunorg_follow[2] = bound(vieworg[2] - cl_followmodel_up_limit.value, cl.gunorg_follow[2] + d * cl_followmodel_up_speed.value * ef_speed, vieworg[2] + cl_followmodel_up_limit.value);
+                                       }
+                                       else
+                                               cl.gunorg_follow[2] = vieworg[2];
+
+                                       VectorCopy(cl.gunorg_follow, gunorg);
+
+                                       // view bobbing code
                                        xyspeed = sqrt(cl.movement_velocity[0]*cl.movement_velocity[0] + cl.movement_velocity[1]*cl.movement_velocity[1]);
                                        if (cl_bob.value && cl_bobcycle.value)
                                        {
@@ -547,8 +620,14 @@ void V_CalcRefdef (void)
                                                bob = xyspeed * cl_bob.value;
                                                bob = bob*0.3 + bob*0.7*cycle;
                                                vieworg[2] += bound(-7, bob, 4);
+                                               // we also need to adjust gunorg, or this appears like pushing the gun!
+                                               // In the old code, this was applied to vieworg BEFORE copying to gunorg,
+                                               // but this is not viable with the new followmodel code as that would mean
+                                               // that followmodel would work on the munged-by-bob vieworg and do feedback
+                                               gunorg[2] += bound(-7, bob, 4);
                                        }
 
+                                       // gun model bobbing code
                                        if (cl_bob.value && cl_bobmodel.value)
                                        {
                                                // calculate for swinging gun model
@@ -589,87 +668,6 @@ void V_CalcRefdef (void)
                                                bob = bspeed * cl_bobmodel_up.value * cl_viewmodel_scale.value * cos (s * 2) * t;
                                                VectorMA (gunorg, bob, up, gunorg);
                                        }
-
-                                       float ef_speed = cl.realframetime * cl_leanmodel_up_speed.value;
-
-                                       // gun model leaning code
-                                       
-                                       // TODO 1 (done): Fix bug where model does a 360* turn when YAW jumps around the 0 - 360 rotation border
-                                       // TODO 2 (done): Implement limits (weapon model must not lean past a certain limit)
-                                       // TODO 3 (done): Cvar everything once the first TODOs are ready
-
-                                       if(cl_leanmodel_up.value && cl_leanmodel_up_speed.value * ef_speed < 1) // bad things happen if this goes over 1, so prevent the effect
-                                       {
-                                               // prevent the gun from doing a 360* rotation when going around the 0 <-> 360 border
-                                               if(cl.viewangles[PITCH] - viewmodel_push_x >= 180)
-                                                       viewmodel_push_x += 360;
-                                               if(viewmodel_push_x - cl.viewangles[PITCH] >= 180)
-                                                       viewmodel_push_x -= 360;
-
-                                               if(viewmodel_push_x < cl.viewangles[PITCH])
-                                               {
-                                                       if(cl.viewangles[PITCH] - viewmodel_push_x > cl_leanmodel_up_limit.value)
-                                                               viewmodel_push_x = cl.viewangles[PITCH] - cl_leanmodel_up_limit.value;
-                                                       else
-                                                               viewmodel_push_x += (cl.viewangles[PITCH] - viewmodel_push_x) * cl_leanmodel_up_speed.value * ef_speed;
-                                               }
-                                               if(viewmodel_push_x > cl.viewangles[PITCH])
-                                               {
-                                                       if(viewmodel_push_x - cl.viewangles[PITCH] > cl_leanmodel_up_limit.value)
-                                                               viewmodel_push_x = cl.viewangles[PITCH] + cl_leanmodel_up_limit.value;
-                                                       else
-                                                               viewmodel_push_x -= (viewmodel_push_x - cl.viewangles[PITCH]) * cl_leanmodel_up_speed.value * ef_speed;
-                                               }
-                                       }
-                                       else
-                                               viewmodel_push_x = cl.viewangles[PITCH];
-
-                                       if(cl_leanmodel_side.value && cl_leanmodel_side_speed.value * ef_speed < 1) // bad things happen if this goes over 1, so prevent the effect
-                                       {
-                                               // prevent the gun from doing a 360* rotation when going around the 0 <-> 360 border
-                                               if(cl.viewangles[YAW] - viewmodel_push_y >= 180)
-                                                       viewmodel_push_y += 360;
-                                               if(viewmodel_push_y - cl.viewangles[YAW] >= 180)
-                                                       viewmodel_push_y -= 360;
-
-                                               if(viewmodel_push_y < cl.viewangles[YAW])
-                                               {
-                                                       if(cl.viewangles[YAW] - viewmodel_push_y > cl_leanmodel_side_limit.value)
-                                                               viewmodel_push_y = cl.viewangles[YAW] - cl_leanmodel_side_limit.value;
-                                                       else
-                                                               viewmodel_push_y += (cl.viewangles[YAW] - viewmodel_push_y) * cl_leanmodel_side_speed.value * ef_speed;
-                                               }
-                                               if(viewmodel_push_y > cl.viewangles[YAW])
-                                               {
-                                                       if(viewmodel_push_y - cl.viewangles[YAW] > cl_leanmodel_side_limit.value)
-                                                               viewmodel_push_y = cl.viewangles[YAW] + cl_leanmodel_side_limit.value;
-                                                       else
-                                                               viewmodel_push_y -= (viewmodel_push_y - cl.viewangles[YAW]) * cl_leanmodel_side_speed.value * ef_speed;
-                                               }
-                                       }
-                                       else
-                                               viewmodel_push_y = cl.viewangles[YAW];
-
-                                       VectorSet(gunangles, viewmodel_push_x, viewmodel_push_y, viewangles[2]);
-
-                               // gun model following code
-
-                               if(gunorg_follow[0] < vieworg[0])
-                                       gunorg_follow[0] += (vieworg[0] - gunorg_follow[0]) * 5 * ef_speed;
-                               if(gunorg_follow[0] > vieworg[0])
-                                       gunorg_follow[0] -= (gunorg_follow[0] - vieworg[0]) * 5 * ef_speed;
-
-                               if(gunorg_follow[1] < vieworg[1])
-                                       gunorg_follow[1] += (vieworg[1] - gunorg_follow[1]) * 5 * ef_speed;
-                               if(gunorg_follow[1] > vieworg[1])
-                                       gunorg_follow[1] -= (gunorg_follow[1] - vieworg[1]) * 5 * ef_speed;
-
-                               if(gunorg_follow[2] < vieworg[2])
-                                       gunorg_follow[2] += (vieworg[2] - gunorg_follow[2]) * 5 * ef_speed;
-                               if(gunorg_follow[2] > vieworg[2])
-                                       gunorg_follow[2] -= (gunorg_follow[2] - vieworg[2]) * 5 * ef_speed;
-
-                               VectorCopy(gunorg_follow, gunorg);
                                }
                        }
                        // calculate a view matrix for rendering the scene
@@ -875,6 +873,13 @@ void V_Init (void)
        Cvar_RegisterVariable (&cl_leanmodel_up_speed);
        Cvar_RegisterVariable (&cl_leanmodel_up_limit);
 
+       Cvar_RegisterVariable (&cl_followmodel_side);
+       Cvar_RegisterVariable (&cl_followmodel_side_speed);
+       Cvar_RegisterVariable (&cl_followmodel_side_limit);
+       Cvar_RegisterVariable (&cl_followmodel_up);
+       Cvar_RegisterVariable (&cl_followmodel_up_speed);
+       Cvar_RegisterVariable (&cl_followmodel_up_limit);
+
        Cvar_RegisterVariable (&cl_viewmodel_scale);
 
        Cvar_RegisterVariable (&v_kicktime);