]> de.git.xonotic.org Git - xonotic/darkplaces.git/blobdiff - world.c
cleaned up entity culling in server code, implemented new option - sv_cullentities_tr...
[xonotic/darkplaces.git] / world.c
diff --git a/world.c b/world.c
index a337aa30f3e83db2cd7de94e2833e75639731e17..5880c7cfe8352242822da1f6d75264170a26bb4b 100644 (file)
--- a/world.c
+++ b/world.c
@@ -8,7 +8,7 @@ of the License, or (at your option) any later version.
 
 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
 See the GNU General Public License for more details.
 
@@ -29,6 +29,55 @@ line of sight checks trace->crosscontent, but bullets don't
 
 */
 
+/*
+typedef struct link_s
+{
+       struct link_s   *prev, *next;
+} link_t;
+*/
+
+
+void ClearLink (link_t *l);
+void RemoveLink (link_t *l);
+void InsertLinkBefore (link_t *l, link_t *before);
+void InsertLinkAfter (link_t *l, link_t *after);
+
+// (type *)STRUCT_FROM_LINK(link_t *link, type, member)
+// ent = STRUCT_FROM_LINK(link,entity_t,order)
+// FIXME: remove this mess!
+//#define      STRUCT_FROM_LINK(l,t,m) ((t *)((byte *)l - (int)&(((t *)0)->m)))
+
+#define        EDICT_FROM_AREA(l) ((edict_t *)((byte *)l - (int)&(((edict_t *)0)->area)))
+
+//============================================================================
+
+// ClearLink is used for new headnodes
+void ClearLink (link_t *l)
+{
+       l->prev = l->next = l;
+}
+
+void RemoveLink (link_t *l)
+{
+       l->next->prev = l->prev;
+       l->prev->next = l->next;
+}
+
+void InsertLinkBefore (link_t *l, link_t *before)
+{
+       l->next = before;
+       l->prev = before->prev;
+       l->prev->next = l;
+       l->next->prev = l;
+}
+void InsertLinkAfter (link_t *l, link_t *after)
+{
+       l->next = after->next;
+       l->prev = after;
+       l->prev->next = l;
+       l->next->prev = l;
+}
+
 
 typedef struct
 {
@@ -138,6 +187,7 @@ hull_t *SV_HullForEntity (edict_t *ent, vec3_t mins, vec3_t maxs, vec3_t offset)
                        Host_Error ("SOLID_BSP without MOVETYPE_PUSH");
 
                model = sv.models[ (int)ent->v.modelindex ];
+               Mod_CheckLoaded(model);
 
                // LordHavoc: fixed SOLID_BSP error message
                if (!model || model->type != mod_brush)
@@ -149,12 +199,29 @@ hull_t *SV_HullForEntity (edict_t *ent, vec3_t mins, vec3_t maxs, vec3_t offset)
 
                VectorSubtract (maxs, mins, size);
                // LordHavoc: FIXME!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-               if (size[0] < 3)
-                       hull = &model->hulls[0];
-               else if (size[0] <= 32)
-                       hull = &model->hulls[1];
+               if (sv.worldmodel->ishlbsp)
+               {
+                       if (size[0] < 3)
+                               hull = &model->hulls[0]; // 0x0x0
+                       else if (size[0] <= 32)
+                       {
+                               if (size[2] < 54) // pick the nearest of 36 or 72
+                                       hull = &model->hulls[3]; // 32x32x36
+                               else
+                                       hull = &model->hulls[1]; // 32x32x72
+                       }
+                       else
+                               hull = &model->hulls[2]; // 64x64x64
+               }
                else
-                       hull = &model->hulls[2];
+               {
+                       if (size[0] < 3)
+                               hull = &model->hulls[0]; // 0x0x0
+                       else if (size[0] <= 32)
+                               hull = &model->hulls[1]; // 32x32x56
+                       else
+                               hull = &model->hulls[2]; // 64x64x88
+               }
 
 // calculate an offset value to center the origin
                VectorSubtract (hull->clip_mins, mins, offset);
@@ -166,7 +233,7 @@ hull_t *SV_HullForEntity (edict_t *ent, vec3_t mins, vec3_t maxs, vec3_t offset)
                VectorSubtract (ent->v.mins, maxs, hullmins);
                VectorSubtract (ent->v.maxs, mins, hullmaxs);
                hull = SV_HullForBox (hullmins, hullmaxs);
-               
+
                VectorCopy (ent->v.origin, offset);
        }
 
@@ -214,28 +281,28 @@ areanode_t *SV_CreateAreaNode (int depth, vec3_t mins, vec3_t maxs)
 
        ClearLink (&anode->trigger_edicts);
        ClearLink (&anode->solid_edicts);
-       
+
        if (depth == AREA_DEPTH)
        {
                anode->axis = -1;
                anode->children[0] = anode->children[1] = NULL;
                return anode;
        }
-       
+
        VectorSubtract (maxs, mins, size);
        if (size[0] > size[1])
                anode->axis = 0;
        else
                anode->axis = 1;
-       
+
        anode->dist = 0.5 * (maxs[anode->axis] + mins[anode->axis]);
-       VectorCopy (mins, mins1);       
-       VectorCopy (mins, mins2);       
-       VectorCopy (maxs, maxs1);       
-       VectorCopy (maxs, maxs2);       
-       
+       VectorCopy (mins, mins1);
+       VectorCopy (mins, mins2);
+       VectorCopy (maxs, maxs1);
+       VectorCopy (maxs, maxs2);
+
        maxs1[anode->axis] = mins2[anode->axis] = anode->dist;
-       
+
        anode->children[0] = SV_CreateAreaNode (depth+1, mins2, maxs2);
        anode->children[1] = SV_CreateAreaNode (depth+1, mins1, maxs1);
 
@@ -251,10 +318,11 @@ SV_ClearWorld
 void SV_ClearWorld (void)
 {
        SV_InitBoxHull ();
-       
+
        memset (sv_areanodes, 0, sizeof(sv_areanodes));
        sv_numareanodes = 0;
-       SV_CreateAreaNode (0, sv.worldmodel->mins, sv.worldmodel->maxs);
+       Mod_CheckLoaded(sv.worldmodel);
+       SV_CreateAreaNode (0, sv.worldmodel->normalmins, sv.worldmodel->normalmaxs);
 }
 
 
@@ -295,11 +363,11 @@ loc0:
                if (!touch->v.touch || touch->v.solid != SOLID_TRIGGER)
                        continue;
                if (ent->v.absmin[0] > touch->v.absmax[0]
-               || ent->v.absmin[1] > touch->v.absmax[1]
-               || ent->v.absmin[2] > touch->v.absmax[2]
-               || ent->v.absmax[0] < touch->v.absmin[0]
-               || ent->v.absmax[1] < touch->v.absmin[1]
-               || ent->v.absmax[2] < touch->v.absmin[2] )
+                || ent->v.absmin[1] > touch->v.absmax[1]
+                || ent->v.absmin[2] > touch->v.absmax[2]
+                || ent->v.absmax[0] < touch->v.absmin[0]
+                || ent->v.absmax[1] < touch->v.absmin[1]
+                || ent->v.absmax[2] < touch->v.absmin[2])
                        continue;
                old_self = pr_global_struct->self;
                old_other = pr_global_struct->other;
@@ -307,16 +375,16 @@ loc0:
                pr_global_struct->self = EDICT_TO_PROG(touch);
                pr_global_struct->other = EDICT_TO_PROG(ent);
                pr_global_struct->time = sv.time;
-               PR_ExecuteProgram (touch->v.touch);
+               PR_ExecuteProgram (touch->v.touch, "");
 
                pr_global_struct->self = old_self;
                pr_global_struct->other = old_other;
        }
-       
+
 // recurse down both sides
        if (node->axis == -1)
                return;
-       
+
        // LordHavoc: optimized recursion
 //     if (ent->v.absmax[node->axis] > node->dist) SV_TouchLinks (ent, node->children[0]);
 //     if (ent->v.absmin[node->axis] < node->dist) SV_TouchLinks (ent, node->children[1]);
@@ -338,63 +406,6 @@ loc0:
 }
 
 
-/*
-===============
-SV_FindTouchedLeafs
-
-===============
-*/
-void SV_FindTouchedLeafs (edict_t *ent, mnode_t *node)
-{
-       mplane_t        *splitplane;
-       mleaf_t         *leaf;
-       int                     sides;
-       int                     leafnum;
-
-loc0:
-       if (node->contents == CONTENTS_SOLID)
-               return;
-       
-// add an efrag if the node is a leaf
-
-       if ( node->contents < 0)
-       {
-               if (ent->num_leafs == MAX_ENT_LEAFS)
-                       return;
-
-               leaf = (mleaf_t *)node;
-               leafnum = leaf - sv.worldmodel->leafs - 1;
-
-               ent->leafnums[ent->num_leafs] = leafnum;
-               ent->num_leafs++;                       
-               return;
-       }
-       
-// NODE_MIXED
-
-       splitplane = node->plane;
-       sides = BOX_ON_PLANE_SIDE(ent->v.absmin, ent->v.absmax, splitplane);
-       
-// recurse down the contacted sides
-       // LordHavoc: optimized recursion
-//     if (sides & 1) SV_FindTouchedLeafs (ent, node->children[0]);
-//     if (sides & 2) SV_FindTouchedLeafs (ent, node->children[1]);
-       switch (sides)
-       {
-       case 1:
-               node = node->children[0];
-               goto loc0;
-       case 2:
-               node = node->children[1];
-               goto loc0;
-       default: // 3
-               if (node->children[0]->contents != CONTENTS_SOLID)
-                       SV_FindTouchedLeafs (ent, node->children[0]);
-               node = node->children[1];
-               goto loc0;
-       }
-}
-
 /*
 ===============
 SV_LinkEdict
@@ -417,21 +428,29 @@ void SV_LinkEdict (edict_t *ent, qboolean touch_triggers)
 // set the abs box
 
 // LordHavoc: enabling rotating bmodels
-       if (ent->v.solid == SOLID_BSP && (ent->v.angles[0] || ent->v.angles[1] || ent->v.angles[2]) )
-       {       // expand for rotation
+       if (ent->v.solid == SOLID_BSP && (ent->v.angles[0] || ent->v.angles[1] || ent->v.angles[2]))
+       {
+               // expand for rotation
                float           max, v;
                int                     i;
 
+               max = DotProduct(ent->v.mins, ent->v.mins);
+               v = DotProduct(ent->v.maxs, ent->v.maxs);
+               if (max < v)
+                       max = v;
+               max = sqrt(max);
+               /*
                max = 0;
                for (i=0 ; i<3 ; i++)
                {
-                       v =fabs( ent->v.mins[i]);
-                       if (v > max)
+                       v = fabs(ent->v.mins[i]);
+                       if (max < v)
                                max = v;
-                       v =fabs( ent->v.maxs[i]);
-                       if (v > max)
+                       v = fabs(ent->v.maxs[i]);
+                       if (max < v)
                                max = v;
                }
+               */
                for (i=0 ; i<3 ; i++)
                {
                        ent->v.absmin[i] = ent->v.origin[i] - max;
@@ -440,7 +459,7 @@ void SV_LinkEdict (edict_t *ent, qboolean touch_triggers)
        }
        else
        {
-               VectorAdd (ent->v.origin, ent->v.mins, ent->v.absmin);  
+               VectorAdd (ent->v.origin, ent->v.mins, ent->v.absmin);
                VectorAdd (ent->v.origin, ent->v.maxs, ent->v.absmax);
        }
 
@@ -456,7 +475,8 @@ void SV_LinkEdict (edict_t *ent, qboolean touch_triggers)
                ent->v.absmax[1] += 15;
        }
        else
-       {       // because movement is clipped an epsilon away from an actual edge,
+       {
+               // because movement is clipped an epsilon away from an actual edge,
                // we must fully check even when bounding boxes don't quite touch
                ent->v.absmin[0] -= 1;
                ent->v.absmin[1] -= 1;
@@ -465,11 +485,6 @@ void SV_LinkEdict (edict_t *ent, qboolean touch_triggers)
                ent->v.absmax[1] += 1;
                ent->v.absmax[2] += 1;
        }
-       
-// link to PVS leafs
-       ent->num_leafs = 0;
-       if (ent->v.modelindex)
-               SV_FindTouchedLeafs (ent, sv.worldmodel->nodes);
 
        if (ent->v.solid == SOLID_NOT)
                return;
@@ -487,14 +502,14 @@ void SV_LinkEdict (edict_t *ent, qboolean touch_triggers)
                else
                        break;          // crosses the node
        }
-       
-// link it in  
+
+// link it in
 
        if (ent->v.solid == SOLID_TRIGGER)
                InsertLinkBefore (&ent->area, &node->trigger_edicts);
        else
                InsertLinkBefore (&ent->area, &node->solid_edicts);
-       
+
 // if touch_triggers, touch all entities at this node and descend for more
        if (touch_triggers)
                SV_TouchLinks ( ent, sv_areanodes );
@@ -510,8 +525,6 @@ POINT TESTING IN HULLS
 ===============================================================================
 */
 
-#if    !id386
-
 /*
 ==================
 SV_HullPointContents
@@ -520,30 +533,12 @@ SV_HullPointContents
 */
 int SV_HullPointContents (hull_t *hull, int num, vec3_t p)
 {
-       dclipnode_t     *node;
-       mplane_t        *plane;
-
        while (num >= 0)
-       {
-               if (num < hull->firstclipnode || num > hull->lastclipnode)
-                       Sys_Error ("SV_HullPointContents: bad node number");
-       
-               node = hull->clipnodes + num;
-               plane = hull->planes + node->planenum;
-               
-// LordHavoc: optimized this slightly (probably no actual impact due to compiler optimization)
-               if (plane->type < 3)
-                       num = node->children[p[plane->type] < plane->dist];
-               else
-                       num = node->children[DotProduct (plane->normal, p) < plane->dist];
-       }
-       
+               num = hull->clipnodes[num].children[(hull->planes[hull->clipnodes[num].planenum].type < 3 ? p[hull->planes[hull->clipnodes[num].planenum].type] : DotProduct (hull->planes[hull->clipnodes[num].planenum].normal, p)) < hull->planes[hull->clipnodes[num].planenum].dist];
+
        return num;
 }
 
-#endif // !id386
-
-
 /*
 ============
 SV_TestEntityPosition
@@ -555,8 +550,8 @@ edict_t     *SV_TestEntityPosition (edict_t *ent)
 {
        trace_t trace;
 
-       trace = SV_Move (ent->v.origin, ent->v.mins, ent->v.maxs, ent->v.origin, 0, ent);
-       
+       trace = SV_Move (ent->v.origin, ent->v.mins, ent->v.maxs, ent->v.origin, MOVE_NORMAL, ent);
+
        if (trace.startsolid)
                return sv.edicts;
                
@@ -573,15 +568,173 @@ LINE TESTING IN HULLS
 */
 
 // 1/32 epsilon to keep floating point happy
-#define        DIST_EPSILON    (0.03125)
+//#define      DIST_EPSILON    (0.03125)
+#define DIST_EPSILON (0.125)
 
-/*
-==================
-SV_RecursiveHullCheck
+#define HULLCHECKSTATE_EMPTY 0
+#define HULLCHECKSTATE_SOLID 1
+#define HULLCHECKSTATE_DONE 2
 
-==================
-*/
-qboolean SV_RecursiveHullCheck (hull_t *hull, int num, float p1f, float p2f, vec3_t p1, vec3_t p2, trace_t *trace)
+// LordHavoc: FIXME: this is not thread safe, if threading matters here, pass
+// this as a struct to RecursiveHullCheck, RecursiveHullCheck_Impact, etc...
+RecursiveHullCheckTraceInfo_t RecursiveHullCheckInfo;
+#define RHC RecursiveHullCheckInfo
+
+void SV_RecursiveHullCheck_Impact (mplane_t *plane, int side)
+{
+       // LordHavoc: using doubles for extra accuracy
+       double t1, t2, frac;
+
+       // LordHavoc: now that we have found the impact, recalculate the impact
+       // point from scratch for maximum accuracy, with an epsilon bias on the
+       // surface distance
+       frac = plane->dist;
+       if (side)
+       {
+               frac -= DIST_EPSILON;
+               VectorNegate (plane->normal, RHC.trace->plane.normal);
+               RHC.trace->plane.dist = -plane->dist;
+       }
+       else
+       {
+               frac += DIST_EPSILON;
+               VectorCopy (plane->normal, RHC.trace->plane.normal);
+               RHC.trace->plane.dist = plane->dist;
+       }
+
+       if (plane->type < 3)
+       {
+               t1 = RHC.start[plane->type] - frac;
+               t2 = RHC.start[plane->type] + RHC.dist[plane->type] - frac;
+       }
+       else
+       {
+               t1 = plane->normal[0] * RHC.start[0] + plane->normal[1] * RHC.start[1] + plane->normal[2] * RHC.start[2] - frac;
+               t2 = plane->normal[0] * (RHC.start[0] + RHC.dist[0]) + plane->normal[1] * (RHC.start[1] + RHC.dist[1]) + plane->normal[2] * (RHC.start[2] + RHC.dist[2]) - frac;
+       }
+
+       frac = t1 / (t1 - t2);
+       frac = bound(0.0f, frac, 1.0f);
+
+       RHC.trace->fraction = frac;
+       RHC.trace->endpos[0] = RHC.start[0] + frac * RHC.dist[0];
+       RHC.trace->endpos[1] = RHC.start[1] + frac * RHC.dist[1];
+       RHC.trace->endpos[2] = RHC.start[2] + frac * RHC.dist[2];
+}
+
+int SV_RecursiveHullCheck (int num, float p1f, float p2f, vec3_t p1, vec3_t p2)
+{
+       dclipnode_t     *node;
+       vec3_t          mid;
+       int                     side;
+       float           midf;
+       // LordHavoc: FIXME: this is not thread safe...  if threading matters here,
+       // remove the static prefixes
+       static int ret;
+       static mplane_t *plane;
+       static float t1, t2, frac;
+
+       // LordHavoc: a goto!  everyone flee in terror... :)
+loc0:
+       // check for empty
+       if (num < 0)
+       {
+               RHC.trace->endcontents = num;
+               if (RHC.trace->startcontents)
+               {
+                       if (num == RHC.trace->startcontents)
+                               RHC.trace->allsolid = false;
+                       else
+                       {
+                               // if the first leaf is solid, set startsolid
+                               if (RHC.trace->allsolid)
+                                       RHC.trace->startsolid = true;
+                               return HULLCHECKSTATE_SOLID;
+                       }
+                       return HULLCHECKSTATE_EMPTY;
+               }
+               else
+               {
+                       if (num != CONTENTS_SOLID)
+                       {
+                               RHC.trace->allsolid = false;
+                               if (num == CONTENTS_EMPTY)
+                                       RHC.trace->inopen = true;
+                               else
+                                       RHC.trace->inwater = true;
+                       }
+                       else
+                       {
+                               // if the first leaf is solid, set startsolid
+                               if (RHC.trace->allsolid)
+                                       RHC.trace->startsolid = true;
+                               return HULLCHECKSTATE_SOLID;
+                       }
+                       return HULLCHECKSTATE_EMPTY;
+               }
+       }
+
+       // find the point distances
+       node = RHC.hull->clipnodes + num;
+
+       plane = RHC.hull->planes + node->planenum;
+       if (plane->type < 3)
+       {
+               t1 = p1[plane->type] - plane->dist;
+               t2 = p2[plane->type] - plane->dist;
+       }
+       else
+       {
+               t1 = DotProduct (plane->normal, p1) - plane->dist;
+               t2 = DotProduct (plane->normal, p2) - plane->dist;
+       }
+
+       // LordHavoc: rearranged the side/frac code
+       if (t1 >= 0)
+       {
+               if (t2 >= 0)
+               {
+                       num = node->children[0];
+                       goto loc0;
+               }
+               // put the crosspoint DIST_EPSILON pixels on the near side
+               side = 0;
+       }
+       else
+       {
+               if (t2 < 0)
+               {
+                       num = node->children[1];
+                       goto loc0;
+               }
+               // put the crosspoint DIST_EPSILON pixels on the near side
+               side = 1;
+       }
+
+       frac = t1 / (t1 - t2);
+       frac = bound(0.0f, frac, 1.0f);
+
+       midf = p1f + ((p2f - p1f) * frac);
+       mid[0] = RHC.start[0] + midf * RHC.dist[0];
+       mid[1] = RHC.start[1] + midf * RHC.dist[1];
+       mid[2] = RHC.start[2] + midf * RHC.dist[2];
+
+       // front side first
+       ret = SV_RecursiveHullCheck (node->children[side], p1f, midf, p1, mid);
+       if (ret != HULLCHECKSTATE_EMPTY)
+               return ret; // solid or done
+       ret = SV_RecursiveHullCheck (node->children[!side], midf, p2f, mid, p2);
+       if (ret != HULLCHECKSTATE_SOLID)
+               return ret; // empty or done
+
+       // front is air and back is solid, this is the impact point...
+       SV_RecursiveHullCheck_Impact(RHC.hull->planes + node->planenum, side);
+
+       return HULLCHECKSTATE_DONE;
+}
+
+/*
+qboolean SV_RecursiveHullCheckContentBoundary (hull_t *hull, int num, float p1f, float p2f, vec3_t p1, vec3_t p2, trace_t *trace)
 {
        dclipnode_t     *node;
        mplane_t        *plane;
@@ -592,29 +745,19 @@ qboolean SV_RecursiveHullCheck (hull_t *hull, int num, float p1f, float p2f, vec
        int                     side;
        float           midf;
 
+       // LordHavoc: a goto!  everyone flee in terror... :)
 loc0:
 // check for empty
        if (num < 0)
        {
-               if (num != CONTENTS_SOLID)
-               {
-                       trace->allsolid = false;
-                       if (num == CONTENTS_EMPTY)
-                               trace->inopen = true;
-                       else
-                               trace->inwater = true;
-               }
-               else
+               if (num != trace->startcontents)
                        trace->startsolid = true;
+               else
+                       trace->allsolid = false;
                return true;            // empty
        }
 
-       if (num < hull->firstclipnode || num > hull->lastclipnode)
-               Sys_Error ("SV_RecursiveHullCheck: bad node number");
-
-//
 // find the point distances
-//
        node = hull->clipnodes + num;
        plane = hull->planes + node->planenum;
 
@@ -628,72 +771,62 @@ loc0:
                t1 = DotProduct (plane->normal, p1) - plane->dist;
                t2 = DotProduct (plane->normal, p2) - plane->dist;
        }
-       
-#if 1
-       if (t1 >= 0 && t2 >= 0)
-       // LordHavoc: optimized recursion
-//             return SV_RecursiveHullCheck (hull, node->children[0], p1f, p2f, p1, p2, trace);
+
+       // LordHavoc: rearranged the side/frac code
+       // LordHavoc: recursion optimization
+       if (t1 >= 0)
        {
-               num = node->children[0];
-               goto loc0;
+               if (t2 >= 0)
+               {
+                       num = node->children[0];
+                       goto loc0;
+               }
+               // put the crosspoint DIST_EPSILON pixels on the near side
+               side = 0;
        }
-       if (t1 < 0 && t2 < 0)
-//             return SV_RecursiveHullCheck (hull, node->children[1], p1f, p2f, p1, p2, trace);
+       else
        {
-               num = node->children[1];
-               goto loc0;
+               if (t2 < 0)
+               {
+                       num = node->children[1];
+                       goto loc0;
+               }
+               // put the crosspoint DIST_EPSILON pixels on the near side
+               side = 1;
        }
-#else
-       if ( (t1 >= DIST_EPSILON && t2 >= DIST_EPSILON) || (t2 > t1 && t1 >= 0) )
-               return SV_RecursiveHullCheck (hull, node->children[0], p1f, p2f, p1, p2, trace);
-       if ( (t1 <= -DIST_EPSILON && t2 <= -DIST_EPSILON) || (t2 < t1 && t1 <= 0) )
-               return SV_RecursiveHullCheck (hull, node->children[1], p1f, p2f, p1, p2, trace);
-#endif
 
-// put the crosspoint DIST_EPSILON pixels on the near side
-       if (t1 < 0)
-               frac = (t1 + DIST_EPSILON)/(t1-t2);
-       else
-               frac = (t1 - DIST_EPSILON)/(t1-t2);
-       if (frac < 0)
-               frac = 0;
-       if (frac > 1)
-               frac = 1;
-               
-       midf = p1f + (p2f - p1f)*frac;
-       for (i=0 ; i<3 ; i++)
-               mid[i] = p1[i] + frac*(p2[i] - p1[i]);
+       frac = t1 / (t1 - t2);
+       frac = bound(0.0f, frac, 1.0f);
 
-       side = (t1 < 0);
+       midf = p1f + ((p2f - p1f) * frac);
+       mid[0] = p1[0] + ((p2[0] - p1[0]) * frac);
+       mid[1] = p1[1] + ((p2[1] - p1[1]) * frac);
+       mid[2] = p1[2] + ((p2[2] - p1[2]) * frac);
 
 // move up to the node
        if (!SV_RecursiveHullCheck (hull, node->children[side], p1f, midf, p1, mid, trace) )
                return false;
 
+*/
+       /*
 #ifdef PARANOID
-       if (SV_HullPointContents (hull, node->children[side], mid) == CONTENTS_SOLID)
+       if (SV_HullPointContents (pm_hullmodel, mid, node->children[side]) != trace->startcontents)
        {
                Con_Printf ("mid PointInHullSolid\n");
                return false;
        }
 #endif
-       
-       if (SV_HullPointContents (hull, node->children[side^1], mid) != CONTENTS_SOLID)
+       */
+/*
+
+       // LordHavoc: warning to the clumsy, this recursion can not be optimized because mid would need to be duplicated on a stack
+       if (SV_HullPointContents (hull, node->children[side^1], mid) == trace->startcontents)
 // go past the node
                return SV_RecursiveHullCheck (hull, node->children[side^1], midf, p2f, mid, p2, trace);
-       // mid would need to be duplicated during recursion...
-       /*
-       {
-               p1f = midf;
-               p1 = mid;
-               num = node->children[side^1];
-               goto loc0;
-       }
-       */
 
        if (trace->allsolid)
                return false;           // never got out of the solid area
-       
+
 //==================
 // the other side of the node is solid, this is the impact point
 //==================
@@ -704,16 +837,15 @@ loc0:
        }
        else
        {
-               // LordHavoc: unrolled vector operation because the compiler can't be sure vec3_origin is 0
-//             VectorSubtract (vec3_origin, plane->normal, trace->plane.normal);
-               trace->plane.normal[0] = -plane->normal[0];
-               trace->plane.normal[1] = -plane->normal[1];
-               trace->plane.normal[2] = -plane->normal[2];
+               VectorNegate (plane->normal, trace->plane.normal);
                trace->plane.dist = -plane->dist;
        }
 
-       while (SV_HullPointContents (hull, hull->firstclipnode, mid) == CONTENTS_SOLID)
-       { // shouldn't really happen, but does occasionally
+*/
+       /*
+       while (SV_HullPointContents (hull, hull->firstclipnode, mid) != trace->startcontents)
+       {
+               // shouldn't really happen, but does occasionally
                frac -= 0.1;
                if (frac < 0)
                {
@@ -723,15 +855,147 @@ loc0:
                        return false;
                }
                midf = p1f + (p2f - p1f)*frac;
-               for (i=0 ; i<3 ; i++)
-                       mid[i] = p1[i] + frac*(p2[i] - p1[i]);
+               mid[0] = p1[0] + frac*(p2[0] - p1[0]);
+               mid[1] = p1[1] + frac*(p2[1] - p1[1]);
+               mid[2] = p1[2] + frac*(p2[2] - p1[2]);
        }
+       */
+/*
+
+       frac = t1;
+       if (side)
+               frac += DIST_EPSILON;
+       else
+               frac -= DIST_EPSILON;
 
-       trace->fraction = midf;
-       VectorCopy (mid, trace->endpos);
+       frac /= (t1 - t2);
+       frac = bound(0.0f, frac, 1.0f);
+
+       trace->fraction = p1f + (p2f - p1f)*frac;
+       trace->endpos[0] = p1[0] + frac*(p2[0] - p1[0]);
+       trace->endpos[1] = p1[1] + frac*(p2[1] - p1[1]);
+       trace->endpos[2] = p1[2] + frac*(p2[2] - p1[2]);
 
        return false;
 }
+*/
+
+/*
+// FIXME: this is broken and I'm not interested in figuring out what is broken about it right now
+qboolean SV_TestLine (hull_t *hull, int num, vec3_t p1, vec3_t p2)
+{
+       dclipnode_t     *node;
+       mplane_t        *plane;
+       float           t1, t2, frac;
+       vec3_t          mid;
+       int                     side;
+
+loc0:
+// check for empty
+       if (num < 0)
+               return num != CONTENTS_SOLID;
+
+       if (num < hull->firstclipnode || num > hull->lastclipnode)
+               Sys_Error ("SV_RecursiveHullCheck: bad node number");
+
+//
+// find the point distances
+//
+       node = hull->clipnodes + num;
+       if (node->children[0] < 0)
+       {
+               if (node->children[0] == CONTENTS_SOLID)
+                       return false;
+               if (node->children[1] < 0)
+                       return node->children[1] != CONTENTS_SOLID;
+       }
+       else if (node->children[1] == CONTENTS_SOLID)
+               return false;
+
+       plane = hull->planes + node->planenum;
+
+       if (plane->type < 3)
+       {
+               t1 = p1[plane->type] - plane->dist;
+               t2 = p2[plane->type] - plane->dist;
+       }
+       else
+       {
+               t1 = DotProduct (plane->normal, p1) - plane->dist;
+               t2 = DotProduct (plane->normal, p2) - plane->dist;
+       }
+
+       if (t1 >= 0)
+       {
+               if (t2 >= 0)
+               {
+                       num = node->children[0];
+                       goto loc0;
+               }
+               side = 0;
+       }
+       else
+       {
+               if (t2 < 0)
+               {
+                       num = node->children[1];
+                       goto loc0;
+               }
+               side = 1;
+       }
+
+       if (node->children[side] < 0)
+       {
+               if (node->children[side] == CONTENTS_SOLID)
+                       return false;
+
+               if (node->children[!side] < 0)
+                       return node->children[!side] != CONTENTS_SOLID;
+               else
+               {
+                       frac = t1 / (t1 - t2);
+                       frac = bound(0, frac, 1);
+
+                       mid[0] = p1[0] + frac*(p2[0] - p1[0]);
+                       mid[1] = p1[1] + frac*(p2[1] - p1[1]);
+                       mid[2] = p1[2] + frac*(p2[2] - p1[2]);
+
+                       return SV_TestLine(hull, node->children[!side], mid, p2);
+               }
+       }
+       else
+       {
+               if (node->children[!side] < 0)
+               {
+                       if (node->children[!side] == CONTENTS_SOLID)
+                               return false;
+
+                       frac = t1 / (t1 - t2);
+                       frac = bound(0, frac, 1);
+
+                       mid[0] = p1[0] + frac*(p2[0] - p1[0]);
+                       mid[1] = p1[1] + frac*(p2[1] - p1[1]);
+                       mid[2] = p1[2] + frac*(p2[2] - p1[2]);
+
+                       return SV_TestLine(hull, node->children[side], p1, mid);
+               }
+               else
+               {
+                       frac = t1 / (t1 - t2);
+                       frac = bound(0, frac, 1);
+
+                       mid[0] = p1[0] + frac*(p2[0] - p1[0]);
+                       mid[1] = p1[1] + frac*(p2[1] - p1[1]);
+                       mid[2] = p1[2] + frac*(p2[2] - p1[2]);
+
+                       if (SV_TestLine(hull, node->children[side], p1, mid))
+                               return SV_TestLine(hull, node->children[!side], mid, p2);
+                       else
+                               return false;
+               }
+       }
+}
+*/
 
 
 /*
@@ -763,8 +1027,7 @@ trace_t SV_ClipMoveToEntity (edict_t *ent, vec3_t start, vec3_t mins, vec3_t max
 
 // LordHavoc: enabling rotating bmodels
        // rotate start and end into the models frame of reference
-       if (ent->v.solid == SOLID_BSP && 
-       (ent->v.angles[0] || ent->v.angles[1] || ent->v.angles[2]) )
+       if (ent->v.solid == SOLID_BSP && (ent->v.angles[0] || ent->v.angles[1] || ent->v.angles[2]))
        {
                vec3_t  forward, right, up;
                vec3_t  temp;
@@ -782,13 +1045,16 @@ trace_t SV_ClipMoveToEntity (edict_t *ent, vec3_t start, vec3_t mins, vec3_t max
                end_l[2] = DotProduct (temp, up);
        }
 
-// trace a line through the apropriate clipping hull
-       SV_RecursiveHullCheck (hull, hull->firstclipnode, 0, 1, start_l, end_l, &trace);
+// trace a line through the appropriate clipping hull
+       VectorCopy(start_l, RecursiveHullCheckInfo.start);
+       VectorSubtract(end_l, start_l, RecursiveHullCheckInfo.dist);
+       RecursiveHullCheckInfo.hull = hull;
+       RecursiveHullCheckInfo.trace = &trace;
+       SV_RecursiveHullCheck (hull->firstclipnode, 0, 1, start_l, end_l);
 
 // LordHavoc: enabling rotating bmodels
        // rotate endpos back to world frame of reference
-       if (ent->v.solid == SOLID_BSP && 
-       (ent->v.angles[0] || ent->v.angles[1] || ent->v.angles[2]) )
+       if (ent->v.solid == SOLID_BSP && (ent->v.angles[0] || ent->v.angles[1] || ent->v.angles[2]))
        {
                vec3_t  a;
                vec3_t  forward, right, up;
@@ -796,7 +1062,7 @@ trace_t SV_ClipMoveToEntity (edict_t *ent, vec3_t start, vec3_t mins, vec3_t max
 
                if (trace.fraction != 1)
                {
-                       VectorSubtract (vec3_origin, ent->v.angles, a);
+                       VectorNegate (ent->v.angles, a);
                        AngleVectors (a, forward, right, up);
 
                        VectorCopy (trace.endpos, temp);
@@ -854,14 +1120,14 @@ loc0:
                        continue;
 
                if (clip->boxmins[0] > touch->v.absmax[0]
-               || clip->boxmins[1] > touch->v.absmax[1]
-               || clip->boxmins[2] > touch->v.absmax[2]
-               || clip->boxmaxs[0] < touch->v.absmin[0]
-               || clip->boxmaxs[1] < touch->v.absmin[1]
-               || clip->boxmaxs[2] < touch->v.absmin[2] )
+                || clip->boxmins[1] > touch->v.absmax[1]
+                || clip->boxmins[2] > touch->v.absmax[2]
+                || clip->boxmaxs[0] < touch->v.absmin[0]
+                || clip->boxmaxs[1] < touch->v.absmin[1]
+                || clip->boxmaxs[2] < touch->v.absmin[2])
                        continue;
 
-               if (clip->passedict!=0 && clip->passedict->v.size[0] && !touch->v.size[0])
+               if (clip->passedict != NULL && clip->passedict->v.size[0] && !touch->v.size[0])
                        continue;       // points never interact
 
        // might intersect, so do an exact clip
@@ -884,8 +1150,7 @@ loc0:
                        trace = SV_ClipMoveToEntity (touch, clip->start, clip->mins2, clip->maxs2, clip->end);
                else
                        trace = SV_ClipMoveToEntity (touch, clip->start, clip->mins, clip->maxs, clip->end);
-               if (trace.allsolid || trace.startsolid ||
-               trace.fraction < clip->trace.fraction)
+               if (trace.allsolid || trace.startsolid || trace.fraction < clip->trace.fraction)
                {
                        trace.ent = touch;
                        if (clip->trace.startsolid)
@@ -899,7 +1164,7 @@ loc0:
                else if (trace.startsolid)
                        clip->trace.startsolid = true;
        }
-       
+
 // recurse down both sides
        if (node->axis == -1)
                return;
@@ -987,7 +1252,7 @@ trace_t SV_Move (vec3_t start, vec3_t mins, vec3_t maxs, vec3_t end, int type, e
                VectorCopy (mins, clip.mins2);
                VectorCopy (maxs, clip.maxs2);
        }
-       
+
 // create the bounding box of the entire move
        SV_MoveBounds ( start, clip.mins2, clip.maxs2, end, clip.boxmins, clip.boxmaxs );