X-Git-Url: http://de.git.xonotic.org/?p=xonotic%2Fdarkplaces.git;a=blobdiff_plain;f=pr_execprogram.h;h=9cc8ed4c35ed6d34b3ec63a2f56715b437028276;hp=524ca44feddd1efdd49242dbf3d74c033c5ac1e7;hb=0c263ee4bea3892b59f8d66858f35171a638e115;hpb=d57be67cb00229acb8564b92c8b7c58eeed8a0cb

diff --git a/pr_execprogram.h b/pr_execprogram.h
index 524ca44f..9cc8ed4c 100644
--- a/pr_execprogram.h
+++ b/pr_execprogram.h
@@ -1,14 +1,25 @@
+
+// This code isn't #ifdef/#define protectable, don't try.
+
 		while (1)
 		{
 			st++;
-			if (++profile > 1000000) // LordHavoc: increased runaway loop limit 10x
+			if (++profile > 10000000) // LordHavoc: increased runaway loop limit 100x
 			{
+				// LordHavoc: update profile counter for debugging reasons
+				// (identifying erroneous loops and recursion patterns)
+				pr_xfunction->profile += profile - startprofile;
+				startprofile = profile;
+				// update the statement number before we error out
 				pr_xstatement = st - pr_statements;
-				PR_RunError ("runaway loop error");
+				Host_Error("runaway loop counter hit limit of %d opcodes\ntip: if having trouble identifying the problem, try typing profile now", profile);
 			}
 
 #if PRTRACE
-			PR_PrintStatement (st);
+			pr_xfunction->profile += profile - startprofile;
+			startprofile = profile;
+			pr_xstatement = st - pr_statements;
+			PR_PrintStatement(st);
 #endif
 
 			switch (st->op)
@@ -79,13 +90,13 @@
 				OPC->_float = !OPA->vector[0] && !OPA->vector[1] && !OPA->vector[2];
 				break;
 			case OP_NOT_S:
-				OPC->_float = !OPA->string || !pr_strings[OPA->string];
+				OPC->_float = !OPA->string || !*PR_GetString(OPA->string);
 				break;
 			case OP_NOT_FNC:
 				OPC->_float = !OPA->function;
 				break;
 			case OP_NOT_ENT:
-				OPC->_float = (PROG_TO_EDICT(OPA->edict) == sv.edicts);
+				OPC->_float = (OPA->edict == 0);
 				break;
 			case OP_EQ_F:
 				OPC->_float = OPA->_float == OPB->_float;
@@ -94,7 +105,7 @@
 				OPC->_float = (OPA->vector[0] == OPB->vector[0]) && (OPA->vector[1] == OPB->vector[1]) && (OPA->vector[2] == OPB->vector[2]);
 				break;
 			case OP_EQ_S:
-				OPC->_float = !strcmp(pr_strings+OPA->string,pr_strings+OPB->string);
+				OPC->_float = !strcmp(PR_GetString(OPA->string),PR_GetString(OPB->string));
 				break;
 			case OP_EQ_E:
 				OPC->_float = OPA->_int == OPB->_int;
@@ -109,7 +120,7 @@
 				OPC->_float = (OPA->vector[0] != OPB->vector[0]) || (OPA->vector[1] != OPB->vector[1]) || (OPA->vector[2] != OPB->vector[2]);
 				break;
 			case OP_NE_S:
-				OPC->_float = strcmp(pr_strings+OPA->string,pr_strings+OPB->string);
+				OPC->_float = strcmp(PR_GetString(OPA->string),PR_GetString(OPB->string));
 				break;
 			case OP_NE_E:
 				OPC->_float = OPA->_int != OPB->_int;
@@ -127,9 +138,9 @@
 				OPB->_int = OPA->_int;
 				break;
 			case OP_STORE_V:
-				OPB->vector[0] = OPA->vector[0];
-				OPB->vector[1] = OPA->vector[1];
-				OPB->vector[2] = OPA->vector[2];
+				OPB->ivector[0] = OPA->ivector[0];
+				OPB->ivector[1] = OPA->ivector[1];
+				OPB->ivector[2] = OPA->ivector[2];
 				break;
 
 			case OP_STOREP_F:
@@ -140,30 +151,28 @@
 #if PRBOUNDSCHECK
 				if (OPB->_int < 0 || OPB->_int + 4 > pr_edictareasize)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to write to an out of bounds edict\n");
-					return;
-				}
-				if (OPB->_int % pr_edict_size < ((byte *)&sv.edicts->v - (byte *)sv.edicts))
-				{
-					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to write to an engine edict field\n");
+					Host_Error("Progs attempted to write to an out of bounds edict (%i)\n", OPB->_int);
 					return;
 				}
 #endif
-				ptr = (eval_t *)((byte *)sv.edicts + OPB->_int);
+				ptr = (eval_t *)((qbyte *)sv.edictsfields + OPB->_int);
 				ptr->_int = OPA->_int;
 				break;
 			case OP_STOREP_V:
 #if PRBOUNDSCHECK
 				if (OPB->_int < 0 || OPB->_int + 12 > pr_edictareasize)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to write to an out of bounds edict\n");
+					Host_Error("Progs attempted to write to an out of bounds edict (%i)\n", OPB->_int);
 					return;
 				}
 #endif
-				ptr = (eval_t *)((byte *)sv.edicts + OPB->_int);
+				ptr = (eval_t *)((qbyte *)sv.edictsfields + OPB->_int);
 				ptr->vector[0] = OPA->vector[0];
 				ptr->vector[1] = OPA->vector[1];
 				ptr->vector[2] = OPA->vector[2];
@@ -171,43 +180,25 @@
 
 			case OP_ADDRESS:
 #if PRBOUNDSCHECK
-				if (OPA->edict <= 0)
-				{
-					if (OPA->edict == 0 && sv.state == ss_active)
-					{
-						pr_xstatement = st - pr_statements;
-						PR_RunError ("assignment to world entity");
-						return;
-					}
-					else
-					{
-						pr_xstatement = st - pr_statements;
-						PR_RunError("Progs attempted to address an out of bounds edict\n");
-						return;
-					}
-				}
-				else if (OPA->edict >= pr_edictareasize)
+				if ((unsigned int)(OPB->_int) >= (unsigned int)(progs->entityfields))
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to address an out of bounds edict\n");
+					Host_Error("Progs attempted to address an invalid field (%i) in an edict\n", OPB->_int);
 					return;
 				}
-				if (OPB->_int < 0 || OPB->_int >= progs->entityfields)
-				{
-					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to address an invalid field in an edict\n");
-					return;
-				}
-#else
+#endif
 				if (OPA->edict == 0 && sv.state == ss_active)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError ("assignment to world entity");
+					Host_Error("assignment to world entity");
 					return;
 				}
-#endif
 				ed = PROG_TO_EDICT(OPA->edict);
-				OPC->_int = (byte *)((int *)&ed->v + OPB->_int) - (byte *)sv.edicts;
+				OPC->_int = (qbyte *)((int *)ed->v + OPB->_int) - (qbyte *)sv.edictsfields;
 				break;
 
 			case OP_LOAD_F:
@@ -216,42 +207,34 @@
 			case OP_LOAD_S:
 			case OP_LOAD_FNC:
 #if PRBOUNDSCHECK
-				if (OPA->edict < 0 || OPA->edict >= pr_edictareasize)
-				{
-					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an out of bounds edict number\n");
-					return;
-				}
-				if (OPB->_int < 0 || OPB->_int >= progs->entityfields)
+				if ((unsigned int)(OPB->_int) >= (unsigned int)(progs->entityfields))
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an invalid field in an edict\n");
+					Host_Error("Progs attempted to read an invalid field in an edict (%i)\n", OPB->_int);
 					return;
 				}
 #endif
 				ed = PROG_TO_EDICT(OPA->edict);
-				OPC->_int = ((eval_t *)((int *)&ed->v + OPB->_int))->_int;
+				OPC->_int = ((eval_t *)((int *)ed->v + OPB->_int))->_int;
 				break;
 
 			case OP_LOAD_V:
 #if PRBOUNDSCHECK
-				if (OPA->edict < 0 || OPA->edict >= pr_edictareasize)
-				{
-					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an out of bounds edict number\n");
-					return;
-				}
 				if (OPB->_int < 0 || OPB->_int + 2 >= progs->entityfields)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an invalid field in an edict\n");
+					Host_Error("Progs attempted to read an invalid field in an edict (%i)\n", OPB->_int);
 					return;
 				}
 #endif
 				ed = PROG_TO_EDICT(OPA->edict);
-				OPC->vector[0] = ((eval_t *)((int *)&ed->v + OPB->_int))->vector[0];
-				OPC->vector[1] = ((eval_t *)((int *)&ed->v + OPB->_int))->vector[1];
-				OPC->vector[2] = ((eval_t *)((int *)&ed->v + OPB->_int))->vector[2];
+				OPC->vector[0] = ((eval_t *)((int *)ed->v + OPB->_int))->vector[0];
+				OPC->vector[1] = ((eval_t *)((int *)ed->v + OPB->_int))->vector[1];
+				OPC->vector[2] = ((eval_t *)((int *)ed->v + OPB->_int))->vector[2];
 				break;
 
 		//==================
@@ -284,16 +267,19 @@
 				pr_xstatement = st - pr_statements;
 				pr_argc = st->op - OP_CALL0;
 				if (!OPA->function)
-					PR_RunError ("NULL function");
+					Host_Error("NULL function");
 
 				newf = &pr_functions[OPA->function];
 
 				if (newf->first_statement < 0)
 				{
 					// negative statements are built in functions
-					if ((-newf->first_statement) >= pr_numbuiltins)
-						PR_RunError ("Bad builtin call number");
-					pr_builtins[-newf->first_statement] ();
+					int builtinnumber = -newf->first_statement;
+					pr_xfunction->builtinsprofile++;
+					if (builtinnumber < pr_numbuiltins && pr_builtins[builtinnumber])
+						pr_builtins[builtinnumber]();
+					else
+						Host_Error("No such builtin #%i", builtinnumber);
 				}
 				else
 					st = pr_statements + PR_EnterFunction(newf);
@@ -301,6 +287,10 @@
 
 			case OP_DONE:
 			case OP_RETURN:
+				pr_xfunction->profile += profile - startprofile;
+				startprofile = profile;
+				pr_xstatement = st - pr_statements;
+
 				pr_globals[OFS_RETURN] = pr_globals[(unsigned short) st->a];
 				pr_globals[OFS_RETURN+1] = pr_globals[(unsigned short) st->a+1];
 				pr_globals[OFS_RETURN+2] = pr_globals[(unsigned short) st->a+2];
@@ -313,10 +303,13 @@
 				break;
 
 			case OP_STATE:
+				pr_xfunction->profile += profile - startprofile;
+				startprofile = profile;
+				pr_xstatement = st - pr_statements;
 				ed = PROG_TO_EDICT(pr_global_struct->self);
-				ed->v.nextthink = pr_global_struct->time + 0.1;
-				ed->v.frame = OPA->_float;
-				ed->v.think = OPB->function;
+				ed->v->nextthink = pr_global_struct->time + 0.1;
+				ed->v->frame = OPA->_float;
+				ed->v->think = OPB->function;
 				break;
 
 // LordHavoc: to be enabled when Progs version 7 (or whatever it will be numbered) is finalized
@@ -476,37 +469,37 @@
 #if PRBOUNDSCHECK
 				if (OPB->_int < 0 || OPB->_int + 4 > pr_edictareasize)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to write to an out of bounds edict\n");
-					return;
-				}
-				if (OPB->_int % pr_edict_size < ((byte *)&sv.edicts->v - (byte *)sv.edicts))
-				{
-					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to write to an engine edict field\n");
+					Host_Error("Progs attempted to write to an out of bounds edict\n");
 					return;
 				}
 #endif
-				ptr = (eval_t *)((byte *)sv.edicts + OPB->_int);
+				ptr = (eval_t *)((qbyte *)sv.edictsfields + OPB->_int);
 				ptr->_int = OPA->_int;
 				break;
 			case OP_LOAD_I:
 #if PRBOUNDSCHECK
 				if (OPA->edict < 0 || OPA->edict >= pr_edictareasize)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an out of bounds edict number\n");
+					Host_Error("Progs attempted to read an out of bounds edict number\n");
 					return;
 				}
 				if (OPB->_int < 0 || OPB->_int >= progs->entityfields)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an invalid field in an edict\n");
+					Host_Error("Progs attempted to read an invalid field in an edict\n");
 					return;
 				}
 #endif
 				ed = PROG_TO_EDICT(OPA->edict);
-				OPC->_int = ((eval_t *)((int *)&ed->v + OPB->_int))->_int;
+				OPC->_int = ((eval_t *)((int *)ed->v + OPB->_int))->_int;
 				break;
 
 			case OP_GSTOREP_I:
@@ -518,8 +511,10 @@
 #if PRBOUNDSCHECK
 				if (OPB->_int < 0 || OPB->_int >= pr_globaldefs)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to write to an invalid indexed global\n");
+					Host_Error("Progs attempted to write to an invalid indexed global\n");
 					return;
 				}
 #endif
@@ -529,8 +524,10 @@
 #if PRBOUNDSCHECK
 				if (OPB->_int < 0 || OPB->_int + 2 >= pr_globaldefs)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to write to an invalid indexed global\n");
+					Host_Error("Progs attempted to write to an invalid indexed global\n");
 					return;
 				}
 #endif
@@ -544,8 +541,10 @@
 #if PRBOUNDSCHECK
 				if (i < 0 || i >= pr_globaldefs)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to address an out of bounds global\n");
+					Host_Error("Progs attempted to address an out of bounds global\n");
 					return;
 				}
 #endif
@@ -561,8 +560,10 @@
 #if PRBOUNDSCHECK
 				if (OPA->_int < 0 || OPA->_int >= pr_globaldefs)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an invalid indexed global\n");
+					Host_Error("Progs attempted to read an invalid indexed global\n");
 					return;
 				}
 #endif
@@ -573,8 +574,10 @@
 #if PRBOUNDSCHECK
 				if (OPA->_int < 0 || OPA->_int + 2 >= pr_globaldefs)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs attempted to read an invalid indexed global\n");
+					Host_Error("Progs attempted to read an invalid indexed global\n");
 					return;
 				}
 #endif
@@ -586,8 +589,10 @@
 			case OP_BOUNDCHECK:
 				if (OPA->_int < 0 || OPA->_int >= st->b)
 				{
+					pr_xfunction->profile += profile - startprofile;
+					startprofile = profile;
 					pr_xstatement = st - pr_statements;
-					PR_RunError("Progs boundcheck failed at line number %d, value is < 0 or >= %d\n", st->b, st->c);
+					Host_Error("Progs boundcheck failed at line number %d, value is < 0 or >= %d\n", st->b, st->c);
 					return;
 				}
 				break;
@@ -595,7 +600,10 @@
 */
 
 			default:
+				pr_xfunction->profile += profile - startprofile;
+				startprofile = profile;
 				pr_xstatement = st - pr_statements;
-				PR_RunError ("Bad opcode %i", st->op);
+				Host_Error ("Bad opcode %i", st->op);
 			}
 		}
+