X-Git-Url: http://de.git.xonotic.org/?p=xonotic%2Fdarkplaces.git;a=blobdiff_plain;f=sv_user.c;h=548a1298dd62eafa2469e84d2c283d64201c81a3;hp=7015dd5011f4b35539296d0df1e9be79bea43710;hb=65c1200fa869c82dc83f04c5bb43d91742669c6a;hpb=8da5e844ba7488e7bc78b4f18fe5324f1526a6d0 diff --git a/sv_user.c b/sv_user.c index 7015dd50..548a1298 100644 --- a/sv_user.c +++ b/sv_user.c @@ -20,15 +20,11 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. // sv_user.c -- server code for moving users #include "quakedef.h" - -cvar_t sv_edgefriction = {0, "edgefriction", "2"}; -cvar_t sv_deltacompress = {0, "sv_deltacompress", "1"}; -cvar_t sv_idealpitchscale = {0, "sv_idealpitchscale","0.8"}; -cvar_t sv_maxspeed = {CVAR_NOTIFY, "sv_maxspeed", "320"}; -cvar_t sv_accelerate = {0, "sv_accelerate", "10"}; +#include "sv_demo.h" +#define DEBUGMOVES 0 static usercmd_t cmd; - +extern cvar_t sv_autodemo_perclient; /* =============== @@ -38,31 +34,31 @@ SV_SetIdealPitch #define MAX_FORWARD 6 void SV_SetIdealPitch (void) { - float angleval, sinval, cosval; + float angleval, sinval, cosval, step, dir; trace_t tr; vec3_t top, bottom; float z[MAX_FORWARD]; int i, j; - int step, dir, steps; + int steps; - if (!((int)host_client->edict->v->flags & FL_ONGROUND)) + if (!((int)host_client->edict->fields.server->flags & FL_ONGROUND)) return; - angleval = host_client->edict->v->angles[YAW] * M_PI*2 / 360; + angleval = host_client->edict->fields.server->angles[YAW] * M_PI*2 / 360; sinval = sin(angleval); cosval = cos(angleval); for (i=0 ; iedict->v->origin[0] + cosval*(i+3)*12; - top[1] = host_client->edict->v->origin[1] + sinval*(i+3)*12; - top[2] = host_client->edict->v->origin[2] + host_client->edict->v->view_ofs[2]; + top[0] = host_client->edict->fields.server->origin[0] + cosval*(i+3)*12; + top[1] = host_client->edict->fields.server->origin[1] + sinval*(i+3)*12; + top[2] = host_client->edict->fields.server->origin[2] + host_client->edict->fields.server->view_ofs[2]; bottom[0] = top[0]; bottom[1] = top[1]; bottom[2] = top[2] - 160; - tr = SV_Move (top, vec3_origin, vec3_origin, bottom, MOVE_NOMONSTERS, host_client->edict); + tr = SV_TraceLine(top, bottom, MOVE_NOMONSTERS, host_client->edict, SUPERCONTENTS_SOLID); // if looking at a wall, leave ideal the way is was if (tr.startsolid) return; @@ -92,16 +88,15 @@ void SV_SetIdealPitch (void) if (!dir) { - host_client->edict->v->idealpitch = 0; + host_client->edict->fields.server->idealpitch = 0; return; } if (steps < 2) return; - host_client->edict->v->idealpitch = -dir * sv_idealpitchscale.value; + host_client->edict->fields.server->idealpitch = -dir * sv_idealpitchscale.value; } -#if 1 static vec3_t wishdir, forward, right, up; static float wishspeed; @@ -119,17 +114,17 @@ void SV_UserFriction (void) vec3_t start, stop; trace_t trace; - speed = sqrt(host_client->edict->v->velocity[0]*host_client->edict->v->velocity[0]+host_client->edict->v->velocity[1]*host_client->edict->v->velocity[1]); + speed = sqrt(host_client->edict->fields.server->velocity[0]*host_client->edict->fields.server->velocity[0]+host_client->edict->fields.server->velocity[1]*host_client->edict->fields.server->velocity[1]); if (!speed) return; // if the leading edge is over a dropoff, increase friction - start[0] = stop[0] = host_client->edict->v->origin[0] + host_client->edict->v->velocity[0]/speed*16; - start[1] = stop[1] = host_client->edict->v->origin[1] + host_client->edict->v->velocity[1]/speed*16; - start[2] = host_client->edict->v->origin[2] + host_client->edict->v->mins[2]; + start[0] = stop[0] = host_client->edict->fields.server->origin[0] + host_client->edict->fields.server->velocity[0]/speed*16; + start[1] = stop[1] = host_client->edict->fields.server->origin[1] + host_client->edict->fields.server->velocity[1]/speed*16; + start[2] = host_client->edict->fields.server->origin[2] + host_client->edict->fields.server->mins[2]; stop[2] = start[2] - 34; - trace = SV_Move (start, vec3_origin, vec3_origin, stop, MOVE_NOMONSTERS, host_client->edict); + trace = SV_TraceLine(start, stop, MOVE_NOMONSTERS, host_client->edict, SV_GenericHitSuperContentsMask(host_client->edict)); if (trace.fraction == 1.0) friction = sv_friction.value*sv_edgefriction.value; @@ -145,7 +140,7 @@ void SV_UserFriction (void) else newspeed /= speed; - VectorScale(host_client->edict->v->velocity, newspeed, host_client->edict->v->velocity); + VectorScale(host_client->edict->fields.server->velocity, newspeed, host_client->edict->fields.server->velocity); } /* @@ -158,7 +153,7 @@ void SV_Accelerate (void) int i; float addspeed, accelspeed, currentspeed; - currentspeed = DotProduct (host_client->edict->v->velocity, wishdir); + currentspeed = DotProduct (host_client->edict->fields.server->velocity, wishdir); addspeed = wishspeed - currentspeed; if (addspeed <= 0) return; @@ -167,43 +162,44 @@ void SV_Accelerate (void) accelspeed = addspeed; for (i=0 ; i<3 ; i++) - host_client->edict->v->velocity[i] += accelspeed*wishdir[i]; + host_client->edict->fields.server->velocity[i] += accelspeed*wishdir[i]; } +extern cvar_t sv_gameplayfix_q2airaccelerate; void SV_AirAccelerate (vec3_t wishveloc) { int i; float addspeed, wishspd, accelspeed, currentspeed; wishspd = VectorNormalizeLength (wishveloc); - if (wishspd > 30) - wishspd = 30; - currentspeed = DotProduct (host_client->edict->v->velocity, wishveloc); + if (wishspd > sv_maxairspeed.value) + wishspd = sv_maxairspeed.value; + currentspeed = DotProduct (host_client->edict->fields.server->velocity, wishveloc); addspeed = wishspd - currentspeed; if (addspeed <= 0) return; - accelspeed = sv_accelerate.value*wishspeed * sv.frametime; + accelspeed = (sv_airaccelerate.value < 0 ? sv_accelerate.value : sv_airaccelerate.value)*(sv_gameplayfix_q2airaccelerate.integer ? wishspd : wishspeed) * sv.frametime; if (accelspeed > addspeed) accelspeed = addspeed; for (i=0 ; i<3 ; i++) - host_client->edict->v->velocity[i] += accelspeed*wishveloc[i]; + host_client->edict->fields.server->velocity[i] += accelspeed*wishveloc[i]; } void DropPunchAngle (void) { float len; - eval_t *val; + prvm_eval_t *val; - len = VectorNormalizeLength (host_client->edict->v->punchangle); + len = VectorNormalizeLength (host_client->edict->fields.server->punchangle); len -= 10*sv.frametime; if (len < 0) len = 0; - VectorScale (host_client->edict->v->punchangle, len, host_client->edict->v->punchangle); + VectorScale (host_client->edict->fields.server->punchangle, len, host_client->edict->fields.server->punchangle); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_punchvector))) + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.punchvector))) { len = VectorNormalizeLength (val->vector); @@ -224,16 +220,16 @@ void SV_FreeMove (void) int i; float wishspeed; - AngleVectors (host_client->edict->v->v_angle, forward, right, up); + AngleVectors (host_client->edict->fields.server->v_angle, forward, right, up); for (i = 0; i < 3; i++) - host_client->edict->v->velocity[i] = forward[i] * cmd.forwardmove + right[i] * cmd.sidemove; + host_client->edict->fields.server->velocity[i] = forward[i] * cmd.forwardmove + right[i] * cmd.sidemove; - host_client->edict->v->velocity[2] += cmd.upmove; + host_client->edict->fields.server->velocity[2] += cmd.upmove; - wishspeed = VectorLength(host_client->edict->v->velocity); + wishspeed = VectorLength(host_client->edict->fields.server->velocity); if (wishspeed > sv_maxspeed.value) - VectorScale(host_client->edict->v->velocity, sv_maxspeed.value / wishspeed, host_client->edict->v->velocity); + VectorScale(host_client->edict->fields.server->velocity, sv_maxspeed.value / wishspeed, host_client->edict->fields.server->velocity); } /* @@ -249,7 +245,7 @@ void SV_WaterMove (void) float speed, newspeed, wishspeed, addspeed, accelspeed, temp; // user intentions - AngleVectors (host_client->edict->v->v_angle, forward, right, up); + AngleVectors (host_client->edict->fields.server->v_angle, forward, right, up); for (i=0 ; i<3 ; i++) wishvel[i] = forward[i]*cmd.forwardmove + right[i]*cmd.sidemove; @@ -269,14 +265,14 @@ void SV_WaterMove (void) wishspeed *= 0.7; // water friction - speed = VectorLength(host_client->edict->v->velocity); + speed = VectorLength(host_client->edict->fields.server->velocity); if (speed) { - newspeed = speed - sv.frametime * speed * sv_friction.value; + newspeed = speed - sv.frametime * speed * (sv_waterfriction.value < 0 ? sv_friction.value : sv_waterfriction.value); if (newspeed < 0) newspeed = 0; temp = newspeed/speed; - VectorScale(host_client->edict->v->velocity, temp, host_client->edict->v->velocity); + VectorScale(host_client->edict->fields.server->velocity, temp, host_client->edict->fields.server->velocity); } else newspeed = 0; @@ -290,23 +286,23 @@ void SV_WaterMove (void) return; VectorNormalize (wishvel); - accelspeed = sv_accelerate.value * wishspeed * sv.frametime; + accelspeed = (sv_wateraccelerate.value < 0 ? sv_accelerate.value : sv_wateraccelerate.value) * wishspeed * sv.frametime; if (accelspeed > addspeed) accelspeed = addspeed; for (i=0 ; i<3 ; i++) - host_client->edict->v->velocity[i] += accelspeed * wishvel[i]; + host_client->edict->fields.server->velocity[i] += accelspeed * wishvel[i]; } void SV_WaterJump (void) { - if (sv.time > host_client->edict->v->teleport_time || !host_client->edict->v->waterlevel) + if (sv.time > host_client->edict->fields.server->teleport_time || !host_client->edict->fields.server->waterlevel) { - host_client->edict->v->flags = (int)host_client->edict->v->flags & ~FL_WATERJUMP; - host_client->edict->v->teleport_time = 0; + host_client->edict->fields.server->flags = (int)host_client->edict->fields.server->flags & ~FL_WATERJUMP; + host_client->edict->fields.server->teleport_time = 0; } - host_client->edict->v->velocity[0] = host_client->edict->v->movedir[0]; - host_client->edict->v->velocity[1] = host_client->edict->v->movedir[1]; + host_client->edict->fields.server->velocity[0] = host_client->edict->fields.server->movedir[0]; + host_client->edict->fields.server->velocity[1] = host_client->edict->fields.server->movedir[1]; } @@ -324,20 +320,20 @@ void SV_AirMove (void) // LordHavoc: correct quake movement speed bug when looking up/down wishvel[0] = wishvel[2] = 0; - wishvel[1] = host_client->edict->v->angles[1]; + wishvel[1] = host_client->edict->fields.server->angles[1]; AngleVectors (wishvel, forward, right, up); fmove = cmd.forwardmove; smove = cmd.sidemove; // hack to not let you back into teleporter - if (sv.time < host_client->edict->v->teleport_time && fmove < 0) + if (sv.time < host_client->edict->fields.server->teleport_time && fmove < 0) fmove = 0; for (i=0 ; i<3 ; i++) wishvel[i] = forward[i]*fmove + right[i]*smove; - if ((int)host_client->edict->v->movetype != MOVETYPE_WALK) + if ((int)host_client->edict->fields.server->movetype != MOVETYPE_WALK) wishvel[2] += cmd.upmove; VectorCopy (wishvel, wishdir); @@ -349,12 +345,12 @@ void SV_AirMove (void) wishspeed = sv_maxspeed.value; } - if (host_client->edict->v->movetype == MOVETYPE_NOCLIP) + if (host_client->edict->fields.server->movetype == MOVETYPE_NOCLIP) { // noclip - VectorCopy (wishvel, host_client->edict->v->velocity); + VectorCopy (wishvel, host_client->edict->fields.server->velocity); } - else if ( onground ) + else if (onground) { SV_UserFriction (); SV_Accelerate (); @@ -378,39 +374,56 @@ void SV_ClientThink (void) { vec3_t v_angle; - if (host_client->edict->v->movetype == MOVETYPE_NONE) + //Con_Printf("clientthink for %ims\n", (int) (sv.frametime * 1000)); + + SV_ApplyClientMove(); + // make sure the velocity is sane (not a NaN) + SV_CheckVelocity(host_client->edict); + + // LordHavoc: QuakeC replacement for SV_ClientThink (player movement) + if (prog->funcoffsets.SV_PlayerPhysics && sv_playerphysicsqc.integer) + { + prog->globals.server->time = sv.time; + prog->globals.server->self = PRVM_EDICT_TO_PROG(host_client->edict); + PRVM_ExecuteProgram (prog->funcoffsets.SV_PlayerPhysics, "QC function SV_PlayerPhysics is missing"); + SV_CheckVelocity(host_client->edict); + return; + } + + if (host_client->edict->fields.server->movetype == MOVETYPE_NONE) return; - onground = (int)host_client->edict->v->flags & FL_ONGROUND; + onground = ((int)host_client->edict->fields.server->flags & FL_ONGROUND) != 0; DropPunchAngle (); // if dead, behave differently - if (host_client->edict->v->health <= 0) + if (host_client->edict->fields.server->health <= 0) return; cmd = host_client->cmd; // angles // show 1/3 the pitch angle and all the roll angle - VectorAdd (host_client->edict->v->v_angle, host_client->edict->v->punchangle, v_angle); - host_client->edict->v->angles[ROLL] = V_CalcRoll (host_client->edict->v->angles, host_client->edict->v->velocity)*4; - if (!host_client->edict->v->fixangle) + VectorAdd (host_client->edict->fields.server->v_angle, host_client->edict->fields.server->punchangle, v_angle); + host_client->edict->fields.server->angles[ROLL] = V_CalcRoll (host_client->edict->fields.server->angles, host_client->edict->fields.server->velocity)*4; + if (!host_client->edict->fields.server->fixangle) { - host_client->edict->v->angles[PITCH] = -v_angle[PITCH]/3; - host_client->edict->v->angles[YAW] = v_angle[YAW]; + host_client->edict->fields.server->angles[PITCH] = -v_angle[PITCH]/3; + host_client->edict->fields.server->angles[YAW] = v_angle[YAW]; } - if ( (int)host_client->edict->v->flags & FL_WATERJUMP ) + if ( (int)host_client->edict->fields.server->flags & FL_WATERJUMP ) { SV_WaterJump (); + SV_CheckVelocity(host_client->edict); return; } /* // Player is (somehow) outside of the map, or flying, or noclipping - if (host_client->edict->v->movetype != MOVETYPE_NOCLIP && (host_client->edict->v->movetype == MOVETYPE_FLY || SV_TestEntityPosition (host_client->edict))) - //if (host_client->edict->v->movetype == MOVETYPE_NOCLIP || host_client->edict->v->movetype == MOVETYPE_FLY || SV_TestEntityPosition (host_client->edict)) + if (host_client->edict->fields.server->movetype != MOVETYPE_NOCLIP && (host_client->edict->fields.server->movetype == MOVETYPE_FLY || SV_TestEntityPosition (host_client->edict))) + //if (host_client->edict->fields.server->movetype == MOVETYPE_NOCLIP || host_client->edict->fields.server->movetype == MOVETYPE_FLY || SV_TestEntityPosition (host_client->edict)) { SV_FreeMove (); return; @@ -418,266 +431,83 @@ void SV_ClientThink (void) */ // walk - if ((host_client->edict->v->waterlevel >= 2) && (host_client->edict->v->movetype != MOVETYPE_NOCLIP)) + if ((host_client->edict->fields.server->waterlevel >= 2) && (host_client->edict->fields.server->movetype != MOVETYPE_NOCLIP)) { SV_WaterMove (); + SV_CheckVelocity(host_client->edict); return; } SV_AirMove (); + SV_CheckVelocity(host_client->edict); } -#else - -extern cvar_t cl_rollspeed; -extern cvar_t cl_rollangle; -void SV_ClientThink(void) -{ - int j; - vec3_t wishvel, wishdir, v, v_forward, v_right, v_up, start, stop; - float wishspeed, f, limit; - trace_t trace; - - if (host_client->edict->v->movetype == MOVETYPE_NONE) - return; - - f = DotProduct(host_client->edict->v->punchangle, host_client->edict->v->punchangle); - if (f) - { - limit = sqrt(f); - f = (limit - 10 * sv.frametime); - f /= limit; - f = max(0, f); - VectorScale(host_client->edict->v->punchangle, f, host_client->edict->v->punchangle); - } - - // if dead, behave differently - if (host_client->edict->v->health <= 0) - return; - - AngleVectors(host_client->edict->v->v_angle, v_forward, v_right, v_up); - // show 1/3 the pitch angle and all the roll angle - f = DotProduct(host_client->edict->v->velocity, v_right) * (1.0 / cl_rollspeed.value); - host_client->edict->v->angles[2] = bound(-1, f, 1) * cl_rollangle.value * 4; - if (!host_client->edict->v->fixangle) - { - host_client->edict->v->angles[0] = (host_client->edict->v->v_angle[0] + host_client->edict->v->punchangle[0]) * -0.333; - host_client->edict->v->angles[1] = host_client->edict->v->v_angle[1] + host_client->edict->v->punchangle[1]; - } - - if ((int)host_client->edict->v->flags & FL_WATERJUMP) - { - host_client->edict->v->velocity[0] = host_client->edict->v->movedir[0]; - host_client->edict->v->velocity[1] = host_client->edict->v->movedir[1]; - if (sv.time > host_client->edict->v->teleport_time || host_client->edict->v->waterlevel == 0) - { - host_client->edict->v->flags = (int)host_client->edict->v->flags - ((int)host_client->edict->v->flags & FL_WATERJUMP); - host_client->edict->v->teleport_time = 0; - } - return; - } - - // swim - if (host_client->edict->v->waterlevel >= 2) - if (host_client->edict->v->movetype != MOVETYPE_NOCLIP) - { - if (host_client->cmd.forwardmove == 0 && host_client->cmd.sidemove == 0 && host_client->cmd.upmove == 0) - { - // drift towards bottom - wishvel[0] = 0; - wishvel[1] = 0; - wishvel[2] = -60; - } - else - { - for (j = 0;j < 3;j++) - wishvel[j] = v_forward[j] * host_client->cmd.forwardmove + v_right[j] * host_client->cmd.sidemove; - wishvel[2] += host_client->cmd.upmove; - } - - wishspeed = VectorLength(wishvel); - wishspeed = min(wishspeed, sv_maxspeed.value) * 0.7; - - // water friction - f = VectorLength(host_client->edict->v->velocity) * (1 - sv.frametime * sv_friction.value); - if (f > 0) - f /= VectorLength(host_client->edict->v->velocity); - else - f = 0; - VectorScale(host_client->edict->v->velocity, f, host_client->edict->v->velocity); - - // water acceleration - if (wishspeed <= f) - return; - - f = wishspeed - f; - limit = sv_accelerate.value * wishspeed * sv.frametime; - if (f > limit) - f = limit; - limit = VectorLength(wishvel); - if (limit) - f /= limit; - VectorMA(host_client->edict->v->velocity, f, wishvel, host_client->edict->v->velocity); - return; - } - - // if not flying, move horizontally only - if (host_client->edict->v->movetype != MOVETYPE_FLY) - { - VectorClear(wishvel); - wishvel[1] = host_client->edict->v->v_angle[1]; - AngleVectors(wishvel, v_forward, v_right, v_up); - } - - // hack to not let you back into teleporter - VectorScale(v_right, host_client->cmd.sidemove, wishvel); - if (sv.time >= host_client->edict->v->teleport_time || host_client->cmd.forwardmove > 0) - VectorMA(wishvel, host_client->cmd.forwardmove, v_forward, wishvel); - if (host_client->edict->v->movetype != MOVETYPE_WALK) - wishvel[2] += cmd.upmove; - - VectorCopy(wishvel, wishdir); - VectorNormalize(wishdir); - wishspeed = VectorLength(wishvel); - if (wishspeed > sv_maxspeed.value) - wishspeed = sv_maxspeed.value; - - if (host_client->edict->v->movetype == MOVETYPE_NOCLIP || host_client->edict->v->movetype == MOVETYPE_FLY) - { - VectorScale(wishdir, wishspeed, host_client->edict->v->velocity); - return; - } - - if ((int)host_client->edict->v->flags & FL_ONGROUND) // walking - { - // friction - f = host_client->edict->v->velocity[0] * host_client->edict->v->velocity[0] + host_client->edict->v->velocity[1] * host_client->edict->v->velocity[1]; - if (f) - { - f = sqrt(f); - VectorCopy(host_client->edict->v->velocity, v); - v[2] = 0; - - // if the leading edge is over a dropoff, increase friction - limit = 16.0f / f; - VectorMA(host_client->edict->v->origin, limit, v, v); - v[2] += host_client->edict->v->mins[2]; - - VectorCopy(v, start); - VectorCopy(v, stop); - stop[2] -= 34; - trace = SV_Move(start, vec3_origin, vec3_origin, stop, MOVE_NOMONSTERS, host_client->edict); - - // apply friction - if (f < sv_stopspeed.value) - f = sv_stopspeed.value / f; - else - f = 1; - if (trace.fraction == 1) - f *= sv_edgefriction.value; - f = 1 - sv.frametime * f * sv_friction.value; - - if (f < 0) - f = 0; - VectorScale(host_client->edict->v->velocity, f, host_client->edict->v->velocity); - } - } - else // airborn - wishspeed = min(wishspeed, 30); - - // ground or air acceleration - f = wishspeed - DotProduct(host_client->edict->v->velocity, wishdir); - if (f > 0) - { - limit = sv_accelerate.value * sv.frametime * wishspeed; - if (f > limit) - f = limit; - VectorMA(host_client->edict->v->velocity, f, wishdir, host_client->edict->v->velocity); - } -} -#endif - /* =================== SV_ReadClientMove =================== */ -void SV_ReadClientMove (usercmd_t *move) +int sv_numreadmoves = 0; +usercmd_t sv_readmoves[CL_MAX_USERCMDS]; +void SV_ReadClientMove (void) { int i; - vec3_t angle; - int bits; - eval_t *val; - float total; + usercmd_t newmove; + usercmd_t *move = &newmove; + + memset(move, 0, sizeof(*move)); - // read ping time if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); - host_client->ping_times[host_client->num_pings % NUM_PING_TIMES] = sv.time - MSG_ReadFloat (); + + // read ping time + if (sv.protocol != PROTOCOL_QUAKE && sv.protocol != PROTOCOL_QUAKEDP && sv.protocol != PROTOCOL_NEHAHRAMOVIE && sv.protocol != PROTOCOL_NEHAHRABJP && sv.protocol != PROTOCOL_NEHAHRABJP2 && sv.protocol != PROTOCOL_NEHAHRABJP3 && sv.protocol != PROTOCOL_DARKPLACES1 && sv.protocol != PROTOCOL_DARKPLACES2 && sv.protocol != PROTOCOL_DARKPLACES3 && sv.protocol != PROTOCOL_DARKPLACES4 && sv.protocol != PROTOCOL_DARKPLACES5 && sv.protocol != PROTOCOL_DARKPLACES6) + move->sequence = MSG_ReadLong (); + move->time = move->clienttime = MSG_ReadFloat (); if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); - host_client->num_pings++; - for (i=0, total = 0;i < NUM_PING_TIMES;i++) - total += host_client->ping_times[i]; - // can be used for prediction - host_client->ping = total / NUM_PING_TIMES; - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_ping))) - val->_float = host_client->ping * 1000.0; + move->receivetime = (float)sv.time; + +#if DEBUGMOVES + Con_Printf("%s move%i #%i %ims (%ims) %i %i '%i %i %i' '%i %i %i'\n", move->time > move->receivetime ? "^3read future" : "^4read normal", sv_numreadmoves + 1, move->sequence, (int)floor((move->time - host_client->cmd.time) * 1000.0 + 0.5), (int)floor(move->time * 1000.0 + 0.5), move->impulse, move->buttons, (int)move->viewangles[0], (int)move->viewangles[1], (int)move->viewangles[2], (int)move->forwardmove, (int)move->sidemove, (int)move->upmove); +#endif + // limit reported time to current time + // (incase the client is trying to cheat) + move->time = min(move->time, move->receivetime + sv.frametime); // read current angles for (i = 0;i < 3;i++) { - if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); - if (sv.protocol == PROTOCOL_QUAKE) - angle[i] = MSG_ReadAngle8i(); + if (sv.protocol == PROTOCOL_QUAKE || sv.protocol == PROTOCOL_QUAKEDP || sv.protocol == PROTOCOL_NEHAHRAMOVIE || sv.protocol == PROTOCOL_NEHAHRABJP || sv.protocol == PROTOCOL_NEHAHRABJP2 || sv.protocol == PROTOCOL_NEHAHRABJP3) + move->viewangles[i] = MSG_ReadAngle8i(); + else if (sv.protocol == PROTOCOL_DARKPLACES1) + move->viewangles[i] = MSG_ReadAngle16i(); else if (sv.protocol == PROTOCOL_DARKPLACES2 || sv.protocol == PROTOCOL_DARKPLACES3) - angle[i] = MSG_ReadAngle32f(); - else if (sv.protocol == PROTOCOL_DARKPLACES1 || sv.protocol == PROTOCOL_DARKPLACES4 || sv.protocol == PROTOCOL_DARKPLACES5 || sv.protocol == PROTOCOL_DARKPLACES6) - angle[i] = MSG_ReadAngle16i(); - if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); + move->viewangles[i] = MSG_ReadAngle32f(); + else + move->viewangles[i] = MSG_ReadAngle16i(); } - - VectorCopy (angle, host_client->edict->v->v_angle); + if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); // read movement - if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); move->forwardmove = MSG_ReadCoord16i (); - if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); move->sidemove = MSG_ReadCoord16i (); - if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); move->upmove = MSG_ReadCoord16i (); if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_movement))) - { - val->vector[0] = move->forwardmove; - val->vector[1] = move->sidemove; - val->vector[2] = move->upmove; - } // read buttons - if (sv.protocol == PROTOCOL_DARKPLACES6) - bits = MSG_ReadLong (); + // be sure to bitwise OR them into the move->buttons because we want to + // accumulate button presses from multiple packets per actual move + if (sv.protocol == PROTOCOL_QUAKE || sv.protocol == PROTOCOL_QUAKEDP || sv.protocol == PROTOCOL_NEHAHRAMOVIE || sv.protocol == PROTOCOL_NEHAHRABJP || sv.protocol == PROTOCOL_NEHAHRABJP2 || sv.protocol == PROTOCOL_NEHAHRABJP3 || sv.protocol == PROTOCOL_DARKPLACES1 || sv.protocol == PROTOCOL_DARKPLACES2 || sv.protocol == PROTOCOL_DARKPLACES3 || sv.protocol == PROTOCOL_DARKPLACES4 || sv.protocol == PROTOCOL_DARKPLACES5) + move->buttons = MSG_ReadByte (); else - bits = MSG_ReadByte (); + move->buttons = MSG_ReadLong (); if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); - host_client->edict->v->button0 = bits & 1; - host_client->edict->v->button2 = (bits & 2)>>1; - // LordHavoc: added 6 new buttons - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_button3))) val->_float = ((bits >> 2) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_button4))) val->_float = ((bits >> 3) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_button5))) val->_float = ((bits >> 4) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_button6))) val->_float = ((bits >> 5) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_button7))) val->_float = ((bits >> 6) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_button8))) val->_float = ((bits >> 7) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_buttonuse))) val->_float = ((bits >> 8) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_buttonchat))) val->_float = ((bits >> 9) & 1); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_cursor_active))) val->_float = ((bits >> 10) & 1); - - i = MSG_ReadByte (); + + // read impulse + move->impulse = MSG_ReadByte (); if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); - if (i) - host_client->edict->v->impulse = i; // PRYDON_CLIENTCURSOR - if (sv.protocol == PROTOCOL_DARKPLACES6) + if (sv.protocol != PROTOCOL_QUAKE && sv.protocol != PROTOCOL_QUAKEDP && sv.protocol != PROTOCOL_NEHAHRAMOVIE && sv.protocol != PROTOCOL_NEHAHRABJP && sv.protocol != PROTOCOL_NEHAHRABJP2 && sv.protocol != PROTOCOL_NEHAHRABJP3 && sv.protocol != PROTOCOL_DARKPLACES1 && sv.protocol != PROTOCOL_DARKPLACES2 && sv.protocol != PROTOCOL_DARKPLACES3 && sv.protocol != PROTOCOL_DARKPLACES4 && sv.protocol != PROTOCOL_DARKPLACES5) { // 30 bytes move->cursor_screen[0] = MSG_ReadShort() * (1.0f / 32767.0f); @@ -689,27 +519,260 @@ void SV_ReadClientMove (usercmd_t *move) move->cursor_impact[1] = MSG_ReadFloat(); move->cursor_impact[2] = MSG_ReadFloat(); move->cursor_entitynumber = (unsigned short)MSG_ReadShort(); - if (move->cursor_entitynumber >= sv.max_edicts) + if (move->cursor_entitynumber >= prog->max_edicts) { Con_DPrintf("SV_ReadClientMessage: client send bad cursor_entitynumber\n"); move->cursor_entitynumber = 0; } // as requested by FrikaC, cursor_trace_ent is reset to world if the // entity is free at time of receipt - if (EDICT_NUM(move->cursor_entitynumber)->e->free) + if (PRVM_EDICT_NUM(move->cursor_entitynumber)->priv.server->free) move->cursor_entitynumber = 0; if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); } - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_cursor_screen))) VectorCopy(move->cursor_screen, val->vector); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_cursor_trace_start))) VectorCopy(move->cursor_start, val->vector); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_cursor_trace_endpos))) VectorCopy(move->cursor_impact, val->vector); - if ((val = GETEDICTFIELDVALUE(host_client->edict, eval_cursor_trace_ent))) val->edict = EDICT_TO_PROG(EDICT_NUM(move->cursor_entitynumber)); + + // if the previous move has not been applied yet, we need to accumulate + // the impulse/buttons from it + if (!host_client->cmd.applied) + { + if (!move->impulse) + move->impulse = host_client->cmd.impulse; + move->buttons |= host_client->cmd.buttons; + } + + // now store this move for later execution + // (we have to buffer the moves because of old ones being repeated) + if (sv_numreadmoves < CL_MAX_USERCMDS) + sv_readmoves[sv_numreadmoves++] = *move; + + // movement packet loss tracking + if(move->sequence) + { + if(move->sequence > host_client->movement_highestsequence_seen) + { + if(host_client->movement_highestsequence_seen) + { + // mark moves in between as lost + if(move->sequence - host_client->movement_highestsequence_seen - 1 < NETGRAPH_PACKETS) + for(i = host_client->movement_highestsequence_seen + 1; i < move->sequence; ++i) + host_client->movement_count[i % NETGRAPH_PACKETS] = -1; + else + memset(host_client->movement_count, -1, sizeof(host_client->movement_count)); + } + // mark THIS move as seen for the first time + host_client->movement_count[move->sequence % NETGRAPH_PACKETS] = 1; + // update highest sequence seen + host_client->movement_highestsequence_seen = move->sequence; + } + else + if(host_client->movement_count[move->sequence % NETGRAPH_PACKETS] >= 0) + ++host_client->movement_count[move->sequence % NETGRAPH_PACKETS]; + } + else + { + host_client->movement_highestsequence_seen = 0; + memset(host_client->movement_count, 0, sizeof(host_client->movement_count)); + } +} + +void SV_ExecuteClientMoves(void) +{ + int moveindex; + float moveframetime; + double oldframetime; + double oldframetime2; +#ifdef NUM_PING_TIMES + double total; +#endif + prvm_eval_t *val; + if (sv_numreadmoves < 1) + return; + // only start accepting input once the player is spawned + if (!host_client->spawned) + return; +#if DEBUGMOVES + Con_Printf("SV_ExecuteClientMoves: read %i moves at sv.time %f\n", sv_numreadmoves, (float)sv.time); +#endif + // disable clientside movement prediction in some cases + if (ceil(max(sv_readmoves[sv_numreadmoves-1].receivetime - sv_readmoves[sv_numreadmoves-1].time, 0) * 1000.0) < sv_clmovement_minping.integer) + host_client->clmovement_disabletimeout = realtime + sv_clmovement_minping_disabletime.value / 1000.0; + // several conditions govern whether clientside movement prediction is allowed + if (sv_readmoves[sv_numreadmoves-1].sequence && sv_clmovement_enable.integer && sv_clmovement_inputtimeout.value > 0 && host_client->clmovement_disabletimeout <= realtime && host_client->edict->fields.server->movetype == MOVETYPE_WALK && (!(val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.disableclientprediction)) || !val->_float)) + { + // process the moves in order and ignore old ones + // but always trust the latest move + // (this deals with bogus initial move sequences after level change, + // where the client will eventually catch up with the level change + // and reset its move sequence) + for (moveindex = 0;moveindex < sv_numreadmoves;moveindex++) + { + usercmd_t *move = sv_readmoves + moveindex; + if (host_client->movesequence < move->sequence || moveindex == sv_numreadmoves - 1) + { +#if DEBUGMOVES + Con_Printf("%smove #%i %ims (%ims) %i %i '%i %i %i' '%i %i %i'\n", (move->time - host_client->cmd.time) > sv.frametime * 1.01 ? "^1" : "^2", move->sequence, (int)floor((move->time - host_client->cmd.time) * 1000.0 + 0.5), (int)floor(move->time * 1000.0 + 0.5), move->impulse, move->buttons, (int)move->viewangles[0], (int)move->viewangles[1], (int)move->viewangles[2], (int)move->forwardmove, (int)move->sidemove, (int)move->upmove); +#endif + // this is a new move + move->time = bound(sv.time - 1, move->time, sv.time); // prevent slowhack/speedhack combos + move->time = max(move->time, host_client->cmd.time); // prevent backstepping of time + moveframetime = bound(0, move->time - host_client->cmd.time, min(0.1, sv_clmovement_inputtimeout.value)); + + // discard (treat like lost) moves with too low distance from + // the previous one to prevent hacks using float inaccuracy + // clients will see this as packet loss in the netgraph + // this should also apply if a move cannot get + // executed because it came too late and + // already was performed serverside + if(moveframetime < 0.0005) + { + // count the move as LOST if we don't + // execute it but it has higher + // sequence count + if(host_client->movesequence) + if(move->sequence > host_client->movesequence) + host_client->movement_count[(move->sequence) % NETGRAPH_PACKETS] = -1; + continue; + } + + //Con_Printf("movesequence = %i (%i lost), moveframetime = %f\n", move->sequence, move->sequence ? move->sequence - host_client->movesequence - 1 : 0, moveframetime); + host_client->cmd = *move; + host_client->movesequence = move->sequence; + + // if using prediction, we need to perform moves when packets are + // received, even if multiple occur in one frame + // (they can't go beyond the current time so there is no cheat issue + // with this approach, and if they don't send input for a while they + // start moving anyway, so the longest 'lagaport' possible is + // determined by the sv_clmovement_inputtimeout cvar) + if (moveframetime <= 0) + continue; + oldframetime = prog->globals.server->frametime; + oldframetime2 = sv.frametime; + // update ping time for qc to see while executing this move + host_client->ping = host_client->cmd.receivetime - host_client->cmd.time; + // the server and qc frametime values must be changed temporarily + prog->globals.server->frametime = sv.frametime = moveframetime; + // if move is more than 50ms, split it into two moves (this matches QWSV behavior and the client prediction) + if (sv.frametime > 0.05) + { + prog->globals.server->frametime = sv.frametime = moveframetime * 0.5f; + SV_Physics_ClientMove(); + } + SV_Physics_ClientMove(); + sv.frametime = oldframetime2; + prog->globals.server->frametime = oldframetime; + host_client->clmovement_inputtimeout = sv_clmovement_inputtimeout.value; + } + } + } + else + { + // try to gather button bits from old moves, but only if their time is + // advancing (ones with the same timestamp can't be trusted) + for (moveindex = 0;moveindex < sv_numreadmoves-1;moveindex++) + { + usercmd_t *move = sv_readmoves + moveindex; + if (host_client->cmd.time < move->time) + { + sv_readmoves[sv_numreadmoves-1].buttons |= move->buttons; + if (move->impulse) + sv_readmoves[sv_numreadmoves-1].impulse = move->impulse; + } + } + // now copy the new move + host_client->cmd = sv_readmoves[sv_numreadmoves-1]; + host_client->cmd.time = max(host_client->cmd.time, sv.time); + // physics will run up to sv.time, so allow no predicted moves + // before that otherwise, there is a speedhack by turning + // prediction on and off repeatedly on client side because the + // engine would run BOTH client and server physics for the same + // time + host_client->movesequence = 0; + // make sure that normal physics takes over immediately + host_client->clmovement_inputtimeout = 0; + } + + // calculate average ping time + host_client->ping = host_client->cmd.receivetime - host_client->cmd.clienttime; +#ifdef NUM_PING_TIMES + host_client->ping_times[host_client->num_pings % NUM_PING_TIMES] = host_client->cmd.receivetime - host_client->cmd.clienttime; + host_client->num_pings++; + for (i=0, total = 0;i < NUM_PING_TIMES;i++) + total += host_client->ping_times[i]; + host_client->ping = total / NUM_PING_TIMES; +#endif +} + +void SV_ApplyClientMove (void) +{ + prvm_eval_t *val; + usercmd_t *move = &host_client->cmd; + int j, movementloss, packetloss; + + if (!move->receivetime) + return; + + // note: a move can be applied multiple times if the client packets are + // not coming as often as the physics is executed, and the move must be + // applied before running qc each time because the id1 qc had a bug where + // it clears self.button2 in PlayerJump, causing pogostick behavior if + // moves are not applied every time before calling qc + move->applied = true; + + // set the edict fields + host_client->edict->fields.server->button0 = move->buttons & 1; + host_client->edict->fields.server->button2 = (move->buttons & 2)>>1; + if (move->impulse) + host_client->edict->fields.server->impulse = move->impulse; + // only send the impulse to qc once + move->impulse = 0; + + movementloss = packetloss = 0; + if(host_client->netconnection) + { + for (j = 0;j < NETGRAPH_PACKETS;j++) + if (host_client->netconnection->incoming_netgraph[j].unreliablebytes == NETGRAPH_LOSTPACKET) + packetloss++; + for (j = 0;j < NETGRAPH_PACKETS;j++) + if (host_client->movement_count[j] < 0) + movementloss++; + } + + VectorCopy(move->viewangles, host_client->edict->fields.server->v_angle); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button3))) val->_float = ((move->buttons >> 2) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button4))) val->_float = ((move->buttons >> 3) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button5))) val->_float = ((move->buttons >> 4) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button6))) val->_float = ((move->buttons >> 5) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button7))) val->_float = ((move->buttons >> 6) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button8))) val->_float = ((move->buttons >> 7) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button9))) val->_float = ((move->buttons >> 11) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button10))) val->_float = ((move->buttons >> 12) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button11))) val->_float = ((move->buttons >> 13) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button12))) val->_float = ((move->buttons >> 14) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button13))) val->_float = ((move->buttons >> 15) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button14))) val->_float = ((move->buttons >> 16) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button15))) val->_float = ((move->buttons >> 17) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.button16))) val->_float = ((move->buttons >> 18) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.buttonuse))) val->_float = ((move->buttons >> 8) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.buttonchat))) val->_float = ((move->buttons >> 9) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_active))) val->_float = ((move->buttons >> 10) & 1); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.movement))) VectorSet(val->vector, move->forwardmove, move->sidemove, move->upmove); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_screen))) VectorCopy(move->cursor_screen, val->vector); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_trace_start))) VectorCopy(move->cursor_start, val->vector); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_trace_endpos))) VectorCopy(move->cursor_impact, val->vector); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.cursor_trace_ent))) val->edict = PRVM_EDICT_TO_PROG(PRVM_EDICT_NUM(move->cursor_entitynumber)); + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.ping))) val->_float = host_client->ping * 1000.0; + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.packetloss))) val->_float = packetloss / (float) NETGRAPH_PACKETS; + if ((val = PRVM_EDICTFIELDVALUE(host_client->edict, prog->fieldoffsets.movementloss))) val->_float = movementloss / (float) NETGRAPH_PACKETS; } void SV_FrameLost(int framenum) { if (host_client->entitydatabase5) - EntityFrame5_LostFrame(host_client->entitydatabase5, framenum, host_client - svs.clients + 1); + { + EntityFrame5_LostFrame(host_client->entitydatabase5, framenum); + EntityFrameCSQC_LostFrame(host_client, framenum); + } } void SV_FrameAck(int framenum) @@ -728,12 +791,17 @@ SV_ReadClientMessage =================== */ extern void SV_SendServerinfo(client_t *client); +extern sizebuf_t vm_tempstringsbuf; void SV_ReadClientMessage(void) { - int cmd, num; - char *s; + int cmd, num, start; + char *s, *p, *q; + + if(sv_autodemo_perclient.integer >= 2) + SV_WriteDemoMessage(host_client, &(host_client->netconnection->message), true); //MSG_BeginReading (); + sv_numreadmoves = 0; for(;;) { @@ -751,17 +819,21 @@ void SV_ReadClientMessage(void) return; } - cmd = MSG_ReadChar (); + cmd = MSG_ReadByte (); if (cmd == -1) { // end of message + // apply the moves that were read this frame + SV_ExecuteClientMoves(); break; } switch (cmd) { default: - Con_Printf("SV_ReadClientMessage: unknown command char %i\n", cmd); + Con_Printf("SV_ReadClientMessage: unknown command char %i (at offset 0x%x)\n", cmd, msg_readcount); + if (developer_networking.integer) + Com_HexDumpToConsole(net_message.data, net_message.cursize); SV_DropClient (false); return; @@ -769,37 +841,46 @@ void SV_ReadClientMessage(void) break; case clc_stringcmd: + // allow reliable messages now as the client is done with initial loading + if (host_client->sendsignon == 2) + host_client->sendsignon = 0; s = MSG_ReadString (); + q = NULL; + for(p = s; *p; ++p) switch(*p) + { + case 10: + case 13: + if(!q) + q = p; + break; + default: + if(q) + goto clc_stringcmd_invalid; // newline seen, THEN something else -> possible exploit + break; + } + if(q) + *q = 0; if (strncasecmp(s, "spawn", 5) == 0 || strncasecmp(s, "begin", 5) == 0 || strncasecmp(s, "prespawn", 8) == 0) Cmd_ExecuteString (s, src_client); - else if (SV_ParseClientCommandQC) + else if (prog->funcoffsets.SV_ParseClientCommand) { - G_INT(OFS_PARM0) = PR_SetString(s); - pr_global_struct->self = EDICT_TO_PROG(host_client->edict); - PR_ExecuteProgram ((func_t)(SV_ParseClientCommandQC - pr_functions), "QC function SV_ParseClientCommand is missing"); + int restorevm_tempstringsbuf_cursize; + restorevm_tempstringsbuf_cursize = vm_tempstringsbuf.cursize; + PRVM_G_INT(OFS_PARM0) = PRVM_SetTempString(s); + prog->globals.server->self = PRVM_EDICT_TO_PROG(host_client->edict); + PRVM_ExecuteProgram (prog->funcoffsets.SV_ParseClientCommand, "QC function SV_ParseClientCommand is missing"); + vm_tempstringsbuf.cursize = restorevm_tempstringsbuf_cursize; } - else if (strncasecmp(s, "status", 6) == 0 - || strncasecmp(s, "name", 4) == 0 - || strncasecmp(s, "say", 3) == 0 - || strncasecmp(s, "say_team", 8) == 0 - || strncasecmp(s, "tell", 4) == 0 - || strncasecmp(s, "color", 5) == 0 - || strncasecmp(s, "kill", 4) == 0 - || strncasecmp(s, "pause", 5) == 0 - || strncasecmp(s, "kick", 4) == 0 - || strncasecmp(s, "ping", 4) == 0 - || strncasecmp(s, "ban", 3) == 0 - || strncasecmp(s, "pmodel", 6) == 0 - || strncasecmp(s, "rate", 4) == 0 - || strncasecmp(s, "playermodel", 11) == 0 - || strncasecmp(s, "playerskin", 10) == 0 - || (gamemode == GAME_NEHAHRA && (strncasecmp(s, "max", 3) == 0 || strncasecmp(s, "monster", 7) == 0 || strncasecmp(s, "scrag", 5) == 0 || strncasecmp(s, "gimme", 5) == 0 || strncasecmp(s, "wraith", 6) == 0)) - || (gamemode != GAME_NEHAHRA && (strncasecmp(s, "god", 3) == 0 || strncasecmp(s, "notarget", 8) == 0 || strncasecmp(s, "fly", 3) == 0 || strncasecmp(s, "give", 4) == 0 || strncasecmp(s, "noclip", 6) == 0))) - Cmd_ExecuteString (s, src_client); else - Con_Printf("%s tried to %s\n", host_client->name, s); + Cmd_ExecuteString (s, src_client); + break; + +clc_stringcmd_invalid: + Con_Printf("Received invalid stringcmd from %s\n", host_client->name); + if(developer.integer > 0) + Com_HexDumpToConsole((unsigned char *) s, strlen(s)); break; case clc_disconnect: @@ -807,16 +888,71 @@ void SV_ReadClientMessage(void) return; case clc_move: - SV_ReadClientMove (&host_client->cmd); + SV_ReadClientMove(); + break; + + case clc_ackdownloaddata: + start = MSG_ReadLong(); + num = MSG_ReadShort(); + if (host_client->download_file && host_client->download_started) + { + if (host_client->download_expectedposition == start) + { + int size = (int)FS_FileSize(host_client->download_file); + // a data block was successfully received by the client, + // update the expected position on the next data block + host_client->download_expectedposition = start + num; + // if this was the last data block of the file, it's done + if (host_client->download_expectedposition >= FS_FileSize(host_client->download_file)) + { + // tell the client that the download finished + // we need to calculate the crc now + // + // note: at this point the OS probably has the file + // entirely in memory, so this is a faster operation + // now than it was when the download started. + // + // it is also preferable to do this at the end of the + // download rather than the start because it reduces + // potential for Denial Of Service attacks against the + // server. + int crc; + unsigned char *temp; + FS_Seek(host_client->download_file, 0, SEEK_SET); + temp = (unsigned char *) Mem_Alloc(tempmempool, size); + FS_Read(host_client->download_file, temp, size); + crc = CRC_Block(temp, size); + Mem_Free(temp); + // calculated crc, send the file info to the client + // (so that it can verify the data) + Host_ClientCommands("\ncl_downloadfinished %i %i %s\n", size, crc, host_client->download_name); + Con_DPrintf("Download of %s by %s has finished\n", host_client->download_name, host_client->name); + FS_Close(host_client->download_file); + host_client->download_file = NULL; + host_client->download_name[0] = 0; + host_client->download_expectedposition = 0; + host_client->download_started = false; + } + } + else + { + // a data block was lost, reset to the expected position + // and resume sending from there + FS_Seek(host_client->download_file, host_client->download_expectedposition, SEEK_SET); + } + } break; case clc_ackframe: if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); num = MSG_ReadLong(); if (msg_badread) Con_Printf("SV_ReadClientMessage: badread at %s:%i\n", __FILE__, __LINE__); - if (developer_networkentities.integer >= 1) + if (developer_networkentities.integer >= 10) Con_Printf("recv clc_ackframe %i\n", num); - if (host_client->latestframenum < num) + // if the client hasn't progressed through signons yet, + // ignore any clc_ackframes we get (they're probably from the + // previous level) + if (host_client->spawned && host_client->latestframenum < num) { int i; for (i = host_client->latestframenum + 1;i < num;i++) @@ -829,48 +965,3 @@ void SV_ReadClientMessage(void) } } -/* -================== -SV_RunClients -================== -*/ -void SV_RunClients (void) -{ - int i; - - for (i = 0, host_client = svs.clients;i < svs.maxclients;i++, host_client++) - { - if (!host_client->active) - continue; - - if (!host_client->spawned) - { - // clear client movement until a new packet is received - memset (&host_client->cmd, 0, sizeof(host_client->cmd)); - continue; - } - - if (sv.frametime) - { - // LordHavoc: QuakeC replacement for SV_ClientThink (player movement) - if (SV_PlayerPhysicsQC) - { - pr_global_struct->time = sv.time; - pr_global_struct->self = EDICT_TO_PROG(host_client->edict); - PR_ExecuteProgram ((func_t)(SV_PlayerPhysicsQC - pr_functions), "QC function SV_PlayerPhysics is missing"); - } - else - SV_ClientThink (); - - SV_CheckVelocity(host_client->edict); - - // LordHavoc: a hack to ensure that the (rather silly) id1 quakec - // player_run/player_stand1 does not horribly malfunction if the - // velocity becomes a number that is both == 0 and != 0 - // (sounds to me like NaN but to be absolutely safe...) - if (DotProduct(host_client->edict->v->velocity, host_client->edict->v->velocity) < 0.0001) - VectorClear(host_client->edict->v->velocity); - } - } -} -