]> de.git.xonotic.org Git - xonotic/gmqcc.git/commitdiff
Fixed another possible implementation specific bug thanks to this progressive splint...
authorDale Weiler <killfieldengine@gmail.com>
Fri, 28 Dec 2012 12:43:08 +0000 (12:43 +0000)
committerDale Weiler <killfieldengine@gmail.com>
Fri, 28 Dec 2012 12:43:08 +0000 (12:43 +0000)
main.c
splint.sh
test.c

diff --git a/main.c b/main.c
index 244d57000c6afae7f0473e3e6bd3eb41b8d2f49a..194679582a8ab4592417677c31c07b329f59d7e0 100644 (file)
--- a/main.c
+++ b/main.c
@@ -527,7 +527,7 @@ int main(int argc, char **argv) {
 
     if (OPTS_FLAG(TRUE_EMPTY_STRINGS) && OPTS_FLAG(FALSE_EMPTY_STRINGS)) {
         con_err("-ftrue-empty-strings and -ffalse-empty-strings are mutually exclusive");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     /* the standard decides which set of operators to use */
@@ -550,7 +550,7 @@ int main(int argc, char **argv) {
                 operators[operator_count-1].id != opid2(':','?'))
             {
                 con_err("internal error: operator precedence table wasn't updated correctly!\n");
-                exit(1);
+                exit(EXIT_FAILURE);
             }
             operators_free = true;
             newops = (oper_info*)mem_a(sizeof(operators[0]) * operator_count);
index 8d4ab2a866f46e0c24293ed7bbc2699927996ffd..ae688ee645607151589ed86104df31bdc8b912ce 100755 (executable)
--- a/splint.sh
+++ b/splint.sh
@@ -55,7 +55,6 @@ FLAGS_MAYBE="\
     -realcompare         \
     -observertrans       \
     -shiftnegative       \
-    -exitarg             \
     -freshtrans          \
     -abstract            \
     -statictrans"
diff --git a/test.c b/test.c
index 5756d452a30983862062a215c41eb4024ff8b230..0762876735d4a30bd469fb567dbdc37c35b2900b 100644 (file)
--- a/test.c
+++ b/test.c
@@ -121,7 +121,7 @@ FILE ** task_popen(const char *command, const char *mode) {
         close(2), dup(errhandle[1]);
 
         execvp(*argv, argv);
-        exit(1);
+        exit(EXIT_FAILURE);
     } else {
         /* fork failed */
         goto task_popen_error_3;