]> de.git.xonotic.org Git - xonotic/xonotic-data.pk3dir.git/blobdiff - qcsrc/common/weapons/w_minelayer.qc
Merge branch 'master' into samual/weapons
[xonotic/xonotic-data.pk3dir.git] / qcsrc / common / weapons / w_minelayer.qc
index 8ac784f0b7b1a7321f7b64225099f392fbd4c41e..198097bfb903fa8a7420eac9ef64ced6e33ceb38 100644 (file)
@@ -1,57 +1,66 @@
 #ifdef REGISTER_WEAPON
 REGISTER_WEAPON(
-/* WEP_##id */ MINE_LAYER,
-/* function */ w_minelayer,
-/* ammotype */ IT_ROCKETS,
-/* impulse  */ 4,
-/* flags    */ WEP_FLAG_MUTATORBLOCKED | WEP_FLAG_RELOADABLE | WEP_TYPE_SPLASH,
-/* rating   */ BOT_PICKUP_RATING_HIGH,
-/* model    */ "minelayer",
-/* netname  */ "minelayer",
-/* fullname */ _("Mine Layer")
+/* WEP_##id  */ MINE_LAYER,
+/* function  */ W_MineLayer,
+/* ammotype  */ ammo_rockets,
+/* impulse   */ 4,
+/* flags     */ WEP_FLAG_MUTATORBLOCKED | WEP_FLAG_RELOADABLE | WEP_TYPE_SPLASH,
+/* rating    */ BOT_PICKUP_RATING_HIGH,
+/* color     */ '0.75 1 0',
+/* modelname */ "minelayer",
+/* simplemdl */ "foobar",
+/* crosshair */ "gfx/crosshairminelayer 0.9",
+/* wepimg    */ "weaponminelayer",
+/* refname   */ "minelayer",
+/* wepname   */ _("Mine Layer")
 );
 
-#define MINELAYER_SETTINGS(weapon) \
-       WEP_ADD_CVAR(weapon, MO_NONE, ammo) \
-       WEP_ADD_CVAR(weapon, MO_NONE, animtime) \
-       WEP_ADD_CVAR(weapon, MO_NONE, damage) \
-       WEP_ADD_CVAR(weapon, MO_NONE, damageforcescale) \
-       WEP_ADD_CVAR(weapon, MO_NONE, detonatedelay) \
-       WEP_ADD_CVAR(weapon, MO_NONE, edgedamage) \
-       WEP_ADD_CVAR(weapon, MO_NONE, force) \
-       WEP_ADD_CVAR(weapon, MO_NONE, health) \
-       WEP_ADD_CVAR(weapon, MO_NONE, lifetime) \
-       WEP_ADD_CVAR(weapon, MO_NONE, lifetime_countdown) \
-       WEP_ADD_CVAR(weapon, MO_NONE, limit) \
-       WEP_ADD_CVAR(weapon, MO_NONE, protection) \
-       WEP_ADD_CVAR(weapon, MO_NONE, proximityradius) \
-       WEP_ADD_CVAR(weapon, MO_NONE, radius) \
-       WEP_ADD_CVAR(weapon, MO_NONE, refire) \
-       WEP_ADD_CVAR(weapon, MO_NONE, remote_damage) \
-       WEP_ADD_CVAR(weapon, MO_NONE, remote_edgedamage) \
-       WEP_ADD_CVAR(weapon, MO_NONE, remote_force) \
-       WEP_ADD_CVAR(weapon, MO_NONE, remote_radius) \
-       WEP_ADD_CVAR(weapon, MO_NONE, speed) \
-       WEP_ADD_CVAR(weapon, MO_NONE, time) \
-       WEP_ADD_PROP(weapon, reloading_ammo, reload_ammo) \
-       WEP_ADD_PROP(weapon, reloading_time, reload_time) \
-       WEP_ADD_PROP(weapon, switchdelay_raise, switchdelay_raise) \
-       WEP_ADD_PROP(weapon, switchdelay_drop, switchdelay_drop)
+#define MINELAYER_SETTINGS(w_cvar,w_prop) MINELAYER_SETTINGS_LIST(w_cvar, w_prop, MINE_LAYER, minelayer)
+#define MINELAYER_SETTINGS_LIST(w_cvar,w_prop,id,sn) \
+       w_cvar(id, sn, NONE, ammo) \
+       w_cvar(id, sn, NONE, animtime) \
+       w_cvar(id, sn, NONE, damage) \
+       w_cvar(id, sn, NONE, damageforcescale) \
+       w_cvar(id, sn, NONE, detonatedelay) \
+       w_cvar(id, sn, NONE, edgedamage) \
+       w_cvar(id, sn, NONE, force) \
+       w_cvar(id, sn, NONE, health) \
+       w_cvar(id, sn, NONE, lifetime) \
+       w_cvar(id, sn, NONE, lifetime_countdown) \
+       w_cvar(id, sn, NONE, limit) \
+       w_cvar(id, sn, NONE, protection) \
+       w_cvar(id, sn, NONE, proximityradius) \
+       w_cvar(id, sn, NONE, radius) \
+       w_cvar(id, sn, NONE, refire) \
+       w_cvar(id, sn, NONE, remote_damage) \
+       w_cvar(id, sn, NONE, remote_edgedamage) \
+       w_cvar(id, sn, NONE, remote_force) \
+       w_cvar(id, sn, NONE, remote_radius) \
+       w_cvar(id, sn, NONE, speed) \
+       w_cvar(id, sn, NONE, time) \
+       w_prop(id, sn, float,  reloading_ammo, reload_ammo) \
+       w_prop(id, sn, float,  reloading_time, reload_time) \
+       w_prop(id, sn, float,  switchdelay_raise, switchdelay_raise) \
+       w_prop(id, sn, float,  switchdelay_drop, switchdelay_drop) \
+       w_prop(id, sn, string, weaponreplace, weaponreplace) \
+       w_prop(id, sn, float,  weaponstart, weaponstart) \
+       w_prop(id, sn, float,  weaponstartoverride, weaponstartoverride) \
+       w_prop(id, sn, float,  weaponthrowable, weaponthrowable)
 
 #ifdef SVQC
-MINELAYER_SETTINGS(minelayer)
-void W_Mine_Think (void);
+MINELAYER_SETTINGS(WEP_ADD_CVAR, WEP_ADD_PROP)
+void W_MineLayer_Think(void);
 .float minelayer_detonate, mine_explodeanyway;
 .float mine_time;
 .vector mine_orientation;
 #endif
 #else
 #ifdef SVQC
-void spawnfunc_weapon_minelayer() { weapon_defaultspawnfunc(WEP_MINE_LAYER); }
+void spawnfunc_weapon_minelayer(void) { weapon_defaultspawnfunc(WEP_MINE_LAYER); }
 
-void W_Mine_Stick (entity to)
+void W_MineLayer_Stick(entity to)
 {
-       spamsound (self, CH_SHOTS, "weapons/mine_stick.wav", VOL_BASE, ATTN_NORM);
+       spamsound(self, CH_SHOTS, "weapons/mine_stick.wav", VOL_BASE, ATTN_NORM);
 
        // in order for mines to face properly when sticking to the ground, they must be a server side entity rather than a csqc projectile
 
@@ -84,7 +93,7 @@ void W_Mine_Stick (entity to)
        newmine.mine_time = self.mine_time;
 
        newmine.touch = func_null;
-       newmine.think = W_Mine_Think;
+       newmine.think = W_MineLayer_Think;
        newmine.nextthink = time;
        newmine.cnt = self.cnt;
        newmine.flags = self.flags;
@@ -96,11 +105,11 @@ void W_Mine_Stick (entity to)
                SetMovetypeFollow(self, to);
 }
 
-void W_Mine_Explode ()
+void W_MineLayer_Explode(void)
 {
        if(other.takedamage == DAMAGE_AIM)
                if(IS_PLAYER(other))
-                       if(IsDifferentTeam(self.realowner, other))
+                       if(DIFF_TEAM(self.realowner, other))
                                if(other.deadflag == DEAD_NO)
                                        if(IsFlying(other))
                                                Send_Notification(NOTIF_ONE, self.realowner, MSG_ANNCE, ANNCE_ACHIEVEMENT_AIRSHOT);
@@ -108,14 +117,14 @@ void W_Mine_Explode ()
        self.event_damage = func_null;
        self.takedamage = DAMAGE_NO;
 
-       RadiusDamage (self, self.realowner, WEP_CVAR(minelayer, damage), WEP_CVAR(minelayer, edgedamage), WEP_CVAR(minelayer, radius), world, world, WEP_CVAR(minelayer, force), self.projectiledeathtype, other);
+       RadiusDamage(self, self.realowner, WEP_CVAR(minelayer, damage), WEP_CVAR(minelayer, edgedamage), WEP_CVAR(minelayer, radius), world, world, WEP_CVAR(minelayer, force), self.projectiledeathtype, other);
 
-       if (self.realowner.weapon == WEP_MINE_LAYER)
+       if(self.realowner.weapon == WEP_MINE_LAYER)
        {
                entity oldself;
                oldself = self;
                self = self.realowner;
-               if (!WEP_ACTION(WEP_MINE_LAYER, WR_CHECKAMMO1))
+               if(!WEP_ACTION(WEP_MINE_LAYER, WR_CHECKAMMO1))
                {
                        self.cnt = WEP_MINE_LAYER;
                        ATTACK_FINISHED(self) = time;
@@ -124,10 +133,10 @@ void W_Mine_Explode ()
                self = oldself;
        }
        self.realowner.minelayer_mines -= 1;
-       remove (self);
+       remove(self);
 }
 
-void W_Mine_DoRemoteExplode ()
+void W_MineLayer_DoRemoteExplode(void)
 {
        self.event_damage = func_null;
        self.takedamage = DAMAGE_NO;
@@ -135,14 +144,14 @@ void W_Mine_DoRemoteExplode ()
        if(self.movetype == MOVETYPE_NONE || self.movetype == MOVETYPE_FOLLOW)
                self.velocity = self.mine_orientation; // particle fx and decals need .velocity
 
-       RadiusDamage (self, self.realowner, WEP_CVAR(minelayer, remote_damage), WEP_CVAR(minelayer, remote_edgedamage), WEP_CVAR(minelayer, remote_radius), world, world, WEP_CVAR(minelayer, remote_force), self.projectiledeathtype | HITTYPE_BOUNCE, world);
+       RadiusDamage(self, self.realowner, WEP_CVAR(minelayer, remote_damage), WEP_CVAR(minelayer, remote_edgedamage), WEP_CVAR(minelayer, remote_radius), world, world, WEP_CVAR(minelayer, remote_force), self.projectiledeathtype | HITTYPE_BOUNCE, world);
 
-       if (self.realowner.weapon == WEP_MINE_LAYER)
+       if(self.realowner.weapon == WEP_MINE_LAYER)
        {
                entity oldself;
                oldself = self;
                self = self.realowner;
-               if (!WEP_ACTION(WEP_MINE_LAYER, WR_CHECKAMMO1))
+               if(!WEP_ACTION(WEP_MINE_LAYER, WR_CHECKAMMO1))
                {
                        self.cnt = WEP_MINE_LAYER;
                        ATTACK_FINISHED(self) = time;
@@ -151,10 +160,10 @@ void W_Mine_DoRemoteExplode ()
                self = oldself;
        }
        self.realowner.minelayer_mines -= 1;
-       remove (self);
+       remove(self);
 }
 
-void W_Mine_RemoteExplode ()
+void W_MineLayer_RemoteExplode(void)
 {
        if(self.realowner.deadflag == DEAD_NO)
                if((self.spawnshieldtime >= 0)
@@ -162,11 +171,11 @@ void W_Mine_RemoteExplode ()
                        : (vlen(NearestPointOnBox(self.realowner, self.origin) - self.origin) > WEP_CVAR(minelayer, remote_radius)) // safety device
                )
                {
-                       W_Mine_DoRemoteExplode();
+                       W_MineLayer_DoRemoteExplode();
                }
 }
 
-void W_Mine_ProximityExplode ()
+void W_MineLayer_ProximityExplode(void)
 {
        // make sure no friend is in the mine's radius. If there is any, explosion is delayed until he's at a safe distance
        if(WEP_CVAR(minelayer, protection) && self.mine_explodeanyway == 0)
@@ -175,17 +184,17 @@ void W_Mine_ProximityExplode ()
                head = findradius(self.origin, WEP_CVAR(minelayer, radius));
                while(head)
                {
-                       if(head == self.realowner || !IsDifferentTeam(head, self.realowner))
+                       if(head == self.realowner || SAME_TEAM(head, self.realowner))
                                return;
                        head = head.chain;
                }
        }
 
        self.mine_time = 0;
-       W_Mine_Explode();
+       W_MineLayer_Explode();
 }
 
-float W_Mine_Count(entity e)
+float W_MineLayer_Count(entity e)
 {
        float minecount = 0;
        entity mine;
@@ -195,7 +204,7 @@ float W_Mine_Count(entity e)
        return minecount;
 }
 
-void W_Mine_Think (void)
+void W_MineLayer_Think(void)
 {
        entity head;
 
@@ -212,21 +221,21 @@ void W_Mine_Think (void)
        
        // our lifetime has expired, it's time to die - mine_time just allows us to play a sound for this
        // TODO: replace this mine_trigger.wav sound with a real countdown
-       if ((time > self.cnt) && (!self.mine_time))
+       if((time > self.cnt) && (!self.mine_time))
        {
                if(WEP_CVAR(minelayer, lifetime_countdown) > 0)
-                       spamsound (self, CH_SHOTS, "weapons/mine_trigger.wav", VOL_BASE, ATTN_NORM);
+                       spamsound(self, CH_SHOTS, "weapons/mine_trigger.wav", VOL_BASE, ATTN_NORM);
                self.mine_time = time + WEP_CVAR(minelayer, lifetime_countdown);
                self.mine_explodeanyway = 1; // make the mine super aggressive -- Samual: Rather, make it not care if a team mate is near.
        }
 
        // a player's mines shall explode if he disconnects or dies
        // TODO: Do this on team change too -- Samual: But isn't a player killed when they switch teams?
-       if(!IS_PLAYER(self.realowner) || self.realowner.deadflag != DEAD_NO)
+       if(!IS_PLAYER(self.realowner) || self.realowner.deadflag != DEAD_NO || self.realowner.freezetag_frozen)
        {
                other = world;
                self.projectiledeathtype |= HITTYPE_BOUNCE;
-               W_Mine_Explode();
+               W_MineLayer_Explode();
                return;
        }
 
@@ -234,11 +243,11 @@ void W_Mine_Think (void)
        head = findradius(self.origin, WEP_CVAR(minelayer, proximityradius));
        while(head)
        {
-               if(IS_PLAYER(head) && head.deadflag == DEAD_NO)
-               if(head != self.realowner && IsDifferentTeam(head, self.realowner)) // don't trigger for team mates
+               if(IS_PLAYER(head) && head.deadflag == DEAD_NO && !head.freezetag_frozen)
+               if(head != self.realowner && DIFF_TEAM(head, self.realowner)) // don't trigger for team mates
                if(!self.mine_time)
                {
-                       spamsound (self, CH_SHOTS, "weapons/mine_trigger.wav", VOL_BASE, ATTN_NORM);
+                       spamsound(self, CH_SHOTS, "weapons/mine_trigger.wav", VOL_BASE, ATTN_NORM);
                        self.mine_time = time + WEP_CVAR(minelayer, time);
                }
                head = head.chain;
@@ -247,18 +256,18 @@ void W_Mine_Think (void)
        // explode if it's time to
        if(self.mine_time && time >= self.mine_time)
        {
-               W_Mine_ProximityExplode();
+               W_MineLayer_ProximityExplode();
                return;
        }
 
        // remote detonation
-       if (self.realowner.weapon == WEP_MINE_LAYER)
-       if (self.realowner.deadflag == DEAD_NO)
-       if (self.minelayer_detonate)
-               W_Mine_RemoteExplode();
+       if(self.realowner.weapon == WEP_MINE_LAYER)
+       if(self.realowner.deadflag == DEAD_NO)
+       if(self.minelayer_detonate)
+               W_MineLayer_RemoteExplode();
 }
 
-void W_Mine_Touch (void)
+void W_MineLayer_Touch(void)
 {
        if(self.movetype == MOVETYPE_NONE || self.movetype == MOVETYPE_FOLLOW)
                return; // we're already a stuck mine, why do we get called? TODO does this even happen?
@@ -277,28 +286,28 @@ void W_Mine_Touch (void)
        }
        else
        {
-               W_Mine_Stick(other);
+               W_MineLayer_Stick(other);
        }
 }
 
-void W_Mine_Damage (entity inflictor, entity attacker, float damage, float deathtype, vector hitloc, vector force)
+void W_MineLayer_Damage(entity inflictor, entity attacker, float damage, float deathtype, vector hitloc, vector force)
 {
-       if (self.health <= 0)
+       if(self.health <= 0)
                return;
                
        float is_from_enemy = (inflictor.realowner != self.realowner);
                
-       if (!W_CheckProjectileDamage(inflictor.realowner, self.realowner, deathtype, (is_from_enemy ? 1 : -1)))
+       if(!W_CheckProjectileDamage(inflictor.realowner, self.realowner, deathtype, (is_from_enemy ? 1 : -1)))
                return; // g_projectiles_damage says to halt
                
        self.health = self.health - damage;
        self.angles = vectoangles(self.velocity);
        
-       if (self.health <= 0)
-               W_PrepareExplosionByDamage(attacker, W_Mine_Explode);
+       if(self.health <= 0)
+               W_PrepareExplosionByDamage(attacker, W_MineLayer_Explode);
 }
 
-void W_Mine_Attack (void)
+void W_MineLayer_Attack(void)
 {
        entity mine;
        entity flash;
@@ -315,9 +324,9 @@ void W_Mine_Attack (void)
                }
        }
 
-       W_DecreaseAmmo(ammo_rockets, WEP_CVAR(minelayer, ammo), autocvar_g_balance_minelayer_reload_ammo);
+       W_DecreaseAmmo(WEP_CVAR(minelayer, ammo));
 
-       W_SetupShot_ProjectileSize (self, '-4 -4 -4', '4 4 4', FALSE, 5, "weapons/mine_fire.wav", CH_WEAPON_A, WEP_CVAR(minelayer, damage));
+       W_SetupShot_ProjectileSize(self, '-4 -4 -4', '4 4 4', FALSE, 5, "weapons/mine_fire.wav", CH_WEAPON_A, WEP_CVAR(minelayer, damage));
        pointparticles(particleeffectnum("rocketlauncher_muzzleflash"), w_shotorg, w_shotdir * 1000, 1);
 
        mine = WarpZone_RefSys_SpawnSameRefSys(self);
@@ -333,20 +342,20 @@ void W_Mine_Attack (void)
        mine.takedamage = DAMAGE_YES;
        mine.damageforcescale = WEP_CVAR(minelayer, damageforcescale);
        mine.health = WEP_CVAR(minelayer, health);
-       mine.event_damage = W_Mine_Damage;
+       mine.event_damage = W_MineLayer_Damage;
        mine.damagedbycontents = TRUE;
 
        mine.movetype = MOVETYPE_TOSS;
        PROJECTILE_MAKETRIGGER(mine);
        mine.projectiledeathtype = WEP_MINE_LAYER;
-       setsize (mine, '-4 -4 -4', '4 4 4'); // give it some size so it can be shot
+       setsize(mine, '-4 -4 -4', '4 4 4'); // give it some size so it can be shot
 
-       setorigin (mine, w_shotorg - v_forward * 4); // move it back so it hits the wall at the right point
-       W_SetupProjectileVelocity(mine, WEP_CVAR(minelayer, speed), 0);
-       mine.angles = vectoangles (mine.velocity);
+       setorigin(mine, w_shotorg - v_forward * 4); // move it back so it hits the wall at the right point
+       W_SetupProjVelocity_Basic(mine, WEP_CVAR(minelayer, speed), 0);
+       mine.angles = vectoangles(mine.velocity);
 
-       mine.touch = W_Mine_Touch;
-       mine.think = W_Mine_Think;
+       mine.touch = W_MineLayer_Touch;
+       mine.think = W_MineLayer_Think;
        mine.nextthink = time;
        mine.cnt = time + (WEP_CVAR(minelayer, lifetime) - WEP_CVAR(minelayer, lifetime_countdown));
        mine.flags = FL_PROJECTILE;
@@ -355,9 +364,9 @@ void W_Mine_Attack (void)
        CSQCProjectile(mine, TRUE, PROJECTILE_MINE, TRUE);
 
        // muzzle flash for 1st person view
-       flash = spawn ();
-       setmodel (flash, "models/flash.md3"); // precision set below
-       SUB_SetFade (flash, time, 0.1);
+       flash = spawn();
+       setmodel(flash, "models/flash.md3"); // precision set below
+       SUB_SetFade(flash, time, 0.1);
        flash.effects = EF_ADDITIVE | EF_FULLBRIGHT | EF_LOWPRECISION;
        W_AttachToShotorg(flash, '5 0 0');
 
@@ -365,10 +374,10 @@ void W_Mine_Attack (void)
 
        other = mine; MUTATOR_CALLHOOK(EditProjectile);
        
-       self.minelayer_mines = W_Mine_Count(self);
+       self.minelayer_mines = W_MineLayer_Count(self);
 }
 
-float W_PlacedMines(float detonate)
+float W_MineLayer_PlacedMines(float detonate)
 {
        entity mine;
        float minfound = 0;
@@ -389,7 +398,7 @@ float W_PlacedMines(float detonate)
        return minfound;
 }
 
-float w_minelayer(float req)
+float W_MineLayer(float req)
 {
        entity mine;
        float ammo_amount;
@@ -417,24 +426,24 @@ float w_minelayer(float req)
                                enemydamage = 0;
                                targetlist = findchainfloat(bot_attack, TRUE);
                                mine = find(world, classname, "mine");
-                               while (mine)
+                               while(mine)
                                {
-                                       if (mine.realowner != self)
+                                       if(mine.realowner != self)
                                        {
                                                mine = find(mine, classname, "mine");
                                                continue;
                                        }
                                        targ = targetlist;
-                                       while (targ)
+                                       while(targ)
                                        {
                                                d = vlen(targ.origin + (targ.mins + targ.maxs) * 0.5 - mine.origin);
                                                d = bound(0, edgedamage + (coredamage - edgedamage) * sqrt(1 - d * recipricoledgeradius), 10000);
                                                // count potential damage according to type of target
-                                               if (targ == self)
+                                               if(targ == self)
                                                        selfdamage = selfdamage + d;
-                                               else if (targ.team == self.team && teamplay)
+                                               else if(targ.team == self.team && teamplay)
                                                        teamdamage = teamdamage + d;
-                                               else if (bot_shouldattack(targ))
+                                               else if(bot_shouldattack(targ))
                                                        enemydamage = enemydamage + d;
                                                targ = targ.chain;
                                        }
@@ -442,27 +451,27 @@ float w_minelayer(float req)
                                }
                                float desirabledamage;
                                desirabledamage = enemydamage;
-                               if (time > self.invincible_finished && time > self.spawnshieldtime)
+                               if(time > self.invincible_finished && time > self.spawnshieldtime)
                                        desirabledamage = desirabledamage - selfdamage * autocvar_g_balance_selfdamagepercent;
-                               if (teamplay && self.team)
+                               if(teamplay && self.team)
                                        desirabledamage = desirabledamage - teamdamage;
 
                                mine = find(world, classname, "mine");
-                               while (mine)
+                               while(mine)
                                {
-                                       if (mine.realowner != self)
+                                       if(mine.realowner != self)
                                        {
                                                mine = find(mine, classname, "mine");
                                                continue;
                                        }
                                        makevectors(mine.v_angle);
                                        targ = targetlist;
-                                       if (skill > 9) // normal players only do this for the target they are tracking
+                                       if(skill > 9) // normal players only do this for the target they are tracking
                                        {
                                                targ = targetlist;
-                                               while (targ)
+                                               while(targ)
                                                {
-                                                       if (
+                                                       if(
                                                                (v_forward * normalize(mine.origin - targ.origin)< 0.1)
                                                                && desirabledamage > 0.1*coredamage
                                                        )self.BUTTON_ATCK2 = TRUE;
@@ -484,13 +493,13 @@ float w_minelayer(float req)
                                }
                                // if we would be doing at X percent of the core damage, detonate it
                                // but don't fire a new shot at the same time!
-                               if (desirabledamage >= 0.75 * coredamage) //this should do group damage in rare fortunate events
+                               if(desirabledamage >= 0.75 * coredamage) //this should do group damage in rare fortunate events
                                        self.BUTTON_ATCK2 = TRUE;
-                               if ((skill > 6.5) && (selfdamage > self.health))
+                               if((skill > 6.5) && (selfdamage > self.health))
                                        self.BUTTON_ATCK2 = FALSE;
                                //if(self.BUTTON_ATCK2 == TRUE)
                                //      dprint(ftos(desirabledamage),"\n");
-                               if (self.BUTTON_ATCK2 == TRUE) self.BUTTON_ATCK = FALSE;
+                               if(self.BUTTON_ATCK2 == TRUE) self.BUTTON_ATCK = FALSE;
                        }
                        
                        return TRUE;
@@ -500,51 +509,46 @@ float w_minelayer(float req)
                        if(autocvar_g_balance_minelayer_reload_ammo && self.clip_load < WEP_CVAR(minelayer, ammo)) // forced reload
                        {
                                // not if we're holding the minelayer without enough ammo, but can detonate existing mines
-                               if not (W_PlacedMines(FALSE) && self.ammo_rockets < WEP_CVAR(minelayer, ammo))
+                               if(!(W_MineLayer_PlacedMines(FALSE) && self.WEP_AMMO(MINE_LAYER) < WEP_CVAR(minelayer, ammo)))
                                        WEP_ACTION(self.weapon, WR_RELOAD);
                        }
-                       else if (self.BUTTON_ATCK)
+                       else if(self.BUTTON_ATCK)
                        {
                                if(weapon_prepareattack(0, WEP_CVAR(minelayer, refire)))
                                {
-                                       W_Mine_Attack();
+                                       W_MineLayer_Attack();
                                        weapon_thinkf(WFRAME_FIRE1, WEP_CVAR(minelayer, animtime), w_ready);
                                }
                        }
 
-                       if (self.BUTTON_ATCK2)
+                       if(self.BUTTON_ATCK2)
                        {
-                               if(W_PlacedMines(TRUE))
-                                       sound (self, CH_WEAPON_B, "weapons/mine_det.wav", VOL_BASE, ATTN_NORM);
+                               if(W_MineLayer_PlacedMines(TRUE))
+                                       sound(self, CH_WEAPON_B, "weapons/mine_det.wav", VOL_BASE, ATTN_NORM);
                        }
                        
                        return TRUE;
                }
                case WR_INIT:
                {
-                       precache_model ("models/flash.md3");
-                       precache_model ("models/mine.md3");
-                       precache_model ("models/weapons/g_minelayer.md3");
-                       precache_model ("models/weapons/v_minelayer.md3");
-                       precache_model ("models/weapons/h_minelayer.iqm");
-                       precache_sound ("weapons/mine_det.wav");
-                       precache_sound ("weapons/mine_fire.wav");
-                       precache_sound ("weapons/mine_stick.wav");
-                       precache_sound ("weapons/mine_trigger.wav");
-                       WEP_SET_PROPS(MINELAYER_SETTINGS(minelayer), WEP_MINE_LAYER)
-                       return TRUE;
-               }
-               case WR_SETUP:
-               {
-                       self.current_ammo = ammo_rockets;
+                       precache_model("models/flash.md3");
+                       precache_model("models/mine.md3");
+                       precache_model("models/weapons/g_minelayer.md3");
+                       precache_model("models/weapons/v_minelayer.md3");
+                       precache_model("models/weapons/h_minelayer.iqm");
+                       precache_sound("weapons/mine_det.wav");
+                       precache_sound("weapons/mine_fire.wav");
+                       precache_sound("weapons/mine_stick.wav");
+                       precache_sound("weapons/mine_trigger.wav");
+                       MINELAYER_SETTINGS(WEP_SKIP_CVAR, WEP_SET_PROP)
                        return TRUE;
                }
                case WR_CHECKAMMO1:
                {
                        // don't switch while placing a mine
-                       if (ATTACK_FINISHED(self) <= time || self.weapon != WEP_MINE_LAYER)
+                       if(ATTACK_FINISHED(self) <= time || self.weapon != WEP_MINE_LAYER)
                        {
-                               ammo_amount = self.ammo_rockets >= WEP_CVAR(minelayer, ammo);
+                               ammo_amount = self.WEP_AMMO(MINE_LAYER) >= WEP_CVAR(minelayer, ammo);
                                ammo_amount += self.(weapon_load[WEP_MINE_LAYER]) >= WEP_CVAR(minelayer, ammo);
                                return ammo_amount;
                        }
@@ -552,14 +556,14 @@ float w_minelayer(float req)
                }
                case WR_CHECKAMMO2:
                {
-                       if (W_PlacedMines(FALSE))
+                       if(W_MineLayer_PlacedMines(FALSE))
                                return TRUE;
                        else
                                return FALSE;
                }
                case WR_CONFIG:
                {
-                       WEP_CONFIG_SETTINGS(MINELAYER_SETTINGS(minelayer))
+                       MINELAYER_SETTINGS(WEP_CONFIG_WRITE_CVARS, WEP_CONFIG_WRITE_PROPS)
                        return TRUE;
                }
                case WR_RESETPLAYER:
@@ -569,7 +573,7 @@ float w_minelayer(float req)
                }
                case WR_RELOAD:
                {
-                       W_Reload(WEP_CVAR(minelayer, ammo), autocvar_g_balance_minelayer_reload_ammo, autocvar_g_balance_minelayer_reload_time, "weapons/reload.wav");
+                       W_Reload(WEP_CVAR(minelayer, ammo), "weapons/reload.wav");
                        return TRUE;
                }
                case WR_SUICIDEMESSAGE:
@@ -581,11 +585,11 @@ float w_minelayer(float req)
                        return WEAPON_MINELAYER_MURDER;
                }
        }
-       return TRUE;
+       return FALSE;
 }
 #endif
 #ifdef CSQC
-float w_minelayer(float req)
+float W_MineLayer(float req)
 {
        switch(req)
        {
@@ -604,8 +608,13 @@ float w_minelayer(float req)
                        precache_sound("weapons/mine_exp.wav");
                        return TRUE;
                }
+               case WR_ZOOMRETICLE:
+               {
+                       // no weapon specific image for this weapon
+                       return FALSE;
+               }
        }
-       return TRUE;
+       return FALSE;
 }
 #endif
 #endif