X-Git-Url: http://de.git.xonotic.org/?p=xonotic%2Fxonotic-data.pk3dir.git;a=blobdiff_plain;f=qcsrc%2Fcommon%2Fstate.qc;h=37813ef716c0bd5f393bc45a1f2fad39036e7b0b;hp=a9bc3e5e3cf8aa379ead84d3cc37163b70e46df1;hb=69eda62d02bc02ff50547bad514af3f7ce487413;hpb=f6a5832d12fbcf7fb4f44778063e2c251b9d0a38

diff --git a/qcsrc/common/state.qc b/qcsrc/common/state.qc
index a9bc3e5e3..37813ef71 100644
--- a/qcsrc/common/state.qc
+++ b/qcsrc/common/state.qc
@@ -17,20 +17,20 @@ void PlayerState_detach(entity this)
 	PS(this) = NULL;
 
 	if (ps.m_client != this) return;  // don't own state, spectator
-	
+	ps.ps_push(ps, this);
+
 	FOREACH_CLIENT(PS(it) == ps, { PS(it) = NULL; });
 	delete(ps);
 
     Inventory_delete(this);
 }
 
-void GetCvars(entity this, int);
+void GetCvars(entity this, entity store, int);
 void DecodeLevelParms(entity this);
 void PlayerScore_Attach(entity this);
 void ClientData_Attach(entity this);
 void accuracy_init(entity this);
 void entcs_attach(entity this);
-void playerdemo_init(entity this);
 void anticheat_init(entity this);
 void W_HitPlotOpen(entity this);
 void bot_clientconnect(entity this);
@@ -39,7 +39,7 @@ void ClientState_attach(entity this)
 {
 	this._cs = NEW(ClientState, this);
 
-    GetCvars(this, 0);  // get other cvars from player
+    GetCvars(this, CS(this), 0);  // get other cvars from player
 
 	// TODO: fold all of these into ClientState
 
@@ -50,7 +50,6 @@ void ClientState_attach(entity this)
 	ClientData_Attach(this);
 	accuracy_init(this);
 	entcs_attach(this);
-	playerdemo_init(this);
 	anticheat_init(this);
 	W_HitPlotOpen(this);
 
@@ -60,7 +59,6 @@ void ClientState_attach(entity this)
 void bot_clientdisconnect(entity this);
 void W_HitPlotClose(entity this);
 void anticheat_report_to_eventlog(entity this);
-void playerdemo_shutdown(entity this);
 void entcs_detach(entity this);
 void accuracy_free(entity this);
 void ClientData_Detach(entity this);
@@ -68,18 +66,17 @@ void PlayerScore_Detach(entity this);
 
 void ClientState_detach(entity this)
 {
+    GetCvars(this, CS(this), -1);  // free cvars TODO: is this still needed now that it's stored on the clientstate entity?
+    accuracy_free(this); // TODO: needs to be before CS() is deleted!
+    PlayerScore_Detach(this); // what ^they^ said
+    W_HitPlotClose(this);
+    ClientData_Detach(this);
 	delete(CS(this));
 	this._cs = NULL;
 
-    GetCvars(this, -1);  // free cvars
 
     bot_clientdisconnect(this);
 
-    W_HitPlotClose(this);
     anticheat_report_to_eventlog(this);
-    playerdemo_shutdown(this);
     entcs_detach(this);
-    accuracy_free(this);
-    ClientData_Detach(this);
-    PlayerScore_Detach(this);
 }