]> de.git.xonotic.org Git - xonotic/xonotic-maps.pk3dir.git/blobdiff - scripts/shader-audit.sh
improve texture blend handling
[xonotic/xonotic-maps.pk3dir.git] / scripts / shader-audit.sh
index 5de24bc4ff580eb15399a5fc1b0b961010a2f527..34ac1bc58c129b15e525f36e08f1321ae37f6ae9 100755 (executable)
@@ -89,13 +89,13 @@ use_texture()
 
        if [ x"$3" = x"map" ]; then
                lasttex=$2
-               if [ -n "$AUDIT_ALPHACHANNELS" ]; then
+               if [ -n "$AUDIT_ALPHACHANNELS" ] && [ x"$offsetmapping_match8" != x"firststagedone" ]; then
                        if [ -f "../${2}_norm.tga" ] || [ -f "../${2}_norm.png" ] || [ -f "../${2}_norm.jpg" ]; then
                                case "$offsetmapping_match8" in
                                        '') # no dpoffsetmapping keyword
                                                getstats "../${2}_norm.tga" || getstats "../${2}_norm.png" || getstats "../${2}_norm.jpg"
                                                if [ "$min" -eq "$max" ]; then
-                                                       echo "(EE) shader $1 uses broken normalmap ${2}_norm.tga (add dpoffsetmapping none)"; seterror
+                                                       echo "(WW) shader $1 uses broken normalmap ${2}_norm.tga (add dpoffsetmapping none)"
                                                else
                                                        echo "(EE) shader $1 uses ${2}_norm.tga but lacks median (add dpoffsetmapping - 1 match8 $median)"; seterror
                                                fi
@@ -105,7 +105,7 @@ use_texture()
                                        default) # offsetmapping keyword without bias
                                                getstats "../${2}_norm.tga"
                                                if [ "$min" -eq "$max" ]; then
-                                                       echo "(EE) shader $1 uses broken normalmap ${2}_norm.tga, maybe use dpoffsetmapping none?"; seterror
+                                                       echo "(WW) shader $1 uses broken normalmap ${2}_norm.tga, maybe use dpoffsetmapping none?"
                                                else
                                                        echo "(EE) shader $1 uses ${2}_norm.tga but lacks median (add to dpoffsetmapping: match8 $median)"; seterror
                                                fi
@@ -115,7 +115,7 @@ use_texture()
                                esac
                        else
                                if [ -n "$offsetmapping_match8" ]; then
-                                       echo "(EE) shader $1 specifies offsetmapping, but texture $2 does not have a normalmap"
+                                       echo "(WW) shader $1 specifies offsetmapping, but texture $2 does not have a normalmap"
                                fi
                        fi
                fi
@@ -272,6 +272,7 @@ parse_shaderstage()
 {
        ss_blendfunc=none
        ss_alphafunc=none
+       ss_alphagen=none
        ss_map=
        while read L A1 Aother; do
                case "`echo "$L" | tr A-Z a-z`" in
@@ -281,6 +282,9 @@ parse_shaderstage()
                        alphafunc)
                                ss_alphafunc=`echo $A1 | tr A-Z a-z`
                                ;;
+                       alphagen)
+                               ss_alphagen=`echo $A1 | tr A-Z a-z`
+                               ;;
                        map|clampmap)
                                case "$A1" in
                                        '$lightmap')
@@ -288,6 +292,7 @@ parse_shaderstage()
                                        *)
                                                use_texture "$parsing_shader" "`normalize "$A1"`" map
                                                ss_map="`normalize "$A1"`"
+                                               offsetmapping_match8=firststagedone
                                                ;;
                                esac
                                ;;
@@ -311,38 +316,26 @@ parse_shaderstage()
                esac
        done
 
-       if [ -n "$AUDIT_ALPHACHANNELS" ] && [ -n "$ss_map" ]; then
-               getstats "../$ss_map.tga" || getstats "../$ss_map.png" || getstats "../$ss_map.jpg"
-               case "$ss_blendfunc" in
-                       *src_alpha*|*blend*)
-                               # texture must have alpha
-                               if [ $min -eq 255 ]; then
-                                       echo "(EE) $parsing_shader uses alpha-less texture $ss_map with blendfunc $ss_blendfunc"; seterror
-                               fi
-                               ;;
-                       add|"gl_one gl_one")
-                               # texture must not have alpha (engine bug)
-                               if [ $min -lt 255 ]; then
-                                       echo "(EE) $parsing_shader uses alpha-using texture $ss_map with blendfunc $ss_blendfunc"; seterror
-                               fi
-                               ;;
-                       *)
-                               case "$ss_alphafunc" in
-                                       g*)
-                                               # texture must have alpha
-                                               if [ $min -eq 255 ]; then
-                                                       echo "(EE) $parsing_shader uses alpha-less texture $ss_map with alphafunc $ss_alphafunc"; seterror
-                                               fi
-                                               ;;
-                                       *)
-                                               # texture should not have alpha (no bug if not)
-                                               if [ $min -lt 255 ]; then
-                                                       echo "(WW) $parsing_shader uses alpha-using texture $ss_map with blendfunc $ss_blendfunc and alphafunc $ss_alphafunc"
-                                               fi
-                                               ;;
-                               esac
-                               ;;
-               esac
+       if [ -n "$ss_map" ]; then
+               if [ -z "$maintexture" ]; then
+                       maintexture=$ss_map
+                       mainblendfunc=$ss_blendfunc
+                       mainalphafunc=$ss_alphafunc
+                       mainalphagen=$ss_alphagen
+               elif [ x"$ss_alphagen" = x"vertex" ] && ! $textureblending; then
+                       case "$mainblendfunc:$mainalphafunc:$ss_blendfunc:$ss_alphafunc" in
+                               none:none:"gl_src_alpha gl_one_minus_src_alpha":none) textureblending=true ;;
+                               none:none:filter:none) textureblending=true ;;
+                               none:none:none:g*) textureblending=true ;;
+                               "gl_one gl_zero":none:filter:none) textureblending=true ;;
+                               "gl_one gl_zero":none:none:g*) textureblending=true ;;
+                               *)
+                                       echo "(EE) texture blending requires first stage to have no blendfunc/alphatest, and requires second stage to be blendfunc filter"; seterror
+                                       ;;
+                       esac
+               else
+                       echo "(EE) multistage shader without alphagen vertex, or using more than 2 stages, is not supported by DarkPlaces"; seterror
+               fi
        fi
 }
 
@@ -350,6 +343,8 @@ parse_shader()
 {
        use_texture "$parsing_shader" "$parsing_shader" shader
        offsetmapping_match8=
+       textureblending=false
+       maintexture=
        while read L A1 Aother; do
                case "`echo "$L" | tr A-Z a-z`" in
                        dpoffsetmapping)
@@ -393,6 +388,47 @@ parse_shader()
                                ;;
                esac
        done
+       if [ -n "$AUDIT_ALPHACHANNELS" ] && [ -n "$maintexture" ] && ! $textureblending; then
+               getstats "../$maintexture.tga" || getstats "../$maintexture.png" || getstats "../$maintexture.jpg"
+               case "$mainblendfunc" in
+                       *src_alpha*|*blend*)
+                               # texture must have alpha
+                               if [ x"$mainalphagen" = x"none" -a $min -eq 255 ]; then
+                                       echo "(EE) $parsing_shader uses alpha-less texture $maintexture with blendfunc $mainblendfunc and alphagen $mainalphagen"; seterror
+                               fi
+                               ;;
+                       add|"gl_one gl_one")
+                               # texture must not have alpha (engine bug)
+                               if [ x"$mainalphagen" != x"none" -o $min -lt 255 ]; then
+                                       echo "(EE) $parsing_shader uses alpha-using texture $maintexture with blendfunc $mainblendfunc and alphagen $mainalphagen"; seterror
+                               fi
+                               ;;
+                       *)
+                               case "$mainalphafunc" in
+                                       g*)
+                                               # texture must have alpha
+                                               if [ x"$mainalphagen" = x"none" -a $min -eq 255 ]; then
+                                                       echo "(EE) $parsing_shader uses alpha-less texture $maintexture with alphafunc $mainalphafunc and alphagen $mainalphagen"; seterror
+                                               fi
+                                               ;;
+                                       *)
+                                               # texture should not have alpha (no bug if not)
+                                               case "$mainalphagen" in
+                                                       none)
+                                                               if [ $min -lt 255 ]; then
+                                                                       echo "(WW) $parsing_shader uses alpha-using texture $maintexture with blendfunc $mainblendfunc and alphafunc $mainalphafunc and alphagen $mainalphagen"
+                                                               fi
+                                                               ;;
+                                                       *)
+                                                               # alphagen is set, but blendfunc has no use for it
+                                                               echo "(EE) $parsing_shader uses alpha-using texture $maintexture with blendfunc $mainblendfunc and alphafunc $mainalphafunc and alphagen $mainalphagen"; seterror
+                                                               ;;
+                                               esac
+                                               ;;
+                               esac
+                               ;;
+               esac
+       fi
 }
 
 parse_shaderfile()