also include alphagen

[xonotic/xonotic-maps.pk3dir.git] / scripts / shader-audit.sh

diff --git a/scripts/shader-audit.sh b/scripts/shader-audit.sh
index 3f0fb83b9e7c2ce6fbd9eecea1c3aca68ed12934..75e7e2825e4a2b16b1984b5a088f8e55d6284746 100755 (executable)
--- a/scripts/shader-audit.sh
+++ b/scripts/shader-audit.sh
@@ -27,7 +27,7 @@ forbidden_prefixes=
 
 getstats_e()
 {
-       identify -verbose -alpha extract -depth 8 "$1" | {
+       identify -verbose -depth 8 -alpha set -alpha extract "$1" | {
                pix=0
                while read -r L V R; do
                        case "$L" in
@@ -53,10 +53,16 @@ getstats_e()
                echo "min=$min"
                echo "max=$max"
                echo "median=$median"
+               echo "error=false"
        }
 }
 getstats()
 {
+       min=255
+       max=255
+       median=255
+       error=true
+       [ -f "$1" ] || return 1
        eval `getstats_e "$1"`
 }
 
@@ -83,15 +89,15 @@ use_texture()
 
        if [ x"$3" = x"map" ]; then
                lasttex=$2
-               if [ -n "$AUDIT_OFFSETMAPPING" ]; then
-                       if [ -f "../${2}_norm.tga" ]; then
+               if [ -n "$AUDIT_ALPHACHANNELS" ]; then
+                       if [ -f "../${2}_norm.tga" ] || [ -f "../${2}_norm.png" ] || [ -f "../${2}_norm.jpg" ]; then
                                case "$offsetmapping_match8" in
                                        '') # no dpoffsetmapping keyword
-                                               getstats "../${2}_norm.tga"
+                                               getstats "../${2}_norm.tga" || getstats "../${2}_norm.png" || getstats "../${2}_norm.jpg"
                                                if [ "$min" -eq "$max" ]; then
                                                        echo "(EE) shader $1 uses broken normalmap ${2}_norm.tga (add dpoffsetmapping none)"; seterror
                                                else
-                                                       echo "(EE) shader $1 uses ${2}_norm.tga but lacks median (add dpoffsetmapping with: match8 $median)"; seterror
+                                                       echo "(EE) shader $1 uses ${2}_norm.tga but lacks median (add dpoffsetmapping - 1 match8 $median)"; seterror
                                                fi
                                                ;;
                                        none) # offsetmapping turned off explicitly
@@ -264,14 +270,28 @@ use_texture()
 parsing_shader=
 parse_shaderstage()
 {
+       ss_blendfunc=none
+       ss_alphafunc=none
+       ss_alphagen=none
+       ss_map=
        while read L A1 Aother; do
                case "`echo "$L" | tr A-Z a-z`" in
+                       blendfunc)
+                               ss_blendfunc=`echo $A1 $Aother | tr A-Z a-z`
+                               ;;
+                       alphafunc)
+                               ss_alphafunc=`echo $A1 | tr A-Z a-z`
+                               ;;
+                       alphagen)
+                               ss_alphagen=`echo $A1 | tr A-Z a-z`
+                               ;;
                        map|clampmap)
                                case "$A1" in
                                        '$lightmap')
                                                ;;
                                        *)
                                                use_texture "$parsing_shader" "`normalize "$A1"`" map
+                                               ss_map="`normalize "$A1"`"
                                                ;;
                                esac
                                ;;
@@ -279,6 +299,10 @@ parse_shaderstage()
                                for X in $Aother; do
                                        use_texture "$parsing_shader" "`normalize "$X"`" animmap
                                done
+                               for X in $Aother; do
+                                       ss_map="`normalize "$X"`"
+                                       break
+                               done
                                ;;
                        '{')
                                echo "(EE) brace nesting error in $parsing_shader"; seterror
@@ -290,6 +314,47 @@ parse_shaderstage()
                                ;;
                esac
        done
+
+       if [ -n "$AUDIT_ALPHACHANNELS" ] && [ -n "$ss_map" ]; then
+               getstats "../$ss_map.tga" || getstats "../$ss_map.png" || getstats "../$ss_map.jpg"
+               case "$ss_blendfunc" in
+                       *src_alpha*|*blend*)
+                               # texture must have alpha
+                               if [ x"$ss_alphagen" = x"none" -a $min -eq 255 ]; then
+                                       echo "(EE) $parsing_shader uses alpha-less texture $ss_map with blendfunc $ss_blendfunc and alphagen $ss_alphagen"; seterror
+                               fi
+                               ;;
+                       add|"gl_one gl_one")
+                               # texture must not have alpha (engine bug)
+                               if [ x"$ss_alphagen" != x"none" -o $min -lt 255 ]; then
+                                       echo "(EE) $parsing_shader uses alpha-using texture $ss_map with blendfunc $ss_blendfunc and alphagen $ss_alphagen"; seterror
+                               fi
+                               ;;
+                       *)
+                               case "$ss_alphafunc" in
+                                       g*)
+                                               # texture must have alpha
+                                               if [ x"$ss_alphagen" = x"none" -a $min -eq 255 ]; then
+                                                       echo "(EE) $parsing_shader uses alpha-less texture $ss_map with alphafunc $ss_alphafunc and alphagen $ss_alphagen"; seterror
+                                               fi
+                                               ;;
+                                       *)
+                                               # texture should not have alpha (no bug if not)
+                                               case "$ss_alphagen" in
+                                                       none)
+                                                               if [ $min -lt 255 ]; then
+                                                                       echo "(WW) $parsing_shader uses alpha-using texture $ss_map with blendfunc $ss_blendfunc and alphafunc $ss_alphafunc and alphagen $ss_alphagen"
+                                                               fi
+                                                               ;;
+                                                       *)
+                                                               echo "(EE) $parsing_shader uses alpha-using texture $ss_map with blendfunc $ss_blendfunc and alphafunc $ss_alphafunc and alphagen $ss_alphagen"; seterror
+                                                               ;;
+                                               esac
+                                               ;;
+                               esac
+                               ;;
+               esac
+       fi
 }
 
 parse_shader()
@@ -394,7 +459,7 @@ for X in *.shader; do
 done
 rm -f "$t"
 
-textures_avail=`( cd ..; find textures/ -type f -not -name '*_norm.*' -not -name '*_glow.*' -not -name '*_gloss.*' -not -name '*_reflect.*' -not -name '*.xcf' ) | while IFS= read -r T; do normalize "$T"; done | sort -u`
+textures_avail=`( cd ..; find textures/ -type f -not -name '*.sh' -not -name '*_norm.*' -not -name '*_glow.*' -not -name '*_gloss.*' -not -name '*_reflect.*' -not -name '*.xcf' ) | while IFS= read -r T; do normalize "$T"; done | sort -u`
 textures_used=`echo "${textures_used#$LF}" | sort -u`
 
 echo "$textures_used$LF$textures_used$LF$textures_avail" | sort | uniq -u | while IFS= read -r L; do