X-Git-Url: https://de.git.xonotic.org/?a=blobdiff_plain;f=qcsrc%2Fcommon%2Fmapinfo.qc;h=ae387e3db9a576df164c92765a250bd1d9681923;hb=90d9f7c775306324957323d53d5a4ad995d999e3;hp=2ec902f68556d121bdceb8122adbef84f4edc999;hpb=edf01df130d0d1877461561178b8833a9ab6051c;p=xonotic%2Fxonotic-data.pk3dir.git diff --git a/qcsrc/common/mapinfo.qc b/qcsrc/common/mapinfo.qc index 2ec902f68..ae387e3db 100644 --- a/qcsrc/common/mapinfo.qc +++ b/qcsrc/common/mapinfo.qc @@ -1,13 +1,19 @@ +#include "mapinfo.qh" #if defined(CSQC) #include "../client/defs.qh" #include "util.qh" - #include - #include "mapinfo.qh" + #include #elif defined(MENUQC) #elif defined(SVQC) #include "util.qh" - #include - #include "mapinfo.qh" + #include +#endif + +#ifdef MENUQC +#define WARN_COND false +#else +bool autocvar_g_mapinfo_ignore_warnings; +#define WARN_COND (!autocvar_g_mapinfo_ignore_warnings && MapInfo_Map_bspname == mi_shortname) #endif // generic string stuff @@ -150,7 +156,11 @@ float _MapInfo_FilterList_cmp(float i, float j, entity pass) return strcasecmp(a, b); } -float MapInfo_FilterGametype(int pGametype, int pFeatures, int pFlagsRequired, int pFlagsForbidden, bool pAbortOnGenerate) +float MapInfo_FilterGametype(Gametype pGametype, int pFeatures, int pFlagsRequired, int pFlagsForbidden, bool pAbortOnGenerate) +{ + return _MapInfo_FilterGametype(pGametype.m_flags, pFeatures, pFlagsRequired, pFlagsForbidden, pAbortOnGenerate); +} +float _MapInfo_FilterGametype(int pGametype, int pFeatures, int pFlagsRequired, int pFlagsForbidden, bool pAbortOnGenerate) { float i, j; if (!_MapInfo_filtered_allocated) @@ -161,10 +171,10 @@ float MapInfo_FilterGametype(int pGametype, int pFeatures, int pFlagsRequired, i MapInfo_count = 0; for(i = 0, j = -1; i < _MapInfo_globcount; ++i) { - if(MapInfo_Get_ByName(_MapInfo_GlobItem(i), 1, 0) == 2) // if we generated one... BAIL OUT and let the caller continue in the next frame. + if(MapInfo_Get_ByName(_MapInfo_GlobItem(i), 1, NULL) == 2) // if we generated one... BAIL OUT and let the caller continue in the next frame. if(pAbortOnGenerate) { - LOG_TRACE("Autogenerated a .mapinfo, doing the rest later.\n"); + LOG_TRACE("Autogenerated a .mapinfo, doing the rest later."); MapInfo_progress = i / _MapInfo_globcount; return 0; } @@ -226,16 +236,13 @@ string MapInfo_BSPName_ByID(float i) string unquote(string s) { - float i, j, l; - l = strlen(s); - j = -1; - for(i = 0; i < l; ++i) + float l = strlen(s); + for(float i = 0; i < l; ++i) { - string ch; - ch = substring(s, i, 1); - if(ch != " ") if(ch != "\"") + string ch = substring(s, i, 1); + if((ch != " ") && (ch != "\"")) { - for(j = strlen(s) - i - 1; j > 0; --j) + for(float j = l - i - 1; j > 0; --j) { ch = substring(s, i+j, 1); if(ch != " ") if(ch != "\"") @@ -249,7 +256,7 @@ string unquote(string s) float MapInfo_Get_ByID(float i) { - if(MapInfo_Get_ByName(MapInfo_BSPName_ByID(i), 0, 0)) + if(MapInfo_Get_ByName(MapInfo_BSPName_ByID(i), 0, NULL)) return 1; return 0; } @@ -265,7 +272,6 @@ float _MapInfo_Generate(string pFilename) // 0: failure, 1: ok ent, 2: ok bsp float i; float inWorldspawn; float r; - float twoBaseModes; float diameter, spawnpoints; float spawnplaces; @@ -282,7 +288,7 @@ float _MapInfo_Generate(string pFilename) // 0: failure, 1: ok ent, 2: ok bsp } if(fh < 0) return 0; - LOG_INFO("Analyzing ", fn, " to generate initial mapinfo\n"); + LOG_INFO("Analyzing ", fn, " to generate initial mapinfo"); inWorldspawn = 2; MapInfo_Map_flags = 0; @@ -345,21 +351,7 @@ float _MapInfo_Generate(string pFilename) // 0: failure, 1: ok ent, 2: ok bsp } else if(k == "classname") { - if(v == "dom_controlpoint") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_DOMINATION; - else if(v == "item_flag_team2") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_CTF; - else if(v == "team_CTF_blueflag") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_CTF; - else if(v == "invasion_spawnpoint") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_INVASION; - else if(v == "target_assault_roundend") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_ASSAULT; - else if(v == "onslaught_generator") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_ONSLAUGHT; - else if(substring(v, 0, 8) == "nexball_" || substring(v, 0, 4) == "ball") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_NEXBALL; - else if(v == "info_player_team1") + if(v == "info_player_team1") ++spawnpoints; else if(v == "info_player_team2") ++spawnpoints; @@ -367,10 +359,6 @@ float _MapInfo_Generate(string pFilename) // 0: failure, 1: ok ent, 2: ok bsp ++spawnpoints; else if(v == "info_player_deathmatch") ++spawnpoints; - else if(v == "trigger_race_checkpoint") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_RACE; - else if(v == "target_startTimer") - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_CTS; else if(v == "weapon_nex") { } else if(v == "weapon_railgun") @@ -385,47 +373,39 @@ float _MapInfo_Generate(string pFilename) // 0: failure, 1: ok ent, 2: ok bsp MapInfo_Map_supportedFeatures |= MAPINFO_FEATURE_MONSTERS; else if(v == "target_music" || v == "trigger_music") _MapInfo_Map_worldspawn_music = string_null; // don't use regular BGM + else + FOREACH(Gametypes, true, it.m_generate_mapinfo(it, v)); } } } if(inWorldspawn) { - LOG_MAPWARN(fn, " ended still in worldspawn, BUG\n"); + LOG_WARN(fn, " ended still in worldspawn, BUG"); return 0; } diameter = vlen(mapMaxs - mapMins); - twoBaseModes = MapInfo_Map_supportedGametypes & (MAPINFO_TYPE_CTF | MAPINFO_TYPE_ASSAULT | MAPINFO_TYPE_RACE | MAPINFO_TYPE_NEXBALL); - if(twoBaseModes && (MapInfo_Map_supportedGametypes == twoBaseModes)) + int twoBaseModes = 0; + FOREACH(Gametypes, it.m_isTwoBaseMode(), twoBaseModes |= it.m_flags); + if(twoBaseModes && (twoBaseModes &= MapInfo_Map_supportedGametypes)) { - // we have a CTF-only or Assault-only map. Don't add other modes then, - // as the map is too symmetric for them. + // we have a symmetrical map, don't add the modes without bases } else { - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_DEATHMATCH; // DM always works - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_LMS; // LMS always works - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_KEEPAWAY; // Keepaway always works - - if(spawnpoints >= 8 && diameter > 4096) { - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_TEAM_DEATHMATCH; - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_FREEZETAG; - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_CA; - } - if(spawnpoints >= 12 && diameter > 5120) - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_KEYHUNT; + FOREACH(Gametypes, it.m_isAlwaysSupported(it, spawnpoints, diameter), MapInfo_Map_supportedGametypes |= it.m_flags); } - if(MapInfo_Map_supportedGametypes & MAPINFO_TYPE_RACE) + if(MapInfo_Map_supportedGametypes & MAPINFO_TYPE_RACE.m_flags) if(!spawnplaces) { - MapInfo_Map_supportedGametypes &= ~MAPINFO_TYPE_RACE; - MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_CTS; + MapInfo_Map_supportedGametypes &= ~MAPINFO_TYPE_RACE.m_flags; + MapInfo_Map_supportedGametypes |= MAPINFO_TYPE_CTS.m_flags; } LOG_TRACE("-> diameter ", ftos(diameter)); LOG_TRACE("; spawnpoints ", ftos(spawnpoints)); - LOG_TRACE("; modes ", ftos(MapInfo_Map_supportedGametypes), "\n"); + LOG_TRACE("; modes ", ftos(MapInfo_Map_supportedGametypes)); fclose(fh); @@ -447,42 +427,22 @@ void _MapInfo_Map_Reset() MapInfo_Map_maxs = '0 0 0'; } -string _MapInfo_GetDefault(float t) +string _MapInfo_GetDefault(Gametype t) { - switch(t) - { - case MAPINFO_TYPE_DEATHMATCH: return "30 20 0"; - case MAPINFO_TYPE_TEAM_DEATHMATCH: return "50 20 2 0"; - case MAPINFO_TYPE_DOMINATION: return "200 20 0"; - case MAPINFO_TYPE_CTF: return "300 20 10 0"; - case MAPINFO_TYPE_LMS: return "9 20 0"; - case MAPINFO_TYPE_CA: return "10 20 0"; - case MAPINFO_TYPE_KEYHUNT: return "1000 20 3 0"; - case MAPINFO_TYPE_ASSAULT: return "20 0"; - case MAPINFO_TYPE_RACE: return "20 5 7 15 0"; - case MAPINFO_TYPE_ONSLAUGHT: return "20 0"; - case MAPINFO_TYPE_NEXBALL: return "5 20 0"; - case MAPINFO_TYPE_CTS: return "20 0 0"; - case MAPINFO_TYPE_FREEZETAG: return "10 20 0"; - // NOTE: DO NOT ADD ANY MORE GAME TYPES HERE - // THIS IS JUST LEGACY SUPPORT FOR NEXUIZ MAPS - // ONLY ADD NEW STUFF TO _MapInfo_GetDefaultEx - // THIS FUNCTION WILL EVENTUALLY BE REMOVED - default: return ""; - } + return t.m_legacydefaults; } -void _MapInfo_Map_ApplyGametype(string s, int pWantedType, int pThisType, int load_default) +void _MapInfo_Map_ApplyGametype(string s, Gametype pWantedType, Gametype pThisType, int load_default) { string sa; - MapInfo_Map_supportedGametypes |= pThisType; - if(!(pThisType & pWantedType)) + MapInfo_Map_supportedGametypes |= pThisType.m_flags; + if(!(pThisType.m_flags & pWantedType.m_flags)) return; if(load_default) _MapInfo_Map_ApplyGametype(_MapInfo_GetDefault(pThisType), pWantedType, pThisType, false); - if(pWantedType == MAPINFO_TYPE_ASSAULT || pWantedType == MAPINFO_TYPE_ONSLAUGHT || pWantedType == MAPINFO_TYPE_RACE || pWantedType == MAPINFO_TYPE_CTS) // these modes don't use fraglimit + if(!pWantedType.frags) // these modes don't use fraglimit { cvar_set("fraglimit", "0"); } @@ -499,59 +459,19 @@ void _MapInfo_Map_ApplyGametype(string s, int pWantedType, int pThisType, int lo cvar_set("timelimit", sa); s = cdr(s); - if(pWantedType == MAPINFO_TYPE_TEAM_DEATHMATCH) - { - sa = car(s); - if(sa != "") - cvar_set("g_tdm_teams", sa); - s = cdr(s); - } - - if(pWantedType == MAPINFO_TYPE_KEYHUNT) - { - sa = car(s); - if(sa != "") - cvar_set("g_keyhunt_teams", sa); - s = cdr(s); - } - - if(pWantedType == MAPINFO_TYPE_CA) - { - sa = car(s); - if(sa != "") - cvar_set("g_ca_teams", sa); - s = cdr(s); - } - - if(pWantedType == MAPINFO_TYPE_FREEZETAG) + if(pWantedType.m_setTeams) { sa = car(s); if(sa != "") - cvar_set("g_freezetag_teams", sa); + pWantedType.m_setTeams(sa); s = cdr(s); } - if(pWantedType == MAPINFO_TYPE_CTF) - { - sa = car(s); - if(sa != "") - cvar_set("fraglimit", sa); - s = cdr(s); - } - - /* keepaway wuz here - if(pWantedType == MAPINFO_TYPE_KEEPAWAY) - { - sa = car(s); - if(sa != "") - cvar_set("fraglimit", sa); - s = cdr(s); - } - */ - // rc = timelimit timelimit_qualification laps laps_teamplay if(pWantedType == MAPINFO_TYPE_RACE) { + cvar_set("fraglimit", "0"); // special case! + sa = car(s); if(sa == "") sa = cvar_string("timelimit"); cvar_set("g_race_qualifying_timelimit", sa); s = cdr(s); @@ -569,20 +489,7 @@ void _MapInfo_Map_ApplyGametype(string s, int pWantedType, int pThisType, int lo s = cdr(s); } - if(pWantedType == MAPINFO_TYPE_CTS) - { - sa = car(s); - - // this is the skill of the map - // not parsed by anything yet - // for map databases - //if(sa != "") - // cvar_set("fraglimit", sa); - - s = cdr(s); - } - - if(pWantedType == MAPINFO_TYPE_ASSAULT || pWantedType == MAPINFO_TYPE_ONSLAUGHT || pWantedType == MAPINFO_TYPE_CTS) // these modes don't use fraglimit + if(!pWantedType.frags) // these modes don't use fraglimit { cvar_set("leadlimit", "0"); } @@ -595,22 +502,20 @@ void _MapInfo_Map_ApplyGametype(string s, int pWantedType, int pThisType, int lo } } -string _MapInfo_GetDefaultEx(float t) +string _MapInfo_GetDefaultEx(Gametype t) { - FOREACH(Gametypes, it.items == t, return it.model2); - return ""; + return t ? t.model2 : ""; } -float _MapInfo_GetTeamPlayBool(float t) +float _MapInfo_GetTeamPlayBool(Gametype t) { - FOREACH(Gametypes, it.items == t, return it.team); - return false; + return t ? t.team : false; } -void _MapInfo_Map_ApplyGametypeEx(string s, int pWantedType, int pThisType) +void _MapInfo_Map_ApplyGametypeEx(string s, Gametype pWantedType, Gametype pThisType) { - MapInfo_Map_supportedGametypes |= pThisType; - if (!(pThisType & pWantedType)) + MapInfo_Map_supportedGametypes |= pThisType.m_flags; + if (!(pThisType.m_flags & pWantedType.m_flags)) return; // reset all the cvars to their defaults @@ -628,7 +533,8 @@ void _MapInfo_Map_ApplyGametypeEx(string s, int pWantedType, int pThisType) if (sa == "") continue; int p = strstrofs(sa, "=", 0); if (p < 0) { - LOG_MAPWARNF("Invalid gametype setting in mapinfo for gametype %s: %s\n", MapInfo_Type_ToString(pWantedType), sa); + if(WARN_COND) + LOG_WARNF("Invalid gametype setting in mapinfo for gametype %s: %s", MapInfo_Type_ToString(pWantedType), sa); continue; } string k = substring(sa, 0, p); @@ -667,8 +573,8 @@ void _MapInfo_Map_ApplyGametypeEx(string s, int pWantedType, int pThisType) } } FOREACH(Gametypes, true, handled |= it.m_parse_mapinfo(k, v)); - if (!handled) - LOG_MAPWARNF("Invalid gametype setting in mapinfo for gametype %s: %s\n", MapInfo_Type_ToString(pWantedType), sa); + if (!handled && WARN_COND) + LOG_WARNF("Invalid gametype setting in mapinfo for gametype %s: %s", MapInfo_Type_ToString(pWantedType), sa); } if (pWantedType == MAPINFO_TYPE_RACE && cvar("g_race_teams") >= 2) @@ -683,52 +589,41 @@ void _MapInfo_Map_ApplyGametypeEx(string s, int pWantedType, int pThisType) } } -Gametype MapInfo_Type(int t) +Gametype MapInfo_Type_FromString(string gtype) { - FOREACH(Gametypes, it.items == t, return it); + string replacement = ""; + switch (gtype) + { + case "nexball": replacement = "nb"; break; + case "freezetag": replacement = "ft"; break; + case "keepaway": replacement = "ka"; break; + case "invasion": replacement = "inv"; break; + case "assault": replacement = "as"; break; + case "race": replacement = "rc"; break; + } + if (replacement != "" && WARN_COND) + { + LOG_WARNF("MapInfo_Type_FromString (probably %s): using deprecated name '%s'. Should use '%s'.", MapInfo_Map_bspname, gtype, replacement); + gtype = replacement; + } + FOREACH(Gametypes, it.mdl == gtype, return it); return NULL; } -int MapInfo_Type_FromString(string t) +string MapInfo_Type_Description(Gametype t) { -#define deprecate(from, to) MACRO_BEGIN { \ - if (t == #from) { \ - string replacement = #to; \ - LOG_MAPWARNF("MapInfo_Type_FromString (probably %s): using deprecated name '%s'. Should use '%s'.\n", MapInfo_Map_bspname, t, replacement); \ - t = replacement; \ - } \ -} MACRO_END - deprecate(nexball, nb); - deprecate(freezetag, ft); - deprecate(keepaway, ka); - deprecate(invasion, inv); - deprecate(assault, as); - deprecate(race, rc); - if (t == "all") return MAPINFO_TYPE_ALL; - FOREACH(Gametypes, it.mdl == t, return it.items); - return 0; -#undef deprecate + return t ? t.gametype_description : ""; } -string MapInfo_Type_Description(float t) +string MapInfo_Type_ToString(Gametype t) { - FOREACH(Gametypes, it.items == t, return it.gametype_description); - return ""; + return t ? t.mdl : ""; } -string MapInfo_Type_ToString(float t) +string MapInfo_Type_ToText(Gametype t) { - if(t == MAPINFO_TYPE_ALL) - return "all"; - FOREACH(Gametypes, it.items == t, return it.mdl); - return ""; -} - -string MapInfo_Type_ToText(float t) -{ - FOREACH(Gametypes, it.items == t, return it.message); /* xgettext:no-c-format */ - return _("@!#%'n Tuba Throwing"); + return t ? t.message : _("@!#%'n Tuba Throwing"); } void _MapInfo_Parse_Settemp(string pFilename, string acl, float type, string s, float recurse) @@ -770,14 +665,14 @@ void _MapInfo_Parse_Settemp(string pFilename, string acl, float type, string s, { fh = fopen(s, FILE_READ); if(fh < 0) - LOG_MAPWARN("Map ", pFilename, " references not existing config file ", s, "\n"); + { + if(WARN_COND) + LOG_WARN("Map ", pFilename, " references not existing config file ", s); + } else { - for (;;) + while((s = fgets(fh))) { - if (!((s = fgets(fh)))) - break; - // catch different sorts of comments if(s == "") // empty lines continue; @@ -798,32 +693,37 @@ void _MapInfo_Parse_Settemp(string pFilename, string acl, float type, string s, fclose(fh); } } - else - LOG_MAPWARN("Map ", pFilename, " uses too many levels of inclusion\n"); + else if(WARN_COND) + LOG_WARN("Map ", pFilename, " uses too many levels of inclusion"); + } + else if(t == "" + || !cvar_value_issafe(t) + || !cvar_value_issafe(s) + || matchacl(MAPINFO_SETTEMP_ACL_SYSTEM, t) <= 0) + { + if (WARN_COND) + LOG_WARN("Map ", pFilename, " contains a potentially harmful setting, ignored"); } - else if(t == "") - LOG_MAPWARN("Map ", pFilename, " contains a potentially harmful setting, ignored\n"); - else if (!cvar_value_issafe(t)) - LOG_MAPWARN("Map ", pFilename, " contains a potentially harmful setting, ignored\n"); - else if (!cvar_value_issafe(s)) - LOG_MAPWARN("Map ", pFilename, " contains a potentially harmful setting, ignored\n"); - else if(matchacl(MAPINFO_SETTEMP_ACL_SYSTEM, t) <= 0) - LOG_MAPWARN("Map ", pFilename, " contains a potentially harmful setting, ignored\n"); else if(matchacl(acl, t) <= 0) - LOG_MAPWARN("Map ", pFilename, " contains a denied setting, ignored\n"); + { + if (WARN_COND) + LOG_WARN("Map ", pFilename, " contains a denied setting, ignored"); + } else { if(type == 0) // server set { - LOG_TRACE("Applying temporary setting ", t, " := ", s, "\n"); + LOG_TRACE("Applying temporary setting ", t, " := ", s); + #if 0 if(cvar("g_campaign")) cvar_set(t, s); // this is a wrapper and is always temporary anyway; no need to backup old values then else + #endif cvar_settemp(t, s); } else { - LOG_TRACE("Applying temporary client setting ", t, " := ", s, "\n"); + LOG_TRACE("Applying temporary client setting ", t, " := ", s); MapInfo_Map_clientstuff = strcat( MapInfo_Map_clientstuff, "cl_cmd settemp \"", t, "\" \"", s, "\"\n" ); @@ -834,22 +734,19 @@ void _MapInfo_Parse_Settemp(string pFilename, string acl, float type, string s, float MapInfo_isRedundant(string fn, string t) { // normalize file name - fn = strreplace("_", "-", fn); + fn = strreplace("_", "", fn); + fn = strreplace("-", "", fn); // normalize visible title - t = strreplace(": ", "-", t); - t = strreplace(":", "-", t); - t = strreplace(" ", "-", t); - t = strreplace("_", "-", t); - t = strreplace("'", "-", t); - - if(!strcasecmp(fn, t)) - return true; + t = strreplace(":", "", t); + t = strreplace(" ", "", t); + t = strreplace("_", "", t); + t = strreplace("-", "", t); + t = strreplace("'", "", t); + t = strdecolorize(t); // we allow the visible title to have punctuation the file name does // not, but not vice versa - t = strreplace("-", "", t); - if(!strcasecmp(fn, t)) return true; @@ -857,7 +754,7 @@ float MapInfo_isRedundant(string fn, string t) } // load info about a map by name into the MapInfo_Map_* globals -float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int pGametypeToSet) +float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, Gametype pGametypeToSet) { string fn; string s, t; @@ -870,11 +767,11 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p if(strstrofs(pFilename, "/", 0) >= 0) { - LOG_MAPWARN("Invalid character in map name, ignored\n"); + LOG_WARN("Invalid character in map name, ignored"); return 0; } - if(pGametypeToSet == 0) + if(pGametypeToSet == NULL) if(MapInfo_Cache_Retrieve(pFilename)) return 1; @@ -939,12 +836,9 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p if(MapInfo_Map_flags & MAPINFO_FLAG_FRUSTRATING) fputs(fh, "frustrating\n"); - for(i = 1; i <= MapInfo_Map_supportedGametypes; i *= 2) - if(MapInfo_Map_supportedGametypes & i) - fputs(fh, sprintf("gametype %s // defaults: %s\n", MapInfo_Type_ToString(i), _MapInfo_GetDefaultEx(i))); - - if(fexists(strcat("scripts/", pFilename, ".arena"))) - fputs(fh, "settemp_for_type all sv_q3acompat_machineshotgunswap 1\n"); + FOREACH(Gametypes, MapInfo_Map_supportedGametypes & it.m_flags, { + fputs(fh, sprintf("gametype %s // defaults: %s\n", MapInfo_Type_ToString(it), _MapInfo_GetDefaultEx(it))); + }); fputs(fh, "// optional: fog density red green blue alpha mindist maxdist\n"); fputs(fh, "// optional: settemp_for_type (all|gametypename) cvarname value\n"); @@ -960,7 +854,8 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p error("... but I just wrote it!"); } - LOG_MAPWARN("autogenerated mapinfo file ", fn, " has been loaded; please edit that file and move it to maps/", pFilename, ".mapinfo\n"); + if(WARN_COND) + LOG_WARN("autogenerated mapinfo file ", fn, " has been loaded; please edit that file and move it to maps/", pFilename, ".mapinfo"); } _MapInfo_Map_Reset(); @@ -998,8 +893,8 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p else if(t == "vehicles") MapInfo_Map_supportedFeatures |= MAPINFO_FEATURE_VEHICLES; else if(t == "monsters") MapInfo_Map_supportedFeatures |= MAPINFO_FEATURE_MONSTERS; else if(t == "new_toys") MapInfo_Map_supportedFeatures |= MAPINFO_FEATURE_WEAPONS; - else - LOG_MAPWARN("Map ", pFilename, " supports unknown feature ", t, ", ignored\n"); + else if(WARN_COND) + LOG_WARN("Map ", pFilename, " supports unknown feature ", t, ", ignored"); } else if(t == "hidden") { @@ -1025,21 +920,22 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p else if(t == "type") { t = car(s); s = cdr(s); - f = MapInfo_Type_FromString(t); - LOG_MAPWARN("Map ", pFilename, " contains the legacy 'type' keyword which is deprecated and will be removed in the future. Please migrate the mapinfo file to 'gametype'.\n"); + Gametype f = MapInfo_Type_FromString(t); + //if(WARN_COND) + //LOG_WARN("Map ", pFilename, " contains the legacy 'type' keyword which is deprecated and will be removed in the future. Please migrate the mapinfo file to 'gametype'."); if(f) _MapInfo_Map_ApplyGametype (s, pGametypeToSet, f, true); - else - LOG_MAPWARN("Map ", pFilename, " supports unknown game type ", t, ", ignored\n"); + else if(WARN_COND) + LOG_DEBUG("Map ", pFilename, " supports unknown game type ", t, ", ignored"); } else if(t == "gametype") { t = car(s); s = cdr(s); - f = MapInfo_Type_FromString(t); + Gametype f = MapInfo_Type_FromString(t); if(f) _MapInfo_Map_ApplyGametypeEx (s, pGametypeToSet, f); - else - LOG_MAPWARN("Map ", pFilename, " supports unknown game type ", t, ", ignored\n"); + else if(WARN_COND) + LOG_DEBUG("Map ", pFilename, " supports unknown game type ", t, ", ignored"); } else if(t == "size") { @@ -1050,16 +946,25 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p t = car(s); s = cdr(s); d = stof(t); t = car(s); s = cdr(s); e = stof(t); if(s == "") - LOG_MAPWARN("Map ", pFilename, " contains an incorrect size line (not enough params), syntax: size mins_x mins_y mins_z maxs_x maxs_y maxs_z\n"); + { + if(WARN_COND) + LOG_WARN("Map ", pFilename, " contains an incorrect size line (not enough params), syntax: size mins_x mins_y mins_z maxs_x maxs_y maxs_z"); + } else { t = car(s); s = cdr(s); f = stof(t); if(s != "") - LOG_MAPWARN("Map ", pFilename, " contains an incorrect size line (too many params), syntax: size mins_x mins_y mins_z maxs_x maxs_y maxs_z\n"); + { + if(WARN_COND) + LOG_WARN("Map ", pFilename, " contains an incorrect size line (too many params), syntax: size mins_x mins_y mins_z maxs_x maxs_y maxs_z"); + } else { if(a >= d || b >= e || c >= f) - LOG_MAPWARN("Map ", pFilename, " contains an incorrect size line, mins have to be < maxs\n"); + { + if(WARN_COND) + LOG_WARN("Map ", pFilename, " contains an incorrect size line, mins have to be < maxs"); + } else { MapInfo_Map_mins.x = a; @@ -1075,37 +980,44 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p else if(t == "settemp_for_type") { t = car(s); s = cdr(s); - if((f = MapInfo_Type_FromString(t))) + bool all = t == "all"; + Gametype f = NULL; + if(all || (f = MapInfo_Type_FromString(t))) { - if(f & pGametypeToSet) + if((all ? MAPINFO_TYPE_ALL : f.m_flags) & pGametypeToSet.m_flags) { _MapInfo_Parse_Settemp(pFilename, acl, 0, s, 1); } } else { - LOG_MAPWARN("Map ", pFilename, " has a setting for unknown game type ", t, ", ignored\n"); + LOG_DEBUG("Map ", pFilename, " has a setting for unknown game type ", t, ", ignored"); } } else if(t == "clientsettemp_for_type") { t = car(s); s = cdr(s); - if((f = MapInfo_Type_FromString(t))) + bool all = t == "all"; + Gametype f = NULL; + if(all || (f = MapInfo_Type_FromString(t))) { - if(f & pGametypeToSet) + if((all ? MAPINFO_TYPE_ALL : f.m_flags) & pGametypeToSet.m_flags) { _MapInfo_Parse_Settemp(pFilename, acl, 1, s, 1); } } else { - LOG_MAPWARN("Map ", pFilename, " has a client setting for unknown game type ", t, ", ignored\n"); + LOG_DEBUG("Map ", pFilename, " has a client setting for unknown game type ", t, ", ignored"); } } else if(t == "fog") { if (!cvar_value_issafe(s)) - LOG_MAPWARN("Map ", pFilename, " contains a potentially harmful fog setting, ignored\n"); + { + if(WARN_COND) + LOG_WARN("Map ", pFilename, " contains a potentially harmful fog setting, ignored"); + } else MapInfo_Map_fog = s; } @@ -1121,15 +1033,18 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p if(pGametypeToSet) { if (!cvar_value_issafe(t)) - LOG_MAPWARN("Map ", pFilename, " contains a potentially harmful cdtrack, ignored\n"); + { + if(WARN_COND) + LOG_WARN("Map ", pFilename, " contains a potentially harmful cdtrack, ignored"); + } else MapInfo_Map_clientstuff = strcat( MapInfo_Map_clientstuff, "cd loop \"", t, "\"\n" ); } } - else - LOG_MAPWARN("Map ", pFilename, " provides unknown info item ", t, ", ignored\n"); + else if(WARN_COND) + LOG_WARN("Map ", pFilename, " provides unknown info item ", t, ", ignored"); } fclose(fh); @@ -1143,24 +1058,19 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p MapInfo_Cache_Store(); if(MapInfo_Map_supportedGametypes != 0) return r; - LOG_MAPWARN("Map ", pFilename, " supports no game types, ignored\n"); + if (WARN_COND) + LOG_WARN("Map ", pFilename, " supports no game types, ignored"); return 0; } -float MapInfo_Get_ByName(string pFilename, float pAllowGenerate, int pGametypeToSet) +int MapInfo_Get_ByName(string pFilename, float pAllowGenerate, Gametype pGametypeToSet) { - float r = MapInfo_Get_ByName_NoFallbacks(pFilename, pAllowGenerate, pGametypeToSet); + int r = MapInfo_Get_ByName_NoFallbacks(pFilename, pAllowGenerate, pGametypeToSet); - if(cvar("g_tdm_on_dm_maps")) - { - // if this is set, all DM maps support TDM too - if (!(MapInfo_Map_supportedGametypes & MAPINFO_TYPE_TEAM_DEATHMATCH)) - if(MapInfo_Map_supportedGametypes & MAPINFO_TYPE_DEATHMATCH) - _MapInfo_Map_ApplyGametypeEx ("", pGametypeToSet, MAPINFO_TYPE_TEAM_DEATHMATCH); - } + FOREACH(Gametypes, it.m_isForcedSupported(it), _MapInfo_Map_ApplyGametypeEx("", pGametypeToSet, it)); if(pGametypeToSet) { - if(!(MapInfo_Map_supportedGametypes & pGametypeToSet)) + if(!(MapInfo_Map_supportedGametypes & pGametypeToSet.m_flags)) { error("Can't select the requested game type. This should never happen as the caller should prevent it!\n"); //_MapInfo_Map_ApplyGametypeEx("", pGametypeToSet, MAPINFO_TYPE_DEATHMATCH); @@ -1228,25 +1138,28 @@ string MapInfo_FixName(string s) int MapInfo_CurrentFeatures() { int req = 0; - if(!(cvar("g_lms") || cvar("g_instagib") || cvar("g_overkill") || cvar("g_nix") || cvar("g_weaponarena") || !cvar("g_pickup_items") || cvar("g_race") || cvar("g_cts") || cvar("g_nexball"))) + // TODO: find a better way to check if weapons are required on the map + if(!(cvar("g_instagib") || cvar("g_overkill") || cvar("g_nix") || cvar("g_weaponarena") || !cvar("g_pickup_items") + || cvar("g_race") || cvar("g_cts") || cvar("g_nexball") || cvar("g_ca") || cvar("g_freezetag") || cvar("g_lms"))) req |= MAPINFO_FEATURE_WEAPONS; return req; } -int MapInfo_CurrentGametype() +Gametype MapInfo_CurrentGametype() { - int prev = cvar("gamecfg"); - FOREACH(Gametypes, cvar(it.netname) && it.items != prev, return it.items); - if (prev) return prev; - return MAPINFO_TYPE_DEATHMATCH; + Gametype prev = REGISTRY_GET(Gametypes, cvar("gamecfg")); + FOREACH(Gametypes, cvar(it.netname) && it != prev, return it); + return prev ? prev : MAPINFO_TYPE_DEATHMATCH; } -float _MapInfo_CheckMap(string s) // returns 0 if the map can't be played with the current settings, 1 otherwise +float _MapInfo_CheckMap(string s, bool gametype_only) // returns 0 if the map can't be played with the current settings, 1 otherwise { - if(!MapInfo_Get_ByName(s, 1, 0)) + if(!MapInfo_Get_ByName(s, 1, NULL)) return 0; - if((MapInfo_Map_supportedGametypes & MapInfo_CurrentGametype()) == 0) + if((MapInfo_Map_supportedGametypes & MapInfo_CurrentGametype().m_flags) == 0) return 0; + if (gametype_only) + return 1; if((MapInfo_Map_supportedFeatures & MapInfo_CurrentFeatures()) != MapInfo_CurrentFeatures()) return 0; return 1; @@ -1255,14 +1168,14 @@ float _MapInfo_CheckMap(string s) // returns 0 if the map can't be played with t float MapInfo_CheckMap(string s) // returns 0 if the map can't be played with the current settings, 1 otherwise { float r; - r = _MapInfo_CheckMap(s); + r = _MapInfo_CheckMap(s, false); MapInfo_ClearTemps(); return r; } -void MapInfo_SwitchGameType(int t) +void MapInfo_SwitchGameType(Gametype t) { - FOREACH(Gametypes, true, cvar_set(it.netname, (it.items == t) ? "1" : "0")); + FOREACH(Gametypes, true, cvar_set(it.netname, (it == t) ? "1" : "0")); } void MapInfo_LoadMap(string s, float reinit) @@ -1272,9 +1185,11 @@ void MapInfo_LoadMap(string s, float reinit) //if(!MapInfo_CheckMap(s)) //{ // print("EMERGENCY: can't play the selected map in the given game mode. Falling back to DM.\n"); - // MapInfo_SwitchGameType(MAPINFO_TYPE_DEATHMATCH); + // MapInfo_SwitchGameType(MAPINFO_TYPE_DEATHMATCH.m_flags); //} + LOG_INFO("Switching to map ", s); + cvar_settemp_restore(); if(reinit) localcmd(strcat("\nmap ", s, "\n")); @@ -1282,17 +1197,16 @@ void MapInfo_LoadMap(string s, float reinit) localcmd(strcat("\nchangelevel ", s, "\n")); } -string MapInfo_ListAllowedMaps(float type, float pRequiredFlags, float pForbiddenFlags) +string MapInfo_ListAllowedMaps(Gametype type, float pRequiredFlags, float pForbiddenFlags) { string out; - float i; // to make absolutely sure: MapInfo_Enumerate(); MapInfo_FilterGametype(type, MapInfo_CurrentFeatures(), pRequiredFlags, pForbiddenFlags, 0); out = ""; - for(i = 0; i < MapInfo_count; ++i) + for(float i = 0; i < MapInfo_count; ++i) out = strcat(out, " ", _MapInfo_GlobItem(MapInfo_FilterList_Lookup(i))); return substring(out, 1, strlen(out) - 1); } @@ -1300,14 +1214,13 @@ string MapInfo_ListAllowedMaps(float type, float pRequiredFlags, float pForbidde string MapInfo_ListAllAllowedMaps(float pRequiredFlags, float pForbiddenFlags) { string out; - float i; // to make absolutely sure: MapInfo_Enumerate(); - MapInfo_FilterGametype(MAPINFO_TYPE_ALL, 0, pRequiredFlags, pForbiddenFlags, 0); + _MapInfo_FilterGametype(MAPINFO_TYPE_ALL, 0, pRequiredFlags, pForbiddenFlags, 0); out = ""; - for(i = 0; i < MapInfo_count; ++i) + for(float i = 0; i < MapInfo_count; ++i) out = strcat(out, " ", _MapInfo_GlobItem(MapInfo_FilterList_Lookup(i))); MapInfo_FilterGametype(MapInfo_CurrentGametype(), MapInfo_CurrentFeatures(), pRequiredFlags, pForbiddenFlags, 0); @@ -1315,49 +1228,52 @@ string MapInfo_ListAllAllowedMaps(float pRequiredFlags, float pForbiddenFlags) return substring(out, 1, strlen(out) - 1); } -void MapInfo_LoadMapSettings_SaveGameType(float t) +void MapInfo_LoadMapSettings_SaveGameType(Gametype t) { MapInfo_SwitchGameType(t); - cvar_set("gamecfg", ftos(t)); + cvar_set("gamecfg", ftos(t.m_id)); MapInfo_LoadedGametype = t; } void MapInfo_LoadMapSettings(string s) // to be called from worldspawn { - float t; - - t = MapInfo_CurrentGametype(); + Gametype t = MapInfo_CurrentGametype(); MapInfo_LoadMapSettings_SaveGameType(t); - if(!_MapInfo_CheckMap(s)) // with underscore, it keeps temps + if(!_MapInfo_CheckMap(s, true)) // with underscore, it keeps temps { if(cvar("g_mapinfo_allow_unsupported_modes_and_let_stuff_break")) { - LOG_SEVERE("can't play the selected map in the given game mode. Working with only the override settings.\n"); + LOG_SEVERE("can't play the selected map in the given game mode. Working with only the override settings."); _MapInfo_Map_ApplyGametypeEx("", t, t); return; // do not call Get_ByName! } if(MapInfo_Map_supportedGametypes == 0) { - LOG_SEVERE("Mapinfo system is not functional at all. Assuming deathmatch.\n"); - MapInfo_Map_supportedGametypes = MAPINFO_TYPE_DEATHMATCH; + LOG_SEVERE("Mapinfo system is not functional at all. Assuming deathmatch."); + MapInfo_Map_supportedGametypes = MAPINFO_TYPE_DEATHMATCH.m_flags; MapInfo_LoadMapSettings_SaveGameType(MAPINFO_TYPE_DEATHMATCH); _MapInfo_Map_ApplyGametypeEx("", MAPINFO_TYPE_DEATHMATCH, MAPINFO_TYPE_DEATHMATCH); return; // do not call Get_ByName! } - t = 1; + int _t = 1; while(!(MapInfo_Map_supportedGametypes & 1)) { - t *= 2; - MapInfo_Map_supportedGametypes = floor(MapInfo_Map_supportedGametypes / 2); + _t <<= 1; + MapInfo_Map_supportedGametypes = floor(MapInfo_Map_supportedGametypes >> 1); } + Gametype t_prev = t; + FOREACH(Gametypes, it.m_flags == _t, { t = it; break; }); // t is now a supported mode! - LOG_WARNING("can't play the selected map in the given game mode. Falling back to a supported mode.\n"); + LOG_WARNF("can't play the selected map in the given game mode (%s). Falling back to a supported mode (%s).", t_prev.mdl, t.mdl); MapInfo_LoadMapSettings_SaveGameType(t); } + if(!_MapInfo_CheckMap(s, false)) { // with underscore, it keeps temps + LOG_WARNF("the selected map lacks features required by current settings; playing anyway."); + } MapInfo_Get_ByName(s, 1, t); } @@ -1390,7 +1306,7 @@ int MapInfo_ForbiddenFlags() { int f = MAPINFO_FLAG_FORBIDDEN; -#ifndef MENUQC +#ifdef GAMEQC if (!cvar("g_maplist_allow_hidden")) #endif f |= MAPINFO_FLAG_HIDDEN;