From 58e906c490e0ac5b72e6dfd5c5a5d9b7181e27b2 Mon Sep 17 00:00:00 2001
From: Mircea Kitsune <sonichedgehog_hyperblast00@yahoo.com>
Date: Thu, 1 Jul 2010 03:06:21 +0300
Subject: [PATCH] Fix issues with weapon switching while keeping the fire
 button pressed, when switching between a weapon with reverse enabled and one
 without.

---
 defaultXonotic.cfg | 19 ++++++++++++++++---
 keybinds.txt       |  4 ++--
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/defaultXonotic.cfg b/defaultXonotic.cfg
index e1e2eb76e..6dedf5bf2 100644
--- a/defaultXonotic.cfg
+++ b/defaultXonotic.cfg
@@ -1531,10 +1531,23 @@ alias _gl_flashblend_update_11 "gl_flashblend 0"
 alias gl_flashblend_update "_gl_flashblend_update_$r_shadow_realtime_dlight$r_showsurfaces"
 
 // this script allows swapping the primary and secondary fire buttons for each weapon, using the cl_swapattacks_* cvars
-alias firing_decision_0 "alias +preattack +attack; alias -preattack -attack; alias +preattack2 +attack2; alias -preattack2 -attack2"
-alias firing_decision_1 "alias +preattack +attack2; alias -preattack -attack2; alias +preattack2 +attack; alias -preattack2 -attack"
+
+set preattack_last 0
+set preattack2_last 0
+alias +preattack "set preattack_last 1; +checkattack"
+alias -preattack "set preattack_last 0; -checkattack"
+alias +preattack2 "set preattack2_last 1; +checkattack2"
+alias -preattack2 "set preattack2_last 0; -checkattack2"
+alias firing_switch_atck_0 ""
+alias firing_switch_atck2_0 ""
+alias firing_switch_atck_1 "+preattack"
+alias firing_switch_atck2_1 "+preattack2"
+alias firing_switch "-preattack; -preattack2; firing_switch_atck_$preattack_last; firing_switch_atck2_$preattack2_last;"
+
+alias firing_decision_0 "alias +checkattack +attack; alias -checkattack -attack; alias +checkattack2 +attack2; alias -checkattack2 -attack2"
+alias firing_decision_1 "alias +checkattack +attack2; alias -checkattack -attack2; alias +checkattack2 +attack; alias -checkattack2 -attack"
 alias firing_swap2 "firing_decision_${$1}"
-alias firing_swap "firing_swap2 cl_swapattacks_$1; -attack; -attack2"
+alias firing_swap "firing_swap2 cl_swapattacks_$1; firing_switch"
 
 // this hook activates when we switch weapons, and allows us to script weapon specific properties like the fire button swapping script
 alias cl_hook_activeweapon "firing_swap $1"
diff --git a/keybinds.txt b/keybinds.txt
index eb4c12f54..d4c35123a 100644
--- a/keybinds.txt
+++ b/keybinds.txt
@@ -8,8 +8,8 @@
 "+hook"                                 "off-hand hook / jet pack"
 ""                                      ""
 ""                                      "Attacking"
-"+preattack"                               "primary fire"
-"+preattack2"                              "secondary fire"
+"+preattack"                            "primary fire"
+"+preattack2"                           "secondary fire"
 ""                                      ""
 ""                                      "Weapon switching"
 "weapprev"                              "previous"
-- 
2.39.2