ht htglobals;
ht *typedefs;
+ /* same as above but for the spelling corrector */
+ ht *correct_variables;
+ size_t ***correct_variables_score; /* vector of vector of size_t* */
+
/* not to be used directly, we use the hash table */
ast_expression **_locals;
size_t *_blocklocals;
static bool parse_block_into(parser_t *parser, ast_block *block);
static bool parse_statement_or_block(parser_t *parser, ast_expression **out);
static bool parse_statement(parser_t *parser, ast_block *block, ast_expression **out, bool allow_cases);
-static ast_expression* parse_expression_leave(parser_t *parser, bool stopatcomma, bool truthvalue);
-static ast_expression* parse_expression(parser_t *parser, bool stopatcomma);
+static ast_expression* parse_expression_leave(parser_t *parser, bool stopatcomma, bool truthvalue, bool with_labels);
+static ast_expression* parse_expression(parser_t *parser, bool stopatcomma, bool with_labels);
static void parseerror(parser_t *parser, const char *fmt, ...)
{
return ( ast_expression*)util_htget(parser->htfields, name);
}
-static ast_expression* parser_find_label(parser_t *parser, const char *name) {
+static ast_expression* parser_find_label(parser_t *parser, const char *name)
+{
size_t i;
- if (!parser->labels)
- return NULL;
-
for(i = 0; i < vec_size(parser->labels); i++)
if (!strcmp(parser->labels[i]->name, name))
return (ast_expression*)parser->labels[i];
exprs[i] = sy->out[vec_size(sy->out)+i].out;
blocks[i] = sy->out[vec_size(sy->out)+i].block;
asvalue[i] = (ast_value*)exprs[i];
+
+ if (exprs[i]->expression.vtype == TYPE_NOEXPR &&
+ !(i != 0 && op->id == opid2('?',':')))
+ {
+ if (ast_istype(exprs[i], ast_label))
+ compile_error(ast_ctx(exprs[i]), "expected expression, got an unknown identifier");
+ else
+ compile_error(ast_ctx(exprs[i]), "not an expression");
+ (void)!compile_warning(ast_ctx(exprs[i]), WARN_DEBUG, "expression %u\n", (unsigned int)i);
+ }
}
if (blocks[0] && !vec_size(blocks[0]->exprs) && op->id != opid1(',')) {
}
}
-static ast_expression* parse_expression_leave(parser_t *parser, bool stopatcomma, bool truthvalue)
+static ast_expression* parse_expression_leave(parser_t *parser, bool stopatcomma, bool truthvalue, bool with_labels)
{
ast_expression *expr = NULL;
shunt sy;
parseerror(parser, "namespace for member not found");
goto onerr;
}
- else if (!(var = parser_find_var(parser, parser_tokval(parser))))
- var = (ast_expression*)parser_find_label(parser, parser_tokval(parser));
+ else
+ var = parser_find_var(parser, parser_tokval(parser));
} else {
var = parser_find_var(parser, parser_tokval(parser));
if (!var)
var = parser_find_field(parser, parser_tokval(parser));
- if (!var)
- var = parser_find_label(parser, parser_tokval(parser));
+ }
+ if (!var && with_labels) {
+ var = (ast_expression*)parser_find_label(parser, parser_tokval(parser));
+ if (!with_labels) {
+ ast_label *lbl = ast_label_new(parser_ctx(parser), parser_tokval(parser), true);
+ var = (ast_expression*)lbl;
+ vec_push(parser->labels, lbl);
+ }
}
if (!var) {
/* intrinsics */
}
else
{
- parseerror(parser, "unexpected ident: %s", parser_tokval(parser));
+ size_t i;
+ char *correct = NULL;
+
+ /*
+ * sometimes people use preprocessing predefs without enabling them
+ * i've done this thousands of times already myself. Lets check for
+ * it in the predef table. And diagnose it better :)
+ */
+ if (!OPTS_FLAG(FTEPP_PREDEFS)) {
+ for (i = 0; i < sizeof(ftepp_predefs)/sizeof(*ftepp_predefs); i++) {
+ if (!strcmp(ftepp_predefs[i].name, parser_tokval(parser))) {
+ parseerror(parser, "unexpected ident: %s (use -fftepp-predef to enable pre-defined macros)", parser_tokval(parser));
+ goto onerr;
+ }
+ }
+ }
+
+ /*
+ * TODO: determine the best score for the identifier: be it
+ * a variable, a field.
+ *
+ * We should also consider adding correction tables for
+ * other things as well.
+ */
+ for (i = 0; i < vec_size(parser->correct_variables); i++) {
+ correct = correct_str(parser->correct_variables[i], "ello");
+ if (strcmp(correct, parser_tokval(parser))) {
+ break;
+ } else if (correct) {
+ mem_d(correct);
+ }
+ }
+
+ if (correct) {
+ parseerror(parser, "unexpected ident: %s (did you mean %s?)", parser_tokval(parser), correct);
+ mem_d(correct);
+ } else {
+ parseerror(parser, "unexpected ident: %s", parser_tokval(parser));
+ }
+
goto onerr;
}
}
return NULL;
}
-static ast_expression* parse_expression(parser_t *parser, bool stopatcomma)
+static ast_expression* parse_expression(parser_t *parser, bool stopatcomma, bool with_labels)
{
- ast_expression *e = parse_expression_leave(parser, stopatcomma, false);
+ ast_expression *e = parse_expression_leave(parser, stopatcomma, false, with_labels);
if (!e)
return NULL;
if (!parser_next(parser)) {
vec_push(parser->typedefs, util_htnew(TYPEDEF_HT_SIZE));
vec_push(parser->_blocktypedefs, vec_size(parser->_typedefs));
vec_push(parser->_block_ctx, parser_ctx(parser));
+
+ /* corrector */
+ vec_push(parser->correct_variables, util_htnew(PARSER_HT_SIZE));
+ vec_push(parser->correct_variables_score, NULL);
}
static bool parser_leaveblock(parser_t *parser)
}
util_htdel(vec_last(parser->variables));
+ correct_del(vec_last(parser->correct_variables), vec_last(parser->correct_variables_score));
+
vec_pop(parser->variables);
+ vec_pop(parser->correct_variables);
+ vec_pop(parser->correct_variables_score);
if (!vec_size(parser->_blocklocals)) {
parseerror(parser, "internal error: parser_leaveblock with no block (2)");
return false;
vec_pop(parser->typedefs);
vec_pop(parser->_block_ctx);
+
return rv;
}
{
vec_push(parser->_locals, e);
util_htset(vec_last(parser->variables), name, (void*)e);
+
+ /* corrector */
+ correct_add (
+ vec_last(parser->correct_variables),
+ &vec_last(parser->correct_variables_score),
+ name
+ );
}
static ast_expression* process_condition(parser_t *parser, ast_expression *cond, bool *_ifnot)
return false;
}
/* parse the condition */
- cond = parse_expression_leave(parser, false, true);
+ cond = parse_expression_leave(parser, false, true, false);
if (!cond)
return false;
/* closing paren */
return false;
}
/* parse the condition */
- cond = parse_expression_leave(parser, false, true);
+ cond = parse_expression_leave(parser, false, true, false);
if (!cond)
return false;
/* closing paren */
return false;
}
/* parse the condition */
- cond = parse_expression_leave(parser, false, true);
+ cond = parse_expression_leave(parser, false, true, false);
if (!cond)
return false;
/* closing paren */
}
else if (parser->tok != ';')
{
- initexpr = parse_expression_leave(parser, false, false);
+ initexpr = parse_expression_leave(parser, false, false, false);
if (!initexpr)
goto onerr;
}
/* parse the condition */
if (parser->tok != ';') {
- cond = parse_expression_leave(parser, false, true);
+ cond = parse_expression_leave(parser, false, true, false);
if (!cond)
goto onerr;
}
/* parse the incrementor */
if (parser->tok != ')') {
- increment = parse_expression_leave(parser, false, false);
+ increment = parse_expression_leave(parser, false, false, false);
if (!increment)
goto onerr;
if (!ast_side_effects(increment)) {
}
if (parser->tok != ';') {
- exp = parse_expression(parser, false);
+ exp = parse_expression(parser, false, false);
if (!exp)
return false;
return false;
}
/* parse the operand */
- operand = parse_expression_leave(parser, false, false);
+ operand = parse_expression_leave(parser, false, false, false);
if (!operand)
return false;
parseerror(parser, "expected expression for case");
return false;
}
- swcase.value = parse_expression_leave(parser, false, false);
+ swcase.value = parse_expression_leave(parser, false, false, false);
if (!swcase.value) {
ast_delete(switchnode);
parseerror(parser, "expected expression for case");
on_true = parse_goto_computed(parser, ((ast_ternary*)side)->on_true);
on_false = parse_goto_computed(parser, ((ast_ternary*)side)->on_false);
- if (!on_true) {
- parseerror(parser, "expected label or expression in ternary");
- ast_unref(((ast_ternary*)side)->on_false);
- return NULL;
- }
-
- if (!on_false) {
+ if (!on_true || !on_false) {
parseerror(parser, "expected label or expression in ternary");
- ast_unref(((ast_ternary*)side)->on_true);
+ if (((ast_ternary*)side)->on_false) ast_unref(((ast_ternary*)side)->on_false);
+ if (((ast_ternary*)side)->on_true) ast_unref(((ast_ternary*)side)->on_true);
return NULL;
}
static bool parse_goto(parser_t *parser, ast_expression **out)
{
- size_t i;
- ast_goto *gt = NULL;
+ ast_goto *gt = NULL;
+ ast_expression *lbl;
if (!parser_next(parser))
return false;
if (parser->tok != TOKEN_IDENT) {
ast_expression *expression;
+
/* could be an expression i.e computed goto :-) */
if (parser->tok != '(') {
parseerror(parser, "expected label name after `goto`");
}
/* failed to parse expression for goto */
- if (!(expression = parse_expression(parser, false)) ||
+ if (!(expression = parse_expression(parser, false, true)) ||
!(*out = parse_goto_computed(parser, expression))) {
parseerror(parser, "invalid goto expression");
+ ast_unref(expression);
return false;
}
/* not computed goto */
gt = ast_goto_new(parser_ctx(parser), parser_tokval(parser));
-
- for (i = 0; i < vec_size(parser->labels); ++i) {
- if (!strcmp(parser->labels[i]->name, parser_tokval(parser))) {
- ast_goto_set_label(gt, parser->labels[i]);
- break;
+ lbl = parser_find_label(parser, gt->name);
+ if (lbl) {
+ if (!ast_istype(lbl, ast_label)) {
+ parseerror(parser, "internal error: label is not an ast_label");
+ ast_delete(gt);
+ return false;
}
+ ast_goto_set_label(gt, (ast_label*)lbl);
}
- if (i == vec_size(parser->labels))
+ else
vec_push(parser->gotos, gt);
if (!parser_next(parser) || parser->tok != ';') {
parseerror(parser, "label must be an identifier");
return false;
}
- label = ast_label_new(parser_ctx(parser), parser_tokval(parser));
- if (!label)
- return false;
- vec_push(parser->labels, label);
+ label = (ast_label*)parser_find_label(parser, parser_tokval(parser));
+ if (label) {
+ if (!label->undefined) {
+ parseerror(parser, "label `%s` already defined", label->name);
+ return false;
+ }
+ label->undefined = false;
+ }
+ else {
+ label = ast_label_new(parser_ctx(parser), parser_tokval(parser), false);
+ vec_push(parser->labels, label);
+ }
*out = (ast_expression*)label;
if (!parser_next(parser)) {
parseerror(parser, "parse error after label");
}
else
{
- ast_expression *exp = parse_expression(parser, false);
+ ast_expression *exp = parse_expression(parser, false, false);
if (!exp)
return false;
*out = exp;
if (!parser_next(parser))
return false;
- framenum = parse_expression_leave(parser, true, false);
+ framenum = parse_expression_leave(parser, true, false, false);
if (!framenum) {
parseerror(parser, "expected a framenumber constant in[frame,think] notation");
return false;
vec_push(parser->globals, (ast_expression*)thinkfunc);
util_htset(parser->htglobals, thinkfunc->name, thinkfunc);
+
nextthink = (ast_expression*)thinkfunc;
} else {
- nextthink = parse_expression_leave(parser, true, false);
+ nextthink = parse_expression_leave(parser, true, false, false);
if (!nextthink) {
ast_unref(framenum);
parseerror(parser, "expected a think-function in [frame,think] notation");
return NULL;
}
- cexp = parse_expression_leave(parser, true, false);
+ cexp = parse_expression_leave(parser, true, false, false);
if (!cexp || !ast_istype(cexp, ast_value)) {
if (cexp)
/* Add it to the local scope */
util_htset(vec_last(parser->variables), var->name, (void*)var);
+
+ /* corrector */
+ correct_add (
+ vec_last(parser->correct_variables),
+ &vec_last(parser->correct_variables_score),
+ var->name
+ );
+
/* now rename the global */
ln = strlen(var->name);
vec_append(defname, ln, var->name);
for (i = 0; i < 3; ++i) {
util_htset(vec_last(parser->variables), me[i]->name, (void*)(me[i]));
+ /* corrector */
+ correct_add(
+ vec_last(parser->correct_variables),
+ &vec_last(parser->correct_variables_score),
+ me[i]->name
+ );
+
vec_shrinkto(defname, prefix_len);
ln = strlen(me[i]->name);
vec_append(defname, ln, me[i]->name);
ast_expression *cexp;
ast_value *cval;
- cexp = parse_expression_leave(parser, true, false);
+ cexp = parse_expression_leave(parser, true, false, false);
if (!cexp)
break;
vec_free(parser->_blocklocals);
vec_free(parser->_locals);
+ /* corrector */
+ for (i = 0; i < vec_size(parser->correct_variables); ++i) {
+ correct_del(parser->correct_variables[i], parser->correct_variables_score[i]);
+ }
+ for (i = 0; i < vec_size(parser->correct_variables_score); ++i) {
+ vec_free(parser->correct_variables_score[i]);
+ }
+ vec_free(parser->correct_variables);
+ vec_free(parser->correct_variables_score);
+
+
for (i = 0; i < vec_size(parser->_typedefs); ++i)
ast_delete(parser->_typedefs[i]);
vec_free(parser->_typedefs);
projects / xonotic / gmqcc.git / blobdiff