From: Thomas Debesse <dev@illwieckz.net>
Date: Mon, 8 Mar 2021 13:10:22 +0000 (+0100)
Subject: radiant: build PIE linux binary on FHS installation
X-Git-Url: https://de.git.xonotic.org/?p=xonotic%2Fnetradiant.git;a=commitdiff_plain;h=c356943808b74e474bec2e88ebc33a3cb85f3643

radiant: build PIE linux binary on FHS installation
---

diff --git a/radiant/CMakeLists.txt b/radiant/CMakeLists.txt
index aa52ef32..3537a7dd 100644
--- a/radiant/CMakeLists.txt
+++ b/radiant/CMakeLists.txt
@@ -136,10 +136,18 @@ endif ()
 # because of a mistake in the mime-type library.
 # Because of that it was not possible to launch such executables from
 # the file browser.
+#
 # While the problem is fixed upstream, most distributions still ship
 # with a faulty mime-type library and may do for a long time.
+#
 # See: https://gitlab.freedesktop.org/xdg/shared-mime-info/-/issues/11
-if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux")
+#
+# It may produce such warning though at strip time:
+#   warning: allocated section `.dynstr' not in segment
+# and produce an unusable binary, better not strip when using this hack.
+#
+# This hack is only wanted when NetRadiant is not installed system-wide.
+if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux"	AND NOT FHS_INSTALL)
     target_link_libraries(${RADIANT_BASENAME} -no-pie)
 endif()