]> de.git.xonotic.org Git - xonotic/xonotic-data.pk3dir.git/blobdiff - qcsrc/common/vehicles/sv_vehicles.qc
Merge new vehicle stuff from combined updates
[xonotic/xonotic-data.pk3dir.git] / qcsrc / common / vehicles / sv_vehicles.qc
index b3a324695bdbea79df3820dc6b66ddbee262ea82..be0a1deaeeb8f5bffd752a6e7c8618d485122f61 100644 (file)
@@ -1,7 +1,5 @@
-// =========================
-//  SVQC Vehicle Properties
-// =========================
-
+#include "vehicles.qh"
+#include "sv_vehicles.qh"
 
 float SendAuxiliaryXhair(entity to, float sf)
 {
@@ -18,12 +16,12 @@ float SendAuxiliaryXhair(entity to, float sf)
        WriteByte(MSG_ENTITY, rint(self.colormod_y * 255));
        WriteByte(MSG_ENTITY, rint(self.colormod_z * 255));
 
-       return TRUE;
+       return true;
 }
 
 void UpdateAuxiliaryXhair(entity own, vector loc, vector clr, float axh_id)
 {
-       if not(IS_REAL_CLIENT(own))
+       if(!IS_REAL_CLIENT(own))
                return;
 
        entity axh;
@@ -37,7 +35,7 @@ void UpdateAuxiliaryXhair(entity own, vector loc, vector clr, float axh_id)
                axh.cnt                          = axh_id;
                axh.drawonlytoclient    = own;
                axh.owner                          = own;
-               Net_LinkEntity(axh, FALSE, 0, SendAuxiliaryXhair);
+               Net_LinkEntity(axh, false, 0, SendAuxiliaryXhair);
        }
 
        setorigin(axh, loc);
@@ -48,22 +46,18 @@ void UpdateAuxiliaryXhair(entity own, vector loc, vector clr, float axh_id)
 
 void CSQCVehicleSetup(entity own, float vehicle_id)
 {
-       if not(IS_REAL_CLIENT(own))
+       if(!IS_REAL_CLIENT(own))
                return;
 
        msg_entity = own;
 
        WriteByte(MSG_ONE, SVC_TEMPENTITY);
        WriteByte(MSG_ONE, TE_CSQC_VEHICLESETUP);
-       if(vehicle_id != 0)
-               WriteByte(MSG_ONE, vehicle_id);
-       else
-               WriteByte(MSG_ONE, 1 + own.vehicle.vehicle_weapon2mode + VEH_LAST);
+       WriteByte(MSG_ONE, vehicle_id);
 }
 
 vector targetdrone_getnewspot()
 {
-
        vector spot;
        float i;
        for(i = 0; i < 100; ++i)
@@ -99,16 +93,17 @@ void vehicles_locktarget(float incr, float decr, float _lock_time)
 
        if(trace_ent != world)
        {
-               if(teamplay && trace_ent.team == self.team)
+               if(SAME_TEAM(trace_ent, self))
                        trace_ent = world;
 
                if(trace_ent.deadflag != DEAD_NO)
                        trace_ent = world;
 
-               if not (trace_ent.vehicle_flags & VHF_ISVEHICLE ||
-                               trace_ent.turrcaps_flags & TFL_TURRCAPS_ISTURRET ||
-                               trace_ent.takedamage == DAMAGE_TARGETDRONE)
+               if(!((trace_ent.vehicle_flags & VHF_ISVEHICLE) || (trace_ent.turrcaps_flags & TFL_TURRCAPS_ISTURRET)))
                        trace_ent = world;
+
+               if(trace_ent.alpha <= 0.5 && trace_ent.alpha != 0)
+                       trace_ent = world; // invisible
        }
 
        if(self.lock_target == world && trace_ent != world)
@@ -126,7 +121,6 @@ void vehicles_locktarget(float incr, float decr, float _lock_time)
                        play2(self.owner, "vehicles/locking.wav");
                        self.lock_soundtime = time + 0.3;
                }
-
        }
 
        // Have a locking target
@@ -213,7 +207,7 @@ void vehicles_projectile_explode()
        PROJECTILE_TOUCH;
 
        self.event_damage = func_null;
-       RadiusDamage (self, self.realowner, self.shot_dmg, 0, self.shot_radius, self, self.shot_force, self.totalfrags, other);
+       RadiusDamage (self, self.realowner, self.shot_dmg, 0, self.shot_radius, self, world, self.shot_force, self.totalfrags, other);
 
        remove (self);
 }
@@ -238,7 +232,7 @@ entity vehicles_projectile(string _mzlfx, string _mzlsound,
        proj.solid                      = SOLID_BBOX;
        proj.movetype            = MOVETYPE_FLYMISSILE;
        proj.flags                      = FL_PROJECTILE;
-       proj.bot_dodge          = TRUE;
+       proj.bot_dodge          = true;
        proj.bot_dodgerating  = _dmg;
        proj.velocity            = _vel;
        proj.touch                      = vehicles_projectile_explode;
@@ -275,6 +269,7 @@ void vehicles_gib_explode()
 {
        sound (self, CH_SHOTS, "weapons/rocket_impact.wav", VOL_BASE, ATTEN_NORM);
        pointparticles(particleeffectnum("explosion_small"), randomvec() * 80 + (self.origin + '0 0 100'), '0 0 0', 1);
+       pointparticles(particleeffectnum("explosion_small"), self.wp00.origin + '0 0 64', '0 0 0', 1);
        remove(self);
 }
 
@@ -323,13 +318,14 @@ float vehicle_addplayerslot(      entity _owner,
                                                                float _hud,
                                                                string _hud_model,
                                                                float() _framefunc,
-                                                               void(float) _exitfunc)
+                                                               void(float) _exitfunc, float() _enterfunc)
 {
-       if not (_owner.vehicle_flags & VHF_MULTISLOT)
+       if(!(_owner.vehicle_flags & VHF_MULTISLOT))
                _owner.vehicle_flags |= VHF_MULTISLOT;
 
        _slot.PlayerPhysplug = _framefunc;
        _slot.vehicle_exit = _exitfunc;
+       _slot.vehicle_enter = _enterfunc;
        _slot.hud = _hud;
        _slot.vehicle_flags = VHF_PLAYERSLOT;
        _slot.vehicle_viewport = spawn();
@@ -343,7 +339,7 @@ float vehicle_addplayerslot(        entity _owner,
        setattachment(_slot.vehicle_hudmodel, _slot, "");
        setattachment(_slot.vehicle_viewport, _slot.vehicle_hudmodel, "");
 
-       return TRUE;
+       return true;
 }
 
 vector vehicle_aimturret(entity _vehic, vector _target, entity _turrret, string _tagname,
@@ -355,7 +351,7 @@ vector vehicle_aimturret(entity _vehic, vector _target, entity _turrret, string
        vtag = gettaginfo(_turrret, gettagindex(_turrret, _tagname));
        vtmp = vectoangles(normalize(_target - vtag));
        vtmp = AnglesTransform_ToAngles(AnglesTransform_LeftDivide(AnglesTransform_FromAngles(_vehic.angles), AnglesTransform_FromAngles(vtmp))) - _turrret.angles;
-       vtmp = AnglesTransform_Normalize(vtmp, TRUE);
+       vtmp = AnglesTransform_Normalize(vtmp, true);
        ftmp = _aimspeed * frametime;
        vtmp_y = bound(-ftmp, vtmp_y, ftmp);
        vtmp_x = bound(-ftmp, vtmp_x, ftmp);
@@ -397,6 +393,19 @@ void vehicles_reset_colors()
                }
                e = e.chain;
        }
+       // Also check head tags
+       e = findchainentity(tag_entity, self.tur_head);
+       while(e)
+       {
+               if(e != self.vehicle_shieldent)
+               {
+                       e.effects   = _effects; //  | EF_LOWPRECISION;
+                       e.colormod  = _colormod;
+                       e.colormap  = _colormap;
+                       e.alpha  = 1;
+               }
+               e = e.chain;
+       }
 
        self.vehicle_hudmodel.effects  = self.effects  = _effects; // | EF_LOWPRECISION;
        self.vehicle_hudmodel.colormod = self.colormod = _colormod;
@@ -484,7 +493,7 @@ void vehicles_showwp()
                rgb = Team_ColorRGB(self.team);
        else
                rgb = '1 1 1';
-       WaypointSprite_Spawn("vehicle", 0, 0, self, '0 0 64', world, 0, self, waypointsprite_attached, TRUE, RADARICON_POWERUP, rgb);
+       WaypointSprite_Spawn("vehicle", 0, 0, self, '0 0 64', world, 0, self, waypointsprite_attached, true, RADARICON_POWERUP, rgb);
        if(self.waypointsprite_attached)
        {
                WaypointSprite_UpdateRule(self.waypointsprite_attached, self.wp00.team, SPRITERULE_DEFAULT);
@@ -535,11 +544,19 @@ void vehicle_use()
        else
                self.active = ACTIVE_ACTIVE;
 
-       if(self.active == ACTIVE_ACTIVE && self.deadflag == DEAD_NO)
+       if(self.active == ACTIVE_ACTIVE && self.deadflag == DEAD_NO && !gameover)
        {
                dprint("Respawning vehicle: ", self.netname, "\n");
-               vehicles_setreturn(self);
-               vehicles_reset_colors();
+               if(self.effects & EF_NODRAW)
+               {
+                       self.think = vehicles_spawn;
+                       self.nextthink = time + 3;
+               }
+               else
+               {
+                       vehicles_setreturn(self);
+                       vehicles_reset_colors();
+               }
        }
 }
 
@@ -599,23 +616,29 @@ void vehicles_damage(entity inflictor, entity attacker, float damage, float deat
 {
        self.dmg_time = time;
 
-       if(DEATH_ISWEAPON(deathtype, WEP_NEX))
-               damage *= autocvar_g_vehicles_nex_damagerate;
+       // WEAPONTODO
+       if(DEATH_ISWEAPON(deathtype, WEP_VORTEX))
+               damage *= autocvar_g_vehicles_vortex_damagerate;
 
-       if(DEATH_ISWEAPON(deathtype, WEP_UZI))
-               damage *= autocvar_g_vehicles_uzi_damagerate;
+       if(DEATH_ISWEAPON(deathtype, WEP_MACHINEGUN))
+               damage *= autocvar_g_vehicles_machinegun_damagerate;
 
        if(DEATH_ISWEAPON(deathtype, WEP_RIFLE))
                damage *= autocvar_g_vehicles_rifle_damagerate;
 
-       if(DEATH_ISWEAPON(deathtype, WEP_MINSTANEX))
-               damage *= autocvar_g_vehicles_minstanex_damagerate;
+       if(DEATH_ISWEAPON(deathtype, WEP_VAPORIZER))
+               damage *= autocvar_g_vehicles_vaporizer_damagerate;
 
        if(DEATH_ISWEAPON(deathtype, WEP_SEEKER))
                damage *= autocvar_g_vehicles_tag_damagerate;
 
+       if(DEATH_WEAPONOFWEAPONDEATH(deathtype))
+               damage *= autocvar_g_vehicles_weapon_damagerate;
+
        self.enemy = attacker;
 
+       self.pain_finished = time;
+
        if((self.vehicle_flags & VHF_HASSHIELD) && (self.vehicle_shield > 0))
        {
                if (wasfreed(self.vehicle_shieldent) || self.vehicle_shieldent == world)
@@ -672,7 +695,7 @@ void vehicles_damage(entity inflictor, entity attacker, float damage, float deat
                        if(self.vehicle_flags & VHF_DEATHEJECT)
                                vehicles_exit(VHEF_EJECT);
                        else
-                               vehicles_exit(VHEF_RELESE);
+                               vehicles_exit(VHEF_RELEASE);
 
 
                antilag_clear(self);
@@ -684,13 +707,13 @@ void vehicles_damage(entity inflictor, entity attacker, float damage, float deat
 
 float vehicles_crushable(entity e)
 {
-       if(IS_PLAYER(e))
-               return TRUE;
+       if(IS_PLAYER(e) && time >= e.vehicle_enter_delay)
+               return true;
 
        if(e.flags & FL_MONSTER)
-               return TRUE;
+               return true;
 
-       return FALSE;
+       return false;
 }
 
 void vehicles_impact(float _minspeed, float _speedfac, float _maxpain)
@@ -776,7 +799,7 @@ void vehicles_exit(float eject)
                return;
        }
 
-       vehicles_exit_running = TRUE;
+       vehicles_exit_running = true;
        if(IS_CLIENT(self))
        {
                _vehicle = self.vehicle;
@@ -785,7 +808,7 @@ void vehicles_exit(float eject)
                {
                        _vehicle.vehicle_exit(eject);
                        self = _oldself;
-                       vehicles_exit_running = FALSE;
+                       vehicles_exit_running = false;
                        return;
                }
        }
@@ -816,6 +839,7 @@ void vehicles_exit(float eject)
                _player.solid                   = SOLID_SLIDEBOX;
                _player.movetype                = MOVETYPE_WALK;
                _player.effects            &= ~EF_NODRAW;
+               _player.teleportable    = TELEPORT_NORMAL;
                _player.alpha                   = 1;
                _player.PlayerPhysplug  = func_null;
                _player.vehicle                 = world;
@@ -824,6 +848,7 @@ void vehicles_exit(float eject)
                _player.hud                             = HUD_NORMAL;
                _player.switchweapon    = _vehicle.switchweapon;
                _player.last_vehiclecheck = time + 3;
+               _player.vehicle_enter_delay = time + 2;
 
                CSQCVehicleSetup(_player, HUD_NORMAL);
        }
@@ -834,7 +859,7 @@ void vehicles_exit(float eject)
 
        _vehicle.tur_head.nodrawtoclient = world;
 
-       if not(teamplay)
+       if(!teamplay)
                _vehicle.team = 0;
 
        Kill_Notification(NOTIF_ONE, _player, MSG_CENTER_CPID, CPID_VEHICLES);
@@ -859,9 +884,12 @@ void vehicles_exit(float eject)
        vehicles_setreturn(_vehicle);
        vehicles_reset_colors();
        _vehicle.owner = world;
+
+       CSQCMODEL_AUTOINIT();
+
        self = _oldself;
 
-       vehicles_exit_running = FALSE;
+       vehicles_exit_running = false;
 }
 
 void vehicles_touch()
@@ -872,10 +900,12 @@ void vehicles_touch()
        // Vehicle currently in use
        if(self.owner)
        {
+               if(!forbidWeaponUse(self.owner))
                if(other != world)
+               if((self.origin_z + self.maxs_z) > (other.origin_z))
                if(vehicles_crushable(other))
                {
-                       if(vlen(self.velocity) != 0)
+                       if(vlen(self.velocity) >= 30)
                                Damage(other, self, self.owner, autocvar_g_vehicles_crush_dmg, DEATH_VH_CRUSH, '0 0 0', normalize(other.origin - self.origin) * autocvar_g_vehicles_crush_force);
 
                        return; // Dont do selfdamage when hitting "soft targets".
@@ -896,26 +926,45 @@ void vehicles_touch()
 void vehicles_enter(entity pl, entity veh)
 {
    // Remove this when bots know how to use vehicles
-       if (IS_BOT_CLIENT(pl))
-       if (autocvar_g_vehicles_allow_bots)
-               dprint("Bot enters vehicle\n"); // This is where we need to disconnect (some, all?) normal bot AI and hand over to vehicle's _aiframe()
-       else
-               return;
-
-       if not(IS_PLAYER(pl))
+       if((IS_BOT_CLIENT(pl) && !autocvar_g_vehicles_allow_bots))
                return;
 
-       if(veh.phase > time)
-               return;
-
-       if(pl.freezetag_frozen)
-               return;
+       if((!IS_PLAYER(pl))
+       || (veh.phase >= time)
+       || (pl.vehicle_enter_delay >= time)
+       || (pl.frozen)
+       || (pl.deadflag != DEAD_NO)
+       || (pl.vehicle)
+       ) { return; }
+
+       if(autocvar_g_vehicles_enter) // vehicle's touch function should handle this if entering via use key is disabled (TODO)
+       if(veh.vehicle_flags & VHF_MULTISLOT)
+       if(veh.owner)
+       {
+               entity oldself = self;
+               self = veh;
+               other = pl; // TODO: fix
+
+               if(!veh.gunner1)
+               if(time >= veh.gun1.phase)
+               if(veh.gun1.vehicle_enter)
+               if(veh.gun1.vehicle_enter())
+               {
+                       self = oldself;
+                       return;
+               }
 
-       if(pl.deadflag != DEAD_NO)
-               return;
+               if(!veh.gunner2)
+               if(time >= veh.gun2.phase)
+               if(veh.gun2.vehicle_enter)
+               if(veh.gun2.vehicle_enter())
+               {
+                       self = oldself;
+                       return;
+               }
 
-       if(pl.vehicle)
-               return;
+               self = oldself;
+       }
 
        if(teamplay)
        if(veh.team)
@@ -928,9 +977,10 @@ void vehicles_enter(entity pl, entity veh)
 
                Send_Notification(NOTIF_ONE, pl, MSG_CENTER, CENTER_VEHICLE_STEAL_SELF);
 
-               WaypointSprite_Spawn("intruder", 0, 0, pl, '0 0 68', world, veh.team, veh, wps_intruder, TRUE, RADARICON_DANGER, Team_ColorRGB(pl.team));
+               if(autocvar_g_vehicles_steal_show_waypoint)
+                       WaypointSprite_Spawn("intruder", 0, 0, pl, '0 0 68', world, veh.team, veh, wps_intruder, true, RADARICON_DANGER, Team_ColorRGB(pl.team));
        }
-       else return;
+       else { return; }
 
        RemoveGrapplingHook(pl);
 
@@ -948,24 +998,26 @@ void vehicles_enter(entity pl, entity veh)
 
        veh.vehicle_hudmodel.viewmodelforclient = pl;
 
+       tracebox(pl.origin, PL_MIN, PL_MAX, pl.origin, false, pl);
+       pl.crouch = false;
+       pl.view_ofs = PL_VIEW_OFS;
+       setsize (pl, PL_MIN, PL_MAX);
+
        veh.event_damage        = vehicles_damage;
        veh.nextthink           = 0;
        pl.angles                       = veh.angles;
        pl.takedamage           = DAMAGE_NO;
        pl.solid                        = SOLID_NOT;
        pl.movetype                     = MOVETYPE_NOCLIP;
+       pl.teleportable         = false;
        pl.alpha                        = -1;
-       pl.vehicle                      = veh;
        pl.event_damage         = func_null;
        pl.view_ofs                     = '0 0 0';
        veh.colormap            = pl.colormap;
        if(veh.tur_head)
                veh.tur_head.colormap = pl.colormap;
        veh.switchweapon = pl.switchweapon;
-       if(veh.hud)
-               pl.hud = veh.hud;
-       else
-               pl.hud = veh.vehicleid;
+       pl.hud = veh.vehicleid;
        pl.PlayerPhysplug = veh.PlayerPhysplug;
 
        pl.vehicle_ammo1 = veh.vehicle_ammo1;
@@ -1013,11 +1065,10 @@ void vehicles_enter(entity pl, entity veh)
        vh_player = pl;
        vh_vehicle = veh;
        MUTATOR_CALLHOOK(VehicleEnter);
-       pl = vh_player;
-       veh = vh_vehicle;
 
        entity oldself = self;
        self = veh;
+       CSQCModel_UnlinkEntity();
        VEH_ACTION(veh.vehicleid, VR_ENTER);
        self = oldself;
 
@@ -1028,13 +1079,18 @@ void vehicles_think()
 {
        self.nextthink = time;
        
+       if(self.owner)
+               self.owner.vehicle_weapon2mode = self.vehicle_weapon2mode;
+       
        VEH_ACTION(self.vehicleid, VR_THINK);
+
+       CSQCMODEL_AUTOUPDATE();
 }
 
 // initialization
 void vehicles_spawn()
 {
-       dprint("Spawning vehicle: ", self.netname, "\n");
+       dprint("Spawning vehicle: ", self.classname, "\n");
 
        // disown & reset
        self.vehicle_hudmodel.viewmodelforclient = self;
@@ -1042,14 +1098,14 @@ void vehicles_spawn()
        self.owner                              = world;
        self.touch                              = vehicles_touch;
        self.event_damage               = vehicles_damage;
-       self.iscreature                 = TRUE;
-       self.teleportable               = FALSE; // no teleporting for vehicles, too buggy
-       self.damagedbycontents  = TRUE;
+       self.iscreature                 = true;
+       self.teleportable               = false; // no teleporting for vehicles, too buggy
+       self.damagedbycontents  = true;
        self.movetype                   = MOVETYPE_WALK;
        self.solid                              = SOLID_SLIDEBOX;
        self.takedamage                 = DAMAGE_AIM;
        self.deadflag                   = DEAD_NO;
-       self.bot_attack                 = TRUE;
+       self.bot_attack                 = true;
        self.flags                              = FL_NOTARGET;
        self.avelocity                  = '0 0 0';
        self.velocity                   = '0 0 0';
@@ -1063,31 +1119,44 @@ void vehicles_spawn()
 
        // Return to spawn
        self.angles = self.pos2;
-       setorigin(self, self.pos1 + '0 0 0');
+       setorigin(self, self.pos1);
        // Show it
        pointparticles(particleeffectnum("teleport"), self.origin + '0 0 64', '0 0 0', 1);
 
        if(self.vehicle_controller)
                self.team = self.vehicle_controller.team;
 
+       entity head; // remove hooks (if any)
+       FOR_EACH_PLAYER(head)
+       if(head.hook.aiment == self)
+               RemoveGrapplingHook(head);
+
        vehicles_reset_colors();
 
        VEH_ACTION(self.vehicleid, VR_SPAWN);
+
+       CSQCMODEL_AUTOINIT();
 }
 
 float vehicle_initialize(float vehicle_id, float nodrop)
 {
-       if not(autocvar_g_vehicles)
-               return FALSE;
+       if(!autocvar_g_vehicles)
+               return false;
 
        entity veh = get_vehicleinfo(vehicle_id);
 
-       if(self.targetname)
+       if(!veh.vehicleid)
+               return false;
+       
+       if(!veh.tur_head) { VEH_ACTION(vehicle_id, VR_PRECACHE); }
+
+       if(self.targetname && self.targetname != "")
        {
                self.vehicle_controller = find(world, target, self.targetname);
-               if not(self.vehicle_controller)
+               if(!self.vehicle_controller)
                {
                        bprint("^1WARNING: ^7Vehicle with invalid .targetname\n");
+                       self.active = ACTIVE_ACTIVE;
                }
                else
                {
@@ -1103,8 +1172,9 @@ float vehicle_initialize(float vehicle_id, float nodrop)
                        }
                }
        }
+       else { self.active = ACTIVE_ACTIVE; }
 
-       if(self.team && !teamplay)
+       if(self.team && (!teamplay || !autocvar_g_vehicles_teams))
                self.team = 0;
 
        self.vehicle_flags |= VHF_ISVEHICLE;
@@ -1115,11 +1185,11 @@ float vehicle_initialize(float vehicle_id, float nodrop)
        self.vehicle_hudmodel           = spawn();
        self.tur_head                           = spawn();
        self.tur_head.owner                     = self;
-       self.takedamage                         = DAMAGE_AIM;
-       self.bot_attack                         = TRUE;
-       self.iscreature                         = TRUE;
-       self.teleportable                       = FALSE; // no teleporting for vehicles, too buggy
-       self.damagedbycontents          = TRUE;
+       self.takedamage                         = DAMAGE_NO;
+       self.bot_attack                         = true;
+       self.iscreature                         = true;
+       self.teleportable                       = false; // no teleporting for vehicles, too buggy
+       self.damagedbycontents          = true;
        self.vehicleid                          = vehicle_id;
        self.PlayerPhysplug                     = veh.PlayerPhysplug;
        self.event_damage                       = func_null;
@@ -1157,7 +1227,7 @@ float vehicle_initialize(float vehicle_id, float nodrop)
 
        setsize(self, veh.mins, veh.maxs);
 
-       if not(nodrop)
+       if(!nodrop)
        {
                setorigin(self, self.origin);
                tracebox(self.origin + '0 0 100', veh.mins, veh.maxs, self.origin - '0 0 10000', MOVE_WORLDONLY, self);
@@ -1170,13 +1240,15 @@ float vehicle_initialize(float vehicle_id, float nodrop)
 
        VEH_ACTION(vehicle_id, VR_SETUP);
 
-       if(autocvar_g_vehicles_delayspawn)
+       if(self.active == ACTIVE_NOT)
+               self.nextthink = 0; // wait until activated
+       else if(autocvar_g_vehicles_delayspawn)
                self.nextthink = time + self.respawntime + (random() * autocvar_g_vehicles_delayspawn_jitter);
        else
                self.nextthink = time + game_starttime;
 
        if(MUTATOR_CALLHOOK(VehicleSpawn))
-               return FALSE;
+               return false;
 
-       return TRUE;
+       return true;
 }