]> de.git.xonotic.org Git - xonotic/xonotic-data.pk3dir.git/log
xonotic/xonotic-data.pk3dir.git
12 years agoMerge remote-tracking branch 'origin/nifrek/hagar_own_traileffect_fix'
Rudolf Polzer [Mon, 12 Dec 2011 08:38:22 +0000 (09:38 +0100)]
Merge remote-tracking branch 'origin/nifrek/hagar_own_traileffect_fix'

Conflicts:
effectinfo.txt

12 years agoMerge remote-tracking branch 'origin/terencehill/m_toggle_fix'
Rudolf Polzer [Mon, 12 Dec 2011 08:33:57 +0000 (09:33 +0100)]
Merge remote-tracking branch 'origin/terencehill/m_toggle_fix'

12 years agodon't hide invisibility in minstagib (fixes #876)
Rudolf Polzer [Mon, 12 Dec 2011 05:55:45 +0000 (06:55 +0100)]
don't hide invisibility in minstagib (fixes #876)

12 years agosprintf1s in help
Rudolf Polzer [Sun, 11 Dec 2011 12:46:38 +0000 (13:46 +0100)]
sprintf1s in help

12 years agoadd duckwalk anims for all directions (optional, if missing, duckwalk is used)
Rudolf Polzer [Sat, 10 Dec 2011 19:00:17 +0000 (20:00 +0100)]
add duckwalk anims for all directions (optional, if missing, duckwalk is used)

12 years agoadd a "selfstuff" clientcommand to embed stuff into a demo
Rudolf Polzer [Sat, 10 Dec 2011 11:04:09 +0000 (12:04 +0100)]
add a "selfstuff" clientcommand to embed stuff into a demo

12 years agobot_cmd aim: 3rd arg being 0 now does the same as 3rd arg missing
Rudolf Polzer [Sat, 10 Dec 2011 11:02:24 +0000 (12:02 +0100)]
bot_cmd aim: 3rd arg being 0 now does the same as 3rd arg missing

12 years agoadd another small demo file
Rudolf Polzer [Fri, 9 Dec 2011 21:11:05 +0000 (22:11 +0100)]
add another small demo file

12 years agocurrent bloom settings are a failure. Revert to engine defaults till we have GOOD...
Rudolf Polzer [Fri, 9 Dec 2011 20:07:12 +0000 (21:07 +0100)]
current bloom settings are a failure. Revert to engine defaults till we have GOOD settings.

12 years agoalso send server port number
Rudolf Polzer [Fri, 9 Dec 2011 19:58:40 +0000 (20:58 +0100)]
also send server port number

12 years agoclear antilag data when respawning (fixes #862)
Rudolf Polzer [Fri, 9 Dec 2011 08:28:11 +0000 (09:28 +0100)]
clear antilag data when respawning (fixes #862)

12 years agoupdate weaponpriority from latest real world stats
Rudolf Polzer [Thu, 8 Dec 2011 12:17:58 +0000 (13:17 +0100)]
update weaponpriority from latest real world stats

12 years agoremove MinstaNex from keybinds.txt, it makes people mad to have 3 guns on that key...
Rudolf Polzer [Thu, 8 Dec 2011 12:07:53 +0000 (13:07 +0100)]
remove MinstaNex from keybinds.txt, it makes people mad to have 3 guns on that key even if only ever 2 can coexist anyway

12 years agoadd aliases weapon_laser etc.
Rudolf Polzer [Thu, 8 Dec 2011 12:05:53 +0000 (13:05 +0100)]
add aliases weapon_laser etc.

12 years agoMerge branch 'master' of git://de.git.xonotic.org/xonotic/xonotic-data.pk3dir
Rudolf Polzer [Tue, 6 Dec 2011 21:14:32 +0000 (22:14 +0100)]
Merge branch 'master' of git://de.git.xonotic.org/xonotic/xonotic-data.pk3dir

12 years agotry a small fix in spawn distance check logic (untested)
Rudolf Polzer [Tue, 6 Dec 2011 21:13:26 +0000 (22:13 +0100)]
try a small fix in spawn distance check logic (untested)

12 years agoadd I to the spec
Rudolf Polzer [Tue, 6 Dec 2011 17:58:23 +0000 (18:58 +0100)]
add I to the spec

12 years agoadd a note about matchid format
Rudolf Polzer [Tue, 6 Dec 2011 17:55:59 +0000 (18:55 +0100)]
add a note about matchid format

12 years agosupport for duckwalkbackwards anim
Rudolf Polzer [Tue, 6 Dec 2011 15:15:38 +0000 (16:15 +0100)]
support for duckwalkbackwards anim

12 years agomake g_tdm_on_dm_maps also work for menu (needs clicking gametype buttons to apply)
Rudolf Polzer [Tue, 6 Dec 2011 13:16:17 +0000 (14:16 +0100)]
make g_tdm_on_dm_maps also work for menu (needs clicking gametype buttons to apply)

12 years ago-deathmatch_force_teamplay; +g_tdm_on_dm_maps
Rudolf Polzer [Tue, 6 Dec 2011 13:15:03 +0000 (14:15 +0100)]
-deathmatch_force_teamplay; +g_tdm_on_dm_maps

12 years agoMerge branch 'master' of /var/cache/git/xonotic/xonotic-data.pk3dir
Rudolf Polzer [Tue, 6 Dec 2011 10:03:26 +0000 (11:03 +0100)]
Merge branch 'master' of /var/cache/git/xonotic/xonotic-data.pk3dir

12 years agoadd greek
Rudolf Polzer [Tue, 6 Dec 2011 10:01:59 +0000 (11:01 +0100)]
add greek

12 years agoadd an alias g_forced_team_matchsetup (untested)
Rudolf Polzer [Mon, 5 Dec 2011 14:45:45 +0000 (15:45 +0100)]
add an alias g_forced_team_matchsetup (untested)

12 years agoMerge remote-tracking branch 'origin/mirceakitsune/sandbox'
Rudolf Polzer [Mon, 5 Dec 2011 13:11:43 +0000 (14:11 +0100)]
Merge remote-tracking branch 'origin/mirceakitsune/sandbox'

12 years agoWhen removing sandbox objects, if the object being removed has been selected for...
Mircea Kitsune [Sun, 4 Dec 2011 20:34:47 +0000 (22:34 +0200)]
When removing sandbox objects, if the object being removed has been selected for attachment by a player, unset it

12 years agoSandbox storage: Replace - with "" for empty properties when applicable. This should...
Mircea Kitsune [Sun, 4 Dec 2011 20:06:01 +0000 (22:06 +0200)]
Sandbox storage: Replace - with "" for empty properties when applicable. This should be both more correct and more safe. Breaks SOME properties in existing storages.

12 years agoMerge branch 'master' into mirceakitsune/sandbox
Mircea Kitsune [Sun, 4 Dec 2011 19:51:04 +0000 (21:51 +0200)]
Merge branch 'master' into mirceakitsune/sandbox

12 years agofix grabbing in sandbox mode
Rudolf Polzer [Sun, 4 Dec 2011 19:47:39 +0000 (20:47 +0100)]
fix grabbing in sandbox mode

12 years agoAlso use crosshair_trace_plusvisibletriggers for tracing sandbox objects in the edito...
Mircea Kitsune [Sun, 4 Dec 2011 19:38:28 +0000 (21:38 +0200)]
Also use crosshair_trace_plusvisibletriggers for tracing sandbox objects in the editor. This gets rid of my ugly hack from earlier, necessary to trace non-solid objects

12 years agoUse crosshair_trace_plusvisibletriggers instead of trace_ent for dragging, which...
Mircea Kitsune [Sun, 4 Dec 2011 19:30:59 +0000 (21:30 +0200)]
Use crosshair_trace_plusvisibletriggers instead of trace_ent for dragging, which is the way things should be

12 years agoUse SOLID_NOT for attachments, which is safest
Mircea Kitsune [Sun, 4 Dec 2011 17:24:38 +0000 (19:24 +0200)]
Use SOLID_NOT for attachments, which is safest

12 years agoUse SOLID_TRIGGER instead of SOLID_NOT for attachments or non-solid object. This...
Mircea Kitsune [Sun, 4 Dec 2011 17:07:49 +0000 (19:07 +0200)]
Use SOLID_TRIGGER instead of SOLID_NOT for attachments or non-solid object. This seems to make grabbing non-solid sandbox objects possible, although the dragging itself is based on trace_ent so I don't understand how this can be (given neither SOLID_NOT or SOLID_TRIGGER can get traced, so it shouldn't make a difference). This seems to work though, so I guess it's good SOLID_TRIGGER should also be better for possible changes that might get done in the future.

12 years agoFix a bug with persisted solidity when attaching / detaching objects
Mircea Kitsune [Sun, 4 Dec 2011 16:54:32 +0000 (18:54 +0200)]
Fix a bug with persisted solidity when attaching / detaching objects

12 years agoAdd solidity to the sandbox menu
Mircea Kitsune [Sun, 4 Dec 2011 16:25:21 +0000 (18:25 +0200)]
Add solidity to the sandbox menu

12 years agoRename edit command from solid to solidity
Mircea Kitsune [Sun, 4 Dec 2011 16:14:01 +0000 (18:14 +0200)]
Rename edit command from solid to solidity

12 years agoMerge branch 'master' into mirceakitsune/sandbox
Mircea Kitsune [Sun, 4 Dec 2011 16:10:34 +0000 (18:10 +0200)]
Merge branch 'master' into mirceakitsune/sandbox

12 years agoNow put my hack in place, making it possible to trace and edit non-solid objects.
Mircea Kitsune [Sun, 4 Dec 2011 16:06:24 +0000 (18:06 +0200)]
Now put my hack in place, making it possible to trace and edit non-solid objects.

12 years agofix multiple bugs in sandbox code regarding sv_cheats
Rudolf Polzer [Sun, 4 Dec 2011 15:59:10 +0000 (16:59 +0100)]
fix multiple bugs in sandbox code regarding sv_cheats

12 years agoFix typo in my last commit
Mircea Kitsune [Sun, 4 Dec 2011 15:50:19 +0000 (17:50 +0200)]
Fix typo in my last commit

12 years agoAllow setting and persisting the solidity of objects. I will use a dirty but necessar...
Mircea Kitsune [Sun, 4 Dec 2011 15:47:17 +0000 (17:47 +0200)]
Allow setting and persisting the solidity of objects. I will use a dirty but necessary hack to make non-solid objects traceable. Note that this change breaks previous storages.

12 years agoMerge remote-tracking branch 'origin/mirceakitsune/sandbox'
Rudolf Polzer [Sun, 4 Dec 2011 15:43:10 +0000 (16:43 +0100)]
Merge remote-tracking branch 'origin/mirceakitsune/sandbox'

Conflicts:
qcsrc/server/miscfunctions.qc
qcsrc/server/mutators/base.qh
qcsrc/server/mutators/mutators.qh
qcsrc/server/progs.src

12 years agoMerge branch 'master' into mirceakitsune/sandbox
Mircea Kitsune [Sun, 4 Dec 2011 15:26:04 +0000 (17:26 +0200)]
Merge branch 'master' into mirceakitsune/sandbox

12 years agoMerge branch 'master' of git://de.git.xonotic.org/xonotic/xonotic-data.pk3dir
Rudolf Polzer [Sun, 4 Dec 2011 15:17:19 +0000 (16:17 +0100)]
Merge branch 'master' of git://de.git.xonotic.org/xonotic/xonotic-data.pk3dir

12 years agofix weird projectile angles on impact
Rudolf Polzer [Sun, 4 Dec 2011 15:17:06 +0000 (16:17 +0100)]
fix weird projectile angles on impact

12 years agoaudit usage of player_localentnum and spectatee_status to also work with FTEQW
Rudolf Polzer [Sun, 4 Dec 2011 14:42:03 +0000 (15:42 +0100)]
audit usage of player_localentnum and spectatee_status to also work with FTEQW

12 years agoMerge remote-tracking branch 'origin/terencehill/hud_updates_bugfixes'
mand1nga [Sun, 4 Dec 2011 12:45:38 +0000 (09:45 -0300)]
Merge remote-tracking branch 'origin/terencehill/hud_updates_bugfixes'

12 years agomore stuff... look at teammate
Rudolf Polzer [Sat, 3 Dec 2011 19:43:22 +0000 (20:43 +0100)]
more stuff... look at teammate

12 years agog_spawn_near_teammate spawnpoint scoring mutator
Rudolf Polzer [Sat, 3 Dec 2011 19:04:00 +0000 (20:04 +0100)]
g_spawn_near_teammate spawnpoint scoring mutator

12 years agoremove an unused arg
Rudolf Polzer [Sat, 3 Dec 2011 18:36:08 +0000 (19:36 +0100)]
remove an unused arg

12 years agospawnpoint selection: restructure to be WAY more mutator friendly and simpler; move...
Rudolf Polzer [Sat, 3 Dec 2011 18:24:15 +0000 (19:24 +0100)]
spawnpoint selection: restructure to be WAY more mutator friendly and simpler; move game mode specific logic to game mode

12 years agoadd a Spawn_Score mutator hook; simplify spawning
Rudolf Polzer [Sat, 3 Dec 2011 18:01:15 +0000 (19:01 +0100)]
add a Spawn_Score mutator hook; simplify spawning

12 years agotwo more cvars
Rudolf Polzer [Sat, 3 Dec 2011 12:06:46 +0000 (13:06 +0100)]
two more cvars

12 years agoremove old minstanex textures :)
Rudolf Polzer [Sat, 3 Dec 2011 11:48:13 +0000 (12:48 +0100)]
remove old minstanex textures :)

12 years agoSquashed commit of the following:
Rudolf Polzer [Sat, 3 Dec 2011 11:46:44 +0000 (12:46 +0100)]
Squashed commit of the following:

commit 1c957af5b9748c46d92a4fa3da93d2c1a19ba778
Merge: a4ae0be 69a2e2b
Author: Samual <samual@xonotic.org>
Date:   Fri Dec 2 15:17:19 2011 -0500

    Merge remote branch 'origin/master' into morphed/minstanex

commit a4ae0be7220424ea0c8d7621b815cc482b18d828
Merge: ebe8eee 0396c95
Author: Samual <samual@xonotic.org>
Date:   Fri Dec 2 02:28:35 2011 -0500

    Merge remote branch 'origin/master' into morphed/minstanex

commit ebe8eee72691e07c3731e4c88f25de4a751a5339
Author: Morphed <morphed@o2.pl>
Date:   Thu Dec 1 23:09:59 2011 +0100

    stupid git !!! forgot models

commit d1bb9dd137bd9ec9372b08776c88c8dfd91de39d
Author: Morphed <morphed@o2.pl>
Date:   Thu Dec 1 22:40:13 2011 +0100

    minstanex by LJFHutch/theShadow #woxblox#

12 years agoMerge branch 'master' into mirceakitsune/sandbox
Mircea Kitsune [Fri, 2 Dec 2011 15:36:48 +0000 (17:36 +0200)]
Merge branch 'master' into mirceakitsune/sandbox

12 years agofix bug in omg config
Rudolf Polzer [Fri, 2 Dec 2011 10:56:30 +0000 (11:56 +0100)]
fix bug in omg config

12 years agorename all "alpha" parameters in CSQC to remove clash with future csqcplayer use...
Rudolf Polzer [Fri, 2 Dec 2011 08:35:22 +0000 (09:35 +0100)]
rename all "alpha" parameters in CSQC to remove clash with future csqcplayer use of .float alpha

12 years agofix min4->min
Jakob MG [Tue, 29 Nov 2011 14:21:07 +0000 (15:21 +0100)]
fix min4->min

12 years agoMerge branch 'master' into mirceakitsune/sandbox
Mircea Kitsune [Tue, 29 Nov 2011 14:21:04 +0000 (16:21 +0200)]
Merge branch 'master' into mirceakitsune/sandbox

12 years agoMerge branch 'master' of git://de.git.xonotic.org/xonotic/xonotic-data.pk3dir
Jakob MG [Tue, 29 Nov 2011 14:06:35 +0000 (15:06 +0100)]
Merge branch 'master' of git://de.git.xonotic.org/xonotic/xonotic-data.pk3dir

12 years agoWaypointsprites / healthbars for turrets #woxblox#
Jakob MG [Tue, 29 Nov 2011 14:04:38 +0000 (15:04 +0100)]
Waypointsprites / healthbars for turrets #woxblox#

12 years agoadd a compatibility workaround for 0.5.0 engine
Rudolf Polzer [Mon, 28 Nov 2011 20:08:30 +0000 (21:08 +0100)]
add a compatibility workaround for 0.5.0 engine

12 years agoRemove msys.qh I've re-added in the previous merge commit :(
terencehill [Mon, 28 Nov 2011 16:14:08 +0000 (17:14 +0100)]
Remove msys.qh I've re-added in the previous merge commit :(

12 years agoMerge remote-tracking branch 'origin' into terencehill/m_toggle_fix
terencehill [Mon, 28 Nov 2011 15:14:20 +0000 (16:14 +0100)]
Merge remote-tracking branch 'origin' into terencehill/m_toggle_fix

Conflicts:
qcsrc/menu/msys.qh

12 years agoGive hagar it's own trail effect instead of sharing it with mortar
nifrek [Mon, 28 Nov 2011 09:50:30 +0000 (04:50 -0500)]
Give hagar it's own trail effect instead of sharing it with mortar

12 years agom_toggle takes a parameter, fix its definition and actually make use of that paramete...
terencehill [Sat, 26 Nov 2011 18:27:25 +0000 (19:27 +0100)]
m_toggle takes a parameter, fix its definition and actually make use of that parameter. Now togglemenu 0/1 works as intended to switch the menu on/off.

12 years agowhen all spawns are allowed, RanOutOfSpawns cannot happen
Rudolf Polzer [Sat, 26 Nov 2011 17:01:06 +0000 (18:01 +0100)]
when all spawns are allowed, RanOutOfSpawns cannot happen

12 years agog_spawn_useallspawns - disable teamplay spawn rules
Rudolf Polzer [Sat, 26 Nov 2011 16:59:44 +0000 (17:59 +0100)]
g_spawn_useallspawns - disable teamplay spawn rules

12 years agodefaultplayermodel: allow multiple and randomize
Rudolf Polzer [Sat, 26 Nov 2011 16:38:24 +0000 (17:38 +0100)]
defaultplayermodel: allow multiple and randomize

12 years agoremove wrong use of r_hdr_scenebrightness in sRGB mode. We really shouldn't do that.
Rudolf Polzer [Sat, 26 Nov 2011 14:05:56 +0000 (15:05 +0100)]
remove wrong use of r_hdr_scenebrightness in sRGB mode. We really shouldn't do that.

12 years agofix declaration of runstandardplayerphysics
Rudolf Polzer [Sat, 26 Nov 2011 11:38:28 +0000 (12:38 +0100)]
fix declaration of runstandardplayerphysics

12 years agofix lots of inconsistencies to EXT_CSQC naming
Rudolf Polzer [Sat, 26 Nov 2011 11:28:29 +0000 (12:28 +0100)]
fix lots of inconsistencies to EXT_CSQC naming

12 years agoadd missing files
Rudolf Polzer [Sat, 26 Nov 2011 11:11:26 +0000 (12:11 +0100)]
add missing files

12 years agolots of csprogdefs stuff
Rudolf Polzer [Sat, 26 Nov 2011 11:10:52 +0000 (12:10 +0100)]
lots of csprogdefs stuff

12 years agofix more dpdefs stuff
Rudolf Polzer [Sat, 26 Nov 2011 10:37:51 +0000 (11:37 +0100)]
fix more dpdefs stuff

12 years agofix warnings
Rudolf Polzer [Sat, 26 Nov 2011 10:35:57 +0000 (11:35 +0100)]
fix warnings

12 years agomany menuqc improvements regarding dpdefs
Rudolf Polzer [Sat, 26 Nov 2011 10:28:02 +0000 (11:28 +0100)]
many menuqc improvements regarding dpdefs

12 years agosome more cleanup - all svqc warnings gone
Rudolf Polzer [Sat, 26 Nov 2011 10:09:21 +0000 (11:09 +0100)]
some more cleanup - all svqc warnings gone

12 years agouse vectoangles2 properly
Rudolf Polzer [Sat, 26 Nov 2011 09:55:14 +0000 (10:55 +0100)]
use vectoangles2 properly

12 years agouse the engine's progsdefs.qc. This may break stuff, please test!
Rudolf Polzer [Sat, 26 Nov 2011 08:39:16 +0000 (09:39 +0100)]
use the engine's progsdefs.qc. This may break stuff, please test!

12 years agofix name of extensions file
Rudolf Polzer [Sat, 26 Nov 2011 08:26:59 +0000 (09:26 +0100)]
fix name of extensions file

12 years agoupdate extensions file from dpdefs
Rudolf Polzer [Sat, 26 Nov 2011 08:26:40 +0000 (09:26 +0100)]
update extensions file from dpdefs

12 years agoset glowintensity to 1 again for now
Rudolf Polzer [Fri, 25 Nov 2011 22:32:02 +0000 (23:32 +0100)]
set glowintensity to 1 again for now

12 years agoless r_ambient in sRGB mode
Rudolf Polzer [Fri, 25 Nov 2011 22:15:37 +0000 (23:15 +0100)]
less r_ambient in sRGB mode

12 years agofix two bugs of crosshair button. Did anyone EVER test this one?
Rudolf Polzer [Fri, 25 Nov 2011 15:23:02 +0000 (16:23 +0100)]
fix two bugs of crosshair button. Did anyone EVER test this one?

12 years agostronger glow on models
Rudolf Polzer [Fri, 25 Nov 2011 12:55:01 +0000 (13:55 +0100)]
stronger glow on models

12 years agoenable sRGB fallback if needed
Rudolf Polzer [Fri, 25 Nov 2011 12:23:46 +0000 (13:23 +0100)]
enable sRGB fallback if needed

12 years agosRGB stuff (not enabled yet)
Rudolf Polzer [Fri, 25 Nov 2011 11:43:43 +0000 (12:43 +0100)]
sRGB stuff (not enabled yet)

12 years agoMerge remote-tracking branch 'origin/mirceakitsune/bloom_tweaks'
Rudolf Polzer [Fri, 25 Nov 2011 11:20:29 +0000 (12:20 +0100)]
Merge remote-tracking branch 'origin/mirceakitsune/bloom_tweaks'

12 years agosimplify spawnpoint logic again - "at least one SP was bad" suffices for disabling now
Rudolf Polzer [Fri, 25 Nov 2011 10:29:20 +0000 (11:29 +0100)]
simplify spawnpoint logic again - "at least one SP was bad" suffices for disabling now

12 years agofix CTS spawns on courtfun
Rudolf Polzer [Fri, 25 Nov 2011 10:24:08 +0000 (11:24 +0100)]
fix CTS spawns on courtfun

12 years agoremove some leftovers from mapcfg
Rudolf Polzer [Fri, 25 Nov 2011 10:02:26 +0000 (11:02 +0100)]
remove some leftovers from mapcfg

12 years agoPort bloom settings from latest Vore Tournament GIT. Might need some tweaking, but...
Mircea Kitsune [Wed, 23 Nov 2011 23:42:05 +0000 (01:42 +0200)]
Port bloom settings from latest Vore Tournament GIT. Might need some tweaking, but should look much better than the old one. Notice: Uses colorexponent

12 years agoFix moving turrets failing target check due to non updated tur_shotorg (use origin...
Jakob MG [Tue, 22 Nov 2011 11:39:21 +0000 (12:39 +0100)]
Fix moving turrets failing target check due to non updated tur_shotorg (use origin insted). Better vehicle target check

12 years agoDont spawn vehicles 128 units above spawm spot (fix raptor spawn-enter-crashdown)
Jakob MG [Tue, 22 Nov 2011 10:01:40 +0000 (11:01 +0100)]
Dont spawn vehicles 128 units above spawm spot (fix raptor spawn-enter-crashdown)

12 years agoMake spider's aim true even if case/chase_up/tilted
Jakob MG [Tue, 22 Nov 2011 09:40:14 +0000 (10:40 +0100)]
Make spider's aim true even if case/chase_up/tilted

12 years agoFix incorrect sending of health/shiled on vehicle enter
Jakob MG [Tue, 22 Nov 2011 09:29:22 +0000 (10:29 +0100)]
Fix incorrect sending of health/shiled on vehicle enter

12 years agoMake alarm sound/s stop right away when exiting a vehicle
Jakob MG [Tue, 22 Nov 2011 09:21:24 +0000 (10:21 +0100)]
Make alarm sound/s stop right away when exiting a vehicle

12 years agoIgnore sky & softtargets for vehicle impact damage. Extand vehile impactdamage to...
Jakob MG [Tue, 22 Nov 2011 08:58:42 +0000 (09:58 +0100)]
Ignore sky & softtargets for vehicle impact damage. Extand vehile impactdamage to all colissions. Fix potentialy massive bug with raptor (missing self re-set after swaping self in frame code)