Merge branch 'master' into Mario/stats_eloranking

[xonotic/xonotic-data.pk3dir.git] / qcsrc / server / clientkill.qc

diff --git a/qcsrc/server/clientkill.qc b/qcsrc/server/clientkill.qc
index aec5387c3eba0ed36274499cd774c7d13dcc6f9d..08758a06536f706bd722e6ed57549e0ae1b6d154 100644 (file)
--- a/qcsrc/server/clientkill.qc
+++ b/qcsrc/server/clientkill.qc
@@ -22,7 +22,10 @@ void ClientKill_Now_TeamChange(entity this)
                PutObserverInServer(this);
        }
        else
-               SV_ChangeTeam(this, this.killindicator_teamchange - 1);
+       {
+               Player_SetTeamIndexChecked(this, Team_TeamToIndex(
+                       this.killindicator_teamchange));
+       }
        this.killindicator_teamchange = 0;
 }
 
@@ -55,14 +58,7 @@ void ClientKill_Now(entity this)
 }
 void KillIndicator_Think(entity this)
 {
-       if (game_stopped)
-       {
-               this.owner.killindicator = NULL;
-               delete(this);
-               return;
-       }
-
-       if (this.owner.alpha < 0 && !this.owner.vehicle)
+       if (game_stopped || (this.owner.alpha < 0 && !this.owner.vehicle))
        {
                this.owner.killindicator = NULL;
                delete(this);
@@ -74,12 +70,9 @@ void KillIndicator_Think(entity this)
                ClientKill_Now(this.owner);
                return;
        }
-       else if (this.count == 1) // count == 1 means that it's silent
-       {
-               this.nextthink = time + 1;
-               this.cnt -= 1;
-       }
-       else
+
+       // count == 1 means that it's silent
+       if (this.count != 1)
        {
                if (this.cnt <= 10)
                        setmodel(this, MDL_NUM(this.cnt));
@@ -88,9 +81,9 @@ void KillIndicator_Think(entity this)
                        if (this.cnt <= 10)
                                Send_Notification(NOTIF_ONE, this.owner, MSG_ANNCE, Announcer_PickNumber(CNT_KILL, this.cnt));
                }
-               this.nextthink = time + 1;
-               this.cnt -= 1;
        }
+       this.nextthink = time + 1;
+       this.cnt -= 1;
 }
 
 .float lip;
@@ -109,6 +102,13 @@ void ClientKill_TeamChange(entity this, float targetteam) // 0 = don't change, -
 
        this.killindicator_teamchange = targetteam;
 
+       // this.killindicator.count == 1 means that the kill indicator was spawned by ClientKill_Silent
+       if(killtime <= 0 && this.killindicator && this.killindicator.count == 1)
+       {
+               ClientKill_Now(this); // allow instant kill in this case
+               return;
+       }
+
        if (!this.killindicator)
        {
                if (!IS_DEAD(this))
@@ -154,43 +154,47 @@ void ClientKill_TeamChange(entity this, float targetteam) // 0 = don't change, -
        }
        if (this.killindicator)
        {
+               Notification notif;
                if (targetteam == 0) // just die
                {
                        this.killindicator.colormod = '0 0 0';
-                       if(IS_REAL_CLIENT(this))
-                       if(this.killindicator.cnt > 0)
-                               Send_Notification(NOTIF_ONE_ONLY, this, MSG_CENTER, CENTER_TEAMCHANGE_SUICIDE, this.killindicator.cnt);
+                       notif = CENTER_TEAMCHANGE_SUICIDE;
                }
                else if (targetteam == -1) // auto
                {
                        this.killindicator.colormod = '0 1 0';
-                       if(IS_REAL_CLIENT(this))
-                       if(this.killindicator.cnt > 0)
-                               Send_Notification(NOTIF_ONE_ONLY, this, MSG_CENTER, CENTER_TEAMCHANGE_AUTO, this.killindicator.cnt);
+                       notif = CENTER_TEAMCHANGE_AUTO;
                }
                else if (targetteam == -2) // spectate
                {
                        this.killindicator.colormod = '0.5 0.5 0.5';
-                       if(IS_REAL_CLIENT(this))
-                       if(this.killindicator.cnt > 0)
-                               Send_Notification(NOTIF_ONE_ONLY, this, MSG_CENTER, CENTER_TEAMCHANGE_SPECTATE, this.killindicator.cnt);
+                       notif = CENTER_TEAMCHANGE_SPECTATE;
                }
                else
                {
                        this.killindicator.colormod = Team_ColorRGB(targetteam);
-                       if(IS_REAL_CLIENT(this))
-                       if(this.killindicator.cnt > 0)
-                               Send_Notification(NOTIF_ONE_ONLY, this, MSG_CENTER, APP_TEAM_NUM(targetteam, CENTER_TEAMCHANGE), this.killindicator.cnt);
+                       notif = APP_TEAM_NUM(targetteam, CENTER_TEAMCHANGE);
                }
+               if (IS_REAL_CLIENT(this) && this.killindicator.cnt > 0)
+                       Send_Notification(NOTIF_ONE_ONLY, this, MSG_CENTER, notif, this.killindicator.cnt);
        }
 
 }
 
+void ClientKill_Silent(entity this, float _delay)
+{
+       this.killindicator = spawn();
+       this.killindicator.owner = this;
+       setthink(this.killindicator, KillIndicator_Think);
+       this.killindicator.nextthink = time + (this.lip) * 0.05;
+       this.killindicator.cnt = ceil(_delay);
+       this.killindicator.count = 1; // this is used to indicate that it should be silent
+       this.lip = 0;
+}
+
 // Called when a client types 'kill' in the console
 void ClientKill(entity this)
 {
-       // TODO: once .health is removed, will need to check it here for the "already dead" message!
-
        if (game_stopped || this.player_blocked || STAT(FROZEN, this))
                return;