Fix wrong filename in the dumpnotifs command; put the filename in a constant in all...

[xonotic/xonotic-data.pk3dir.git] / qcsrc / common / effects / effectinfo.qc

diff --git a/qcsrc/common/effects/effectinfo.qc b/qcsrc/common/effects/effectinfo.qc
index f4b0dbabcf37f3ac844bfa7627da22e5dbf51705..d6da6c4aa7d71fdb0f685992b80a879a06a65cde 100644 (file)
--- a/qcsrc/common/effects/effectinfo.qc
+++ b/qcsrc/common/effects/effectinfo.qc
@@ -287,17 +287,19 @@ void effectinfo_dump(int fh, bool alsoprint)
     #undef WRITE
 }
 
-GENERIC_COMMAND(dumpeffectinfo, "Dump all effectinfo to effectinfo_dump.txt", false)
+#define DEFAULT_FILENAME "effectinfo_dump.txt"
+// NOTE: dumpeffectinfo, dumpnotifs, dumpturrets and dumpweapons use similar code
+GENERIC_COMMAND(dumpeffectinfo, "Dump all effectinfo into " DEFAULT_FILENAME, false)
 {
     switch (request) {
         case CMD_REQUEST_COMMAND: {
             string filename = argv(1);
                        bool alsoprint = false;
             if (filename == "") {
-                filename = "effectinfo_dump.txt";
+                filename = DEFAULT_FILENAME;
                 alsoprint = false;
             } else if (filename == "-") {
-                filename = "effectinfo_dump.txt";
+                filename = DEFAULT_FILENAME;
                 alsoprint = true;
             }
             int fh = fopen(filename, FILE_WRITE);
@@ -314,13 +316,14 @@ GENERIC_COMMAND(dumpeffectinfo, "Dump all effectinfo to effectinfo_dump.txt", fa
         default:
         case CMD_REQUEST_USAGE: {
             LOG_HELP("Usage:^3 ", GetProgramCommandPrefix(), " dumpeffectinfo [<filename>]");
-            LOG_HELP("  Where <filename> is the file to write (default is effectinfo_dump.txt),");
+            LOG_HELPF("  Where <filename> is the file to write (default is %s),", DEFAULT_FILENAME);
             LOG_HELP("  if supplied with '-' output to console as well as default,");
             LOG_HELP("  if left blank, it will only write to default.");
             return;
         }
     }
 }
+#undef DEFAULT_FILENAME
 
 
 REGISTRY(EffectInfos, BITS(9))